DPDK patches and discussions
 help / color / mirror / Atom feed
From: Shahaf Shuler <shahafs@mellanox.com>
To: Dekel Peled <dekelp@mellanox.com>, Yongseok Koh <yskoh@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Ori Kam" <orika@mellanox.com>,
	"Dekel Peled" <dekelp@mellanox.com>,
	"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix validation of Rx queue number
Date: Thu, 6 Dec 2018 11:34:39 +0000	[thread overview]
Message-ID: <DB7PR05MB4426CE6CAB1514BB7EA19475C3A90@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1543396577-60481-1-git-send-email-dekelp@mellanox.com>

Wednesday, November 28, 2018 11:16 AM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix validation of Rx queue number
> 
> Function mlx5_ctrl_flow_vlan() is used to set the rss rule in
> MLX5 PMD, using priv->reta_idx_n as number of Rx queues.
> This number is passed to mlx5_flow_validate_action_rss(), which attempts
> to access the Rx queues at priv->rxqs.
> In case priv->rxqs_n is 0, priv->rxqs is empty, and
> mlx5_flow_validate_action_rss() will crash with segmentation fault.
> 
> priv->reta_idx_n can never be 0, even if priv->rxqs_n is set to 0.
> But when priv->rxqs_n is set to 0, setting the rss rule is invalid.
> 
> This patch updates mlx5_ctrl_flow_vlan(), if priv->rxqs_n is 0 the function will
> fail with EINVAL errno.
> 
> Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")
> Cc: nelio.laranjeiro@6wind.com
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

Applied to next-net-mlx, thanks. 

      reply	other threads:[~2018-12-06 11:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28  9:16 Dekel Peled
2018-12-06 11:34 ` Shahaf Shuler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB7PR05MB4426CE6CAB1514BB7EA19475C3A90@DB7PR05MB4426.eurprd05.prod.outlook.com \
    --to=shahafs@mellanox.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=orika@mellanox.com \
    --cc=yskoh@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).