From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10055.outbound.protection.outlook.com [40.107.1.55]) by dpdk.org (Postfix) with ESMTP id 6E7A04C7C for ; Thu, 22 Mar 2018 10:45:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DqN9XfAVZdt28hberJ0/BjztQuvxYfVGK+SJPxbKOQw=; b=EvsNP3sPuxPGMfrboBwUZbYcyHdENkF/SBzbfiDRE8m7QDpMapP8MWK42FIw1mWsu2hiWNy0ZqcIGyugpKvutFoXBGzrxwAxT7kRTAJMo1ns5caS/9gSYZn2sgVgDADmbnfEiF4Jkx9ZmkGShLtfEfjefodFPg5Dt4CRp5TtbAs= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4267.eurprd05.prod.outlook.com (52.134.108.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Thu, 22 Mar 2018 09:45:16 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e%13]) with mapi id 15.20.0588.016; Thu, 22 Mar 2018 09:45:16 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses Thread-Index: AQHTwbzxtVGv2H+d90GeoBi5DhkLaaPcAHZw Date: Thu, 22 Mar 2018 09:45:16 +0000 Message-ID: References: <20180322090445.63pcs6jwljdob6pi@laranjeiro-vm.dev.6wind.com> In-Reply-To: <20180322090445.63pcs6jwljdob6pi@laranjeiro-vm.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4267; 7:A1QhOWkYWzA6nJsTnWQF3sNfTWKVAsmon/GUMKBx7tQZbW9ABW5K8QMa+6KbCKnU15Tqmg36UXR5jSyD1++xDh9wXfNyrKy3fNS5Vz87YVt1UqrCJABVwmgjn5G+5UJkH227pidHujtyLIWGXgilxq8xswNNC1CwfCFIus/9WemMPFcHborj0o29akZoewlfrVnQKKBrHuk8MqyvaHaJFvqVfn62HjC/qjmbXEVHj1z+L71HHzGQ3jfI/z8SYaaG x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4f85a5ca-e78c-490a-9be2-08d58fd99e4b x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4267; x-ms-traffictypediagnostic: DB7PR05MB4267: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4267; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4267; x-forefront-prvs: 0619D53754 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(346002)(39380400002)(39860400002)(376002)(366004)(199004)(189003)(2900100001)(7736002)(305945005)(97736004)(105586002)(316002)(74316002)(186003)(54906003)(6506007)(3846002)(6116002)(102836004)(446003)(33656002)(6436002)(8936002)(68736007)(106356001)(6916009)(86362001)(4326008)(6246003)(7696005)(3280700002)(26005)(2950100002)(55016002)(478600001)(5660300001)(229853002)(8676002)(76176011)(25786009)(81166006)(5250100002)(66066001)(93886005)(9686003)(14454004)(81156014)(53936002)(99286004)(3660700001)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4267; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: kBBuCpXZEwZAk+h6oEoeJdLosoKJrxy/VBF4ate1SllMRyetFwAyAHA/mXGw295JhdAhjqom0OARzTFnUtY6A5snXXEKf1ZEyYbhpruaLyQDaahg0x88ZHrk3omQR5HVWFy1HHtHIDa9szr8NBXjCLXQ2qTpv/wtyw75uqE8MlzgqFTBkiN6SsxKpciz2c+rV8NIN5IVYR6pCHSnHMwS8bIRhxu8UlWxEhL6roGBawDUBRloavlXfx9a6osl5JAoCdWKI3MkXTYzWHY2YszE1sT9e5ptsEyWo1lnEfKrrYW4OZxEVoVyE27XCsMZZYOo/zAFVQHoDYt9pTQgyxX1WQ== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4f85a5ca-e78c-490a-9be2-08d58fd99e4b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2018 09:45:16.7504 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4267 Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 09:45:19 -0000 Thursday, March 22, 2018 11:05 AM, N=E9lio Laranjeiro: > > What if the DPDK process is terminated ungracefully? I think the MAC > > table will remain with all the MACs which were added. > > The next run of the process may have un-expected results. > > > > Should we flush the neighbor mac table also on probe to make sure only > > the VF mac exists? >=20 > In such situation the sysadmin should make the clean up, the DPDK > application cannot consider it is the only one using the device as it is = not the > case, Linux still owns the device. > We have no guarantee the admin did not use another MAC address for a > service outside of the DPDK application (even if in such case he should > disable this feature to fully control what happens on the neighbor mac ta= ble). There should be only one owner for the VF mac tables - either the DPDK or t= he Linux. If the DPDK is the owner, it should do the cleanup. If the sysadmin wants t= o be the owner then it should set the proper flag when running dpdk or alte= rnatively not set the VF in trusted mode.=20 >=20 > Thanks, >=20 > -- > N=E9lio Laranjeiro > 6WIND