From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77]) by dpdk.org (Postfix) with ESMTP id B8A102C5; Sun, 19 Aug 2018 09:27:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1LeRPpdkI3kD4KFF8AerqK0qsodprgJAtQatfP4Iiak=; b=tatFj7sqZQ9lP2ONLfQgHGbFwmp64I7DAQ5rD8hjhDIaq5KQyp8QVMG4A0ygairElQAFpl8wSgjnarmMKYk7qv6MCQtEDllrLGsAh5iGMl4/65G3oJdspHo6AMXdvhTYHtly6IiruDVcrjfon2gve3G0dGCIMb7rE2egx/WTstU= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4969.eurprd05.prod.outlook.com (20.176.236.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1059.20; Sun, 19 Aug 2018 07:27:18 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c873:513b:cfb5:a3bc]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::c873:513b:cfb5:a3bc%4]) with mapi id 15.20.1059.021; Sun, 19 Aug 2018 07:27:18 +0000 From: Shahaf Shuler To: Shahaf Shuler , Yongseok Koh CC: "dev@dpdk.org" , "stable@dpdk.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , Ori Kam Thread-Topic: [dpdk-stable] [PATCH v2] net/mlx5: fix RSS flow action hash type selection Thread-Index: AQHUM8BqBRTCTUa5IUCAdtRLarFftaTGtHPw Date: Sun, 19 Aug 2018 07:27:18 +0000 Message-ID: References: <20180812111441.149234-1-shahafs@mellanox.com> <40237a945a95cad4cd0a422f0975bc03f294b0e7.1534245265.git.shahafs@mellanox.com> In-Reply-To: <40237a945a95cad4cd0a422f0975bc03f294b0e7.1534245265.git.shahafs@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [31.154.10.105] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4969; 6:uZjoOwhENlaNFwdB4Xjh5j8jQENZ8JzR+qYAOIoB/6fleU4+IkYzeg47uxfOI1NqglHgqSQT8nQBzPOCPC5qoNJnJMj2ZGIDYOsTv8FmKcisGUpOerhl4UV1tuAZ/b5P93wGFYaanp/nOGAD/b5mMB7npaDr5t6AREMzovPVPIAmEaCiNFeBG3s9PWaaCMCuku/z9RCuqXFfvrYX+xyOlEiDRqS6WK923FFbz9QsxbKDfai9c1MOm8cxiyd0hupm7YEaPuQgHEUVT2Am4cKwgvfLAtRQ44ufgS/hwnqGleq+U6ozaOJnTClrKpOwwl1T6geUGlbEXQxSnpReghgI27aHVQTaM5MMwxSE6hDSxbx/F+ma/vGVvUEO6q8j431b+gie+clXUG2Ut9Euf0NqHpnF7vil7Dp296pQBMfH3qCv559tg8anrJLanbQPbfkLp6pfz53NaWZg3kJNK2db1Q==; 5:SquIRfWkrsqWxd6XC9c0mkpT5oqIqFGPSjD+pSITB59f1+QmZ/7/3sLynu6gU7VJHcFhtMDDzXxJ5+f9OyPAVRylLSMFSXoW4p9gtfJ5hwQueJ1ohoUOUde1Pu45s98cLMbt5qrRGu3F20c1qe5LE2d16VnuVEnVBsUBylyH61Q=; 7:NTSsEv87VWXOSBE4lsMnRtfVr5un4pG6mYcEt/BkPxmbdT8rM9CSvF+DVtRuIzRzddbak+BdZoAqgI1QVjiW0qNUyoEMDbPWDIzMT769dVAZYHuW2wfKQdNymlaS9zMJvA07uN13WIQpffolDxeVdq/9FShq5+CO9Jhgt3HzaKrNRui1tu4AVeyGFzU1yaa4/GVF2HUgSll0WbZE6LObPFJZXEQ5NunIhOu3BaVFMdbueELvI+cDkOWtiELKey9Q x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 564d6ab0-6c24-4176-52d5-08d605a531dd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4969; x-ms-traffictypediagnostic: DB7PR05MB4969: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(95692535739014); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699016); SRVR:DB7PR05MB4969; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4969; x-forefront-prvs: 07697999E6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(396003)(136003)(189003)(199004)(102836004)(26005)(6116002)(105586002)(33656002)(86362001)(2900100001)(575784001)(6506007)(4326008)(2906002)(106356001)(229853002)(6636002)(74316002)(8936002)(305945005)(7736002)(81166006)(81156014)(14454004)(5660300001)(6436002)(3846002)(7696005)(107886003)(76176011)(99286004)(6246003)(55016002)(53936002)(9686003)(54906003)(11346002)(97736004)(110136005)(316002)(478600001)(476003)(25786009)(486006)(66066001)(256004)(5250100002)(446003)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4969; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: OYS1U5M9aFAf5MPaicZjCTwNZJVMIe1ZmYqrs/3fgQEreFekd6rd1igXUNse5bqF5IYlQ6vKxUIpHvPab1VNi4rrs/Q1GioNXcHLkeAXtnZMlhrxM4BFGxs0hJ8QPUgXMzWQnz7NlmQX6HlblzxKLVQilKHfUeljy629eZaD4hdtN5sSf7Acw0KVcx7tbNjN41qaiLS2s2JKPQW2NAqYDV0i3VvYZpWdTCWEXI250prcQnK6IkWLWTUJ8ltvbJK9ZF4EQ49RdMW3qrrqIYqwXxAXSOEH1J1RPG+EIMiY7FqZbKrig5zoEFnBqkTGRcFnAadjtCb0V3SiDGtx/UtPFQvgZH7+oC6VR995LCsTGRI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 564d6ab0-6c24-4176-52d5-08d605a531dd X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2018 07:27:18.2116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4969 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/mlx5: fix RSS flow action hash type selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Aug 2018 07:27:20 -0000 Tuesday, August 14, 2018 2:17 PM, Shahaf Shuler: > Subject: [dpdk-stable] [PATCH v2] net/mlx5: fix RSS flow action hash type > selection >=20 > On the code after the below commits, the criteria to select the IPV4 or > IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on > the flow rule. >=20 > The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not > select the IPV4 hash which will cause the packet to be spread in a bad wa= y. >=20 > Fix it by adding the corresponding types needed for each hash selection. >=20 > Fixes: 592f05b29a25 ("net/mlx5: add RSS flow action") > Fixes: fd0b70316bca ("net/mlx5: support inner RSS computation") > Cc: stable@dpdk.org > Cc: nelio.laranjeiro@6wind.com > Cc: orika@mellanox.com >=20 > Reported-by: Yaroslav Brustinov > Signed-off-by: Shahaf Shuler > --- >=20 > Few notes: > 1. this patch should be backported to 18.08 stable 2. There is more work > planned in 18.11 for the flow engine. > The work should be on top of this fix. >=20 > On v2: > * Removed duplicated ETH_RSS_NONFRAG_IPV6_OTHER flag. > * Ordered the flags according to their aprearance in rte_ethdev.h >=20 > --- Applied to next-net-mlx, thanks.