From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0082.outbound.protection.outlook.com [104.47.2.82]) by dpdk.org (Postfix) with ESMTP id 552DB728A for ; Thu, 22 Mar 2018 08:34:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+WHVO7o6wT5W0p5biFHLZs4ByWRDEiyIvg5FKWXuojo=; b=uW/ozaPlylFVPweJF9BGyeXhRX0aqf8aWhhfJRP+BWhrGRHHIth0SY5VU34ORsDry6qktnSpIWML1RjfrYVfFXMn9eZRCcCfxYKqld+RvSCWiWUuutlrBBFWJTU2SpG6NOJFw+I52Ca2Ld8mXdnVhPgf/38Ce/S+PuIdBkpsUtE= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4492.eurprd05.prod.outlook.com (52.134.109.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Thu, 22 Mar 2018 07:34:51 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::3473:b2b5:68f:fe6e%13]) with mapi id 15.20.0588.016; Thu, 22 Mar 2018 07:34:50 +0000 From: Shahaf Shuler To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "Adrien Mazarguil" , Yongseok Koh CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses Thread-Index: AQHTwRpZyPf7iCxleEyg/0C/MP3VAqPb2Asw Date: Thu, 22 Mar 2018 07:34:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4492; 7:b9RLHrm80FWiwdDPVjI9+BM6XJzi1xi6omo8h7sKFtrkFPURXefQr27WweFpIYyX7/LeUXBisxyKLP8+scnTDTGgs4MeKKq1/1rh0zpxFdVu95oMyY+sxQ0ZSlbeucCRL7QA0xSz9jK1fGckqO32LaecmO67qAVsUBzfMq3LazWFgqgEX1eLVapKnlZWbbFHPf1b58f3LNGEGvE1EXj9Ai0YI008EApSFf7kufNlAZTk5zA1T1VFTkTl+A8i5Hlg x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4e8bb461-029d-4051-fcf4-08d58fc765a8 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4492; x-ms-traffictypediagnostic: DB7PR05MB4492: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:DB7PR05MB4492; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4492; x-forefront-prvs: 0619D53754 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39380400002)(396003)(366004)(39860400002)(199004)(189003)(86362001)(2900100001)(14454004)(6116002)(106356001)(478600001)(102836004)(6506007)(7696005)(66066001)(229853002)(3660700001)(8936002)(76176011)(446003)(74316002)(3846002)(2906002)(186003)(59450400001)(4326008)(99286004)(316002)(53936002)(110136005)(68736007)(6246003)(3280700002)(5250100002)(97736004)(7736002)(9686003)(81166006)(81156014)(2950100002)(105586002)(6436002)(26005)(33656002)(5660300001)(305945005)(25786009)(6636002)(55016002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4492; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: rT89lVBX91T1PH1hgJjjyb7KvOFcrVOGJ60ko+6bExyIXupJf4ECWnZuz6TnJV2GkV9879Cn4a1Kbb+xPDKtKfyojFi/32e9X2rkPWmPKDz0QYYvfsG9gcHEylNLl5Ix/iD4pVX1oL37pmxwtSUaYfzn2/7H97uHMGYQ5WnYjJ+6umowWa7jPD5tK0uY37UMdjAzfQHi5lUDW60gT1NKkUOCTIlDHFjJyCxZ2fuMPQSbP592bQTWTOIeqnQR/7MzF0iCTXNF4iJgUNOFPCodW0DR5Fvx48mJ1cQNAuCP5htESByc6oriztH76+IgZzQEWhRIKQPajpigNu+LLDF38w== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e8bb461-029d-4051-fcf4-08d58fc765a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2018 07:34:50.8068 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4492 Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/mlx5: use Netlink to add/remove MAC addresses X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Mar 2018 07:34:52 -0000 Hi Nelio, Wednesday, March 21, 2018 3:40 PM, Nelio Laranjeiro: > VF devices are not able to receive traffic unless it fully requests it th= ough > Netlink. This will cause the request to be processed by the PF which wil= l > add/remove the MAC address to the VF table if the VF is trusted. >=20 > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil > --- > drivers/net/mlx5/Makefile | 1 + > drivers/net/mlx5/mlx5.c | 22 ++ > drivers/net/mlx5/mlx5.h | 13 + > drivers/net/mlx5/mlx5_ethdev.c | 27 +++ > drivers/net/mlx5/mlx5_mac.c | 25 +- > drivers/net/mlx5/mlx5_nl.c | 530 > +++++++++++++++++++++++++++++++++++++++++ > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index > faacfd9d6..6a7e9f310 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -78,6 +78,7 @@ struct mlx5_dev_config { > unsigned int hw_vlan_strip:1; /* VLAN stripping is supported. */ > unsigned int hw_fcs_strip:1; /* FCS stripping is supported. */ > unsigned int hw_padding:1; /* End alignment padding is supported. > */ > + unsigned int vf:1; /* This is a VF. */ > unsigned int mps:2; /* Multi-packet send supported mode. */ > unsigned int tunnel_en:1; > /* Whether tunnel stateless offloads are supported. */ @@ -154,6 > +155,8 @@ struct priv { > struct mlx5_dev_config config; /* Device configuration. */ > struct mlx5_verbs_alloc_ctx verbs_alloc_ctx; > /* Context for Verbs allocator. */ > + int nl_socket; /* Netlink socket. */ > + uint32_t nl_sn; /* Netlink message sequence number. */ > }; >=20 > /* mlx5.c */ > @@ -163,6 +166,7 @@ int mlx5_getenv_int(const char *); > /* mlx5_ethdev.c */ >=20 > int mlx5_get_ifname(const struct rte_eth_dev *dev, char > (*ifname)[IF_NAMESIZE]); > +int mlx5_ifindex(const struct rte_eth_dev *dev); > int mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq *ifr= ); int > mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu); int > mlx5_set_flags(struct rte_eth_dev *dev, unsigned int keep, @@ -297,4 > +301,13 @@ struct mlx5_mr *mlx5_mr_get(struct rte_eth_dev *dev, struct > rte_mempool *mp); int mlx5_mr_release(struct mlx5_mr *mr); int > mlx5_mr_verify(struct rte_eth_dev *dev); >=20 > +/* mlx5_nl.c */ > + > +int mlx5_nl_init(uint32_t nlgroups); > +int mlx5_nl_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr > +*mac); int mlx5_nl_mac_addr_remove(struct rte_eth_dev *dev, struct > +ether_addr *mac); void mlx5_nl_mac_addr_flush(struct rte_eth_dev > *dev); I think the two below should be introduced only on the next patch of the se= ries.=20 > +int mlx5_nl_promisc(struct rte_eth_dev *dev, int enable); int > +mlx5_nl_allmulti(struct rte_eth_dev *dev, int enable); > + > #endif /* RTE_PMD_MLX5_H_ */ [...] > +/** > + * Flush all added MAC addresses. > + * > + * @param dev > + * Pointer to Ethernet device. > + */ > +void > +mlx5_nl_mac_addr_flush(struct rte_eth_dev *dev) { > + int i; > + const struct ether_addr mac_null =3D { .addr_bytes =3D { 0 }, }; > + > + for (i =3D MLX5_MAX_MAC_ADDRESSES - 1; i >=3D 0; --i) { > + struct ether_addr *m =3D &dev->data->mac_addrs[i]; > + > + if (memcmp(&mac_null, m, ETHER_ADDR_LEN)) > + mlx5_nl_mac_addr_remove(dev, m); > + } > +} What if the DPDK process is terminated ungracefully? I think the MAC table = will remain with all the MACs which were added.=20 The next run of the process may have un-expected results. Should we flush the neighbor mac table also on probe to make sure only the = VF mac exists?=20 > -- > 2.11.0