From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00058.outbound.protection.outlook.com [40.107.0.58]) by dpdk.org (Postfix) with ESMTP id A58694CA5 for ; Wed, 31 Oct 2018 16:09:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nPQK5f2Y8YO33EjzYz6pReFezkiW7A5NoHoprucncPE=; b=BdGhVG1pS0XBj7YrIBQTrAWPip2qIjV/jFvZ4eeRb7F4x7JYtgGHArePfz231GvgsaJSb+Vre5aoN4w/rt2ekM09m66i6KqSt8xkHvVEgdUlOgt0A+3WqLMcp85ln88YlvezOZbfUZ/yHun3ez1i2UVLtP6c/94uTWlxGLu4gjw= Received: from DB7PR05MB4426.eurprd05.prod.outlook.com (52.134.109.15) by DB7PR05MB4187.eurprd05.prod.outlook.com (52.134.107.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.25; Wed, 31 Oct 2018 15:09:51 +0000 Received: from DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973]) by DB7PR05MB4426.eurprd05.prod.outlook.com ([fe80::80e:e6b:baf2:d973%3]) with mapi id 15.20.1273.027; Wed, 31 Oct 2018 15:09:51 +0000 From: Shahaf Shuler To: Dekel Peled , Yongseok Koh CC: "dev@dpdk.org" , Ori Kam Thread-Topic: [PATCH v7 2/7] net/mlx5: add VXLAN encap action to Direct Verbs Thread-Index: AQHUcO/NPLrK7Q59BU+ufVWtdJcJuqU5T4ag Date: Wed, 31 Oct 2018 15:09:51 +0000 Message-ID: References: <1540498108-18358-1-git-send-email-dekelp@mellanox.com> <1540969847-48919-3-git-send-email-dekelp@mellanox.com> In-Reply-To: <1540969847-48919-3-git-send-email-dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shahafs@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR05MB4187; 6:4efMiv8oyjJn427Lugd9hHtGEZA8MtKy6YDW/d9hz8/WN/Skf1a8tiAfopzY1EYldijb2HGRdZ1+JeiK4LCCuB1GbB1WMiXFuGseq+MTpAeoO6Ery/gm1wcBjqJPQ4akqwCYnbDGlhpq4W5NZa1uZ3MWRn7+4c+if1XPq543fXinCI6XK/sA3vU28rAVTO44lgWpkuEPuwLJHywJNoGzHsDasXkrInNjXriZRbv7ER/Io0uMsfFoqdLIBYEbcfz7JHRNXuWinBZ5qWIzxvKkFyiXnEOR0XYW+pqHSX8r8UTqgcXRvQz0Rs01cMYo1t2gQrFYpIxah4rDb6Ex+3L62a6VoLwmWmANta+fdjStBuYDJr7t2octzI95X1N4T0yghcZnpc8u+LNYvaqgnq9IXKAJ1G6/DiqWsyYSPITOAlHzdClCZoLX0eqozGaxzY5O0YFMbFVvwyhLSOvL0FBNQg==; 5:9PVGt7OAiax85m27uIK4TLKWcTMJ19duzuXLEkHZeYNZcE8UZxDGkBMJrsZKVlxM2mPofgzmtjNJjwTyjZhCnZjY//KKpDEscArfVvLN7Sg4t4nL0kuJJ2aW6swtlg9A3TbWWFE38zYir7Bt38xGTCvKfkjPa58SXduUsY2xJVM=; 7:qMNiiSdAz84dw3D20lTV7PHSJ+SwpalevdzSPwCOIXUKujOLZU8yH3MD4LC4auEoB9GIE0IF+mY1oW9ZTbeM0QhQ8vVQPHH0nvPXu5vAJPst7kiJIBEr1i8eIB4yYe6M/OFIGqoMnLE+mEAX3aPQrw== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: ddcb5663-5bd3-4795-eba4-08d63f42e81c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR05MB4187; x-ms-traffictypediagnostic: DB7PR05MB4187: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3002001)(3231382)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:DB7PR05MB4187; BCL:0; PCL:0; RULEID:; SRVR:DB7PR05MB4187; x-forefront-prvs: 084285FC5C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(136003)(396003)(366004)(39860400002)(199004)(189003)(476003)(86362001)(575784001)(14454004)(478600001)(105586002)(102836004)(26005)(106356001)(186003)(6636002)(486006)(81156014)(81166006)(8676002)(4326008)(2900100001)(110136005)(54906003)(25786009)(446003)(97736004)(14444005)(256004)(8936002)(11346002)(68736007)(4744004)(66066001)(2906002)(316002)(6116002)(71200400001)(33656002)(5250100002)(5660300001)(55016002)(53936002)(6246003)(107886003)(99286004)(3846002)(71190400001)(9686003)(74316002)(305945005)(7736002)(76176011)(7696005)(6506007)(6436002)(229853002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR05MB4187; H:DB7PR05MB4426.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 872iaxFOcA638mt1NVOM48Cuo3Phai4x268K74iCBzpf4KIUcVopTXNoESVydUY3ekw+u1tdKe8rkePF9ytTx3/010ZO7Hhe30oE8ZTzdx6fqdpp8DQZAXRXzsy3PIQv/sVNdh70roGa4X/CiRvc3Z7WVDJEwLW+idAaOlPTrwtrWakaUrpzX00x+dILEq1M+y2I+hJyTaIJ/LystRZAw0Mc5BbgT28peUQrNg/3DG768qBiritwqfJdTC/zZHSHMI+y2n3jDRNYvcuho9J2IL6cdaoA1r3/MH/HlHKwHEAGfOeprLUcRjzfiRFpTKx0k86JFF6ufUQw9XbPxnORarG54HZmT8uW9PcZmwEUn3Q= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ddcb5663-5bd3-4795-eba4-08d63f42e81c X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2018 15:09:51.2073 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4187 Subject: Re: [dpdk-dev] [PATCH v7 2/7] net/mlx5: add VXLAN encap action to Direct Verbs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 15:09:52 -0000 Wednesday, October 31, 2018 9:11 AM, Dekel Peled: > Subject: [PATCH v7 2/7] net/mlx5: add VXLAN encap action to Direct Verbs >=20 > This patch implements the VXLAN encap action in DV flow for MLX5 PMD. >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_flow.h | 3 + > drivers/net/mlx5/mlx5_flow_dv.c | 347 > +++++++++++++++++++++++++++++++++++++++- > 2 files changed, 345 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h > index 61299d6..286d7bb 100644 > --- a/drivers/net/mlx5/mlx5_flow.h > +++ b/drivers/net/mlx5/mlx5_flow.h > @@ -92,6 +92,7 @@ > #define MLX5_FLOW_ACTION_DEC_TTL (1u << 19) #define > MLX5_FLOW_ACTION_SET_MAC_SRC (1u << 20) #define > MLX5_FLOW_ACTION_SET_MAC_DST (1u << 21) > +#define MLX5_FLOW_ACTION_VXLAN_ENCAP (1u << 22) >=20 > #define MLX5_FLOW_FATE_ACTIONS \ > (MLX5_FLOW_ACTION_DROP | MLX5_FLOW_ACTION_QUEUE | > MLX5_FLOW_ACTION_RSS) @@ -181,6 +182,8 @@ struct mlx5_flow_dv { > #ifdef HAVE_IBV_FLOW_DV_SUPPORT > struct mlx5dv_flow_action_attr > actions[MLX5_DV_MAX_NUMBER_OF_ACTIONS]; > /**< Action list. */ > + struct ibv_flow_action *encap_decap_verbs_action; > + /**< Verbs encap/decap object. */ > #endif > int actions_n; /**< number of actions. */ }; diff --git > a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c > index 8f729f4..1f9a842 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -34,6 +34,8 @@ >=20 > #ifdef HAVE_IBV_FLOW_DV_SUPPORT >=20 > +#define MLX5_ENCAP_MAX_LEN 132 > + > /** > * Validate META item. > * > @@ -96,6 +98,303 @@ > } >=20 > /** > + * Validate the L2 encap action. > + * > + * @param[in] action_flags > + * Holds the actions detected until now. > + * @param[in] action > + * Pointer to the encap action. > + * @param[in] attr > + * Pointer to flow attributes > + * @param[out] error > + * Pointer to error structure. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set= . > + */ > +static int > +flow_dv_validate_action_l2_encap(uint64_t action_flags, > + const struct rte_flow_action *action, > + const struct rte_flow_attr *attr, > + struct rte_flow_error *error) > +{ > + if (!(action->conf)) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > action, > + "configuration cannot be null"); > + if (action_flags & MLX5_FLOW_ACTION_DROP) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > + "can't drop and encap in same > flow"); > + if (action_flags & MLX5_FLOW_ACTION_VXLAN_ENCAP) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > NULL, > + "can only have a single encap" > + " action in a flow"); > + if (attr->ingress) > + return rte_flow_error_set(error, ENOTSUP, > + > RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, > + NULL, > + "encap action not supported for " > + "ingress"); > + return 0; > +} > + > +/** > + * Get the size of specific rte_flow_item_type > + * > + * @param[in] item_type > + * Tested rte_flow_item_type. > + * > + * @return > + * sizeof struct item_type, 0 if void or irrelevant. > + */ > +static size_t > +flow_dv_get_item_len(const enum rte_flow_item_type item_type) { > + size_t retval; > + > + switch (item_type) { > + case RTE_FLOW_ITEM_TYPE_ETH: > + retval =3D sizeof(struct rte_flow_item_eth); > + break; > + case RTE_FLOW_ITEM_TYPE_VLAN: > + retval =3D sizeof(struct rte_flow_item_vlan); > + break; > + case RTE_FLOW_ITEM_TYPE_IPV4: > + retval =3D sizeof(struct rte_flow_item_ipv4); > + break; > + case RTE_FLOW_ITEM_TYPE_IPV6: > + retval =3D sizeof(struct rte_flow_item_ipv6); > + break; > + case RTE_FLOW_ITEM_TYPE_UDP: > + retval =3D sizeof(struct rte_flow_item_udp); > + break; > + case RTE_FLOW_ITEM_TYPE_TCP: > + retval =3D sizeof(struct rte_flow_item_tcp); > + break; > + case RTE_FLOW_ITEM_TYPE_VXLAN: > + retval =3D sizeof(struct rte_flow_item_vxlan); > + break; > + case RTE_FLOW_ITEM_TYPE_GRE: > + retval =3D sizeof(struct rte_flow_item_gre); > + break; > + case RTE_FLOW_ITEM_TYPE_NVGRE: > + retval =3D sizeof(struct rte_flow_item_nvgre); > + break; > + case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: > + retval =3D sizeof(struct rte_flow_item_vxlan_gpe); > + break; > + case RTE_FLOW_ITEM_TYPE_MPLS: > + retval =3D sizeof(struct rte_flow_item_mpls); > + break; > + case RTE_FLOW_ITEM_TYPE_VOID: /* Fall through. */ > + default: > + retval =3D 0; > + break; > + } > + return retval; > +}; > + > +#define MLX5_IPV4_VERSION 0x40 > +#define MLX5_IPV4_IHL_MIN 0x05 > +#define MLX5_IPV4_TTL_DEF 0x40 > +#define MLX5_IPV6_VTC_FLOW 0x60000000 > +#define MLX5_IPV6_HOP_LIMIT 0xff > +#define MLX5_VXLAN_FLAGS 0x08000000 > +#define MLX5_VXLAN_GPE_FLAGS 0x0c000003 Better to prefix them all w/ MLX5_ENCAP_* > + > +/** > + * Convert the encap action data from list of rte_flow_item to raw > +buffer > + * > + * @param[in] items > + * Pointer to rte_flow_item objects list. > + * @param[out] buf > + * Pointer to the output buffer. > + * @param[out] size > + * Pointer to the output buffer size. > + * @param[out] error > + * Pointer to the error structure. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set= . > + */ > +static int > +flow_dv_convert_encap_data(const struct rte_flow_item *item, uint8_t Here it is also items > *buf, > + size_t *size, struct rte_flow_error *error) { > + struct ether_hdr *eth =3D NULL; > + struct vlan_hdr *vlan =3D NULL; > + struct ipv4_hdr *ipv4 =3D NULL; > + struct ipv6_hdr *ipv6 =3D NULL; > + struct udp_hdr *udp =3D NULL; > + struct vxlan_hdr *vxlan =3D NULL; > + size_t len; > + size_t temp_size =3D 0; > + > + if (!item) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ACTION, > + NULL, "invalid empty data"); > + for (; item->type !=3D RTE_FLOW_ITEM_TYPE_END; item++) { > + len =3D flow_dv_get_item_len(item->type); > + if (len + temp_size > MLX5_ENCAP_MAX_LEN) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "items total size is too big" > + " for encap action"); > + rte_memcpy((void *)&buf[temp_size], item->spec, len); > + switch (item->type) { > + case RTE_FLOW_ITEM_TYPE_ETH: > + eth =3D (struct ether_hdr *)&buf[temp_size]; > + break; > + case RTE_FLOW_ITEM_TYPE_VLAN: > + vlan =3D (struct vlan_hdr *)&buf[temp_size]; > + if (!eth) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "eth header not found"); > + if (!eth->ether_type) > + eth->ether_type =3D > RTE_BE16(ETHER_TYPE_VLAN); > + break; > + case RTE_FLOW_ITEM_TYPE_IPV4: > + ipv4 =3D (struct ipv4_hdr *)&buf[temp_size]; > + if (!vlan && !eth) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "neither eth nor vlan" > + " header found"); > + if (vlan && !vlan->eth_proto) > + vlan->eth_proto =3D > RTE_BE16(ETHER_TYPE_IPv4); > + else if (eth && !eth->ether_type) > + eth->ether_type =3D > RTE_BE16(ETHER_TYPE_IPv4); > + if (!ipv4->version_ihl) > + ipv4->version_ihl =3D MLX5_IPV4_VERSION | > + MLX5_IPV4_IHL_MIN; > + if (!ipv4->time_to_live) > + ipv4->time_to_live =3D MLX5_IPV4_TTL_DEF; > + break; > + case RTE_FLOW_ITEM_TYPE_IPV6: > + ipv6 =3D (struct ipv6_hdr *)&buf[temp_size]; > + if (!vlan && !eth) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "neither eth nor vlan" > + " header found"); > + if (vlan && !vlan->eth_proto) > + vlan->eth_proto =3D > RTE_BE16(ETHER_TYPE_IPv6); > + else if (eth && !eth->ether_type) > + eth->ether_type =3D > RTE_BE16(ETHER_TYPE_IPv6); > + if (!ipv6->vtc_flow) > + ipv6->vtc_flow =3D > RTE_BE32(MLX5_IPV6_VTC_FLOW); > + if (!ipv6->hop_limits) > + ipv6->hop_limits =3D MLX5_IPV6_HOP_LIMIT; > + break; > + case RTE_FLOW_ITEM_TYPE_UDP: > + udp =3D (struct udp_hdr *)&buf[temp_size]; > + if (!ipv4 && !ipv6) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "ip header not found"); > + if (ipv4 && !ipv4->next_proto_id) > + ipv4->next_proto_id =3D IPPROTO_UDP; > + else if (ipv6 && !ipv6->proto) > + ipv6->proto =3D IPPROTO_UDP; This is not what I meant. I meant to check the vxlan GPE next protocol. Thi= s one must be set by the App > + break; > + case RTE_FLOW_ITEM_TYPE_VXLAN: > + vxlan =3D (struct vxlan_hdr *)&buf[temp_size]; > + if (!udp) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "udp header not found"); > + if (!udp->dst_port) > + udp->dst_port =3D > RTE_BE16(MLX5_UDP_PORT_VXLAN); > + if (!vxlan->vx_flags) > + vxlan->vx_flags =3D > RTE_BE32(MLX5_VXLAN_FLAGS); > + break; > + case RTE_FLOW_ITEM_TYPE_VXLAN_GPE: > + vxlan =3D (struct vxlan_hdr *)&buf[temp_size]; > + if (!udp) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "udp header not found"); > + if ((ipv4 && !ipv4->next_proto_id) || > + (ipv6 && !ipv6->proto)) > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "next protocol not found"); > + if (!udp->dst_port) > + udp->dst_port =3D > + > RTE_BE16(MLX5_UDP_PORT_VXLAN_GPE); > + if (!vxlan->vx_flags) > + vxlan->vx_flags =3D > + > RTE_BE32(MLX5_VXLAN_GPE_FLAGS); > + break; > + case RTE_FLOW_ITEM_TYPE_VOID: > + break; > + default: > + return rte_flow_error_set(error, EINVAL, > + > RTE_FLOW_ERROR_TYPE_ACTION, > + (void *)item->type, > + "unsupported item type"); > + break; > + } > + temp_size +=3D len; > + } > + *size =3D temp_size; > + return 0; > +} > + > +/** > + * Convert L2 encap action to DV specification. > + * > + * @param[in] dev > + * Pointer to rte_eth_dev structure. > + * @param[in] action > + * Pointer to action structure. > + * @param[out] error > + * Pointer to the error structure. > + * > + * @return > + * Pointer to action on success, NULL otherwise and rte_errno is set. > + */ > +static struct ibv_flow_action * > +flow_dv_create_action_l2_encap(struct rte_eth_dev *dev, > + const struct rte_flow_action *action, > + struct rte_flow_error *error) { > + struct ibv_flow_action *verbs_action =3D NULL; > + const struct rte_flow_item *encap_data; > + struct priv *priv =3D dev->data->dev_private; > + uint8_t buf[MLX5_ENCAP_MAX_LEN]; > + size_t size =3D 0; > + int convert_result =3D 0; > + > + encap_data =3D ((const struct rte_flow_action_vxlan_encap *) > + action->conf)->definition; > + convert_result =3D flow_dv_convert_encap_data(encap_data, buf, > + &size, error); > + if (convert_result) > + return NULL; > + verbs_action =3D mlx5_glue- > >dv_create_flow_action_packet_reformat > + (priv->ctx, size, buf, > + > MLX5DV_FLOW_ACTION_PACKET_REFORMAT_TYPE_L2_TO_L2_TUNNEL, > + MLX5DV_FLOW_TABLE_TYPE_NIC_TX); > + if (!verbs_action) > + rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > + NULL, "cannot create L2 encap action"); > + return verbs_action; > +} > + > +/** > * Verify the @p attributes will be correctly understood by the NIC and = store > * them in the @p flow if everything is correct. > * > @@ -339,6 +638,16 @@ > action_flags |=3D MLX5_FLOW_ACTION_COUNT; > ++actions_n; > break; > + case RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP: > + ret =3D > flow_dv_validate_action_l2_encap(action_flags, > + actions, attr, > + error); > + if (ret < 0) > + return ret; > + action_flags |=3D > MLX5_FLOW_ACTION_VXLAN_ENCAP; > + ++actions_n; > + break; > + > default: > return rte_flow_error_set(error, ENOTSUP, >=20 > RTE_FLOW_ERROR_TYPE_ACTION, > @@ -1045,14 +1354,23 @@ > /** > * Store the requested actions in an array. > * > + * @param[in] dev > + * Pointer to rte_eth_dev structure. > * @param[in] action > * Flow action to translate. > * @param[in, out] dev_flow > * Pointer to the mlx5_flow. > + * @param[out] error > + * Pointer to the error structure. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set= . > */ > -static void > -flow_dv_create_action(const struct rte_flow_action *action, > - struct mlx5_flow *dev_flow) > +static int > +flow_dv_create_action(struct rte_eth_dev *dev, > + const struct rte_flow_action *action, > + struct mlx5_flow *dev_flow, > + struct rte_flow_error *error) > { > const struct rte_flow_action_queue *queue; > const struct rte_flow_action_rss *rss; @@ -1100,10 +1418,24 @@ > /* Added to array only in apply since we need the QP */ > flow->actions |=3D MLX5_FLOW_ACTION_RSS; > break; > + case RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP: > + dev_flow->dv.actions[actions_n].type =3D > + MLX5DV_FLOW_ACTION_IBV_FLOW_ACTION; > + dev_flow->dv.actions[actions_n].action =3D > + flow_dv_create_action_l2_encap(dev, > action, > + error); > + if (!(dev_flow->dv.actions[actions_n].action)) > + return -rte_errno; > + dev_flow->dv.encap_decap_verbs_action =3D > + dev_flow->dv.actions[actions_n].action; > + flow->actions |=3D MLX5_FLOW_ACTION_VXLAN_ENCAP; > + actions_n++; > + break; > default: > break; > } > dev_flow->dv.actions_n =3D actions_n; > + return 0; > } >=20 > static uint32_t matcher_zero[MLX5_ST_SZ_DW(fte_match_param)] =3D { 0 }; > @@ -1217,7 +1549,6 @@ > return 0; > } >=20 > - > /** > * Fill the flow with DV spec. > * > @@ -1272,7 +1603,8 @@ > if (flow_dv_matcher_register(dev, &matcher, dev_flow, error)) > return -rte_errno; > for (; actions->type !=3D RTE_FLOW_ACTION_TYPE_END; actions++) > - flow_dv_create_action(actions, dev_flow); > + if (flow_dv_create_action(dev, actions, dev_flow, error)) > + return -rte_errno; > return 0; > } >=20 > @@ -1457,6 +1789,11 @@ > LIST_REMOVE(dev_flow, next); > if (dev_flow->dv.matcher) > flow_dv_matcher_release(dev, dev_flow); > + if (dev_flow->dv.encap_decap_verbs_action) { > + claim_zero(mlx5_glue->destroy_flow_action > + (dev_flow->dv.encap_decap_verbs_action)); > + dev_flow->dv.encap_decap_verbs_action =3D NULL; > + } > rte_free(dev_flow); > } > } > -- > 1.8.3.1