From: Shahaf Shuler <shahafs@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"santosh.shukla@caviumnetworks.com"
<santosh.shukla@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs
Date: Thu, 22 Mar 2018 06:26:04 +0000 [thread overview]
Message-ID: <DB7PR05MB4426FFB1A515AF25E8724FA1C3A90@DB7PR05MB4426.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <09c1f0a1-46f8-4eb0-55a9-e5630001822f@intel.com>
Wednesday, March 21, 2018 9:26 PM, Ferruh Yigit:
> Subject: Re: [dpdk-dev] [PATCH] net/octeontx: use the new offload APIs
>
> > +
> > + if (configured_offloads & DEV_RX_OFFLOAD_CHECKSUM) {
> > + PMD_INIT_LOG(NOTICE, "rxcksum not supported");
> > + configured_offloads &= ~DEV_RX_OFFLOAD_CHECKSUM;
> > + }
>
> Not sure about changing the application configuration, and since this offload
> is not reported as supported application should not set it, if it does this
> should return an error.
Yes, any wrong offload configuration should fail the port/queue configuration with the proper error logging.
PMDs should not silently adopt to wrong configuration. This might lead the application to believe Rx checksum offload was enabled.
next prev parent reply other threads:[~2018-03-22 6:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 19:07 Pavan Nikhilesh
2018-03-11 18:14 ` santosh
2018-03-21 19:25 ` Ferruh Yigit
2018-03-22 6:26 ` Shahaf Shuler [this message]
2018-03-26 7:30 ` Pavan Nikhilesh
2018-03-26 11:02 ` [dpdk-dev] [PATCH v2] " Pavan Nikhilesh
2018-04-05 13:13 ` Ferruh Yigit
2018-04-05 13:23 ` [dpdk-dev] [PATCH v3] " Pavan Nikhilesh
2018-04-05 13:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB4426FFB1A515AF25E8724FA1C3A90@DB7PR05MB4426.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).