From: Tal Shnaiderman <talshn@mellanox.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
"pallavi.kadam@intel.com" <pallavi.kadam@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"grive@u256.net" <grive@u256.net>,
"ranjit.menon@intel.com" <ranjit.menon@intel.com>,
"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>
Subject: Re: [dpdk-dev] [PATCH v2 7/7] bus/pci: support Windows with bifurcated drivers
Date: Sun, 3 May 2020 11:53:20 +0000 [thread overview]
Message-ID: <DB7PR05MB53242A68A5D50AF019501424A9A90@DB7PR05MB5324.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200429030152.0ebaae32@Sovereign>
> Subject: Re: [PATCH v2 7/7] bus/pci: support Windows with bifurcated
> drivers
>
> On 2020-04-28 12:11 GMT+0300 talshn@mellanox.com wrote:
> [snip]
> > + switch (dev->kdrv) {
> > + case RTE_KDRV_NONE:
> > + /* Get NUMA node using DEVPKEY_Device_Numa_Node */
> > + bResult = SetupDiGetDevicePropertyW(hDevInfo,
> pDeviceInfoData,
> > + &DEVPKEY_Device_Numa_Node, &uPropertyType,
> > + (BYTE *)&uNumaNode, sizeof(uNumaNode), NULL,
> 0);
> > + if (!bResult) {
> > + ret = GetLastError();
> > + goto end;
> > + }
> > + dev->device.numa_node = uNumaNode;
>
> Note: NUMA node != socket ID, but this field is used as socket ID by PMDs.
> I suggest adding Windows-only EAL API to do the translation.
Thank you for the review and notes Dmitry, will apply in v3.
Regarding numa node and socket id, AFAIK in x86 processors numa node == socket id
In other processors that is not the case but of the current Windows support of DPDK the
Implementation above should be sufficient.
> [snip]
prev parent reply other threads:[~2020-05-03 11:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 9:11 [dpdk-dev] [PATCH v2 0/7] Windows bus/pci support talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 1/7] eal: move OS common functions to single file talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 2/7] pci: build on Windows talshn
2020-04-28 23:52 ` Dmitry Kozlyuk
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 3/7] eal: add function finding integer in a string talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 4/7] drivers: ignore pmdinfogen generation for Windows talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 5/7] drivers: fix incorrect meson import folder " talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 6/7] bus/pci: introduce Windows support with stubs talshn
2020-04-28 9:11 ` [dpdk-dev] [PATCH v2 7/7] bus/pci: support Windows with bifurcated drivers talshn
2020-04-29 0:01 ` Dmitry Kozlyuk
2020-05-03 11:53 ` Tal Shnaiderman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB7PR05MB53242A68A5D50AF019501424A9A90@DB7PR05MB5324.eurprd05.prod.outlook.com \
--to=talshn@mellanox.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=grive@u256.net \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).