From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40050.outbound.protection.outlook.com [40.107.4.50]) by dpdk.org (Postfix) with ESMTP id 876512BFA; Wed, 12 Sep 2018 03:59:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ccoe3qKjlBBR6VpW6STPZusXBYIYaFVThgXNqSEPAS8=; b=YVfCAKR3uBF1+Q8w1eZ2ZyflCG0KcY/sVFxQVzOSf/BfswPyHoBvEBwG2sFDezvLtHZ63n9exijp8hgjuCx2w3tVaVEpKZ0v/l2QLVqr/SUIYYjlYv8YzShrywa+McPNd2FBll4EVATPEqopWvHjJ0MGNiIr5a3uPn9r8jxYKfE= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3321.eurprd08.prod.outlook.com (52.134.111.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1122.15; Wed, 12 Sep 2018 01:59:29 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::f0e6:1c3d:9285:472f]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::f0e6:1c3d:9285:472f%3]) with mapi id 15.20.1122.020; Wed, 12 Sep 2018 01:59:29 +0000 From: "Phil Yang (Arm Technology China)" To: "Iremonger, Bernard" , dev , "dev@dpdk.org" CC: nd , "Gavin Hu (Arm Technology China)" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation Thread-Index: AQHUPekIghDJhLNkCk+16QwKIHIg56TrW6MAgACgf2A= Date: Wed, 12 Sep 2018 01:59:29 +0000 Message-ID: References: <1535362398-6526-1-git-send-email-phil.yang@arm.com> <8CEF83825BEC744B83065625E567D7C260CEECCC@IRSMSX107.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CEECCC@IRSMSX107.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR08MB3321; 6:iy7lMOnfjspSg05RssXu6TBmXQmJ0kwpo3l/C6XgKgXQV/IsFYVyl0aG+zzVulI5ZMz01F9irP7dOBYFFRLRzPFb+ukf/QNEJr4+WNTFPUI7ItpYz43zXYbGFfNYRRTv/spEFzY4Qqys4ghra939c5pj8Dru/ypSdqFeMZlfLYW1FWiRNo7cN3Wh/OgERwhwSdMllTC41ihUd9oIXTsUtE8+1WpBb1w525L1JiUCvUFCAun7ymKKr0rhgq+mo7lLUOs6jFHoK+g2z40C9+4Dq1flaNIw8qa3bnKFZmSQBCvi685J7KiqEWqpcoz8GhAUM6f+7z8YvV55XyJQvo+DJXYODgd8uTUSEi5L2DRjhPUw+d9f1l6HauGMMN5TbTHCqzEPjVkw9mbRbGDEF44VXKU7RB8hI19TViwwG+a8KQQHgr2ViLL3TFZMo2JUqyd56MkklwuAjJTtphoTIKWxCQ==; 5:1o/JmRuTB4aKFY3iLXeFd5FbalGtQlB/D5VXl1cUZ2+/x9JuSAIOirmBuCKvRC8NIRn747z/LG+lSNku4ae9iztEdaRms3opfaq4ABMLgy7rxhHvWFJVEe0uiIS5bHaCOcSExSgFqH4JMTzZ5Tjgvm/f8nuGuSUN4v9ua1m+40Q=; 7:QcjL72r3OtuoL4or4T+cedFHPoYDC4fGvNyI7mv6k85m36yjvoI8DtuSl6JFhtICq5HMr9up9LWVxeM4WKkXoTpCQ4+VdM4BHWkKqExmwEWGC+4jAEPUKXhnhJ7c4j7Pakz046EUOcd75qG+WVcJ2MJqMybi8mjJ/CXzJtqfdhFoF5dB16/YBZ+1ZF7usFzKMLo/jtwuag40zNfDZlRtUlfBrhraMQeT9kuy2wK0WeYLFhbnb+YEE30dpGebh5dJ x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: fd10e6f6-9e28-4a69-faaf-08d618536074 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3321; x-ms-traffictypediagnostic: DB7PR08MB3321: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301075)(93006095)(93001095)(10201501046)(3002001)(3231344)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699050)(76991041); SRVR:DB7PR08MB3321; BCL:0; PCL:0; RULEID:; SRVR:DB7PR08MB3321; x-forefront-prvs: 07935ACF08 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(136003)(396003)(366004)(376002)(189003)(199004)(13464003)(99286004)(86362001)(8676002)(66066001)(229853002)(74316002)(2906002)(476003)(7696005)(305945005)(2900100001)(11346002)(446003)(7736002)(486006)(256004)(186003)(76176011)(2501003)(33656002)(5660300001)(81156014)(5250100002)(97736004)(6506007)(81166006)(54906003)(8936002)(316002)(53936002)(68736007)(6346003)(6246003)(53546011)(55236004)(106356001)(26005)(6116002)(55016002)(3846002)(6436002)(9686003)(14454004)(25786009)(478600001)(72206003)(110136005)(105586002)(102836004)(4326008); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3321; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-microsoft-antispam-message-info: wJZgWUxSP91Tx+N4nIvN5YR/Ys4Cuvblj8cEhv5HBVUKsjLykJhwgbIq9n91EKxRVRI5q29J9c8UWlodEEXfg8HUnyO0r7mBJ1NkXzS5MwNI6K4+dwDhCDAkWKy2mMHG9oQFDhZT6vedLyG5mX6TCHz8w0/bj0wGYp2DOa4SLNgyz/xj0hJ91q3QK1Kyh0v9Uujnqpb5dC7o3KLqTjPElw5w2noxozSBeSANsMfMvRL5IsF5wbT/Hroe3gsVYMPrGxoxISxFvYw5YCNv8dFUM6P0rD5N5OCtdHG3I7XTFSbjvFQnAZ+DQRgD6glz3mokOFuRCegvi19ZraKipypk+4LXqVqh0qCt2d2k25ATGOE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd10e6f6-9e28-4a69-faaf-08d618536074 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2018 01:59:29.8274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3321 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 01:59:30 -0000 Hi Bernard, Thanks for you comments. I have updated the patch. Please review it. Thanks, Phil Yang > -----Original Message----- > From: dev On Behalf Of Iremonger, Bernard > Sent: Wednesday, September 12, 2018 12:23 AM > To: dev ; dev@dpdk.org > Cc: nd ; Gavin Hu (Arm Technology China) > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool allocat= ion >=20 > Hi Gavin, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] > > Sent: Monday, August 27, 2018 10:33 AM > > To: dev@dpdk.org > > Cc: nd@arm.com; gavin.hu@arm.com > > Subject: [dpdk-dev] [PATCH] app/testpmd: Optimize membuf pool > > allocation > > > > By default, testpmd will create membuf pool for all NUMA nodes and > > ignore EAL configuration. > > > > Count the number of available NUMA according to EAL core mask or core > > list configuration. Optimized by only creating membuf pool for those no= des. > > > > Fixes: d5aeab6542f ("app/testpmd: fix mempool creation by socket id") > > > > Signed-off-by: Phil Yang > > --- > > app/test-pmd/testpmd.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > ee48db2..a56af2b 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -476,6 +476,8 @@ set_default_fwd_lcores_config(void) > > > > nb_lc =3D 0; > > for (i =3D 0; i < RTE_MAX_LCORE; i++) { > > + if (!rte_lcore_is_enabled(i)) > > + continue; > > sock_num =3D rte_lcore_to_socket_id(i); > > if (new_socket_id(sock_num)) { > > if (num_sockets >=3D RTE_MAX_NUMA_NODES) { @@ - > > 485,8 +487,6 @@ set_default_fwd_lcores_config(void) > > } > > socket_ids[num_sockets++] =3D sock_num; > > } > > - if (!rte_lcore_is_enabled(i)) > > - continue; > > if (i =3D=3D rte_get_master_lcore()) > > continue; > > fwd_lcores_cpuids[nb_lc++] =3D i; > > -- > > 2.7.4 >=20 > ./dpdk/devtools/check-git-log.sh -1 >=20 > Wrong headline uppercase: > app/testpmd: Optimize membuf pool allocation Wrong 'Fixes' refere= nce: > Fixes: d5aeab6542f ("app/testpmd: fix mempool creation by socket = id") >=20 > Regards, >=20 > Bernard. >=20