From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70078.outbound.protection.outlook.com [40.107.7.78]) by dpdk.org (Postfix) with ESMTP id 22119239 for ; Sat, 30 Mar 2019 17:55:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8z6iy4cahSz2bYsqjJxaOOfeGZ+4Xwi1ynWKv8OEfO4=; b=iGYEmtt/DxT3KDVvhZLFHvcbw/uNlKevLwakGVvfLvMSqPaQG7y+hIaMJ0Otn0nSaIqdswpm6pFIsFaChbCD3YU4AX2DyeIyFXf/heQugX0Q/BXZjPfBmOKKxw2Hmy0wcG9XqtwKJ7iRCza1bveNddy/hyfF/+RjEL9BWiUxbKM= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3564.eurprd08.prod.outlook.com (20.177.120.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.16; Sat, 30 Mar 2019 16:55:22 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe%5]) with mapi id 15.20.1750.017; Sat, 30 Mar 2019 16:55:22 +0000 From: "Phil Yang (Arm Technology China)" To: "Pattan, Reshma" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "Hunt, David" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Thread-Index: AQHU5h4f4SycvOPeMUyZPHSuJ0FAPqYiz88AgAGCYuA= Date: Sat, 30 Mar 2019 16:55:22 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1553856998-25394-2-git-send-email-phil.yang@arm.com> <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [240e:e0:e440:af00:dd61:2462:efec:994d] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92ef17e9-eb94-4521-6aba-08d6b5307fac x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3564; x-ms-traffictypediagnostic: DB7PR08MB3564: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 09928BEC91 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(396003)(376002)(136003)(366004)(52314003)(199004)(189003)(13464003)(102836004)(478600001)(25786009)(33656002)(55016002)(9686003)(6116002)(99286004)(68736007)(97736004)(7696005)(186003)(8936002)(52536014)(229853002)(6436002)(5660300002)(81166006)(81156014)(8676002)(46003)(72206003)(14454004)(54906003)(2201001)(305945005)(110136005)(105586002)(7736002)(256004)(74316002)(53546011)(4326008)(316002)(6246003)(486006)(2906002)(71200400001)(106356001)(11346002)(2501003)(53936002)(71190400001)(446003)(76176011)(476003)(86362001)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3564; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9lyQxaLZ9ZEqt+K6uiEwuR8pnlRD6yq1PzBF8yq+2S+Zfc4Y32k9/SSlVeqYar/G/8lOeoNKFib3Wdikg0741B1K0RiW8+Q1WKwoP56I8AzNhjeg9cztG3mLiQlCHjiKUJ25fuyRMbXMVCifYk9f31Dj8ivomG4FXL1lgcZaadA/EmyYfPPn2uGmxr3oW2EPYzLZ6t5qjo7p9bs9T+0OgyYu3YxDpcYcvkx8n4oQqPntWF9fu0DPJUYP3TjKvbAuvdbhz7e6S2/6sVROKlchzMD+tfLYkaa1xWQRZrttjNAC1lFTQpzfvnGKk5Rv+YAmvt2kzz+V/uCS+B60DNA3YSihJJHMR26teDVBclcj2KY3PCA6Rz2tD6KxjHsDL0/d50PwHB5QSAYSQJB+APIU+yIRjCi9B1xjMmRbnnjxUoY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92ef17e9-eb94-4521-6aba-08d6b5307fac X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2019 16:55:22.3676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564 Subject: Re: [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Mar 2019 16:55:24 -0000 > -----Original Message----- > From: Pattan, Reshma > Sent: Saturday, March 30, 2019 12:40 AM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org; > thomas@monjalon.net > Cc: Hunt, David ; Gavin Hu (Arm Technology China) > ; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each work= er > thread >=20 >=20 >=20 > > -----Original Message----- > > From: Phil Yang [mailto:phil.yang@arm.com] > > > > The current implementation using '__sync' built-ins to synchronize > > statistics within worker threads. '__sync' built-ins functions are > > full barriers which will affect the performance, so add a per worker pa= ckets > statistics. > > > > Enable by option --insight-worker. > > >=20 > I don't feel the need of this new option to print per core stats. Any re= ason > for this? Hi Reshma, Thanks for your comment.=20 The per core stats aims at removing the '__sync' builtin full barrier in th= e worker thread.=20 It records the workload of each core (It shows the bottleneck core as well)= . Since the maximum core number may be more than 128, so disable the print= in default and add this new option for debugging use.=20 Anyway, if you insist there is no need to print that info out, I can remove= the option. But I think using per core stats will benefit performance. Thanks, Phil >=20 > Thanks, > Reshma From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD45CA05D3 for ; Sat, 30 Mar 2019 17:55:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 678271E33; Sat, 30 Mar 2019 17:55:25 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70078.outbound.protection.outlook.com [40.107.7.78]) by dpdk.org (Postfix) with ESMTP id 22119239 for ; Sat, 30 Mar 2019 17:55:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8z6iy4cahSz2bYsqjJxaOOfeGZ+4Xwi1ynWKv8OEfO4=; b=iGYEmtt/DxT3KDVvhZLFHvcbw/uNlKevLwakGVvfLvMSqPaQG7y+hIaMJ0Otn0nSaIqdswpm6pFIsFaChbCD3YU4AX2DyeIyFXf/heQugX0Q/BXZjPfBmOKKxw2Hmy0wcG9XqtwKJ7iRCza1bveNddy/hyfF/+RjEL9BWiUxbKM= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3564.eurprd08.prod.outlook.com (20.177.120.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.16; Sat, 30 Mar 2019 16:55:22 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::54da:2a4f:adc2:63fe%5]) with mapi id 15.20.1750.017; Sat, 30 Mar 2019 16:55:22 +0000 From: "Phil Yang (Arm Technology China)" To: "Pattan, Reshma" , "dev@dpdk.org" , "thomas@monjalon.net" CC: "Hunt, David" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH v2 1/3] packet_ordering: add statistics for each worker thread Thread-Index: AQHU5h4f4SycvOPeMUyZPHSuJ0FAPqYiz88AgAGCYuA= Date: Sat, 30 Mar 2019 16:55:22 +0000 Message-ID: References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1553856998-25394-2-git-send-email-phil.yang@arm.com> <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com> In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A432EBB@irsmsx110.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [240e:e0:e440:af00:dd61:2462:efec:994d] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92ef17e9-eb94-4521-6aba-08d6b5307fac x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3564; x-ms-traffictypediagnostic: DB7PR08MB3564: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 09928BEC91 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(39860400002)(396003)(376002)(136003)(366004)(52314003)(199004)(189003)(13464003)(102836004)(478600001)(25786009)(33656002)(55016002)(9686003)(6116002)(99286004)(68736007)(97736004)(7696005)(186003)(8936002)(52536014)(229853002)(6436002)(5660300002)(81166006)(81156014)(8676002)(46003)(72206003)(14454004)(54906003)(2201001)(305945005)(110136005)(105586002)(7736002)(256004)(74316002)(53546011)(4326008)(316002)(6246003)(486006)(2906002)(71200400001)(106356001)(11346002)(2501003)(53936002)(71190400001)(446003)(76176011)(476003)(86362001)(6506007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3564; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 9lyQxaLZ9ZEqt+K6uiEwuR8pnlRD6yq1PzBF8yq+2S+Zfc4Y32k9/SSlVeqYar/G/8lOeoNKFib3Wdikg0741B1K0RiW8+Q1WKwoP56I8AzNhjeg9cztG3mLiQlCHjiKUJ25fuyRMbXMVCifYk9f31Dj8ivomG4FXL1lgcZaadA/EmyYfPPn2uGmxr3oW2EPYzLZ6t5qjo7p9bs9T+0OgyYu3YxDpcYcvkx8n4oQqPntWF9fu0DPJUYP3TjKvbAuvdbhz7e6S2/6sVROKlchzMD+tfLYkaa1xWQRZrttjNAC1lFTQpzfvnGKk5Rv+YAmvt2kzz+V/uCS+B60DNA3YSihJJHMR26teDVBclcj2KY3PCA6Rz2tD6KxjHsDL0/d50PwHB5QSAYSQJB+APIU+yIRjCi9B1xjMmRbnnjxUoY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92ef17e9-eb94-4521-6aba-08d6b5307fac X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2019 16:55:22.3676 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564 Subject: Re: [dpdk-dev] [PATCH v2 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190330165522.gLIFjmlnseE7DegYAGQ8T1v8Y97rg93bvrRESEPXxB4@z> > -----Original Message----- > From: Pattan, Reshma > Sent: Saturday, March 30, 2019 12:40 AM > To: Phil Yang (Arm Technology China) ; dev@dpdk.org; > thomas@monjalon.net > Cc: Hunt, David ; Gavin Hu (Arm Technology China) > ; Honnappa Nagarahalli > ; nd > Subject: RE: [PATCH v2 1/3] packet_ordering: add statistics for each work= er > thread >=20 >=20 >=20 > > -----Original Message----- > > From: Phil Yang [mailto:phil.yang@arm.com] > > > > The current implementation using '__sync' built-ins to synchronize > > statistics within worker threads. '__sync' built-ins functions are > > full barriers which will affect the performance, so add a per worker pa= ckets > statistics. > > > > Enable by option --insight-worker. > > >=20 > I don't feel the need of this new option to print per core stats. Any re= ason > for this? Hi Reshma, Thanks for your comment.=20 The per core stats aims at removing the '__sync' builtin full barrier in th= e worker thread.=20 It records the workload of each core (It shows the bottleneck core as well)= . Since the maximum core number may be more than 128, so disable the print= in default and add this new option for debugging use.=20 Anyway, if you insist there is no need to print that info out, I can remove= the option. But I think using per core stats will benefit performance. Thanks, Phil >=20 > Thanks, > Reshma