From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80044.outbound.protection.outlook.com [40.107.8.44]) by dpdk.org (Postfix) with ESMTP id E5EBE568A; Wed, 17 Oct 2018 03:41:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZNMWUG0550sdMcLr6AJeVdd40orubdjg/MARuk+128c=; b=KmwBgHGEGO9u5Y5cUF+ElblfEF+r/W+q9zDai49Yzcb1lLsN31n/zft5QxuaYnwFP7gJ069DT5xChpjil9gIU+p7RSjp7oCu1oGs1utOoM93R9p7BKBpBcsKH1w/fMM/NBHIGwcl00BOSvKJPDX7bqdy54gIDgaM8uL8DhkPR6M= Received: from DB7PR08MB3385.eurprd08.prod.outlook.com (20.176.238.90) by DB7PR08MB3564.eurprd08.prod.outlook.com (20.177.120.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.21; Wed, 17 Oct 2018 01:41:01 +0000 Received: from DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::eda0:7bf6:a891:3ae7]) by DB7PR08MB3385.eurprd08.prod.outlook.com ([fe80::eda0:7bf6:a891:3ae7%6]) with mapi id 15.20.1250.020; Wed, 17 Oct 2018 01:41:01 +0000 From: "Phil Yang (Arm Technology China)" To: "Ananyev, Konstantin" , dev , "dev@dpdk.org" CC: "Yigit, Ferruh" , nd Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initialization Thread-Index: AQHUZTyd7OOc7duLSE2BrfE7bDrkcqUiqeZg Date: Wed, 17 Oct 2018 01:41:01 +0000 Message-ID: References: <1539684892-19831-1-git-send-email-phil.yang@arm.com> <2601191342CEEE43887BDE71AB9772580102FE779C@IRSMSX106.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580102FE779C@IRSMSX106.ger.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Phil.Yang@arm.com; x-originating-ip: [59.152.244.201] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR08MB3564; 6:R3xYCXa0tCTTKh6fn+9K9XZ8637lBkIR41oj1iLWHYT1RO0cSMBoIBlSud2bpKZY+VvKPf3H6svqjofR6qzB4dI0JFcDcZ53xZbx4ChgD9mEKZNRH6YTyphEfxWO2Oe+rClTSZgvOMgcJSbm/rPHT6BhoSa/sdihcTJRyra1xe0TBsrLkzi/LL8A+kq9ZucX30IyxrYDJjuLuv8GKOYl46uQjqx+HuXk28DaQY1lI+t44w7l2YStmEb0y5cwD7JAIcvBj4BJWFRTYGc87zki+1zqbt+yvcRETQmkxnfAaDNSNeovrXdXIrAt9ho7/7H12DBB22krpvHBpEYNXoIQzVSLbu6mEISmZ2dNyRNGNwWY0PNzTt4c0w/d7mxfjdq2Djh2I9S/tsETjaGBwyhnQKhz954Pu08oy2r9EBBO8Cb9/FfGr1vLdDvz4BmRCRsuLXM4wL7DwWJChdE4u7btPA==; 5:u1hJwx3rusyObq3f5aeEolEdZdc1zzDwnJtp2HE1izvEcdpo/PStk9WOs7wO/ZtOyL+3QLwycIUCxr2akqw3B4pJHCFNFei8Oq/K/wl31TWeIR1mWzqw/5X4na9uV7fG8aEzztXfrdqQikaDZl9HjxF/OBcuz05kN4pzCV0VSjI=; 7:W4DW8BLYSTnBFQ207uF8d1LhOF7EexvNynR5RYO4vjjXAiW53Yk3kuRJsdLYE7ZbozInI0qVLmjr+HFSRegsH5y5vO3Taz6NUyi1H0M6pOhLxpZ6o/BjCtLzRhDFkIEPJ/6WDodL7RyIOLzI1IhZ5hLxFAvA+FsWm2cHUXbNKK5bL7trRIrezxz8Con5u7EbWSzHTguLJwr8g268279WIx+8Atwk9jBR+lb/E/c/FbKiGR3dgSZc+RFH6de/QpKW x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 2f07b2b2-5ab0-4043-441f-08d633d19813 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3564; x-ms-traffictypediagnostic: DB7PR08MB3564: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051); SRVR:DB7PR08MB3564; BCL:0; PCL:0; RULEID:; SRVR:DB7PR08MB3564; x-forefront-prvs: 08286A0BE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(366004)(346002)(376002)(136003)(39860400002)(396003)(13464003)(199004)(189003)(2906002)(6246003)(2501003)(478600001)(97736004)(6116002)(3846002)(72206003)(2900100001)(256004)(14444005)(5024004)(66066001)(81166006)(81156014)(14454004)(4326008)(86362001)(68736007)(316002)(25786009)(229853002)(26005)(54906003)(186003)(110136005)(102836004)(105586002)(8936002)(106356001)(5660300001)(6436002)(5250100002)(71200400001)(71190400001)(76176011)(99286004)(6506007)(305945005)(446003)(7736002)(74316002)(55016002)(7696005)(53546011)(476003)(33656002)(9686003)(486006)(53936002)(11346002)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3564; H:DB7PR08MB3385.eurprd08.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: hYk3SFcN8A894Is5MxrnPHNDDwgvcXZd2X9uUypReRk8eKDA+Lyyftw2ydPrth1SVqatmP3ETw3sw8gUhdr88sAykbISpz+xQsGCtwueBJFeJwqmwHaFbvV5eNfTOye8UgXB6w4PZXu3i6EB3fj86XUcpXfOsb+g57JO0kG84Gd1003n2GtFms3I9I1Ml76EhwoOXblSMJC+1JPwUflxCvH2iE+ooKYWhyAKJmjiczMNAqznaxXr3mZ8G3ftKLzXbxvg7RoKeoVQMrLDItW7IeeUbQWTL3DbMhfV3wMw9gQ+n4/3oXEme1MmrRnVR5yBOfZn8T7ICNXt3KZEc9cgHpKJWwRIuZwA80bJu3FB+bU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f07b2b2-5ab0-4043-441f-08d633d19813 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2018 01:41:01.1694 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3564 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 01:41:18 -0000 > -----Original Message----- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Tuesday, October 16, 2018 6:40 PM > To: dev ; dev@dpdk.org > Cc: Yigit, Ferruh ; nd > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket initi= alization >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] > > Sent: Tuesday, October 16, 2018 11:15 AM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh ; nd@arm.com > > Subject: [dpdk-dev] [PATCH] app/testpmd: fix physic port socket > > initialization > > > > Once the lcore list setting excluded the socket which physic device > > attached, it will cause failure. Meanwhile, it will disable Testpmd > > cross NUMA scenario. > > > > Fixes: dbfb8ec ("app/testpmd: optimize mbuf pool allocation") > > > > Signed-off-by: Phil Yang > > Reviewed-by: Gavin Hu > > --- > > app/test-pmd/testpmd.c | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > 5dbbf78..4739ddb 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -565,9 +565,21 @@ set_default_fwd_ports_config(void) > > portid_t pt_id; > > int i =3D 0; > > > > - RTE_ETH_FOREACH_DEV(pt_id) > > + RTE_ETH_FOREACH_DEV(pt_id) { > > fwd_ports_ids[i++] =3D pt_id; > > > > + /* Update sockets info according to the attached device */ > > + int socket_id =3D rte_eth_dev_socket_id(pt_id); > > + if (socket_id >=3D 0 && new_socket_id(pt_id)) { >=20 > Should be: ' new_socket_id(socket_id)', I think. > Konstantin Exactly. Thanks Konstantin. It has been fixed in V2. >=20 > > + if (num_sockets >=3D RTE_MAX_NUMA_NODES) { > > + rte_exit(EXIT_FAILURE, > > + "Total sockets greater than %u\n", > > + RTE_MAX_NUMA_NODES); > > + } > > + socket_ids[num_sockets++] =3D socket_id; > > + } > > + } > > + > > nb_cfg_ports =3D nb_ports; > > nb_fwd_ports =3D nb_ports; > > } > > -- > > 2.7.4