From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40087.outbound.protection.outlook.com [40.107.4.87]) by dpdk.org (Postfix) with ESMTP id E39D11B136 for ; Wed, 2 Jan 2019 19:23:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GmN5QwyFcWHH8YfUD01mX3Z5lKo/kE+PkIRzKMOnFOc=; b=LLLZ3+aEUyINd53nLyNLSmZ1gilf8J8p3edtxMrQD7unEET9iJVGaQ5D76S/pccUTTO4kdrgV1/8vpJJ+jLuHSuLKEE71sySqK7vOE0haUe5S4gSfa0XWTI3aoGwAyJ7rDfN6J+nrN5l5jLsWJJlSXjK79Sq/sQZCLPwn1XPuN8= Received: from DB7PR08MB3674.eurprd08.prod.outlook.com (20.177.120.156) by DB7PR08MB3563.eurprd08.prod.outlook.com (20.177.120.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Wed, 2 Jan 2019 18:23:11 +0000 Received: from DB7PR08MB3674.eurprd08.prod.outlook.com ([fe80::e146:fdc1:bfa1:9953]) by DB7PR08MB3674.eurprd08.prod.outlook.com ([fe80::e146:fdc1:bfa1:9953%5]) with mapi id 15.20.1495.005; Wed, 2 Jan 2019 18:23:11 +0000 From: Honnappa Nagarahalli To: "Ruifeng Wang (Arm Technology China)" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "bruce.richardson@intel.com" , "chaozhu@linux.vnet.ibm.com" , nd , "Ruifeng Wang (Arm Technology China)" , "tomaszx.kulasek@intel.com" , nd Thread-Topic: [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM Thread-Index: AQHUolwb+tilr6lpFk+iL938RxKCjqWcSoqQ Date: Wed, 2 Jan 2019 18:23:11 +0000 Message-ID: References: <20190102052826.156605-1-ruifeng.wang@arm.com> In-Reply-To: <20190102052826.156605-1-ruifeng.wang@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Honnappa.Nagarahalli@arm.com; x-originating-ip: [217.140.111.135] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB7PR08MB3563; 6:FTtk/9QzJT6kcJ57AHoe0xzUfso3NtyiSyscVQtn7DzVuthdeNYFP/JT9oovpHNPLG53BIYYLySLzD8iWCnfrKTLLogi1JRdvqFjCprxMEER1MRox6/8vIHzTh4EKbgGEA/mD78o8bhAOgVPCrSBy+mNLpVJ1bd9kWw8vEE0kT4RkrZ0WnQnqA27lgRARa0DCGtNh1GBsI1Hbuz7CU3v7Cm2xDvbZ9/hchNNN77WZKpGUanmcoRpiGxUM1Sp6H+qw1xjYDXdurbPp0nkS/PtM7S9s6KBps/tk1GOFIINDTmi5k8f/hmgNh+njNEevtI8bNzH3bxHQ6Frcq8Fie7BG+L1Mazse/3sZtqkiMjvBkmlxRLgbz7CfhWWdxwEIFMW/ryFv/wyLYSZfc8ohjhXc+uWWG+j6oLtrKGtnsdNOpFpxALnplnRDO2Zt5NOUVhv+6PMZsYAWQxW0KZ+pAV8aA==; 5:NvlBjaMDdi1riqf3GtdwBvMG3fFy0iyl4ceVTijECnq8Xu3zqkj4cQLExR1LyuJPD2Dt9WgsV7FpqxSoappjxGNnu3VFMp9WSUHyxeBUUpmH/xCZxVGWXY2BP+h+1PtYedDX2fHp+bpXiYchkHvyFTOm8CeiNRkoUiuXSzTd+OlnPI/HZGUqYdDY0Y37bz+bF0cI+LeJGeppyEQnGNEpiA==; 7:1u1pm5uJrcdHEEaUkXGgHcQYhSRjsGSiy1ED5+ZZ197WFqFQB4PSwbmZT2t0BD4cduZif1rB9uoinshIiGv9aj0GisrQh6Az6NHUKvPeYITIsUORhUk2WyC6yvxYcNaJ7gvtOMUdZ4FO93uioqJZSw== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-ms-office365-filtering-correlation-id: b95a331c-08d8-4b84-e6e2-08d670df5a6e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR08MB3563; x-ms-traffictypediagnostic: DB7PR08MB3563: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220060)(2401047)(8121501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(10201501046)(6055026)(6041310)(20161123564045)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:DB7PR08MB3563; BCL:0; PCL:0; RULEID:; SRVR:DB7PR08MB3563; x-forefront-prvs: 0905A6B2C7 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(366004)(346002)(376002)(396003)(13464003)(199004)(189003)(81166006)(81156014)(26005)(53546011)(7696005)(8676002)(6506007)(76176011)(99286004)(186003)(229853002)(53936002)(102836004)(11346002)(446003)(476003)(7736002)(55016002)(305945005)(8936002)(9686003)(54906003)(6246003)(110136005)(105586002)(2501003)(106356001)(33656002)(6436002)(316002)(5660300001)(97736004)(71190400001)(71200400001)(486006)(2906002)(86362001)(575784001)(6116002)(3846002)(256004)(74316002)(66066001)(72206003)(478600001)(25786009)(4326008)(14454004)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR08MB3563; H:DB7PR08MB3674.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: QCJ3kFyxCfcLA/1EsnV1M3qmpc2cGy8DdawW6Zcfh7bZhJpKVQ4Rat5nqWRt/eTnVdkQl1im1D6Yz3oNlPCA7QMWMrzWNFcvVRf/GapUrGrfGf/40fFxVhP8nRGztFJh5Y5wnCs36mWxVQ7H1xMg0FEubSHa5SYII2gHMhThRh1BmKuLNfUOQTbINIAA+uauqLgypPDTklvweDBOloOqvokyTqK9Lzs0FNtTdmEDmT9KkE9onSDde4pJp/iAs97CPiWaxWsBX2zIEWyMG7jBVfeK5QddJCCMn5YGmiZ1yRd2o5lMmetTuRC3C5EnqYW1 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: b95a331c-08d8-4b84-e6e2-08d670df5a6e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jan 2019 18:23:11.5448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3563 Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 18:23:13 -0000 Thanks Ruifeng for the patch. I have one question inline. Jerin/Hemant, It would be good if you could test this on your platforms, since this is b= eing made default. Thanks, Honnappa > -----Original Message----- > From: Ruifeng Wang > Sent: Tuesday, January 1, 2019 11:28 PM > To: dev@dpdk.org > Cc: thomas@monjalon.net; jerinj@marvell.com; hemant.agrawal@nxp.com; > bruce.richardson@intel.com; chaozhu@linux.vnet.ibm.com; Honnappa > Nagarahalli ; nd ; Ruifeng > Wang (Arm Technology China) ; > tomaszx.kulasek@intel.com > Subject: [PATCH v1] examples/l3fwd: enable hash multi lookup for ARM >=20 > Compile option for hash_multi_lookup was broken, and caused feature canno= t > be enabled on Arm. > This patch sets hash_multi_lookup method as default, and sequential looku= p > becomes optional. >=20 > In test of 8192 flows with 128-byte packets, throughput increased by 25.6= % > after enabling hash_multi_lookup. >=20 I assume these are lookup-hit numbers. Do you have look-up miss numbers? > Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") > Cc: tomaszx.kulasek@intel.com >=20 > Signed-off-by: Ruifeng Wang > Reviewed-by: Gavin Hu > Reviewed-by: Phil Yang > Tested-by: Ruifeng Wang > --- > examples/l3fwd/l3fwd.h | 4 ---- > 1 file changed, 4 deletions(-) >=20 > diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index > c962deac3..063b80018 100644 > --- a/examples/l3fwd/l3fwd.h > +++ b/examples/l3fwd/l3fwd.h > @@ -11,10 +11,6 @@ >=20 > #define RTE_LOGTYPE_L3FWD RTE_LOGTYPE_USER1 >=20 > -#if !defined(NO_HASH_MULTI_LOOKUP) && > defined(RTE_MACHINE_CPUFLAG_NEON) -#define > NO_HASH_MULTI_LOOKUP 1 -#endif > - > #define MAX_PKT_BURST 32 > #define BURST_TX_DRAIN_US 100 /* TX drain every ~100us */ >=20 > -- > 2.17.1