From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E4F29A04BC; Tue, 29 Sep 2020 17:35:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D0D31D6E7; Tue, 29 Sep 2020 17:35:27 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41]) by dpdk.org (Postfix) with ESMTP id 253B51D6C0 for ; Tue, 29 Sep 2020 17:35:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1g2bsOBWQu9etV67l/BWcX/QC1+ZDMztxG/WKHw1wXs=; b=2YDg5jFN+r9pPJzNRcet2lNDTZGxbG1VYKvtloSqacLV0yQwz4aFC1fRt1ANnkrUpLmGFChM3WUbf234jc+pFWQlJAZHHuoOTB4teVYKGBHcz+HUMN0uWFHiu1tJR7N9EvFIMmkC8One+a0XQMayvj4Le+9pj+sFYfJByohdSF4= Received: from AM6P193CA0057.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::34) by HE1PR0801MB2108.eurprd08.prod.outlook.com (2603:10a6:3:51::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.25; Tue, 29 Sep 2020 15:35:22 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::c8) by AM6P193CA0057.outlook.office365.com (2603:10a6:209:8e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.22 via Frontend Transport; Tue, 29 Sep 2020 15:35:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Tue, 29 Sep 2020 15:35:21 +0000 Received: ("Tessian outbound e8cdb8c6f386:v64"); Tue, 29 Sep 2020 15:35:20 +0000 X-CR-MTA-TID: 64aa7808 Received: from 099346d66160.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A91B2E2B-0056-4645-ABE8-B0F5FCDF12F5.1; Tue, 29 Sep 2020 15:35:15 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 099346d66160.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 29 Sep 2020 15:35:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IePyeNZtAjoyBnsHr5+Rldz57RG3o2ktqzDcPefdf8oX6R23lynKyi7DFmTtUDuqV3uFDpim+gU1fdyHrikRoAhfrn+V6ggNRPZfgIlEVGTa/wCw+QT+9/7KsJY1QB4ufP7rbiMhL66YPu0MA/2zx9z0nlpLI1XPswKdCH5Pfo8RXgxUu5zeumn0apw/R25ewn0N2oei9lxFTi6gz1/HOZfq/TPIb4o5gVhS73mJ/CCCBl6BqvzkpEz3maTNM+u+BemMdysKL+uy4BBnOYTmUrDmIgn9F9i+Lugr4v4geP9ETi1A52V0An4Addq1UpppyM2dgw8muorKj7E7gdO4uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1g2bsOBWQu9etV67l/BWcX/QC1+ZDMztxG/WKHw1wXs=; b=fm/OfVshW4C+TFpm6//T0KvkIAWhaVgvnlPmPCDCK4vV08Wrlu6pn2rzgF9THVBpsxnOBlwLr+z9R1LLyEZo0p3YzGI9vKJuNazdBIL5BEOqwt+HC9p0ML5GFkOWRXwJ+aGELrb9M5z0/ERMeZZuSAEmjwaq1k1NFu2rjWHXkkRSOVcYD/+KzimS8D7H7QetQTqVzsWSSRpNRWiWFLQnEnvTcm7FAhkZJJ381t5GCgrfGJ6ajA/XSGfsJqBVdj4pq/OafEcSd/czZvbKdfb8gqBoDrgmmf1fFEw+yNNn3HPybzE0Ykv1efVTE1tq6aqzyEfm0bTVtz+62aPSNOA8WA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1g2bsOBWQu9etV67l/BWcX/QC1+ZDMztxG/WKHw1wXs=; b=2YDg5jFN+r9pPJzNRcet2lNDTZGxbG1VYKvtloSqacLV0yQwz4aFC1fRt1ANnkrUpLmGFChM3WUbf234jc+pFWQlJAZHHuoOTB4teVYKGBHcz+HUMN0uWFHiu1tJR7N9EvFIMmkC8One+a0XQMayvj4Le+9pj+sFYfJByohdSF4= Received: from DB7PR08MB3865.eurprd08.prod.outlook.com (2603:10a6:10:74::25) by DB6PR0801MB1717.eurprd08.prod.outlook.com (2603:10a6:4:3c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.20; Tue, 29 Sep 2020 15:35:14 +0000 Received: from DB7PR08MB3865.eurprd08.prod.outlook.com ([fe80::519c:72bd:e189:625b]) by DB7PR08MB3865.eurprd08.prod.outlook.com ([fe80::519c:72bd:e189:625b%7]) with mapi id 15.20.3412.029; Tue, 29 Sep 2020 15:35:14 +0000 From: Phil Yang To: Lijun Ou , "wenzhuo.lu@intel.com" , "beilei.xing@intel.com" , "adrien.mazarguil@6wind.com" , "ferruh.yigit@intel.com" CC: "dev@dpdk.org" , "linuxarm@huawei.com" , nd , nd Thread-Topic: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration Thread-Index: AQHWknlds8TGHWJXLU6Sf4bUMh4txKl/xtmg Date: Tue, 29 Sep 2020 15:35:14 +0000 Message-ID: References: <1599702678-11142-1-git-send-email-oulijun@huawei.com> <1600955105-53176-1-git-send-email-oulijun@huawei.com> <1600955105-53176-2-git-send-email-oulijun@huawei.com> In-Reply-To: <1600955105-53176-2-git-send-email-oulijun@huawei.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 04CCBF3C2FD9934E86A9411128C2375B.0 x-checkrecipientchecked: true Authentication-Results-Original: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [114.85.108.161] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c74dbc02-75d5-4f70-c341-08d8648d473f x-ms-traffictypediagnostic: DB6PR0801MB1717:|HE1PR0801MB2108: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:597;OLM:597; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B57MHGKAB01z9xX3TNCRYNA0J34Gr3HpQnt9mm3uC6ugzWK63i6YfYaIT0GawjfuEihyIimLyoRt916h5qXrfYXj+gn3P5nsbYJp05NiHExvgrV7CLVjMsQ6V2TTsFab0lTJYYq3eSKjNjN3LIkzuDdSjW1UHoe0iyisOt10VsoYRNZCiGScRJQyJSC/G23IPnc1Q7HoSZ+OOw3/QDC/fcJzE1AnbakU8WzvsgHPxdfgwsgbp6fkIGxdfl5VShIoyU++uLi1eeiAvAqmIBNT3tt7LhLzUiSnWWc2x/vwHgoxXnaTKEBMv4wfTlk3EGvfmjfeFJlNYqavZ4fAoSlFByaX7BrDvw2y3T5t0eqBpx8bzwfBOdd7KT+V2qwicq/f X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR08MB3865.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(366004)(346002)(39860400002)(376002)(52536014)(5660300002)(66446008)(64756008)(66556008)(66476007)(76116006)(66946007)(9686003)(71200400001)(316002)(110136005)(83380400001)(55016002)(7696005)(33656002)(26005)(4326008)(86362001)(54906003)(8936002)(186003)(478600001)(2906002)(6506007)(53546011); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: lbLU3gGhzEVSSs1EhdgpFF5Fh2Z+u3H/ru/XeMGW4I9CTg1Zb75Sm6RYOsXXEtc7LxibpZsfUB/bghe4oUqC5q+/iZK9L+9KM7/VKJ7FFcivi+jEtknfA69mOUqAF5fCuDPFHt3xI8dJ4iH4+PuprAm+PUpTEJwsewabflvHmvbUSlLo68rDhhk7IPvYF6hd7MIVTrV4hB9b+1AkEhqYl0VWSNPIMyrxwjr7DaspKmb/5zr8gd/QIhGbiNfw+8wkZvc+/FZlgK2G+r7R3fqV+TI6WQPbx3vPfVM6gJNNQOBqCOlBFyD0eZyY7NFA+ZLJnqelP8TTuC2Lkl2ovtpCYGiayN0zYw+Y/sB9frx2hQ8hWmX2l6Fjtsf0RiG7f//AD5nLayaGd8GiYkkEjO4SMCtU0J2Vz3QE2C4Sm36ixxje6fKY8rOzow6BOHxWIlf7c62F9aSHHgKd+bB3nXZKNHxwUlrU7sCpMwNNDr5Sw+KYnton3qhMQgtOUozZ3DfvVt4LUG73j7oTRRF4TpZAlRPn9OVgGu+a2eVySvERJ8OksFkS6njDMpLLGOUWDlIdWXBPxMS9DVFwF0Ud4X9bFZ+IxD2ygsvYQG4uhb33nAYH37SP2vFwFnzgLCcY/P13neqpWiR90ifyW6+sNttT3w== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1717 Original-Authentication-Results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fffaceae-e38c-440e-ab33-08d8648d42e4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vshcynp+oCyRJOKCpVksdTYm9sYCf0uZJQ5lrK5COpSOu0cJepLqt8H40oP1/CPsykCVL+FDRGNn1UnB4IGIKd0K4LbflIE/cl6vh1K1SvEZUlbcFt+pPcR6hffX4riSn6OMnzT+uOMdlNhT6LDXBjw2eYRSguDwwvwHUcjol+BszlJDc/jlN+1XKCStqAyoOmTdMYzcKqBfguo9aWoTAA9jcsp+9UprHMFWdrrSAYZvEe5Td7H57SzB3eXePjGfUDs6yAkF34RZoqOwYjsIYszJt36laSy2EfJdPmHfuenAC76qs6Zq9Ktxyrt84aRnELbq45aUVuRU2k+UILMYRJSTmBAMEUuPIjhvZlzmM71kMzFmQVr4CCDgqB2HWlQ1g4hSIYEVtWedYIjL6kkFiZ5oXTP178bR6AFCfWLmXx3S0tNqIfyFEsefzeBlstOq X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(376002)(346002)(46966005)(9686003)(110136005)(55016002)(47076004)(81166007)(52536014)(356005)(82740400003)(70586007)(70206006)(4326008)(83380400001)(316002)(8936002)(36906005)(7696005)(5660300002)(54906003)(82310400003)(6506007)(2906002)(186003)(53546011)(478600001)(33656002)(26005)(336012)(86362001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2020 15:35:21.9083 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c74dbc02-75d5-4f70-c341-08d8648d473f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2108 Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Lijun Ou > Sent: Thursday, September 24, 2020 9:45 PM > To: wenzhuo.lu@intel.com; beilei.xing@intel.com; > adrien.mazarguil@6wind.com; ferruh.yigit@intel.com > Cc: dev@dpdk.org; linuxarm@huawei.com > Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key > configuration >=20 > It use the NIC valid default RSS key instead of the testpmd > dummy RSS key in the flow configuration when the RSS key is > not specified in the flow rule. If the NIC RSS key is > invalid, it will use testpmd dummy RSS key as the default > key. >=20 > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Lijun Ou It looks good to me. Thanks. Reviewed-by: Phil Yang > --- > V3->V4: > -fix checkpatch warning and shorter commit content. >=20 > V2->V3: > -fix checkpatch warning. >=20 > V1->V2: > -fix the commit. > --- > app/test-pmd/cmdline_flow.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index 6263d30..e6648da 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -4312,6 +4312,7 @@ parse_vc_action_rss(struct context *ctx, const > struct token *token, > action_rss_data->queue[i] =3D i; > if (!port_id_is_invalid(ctx->port, DISABLED_WARN) && > ctx->port !=3D (portid_t)RTE_PORT_ALL) { > + struct rte_eth_rss_conf rss_conf =3D {0}; > struct rte_eth_dev_info info; > int ret2; >=20 > @@ -4322,6 +4323,13 @@ parse_vc_action_rss(struct context *ctx, const > struct token *token, > action_rss_data->conf.key_len =3D > RTE_MIN(sizeof(action_rss_data->key), > info.hash_key_size); > + > + rss_conf.rss_key_len =3D sizeof(action_rss_data->key); > + rss_conf.rss_key =3D action_rss_data->key; > + ret2 =3D rte_eth_dev_rss_hash_conf_get(ctx->port, > &rss_conf); > + if (ret2 !=3D 0) > + return ret2; > + action_rss_data->conf.key =3D rss_conf.rss_key; > } > action->conf =3D &action_rss_data->conf; > return ret; > -- > 2.7.4