From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A868A04B7; Sun, 20 Sep 2020 11:32:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 15DA71D9AC; Sun, 20 Sep 2020 11:32:34 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130054.outbound.protection.outlook.com [40.107.13.54]) by dpdk.org (Postfix) with ESMTP id CF4D71D9AA for ; Sun, 20 Sep 2020 11:32:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5O6fxWyPgdkInnpfuvNLt4mDKgw37dAnCOZNijfPNk=; b=cSiVaBNpxr6ltiQeaWzV+nyeL69Vy6vDkM+LzkYQjyya0Kc9E06GjN4OyKUORLqTJLnJE+3Ps7ZeErADNkj/GL2xhJoG7qWRCyHUY6MiEbB5yHhEvFF4lIzlgEkMO0kkYMQatJqDEbogFVRARMhTI/DcmdULofRJwttm3JsCykI= Received: from AM5PR0701CA0023.eurprd07.prod.outlook.com (2603:10a6:203:51::33) by VI1PR0802MB2605.eurprd08.prod.outlook.com (2603:10a6:800:b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Sun, 20 Sep 2020 09:32:29 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::a2) by AM5PR0701CA0023.outlook.office365.com (2603:10a6:203:51::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.6 via Frontend Transport; Sun, 20 Sep 2020 09:32:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Sun, 20 Sep 2020 09:32:29 +0000 Received: ("Tessian outbound 34b830c8a0ef:v64"); Sun, 20 Sep 2020 09:32:28 +0000 X-CR-MTA-TID: 64aa7808 Received: from 77c4409551ce.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C6DB051D-F3CB-4826-B1C4-4237E878B913.1; Sun, 20 Sep 2020 09:32:23 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 77c4409551ce.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 20 Sep 2020 09:32:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dvwjkKNk3D+mhLAFglg9z8BiA5CzL1T5BLeLQy4D2mcoXoWnlEMoWnZaFw0pl7t+B/vIpj7IEqGcaYTDDeoyLRn5ogizjqjkylMsLppfadho8lpGwazGs7FXxvxqYFgzhoCDGKkof/Ztb2FUtDtQe6c3/D7R1lflYPrHPgZIWWNiwPTaKTIUer4hSbQ0R90bOzENwWjkvqJqSFNtVgM/YpGdG9UumQAL8mdAyBTBKC0NTVqJcDnmPbhqag3IL5KW6NH+QBBjbZ4byAXEF1ytUli+/8k06AYFMpq3nLvTTbzDWJtKK+6M6pxBcl9r8mVR1WNAaI1VT/IRAEDnfOESkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5O6fxWyPgdkInnpfuvNLt4mDKgw37dAnCOZNijfPNk=; b=DjHR6DUZypNwD0EFtYSSnQvZF2XEdvAXaJ0Ix8NDR+MxbyMV9wNUb5blueeE7oaM9RNjpGAIJk/VqD9VVxTcHfPiQtg2MWNvMKNyVZUSqpY0jun1OOYN/TgcWTJ95whBJaL2keAXlDX782Za6xXFGQAsC+fuqpShzMSBsDUnPh7696TQ7o1XrzTust2gPXnM0dATmGmxiy2Y0TZGG6O8AYtXQ2hCxIm6d9lhKlfDJUa+ZF3jwU60WmiqW+ULSzaODmG1o8VSNAaOBOQ+By/sEww4D4vGxrlqUw9Y0KjMuWkEukVR9TQG/0Yyfk1K7rfNgttr8oXgxCba/DIG3Q12yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5O6fxWyPgdkInnpfuvNLt4mDKgw37dAnCOZNijfPNk=; b=cSiVaBNpxr6ltiQeaWzV+nyeL69Vy6vDkM+LzkYQjyya0Kc9E06GjN4OyKUORLqTJLnJE+3Ps7ZeErADNkj/GL2xhJoG7qWRCyHUY6MiEbB5yHhEvFF4lIzlgEkMO0kkYMQatJqDEbogFVRARMhTI/DcmdULofRJwttm3JsCykI= Received: from DB7PR08MB3865.eurprd08.prod.outlook.com (2603:10a6:10:74::25) by DB6PR0801MB2088.eurprd08.prod.outlook.com (2603:10a6:4:78::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Sun, 20 Sep 2020 09:32:19 +0000 Received: from DB7PR08MB3865.eurprd08.prod.outlook.com ([fe80::519c:72bd:e189:625b]) by DB7PR08MB3865.eurprd08.prod.outlook.com ([fe80::519c:72bd:e189:625b%7]) with mapi id 15.20.3391.011; Sun, 20 Sep 2020 09:32:19 +0000 From: Phil Yang To: =?iso-8859-2?Q?Juraj_Linke=B9?= , "david.marchand@redhat.com" , "dev@dpdk.org" CC: Honnappa Nagarahalli , Ruifeng Wang , nd , nd Thread-Topic: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path Thread-Index: AQHWVb2nZiqMRXKQk0KXYp1FraKqM6ltGjeAgASTOlA= Date: Sun, 20 Sep 2020 09:32:19 +0000 Message-ID: References: <1594277585-15281-1-git-send-email-phil.yang@arm.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BEEE35333990404EBEDC69C788B39E12.0 x-checkrecipientchecked: true Authentication-Results-Original: pantheon.tech; dkim=none (message not signed) header.d=none; pantheon.tech; dmarc=none action=none header.from=arm.com; x-originating-ip: [114.85.108.161] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4af81bbd-d2d2-4afe-08ce-08d85d4817da x-ms-traffictypediagnostic: DB6PR0801MB2088:|VI1PR0802MB2605: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:5516;OLM:5516; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Gr0cdc4B6mTT9q4VADftUcjVmFEpR6XqaWNeKSU5TCBfiwnOLcXLqCohxD6SVBnUPejsXYvTNRdrLwCI3iLpygUEzCiTn6bXDNOZTu8ZciBgpCSkDlHjCGaUVWOuW43wySIWE8gCRZT+hC6CFmLuQm5wlYhZRs4+tKWGGvXTIobwzMLz/elz1Ce1o13nAQ69H2oy/aRrTd1IGB95WxUR07SyMcrF0RzbL4WyBQ1NUBL4SQpTRMW8hAaKPh5APWPiIMazDNGvsa4+HSUVZSen9G0BnoYbBg9gPGjUCC4CeVIR5CO/DgnERGl6qeNcurdiBe2c2wXs2SSgEvBy7ygSfA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR08MB3865.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(346002)(396003)(376002)(136003)(366004)(110136005)(33656002)(316002)(26005)(52536014)(86362001)(54906003)(5660300002)(478600001)(9686003)(8936002)(66946007)(2906002)(4326008)(64756008)(66556008)(186003)(55016002)(66446008)(71200400001)(76116006)(6506007)(7696005)(83380400001)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 7zsdmmMFbA2IybmR3hMQrpVWurBlffuKE0rfSacF3wg1q4iI+I3s5wWPETPRx6wZWwFY/70OSsE82RHq1D4CzMmVungt5yXXetdI75bPFL/W+tg8DXxR4Wne1AEGMkFt6yROVBJEOsF9xRUOoTD1FmnjQeC3eIz9mx1QIxiOuTJBFj/TNuWzvevx/D/JDfiJpC4rTUZkjhagnTFx1Jg16i7wAt6xrWgaHzhqKnH14GPMNi+UgvWngXTb4yoE8vjRLSPUXLw0Hqr23VVh0g/+8uZZhSrOWKAZr+bDhk4ZtvGCLAduN8SZ7lNKRN9aTnHzkAZJRsHquI8RKgJcycchpZJkj67Z5NhmruvDe7PJaCckTRxE7vJr1Da9qhwfQ9UZF1laMWtqiO9QUVCO44pIdnRzjjgGaARvfkJcg+AjTfb1WQEZXJrG3X9hIu28oxHMnzAisLDKd588oV8q4WqS1UMJCqQu1Z4Mfxhg4MlUnH40qyRAO1nQrU9kka1TW06TnQ6hBMG03iEpOiqVZKTJiRjvss2Ibtfsdea24Nt23EJoXPdu5uPDD2uG6sODYnfPCukP1PTKgEyJsqEb33GEU0M1iOgPAGcUuV4WIao10iCh7nuTdpNQSr7NDYR84K2Edd/VDDnCiRuMxY7lgLhhRg== Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2088 Original-Authentication-Results: pantheon.tech; dkim=none (message not signed) header.d=none; pantheon.tech; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f1f2b6cd-5213-4f33-c59f-08d85d48122c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CvYpYmv4rxQXie1lb3Pn2sYMHTw8dd9yUr1l6Pn6ym0fnDr0r84WTSwyV2U40HBrY+sqHpjGKzS0OLmtW3JLInUK6vGSKJaIRkx8ShCplZpnrT336v60hjWPc2PJirFdgzowE/puuep91/rCc1+7QDC9857BvDsuWA9goXHyuVm8KT39pMpmkWotw7V/pZTuVM5wZn8abpwebZaW/iawY7l4oV+3Vd+tnh1w54o0H5Z1IwJkAY2pmpFcaadZ+cHelYPaku+9A4IN8xNIN3RXZAZI2tKDhWQv7ISdU2hidQvbfnIaYyA/pS2KMAxwJ0Z+A2uwuzJiZMI7TH+BtUcPUu2Lb15nOpVpZvJvuxAW+lTj1+yxz69ZE6HqXlv5/xHHEuI0EnNhsn3Lyh6HTfmT0g== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(39850400004)(396003)(136003)(346002)(46966005)(186003)(47076004)(356005)(4326008)(82310400003)(83380400001)(81166007)(7696005)(70206006)(2906002)(6506007)(70586007)(8936002)(86362001)(55016002)(82740400003)(26005)(9686003)(33656002)(52536014)(478600001)(5660300002)(110136005)(316002)(336012)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2020 09:32:29.0949 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4af81bbd-d2d2-4afe-08ce-08d85d4817da X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2605 Subject: Re: [dpdk-dev] [PATCH] devtools: fix ninja break under default DESTDIR path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Juraj Linke=B9 writes: > > Subject: [dpdk-dev] [PATCH] devtools: fix ninja break under default > DESTDIR > > path > > > > If DPDK_ABI_REF_DIR is not set, the default DESTDIR is a relative path. > > This will break ninja in the ABI check test. > > >=20 > The commit message is not very clear. The problem is we're specifying nin= ja's > destination dir in variable DESTDIR when invoking ninja install. If the D= ESTDIR > is not an absolute path, ninja complains (when invoking install). This is= n't Yes, this defect is due to 'ninja install' not happy with the relative path= .=20 Will reword the commit message in the next version. > directly related to DPDK_ABI_REF_DIR, it's more a problem with how we cal= l > install_target. If we have set 'DPDK_ABI_REF_DIR' before the test, 'abiref' should be an ab= solute path, but the default 'abiref' value is a relative path. So should we keep them align? >=20 > > Fixes: 777014e56d07 ("devtools: add ABI checks") > > > > Signed-off-by: Phil Yang > > --- > > devtools/test-meson-builds.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson- > builds.sh index > > a87de63..2bfcaca 100755 > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > @@ -143,7 +143,7 @@ build () # > > > > config $srcdir $builds_dir/$targetdir $cross --werror $* > > compile $builds_dir/$targetdir > > if [ -n "$DPDK_ABI_REF_VERSION" ]; then > > - abirefdir=3D${DPDK_ABI_REF_DIR:- > > reference}/$DPDK_ABI_REF_VERSION > > + abirefdir=3D${DPDK_ABI_REF_DIR:- > > $(pwd)/reference}/$DPDK_ABI_REF_VERSION > > if [ ! -d $abirefdir/$targetdir ]; then > > # clone current sources > > if [ ! -d $abirefdir/src ]; then > > -- > > 2.7.4 > > >=20 > install_target on line 160 is called improperly. Let's fix it so that it = matches line > 169: > install_target $abirefdir/build $(readlink -f $abirefdir/$targetdir) If so we need to call readlink at line #161 as well as it does at line #171= . >=20 > This way we don't need to add $(pwd). If you don't prefer $(pwd), we can do it like this: abirefdir=3D$(readlink -f ${DPDK_ABI_REF_DIR:- reference}/$DPDK_ABI_REF_VER= SION) Thanks, Phil