Re: [dpdk-dev] [PATCH 03/20] security: add hfn override option in PDCP

[Akhil Goyal <akhil.goyal@nxp.com>]

Hi Konstantin/Anoob/Radu,

Any comments on this patch.

Regards,
Akhil
> 
> HFN can be given as a per packet value also.
> As we do not have IV in case of PDCP, and HFN is
> used to generate IV. IV field can be used to get the
> per packet HFN while enq/deq
> If hfn_ovrd field in pdcp_xform is set,
> application is expected to set the per packet HFN
> in place of IV. Driver will extract the HFN and perform
> operations accordingly.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  lib/librte_security/rte_security.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_security/rte_security.h
> b/lib/librte_security/rte_security.h
> index 96806e3a2..4452545fe 100644
> --- a/lib/librte_security/rte_security.h
> +++ b/lib/librte_security/rte_security.h
> @@ -1,5 +1,5 @@
>  /* SPDX-License-Identifier: BSD-3-Clause
> - * Copyright 2017 NXP.
> + * Copyright 2017,2019 NXP
>   * Copyright(c) 2017 Intel Corporation.
>   */
> 
> @@ -270,6 +270,8 @@ struct rte_security_pdcp_xform {
>  	uint32_t hfn;
>  	/** HFN Threshold for key renegotiation */
>  	uint32_t hfn_threshold;
> +	/** Enable per packet HFN override */
> +	uint32_t hfn_ovrd;
>  };
> 
>  /**
> --
> 2.17.1