From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CACAAA0350; Mon, 3 Jan 2022 09:39:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C86D40042; Mon, 3 Jan 2022 09:39:33 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by mails.dpdk.org (Postfix) with ESMTP id 3EA714003C for ; Mon, 3 Jan 2022 09:39:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mEI7QKCiTXQHsLNkvWyIu7sseN+0zlZ3tSFDyNIUBieV2/s9gKtWz1GAkhHGc2zCU8e8n1r5EUXvVnpXaUW6gHEAAszNMTCR6vyRv1Sv/97hvU8NHnSDJyfVDNS+N21TVc31vtG0cXlXJUOl0iq5kXEWLrdCW32skYCKnjfgmXKdnM3HScnwf15GX1jbcyQOnJaJe20l4wFjgqPV3CzXUd6ni2dw1/jVwH37/2H8l3LVTPTniwfv06vo1daGq/cY2wn8H6n3VNOYv5Whb0V4RM/q2GL5Tq6+tepKoCBQySQGDakPz5z7/7Jvmfnd5d/LxOcvW7XKhY4HVkPsjltXTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vykWfHHPc2q1fv1d0pYVPXhQqMt0+5+478sCG6S7KAg=; b=aMTeAZWsIQz4q6JDYJCwziiAiHV+522F0Blq85/4glS0wcIJWKMI6YxUc2cVOtehQl8WjYLM84+OD1mKu+UBK3EkEOZ9KoE0Z07kXJGh/vO11heeLl/t3jxtXcjKYCvgRy74gY77Lg8IXnLRT3emrBsn/AcMP6DQC6xDI8iviyrn1t+/RSveg7ioBEeTDBC1PyhusTglyjoJvuex4fAEbEVV9AKsUJp2YC05sE2O8yvKDo8EFxrDY/V3IQ8zAG7Y23tCxb6p696/3hEnP+IrIYtVXjRyVsJSQ2jV9+l+omfYn20sj0X0fAbWOqiICIP8l+W6MznpzQgH75edw3NV9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vykWfHHPc2q1fv1d0pYVPXhQqMt0+5+478sCG6S7KAg=; b=MiZJldKoA+WTSUAXo2iyxalIxcSCrn3tJgrDx3Jol2XyEfbDDOtN54qN8xprJMRhItzWDSdj83ON+9qulQHcyH83Iw3Le8zXsJt+I78/BE+Iu+6ThVeoxlR3viWpyZkD7v0jeNGbjnojIneFOVxnmyApJRmclLoC8qWa1tj0NDE= Received: from DB9PR04MB8429.eurprd04.prod.outlook.com (2603:10a6:10:24e::23) by DBBPR04MB6249.eurprd04.prod.outlook.com (2603:10a6:10:c6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.13; Mon, 3 Jan 2022 08:39:29 +0000 Received: from DB9PR04MB8429.eurprd04.prod.outlook.com ([fe80::c94c:cbd8:dee0:70f6]) by DB9PR04MB8429.eurprd04.prod.outlook.com ([fe80::c94c:cbd8:dee0:70f6%6]) with mapi id 15.20.4844.016; Mon, 3 Jan 2022 08:39:29 +0000 From: Nipun Gupta To: Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , Hemant Agrawal , Jun Yang Subject: RE: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue for ordered Thread-Topic: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue for ordered Thread-Index: AQHX+z1B52Zc2Nmqi0Ogpeq0u76LrKxGoS4AgAoyn8CAADBOoA== Date: Mon, 3 Jan 2022 08:39:29 +0000 Message-ID: References: <20211206121824.3493-1-nipun.gupta@nxp.com> <20211227161645.24359-1-nipun.gupta@nxp.com> <20211227161645.24359-7-nipun.gupta@nxp.com> <20211227100154.15da0346@hermes.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fdd64210-0a38-4fd1-657a-08d9ce948edd x-ms-traffictypediagnostic: DBBPR04MB6249:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m3nTDGq8h+psqu5FJy5Va1asClYK3M8EGX9Nf6BBJLnB4rNBukbqqiMknKLyWg2AuJX0i6tP2du2YePuVIiGnZXRRewcVSL2wPg++ufnRYhQTf4pgfN8PLUSJsd7e0FNPH2rC+ZcXPPl0OGMKbYW+lta4NDeWgwcGTIErhpTpqS3Z9MuhHLTAzidKzqALmEM6Jo1T6wH0BdxaUZkzLzJUZvTC6t+NAW0fRKpwe1SRQJwwplsI0RhYt4FxBdm/9znECzd78LjacAYzcjI5kOaZHN19rmCCjtuEfzbzbtJPhAx3nUDZ1s14svb2KIySoMczHd4sEAzlEIrDGpI5UcgKyBw4ttPFgrAl5QCBvW2VDK/UCzfmIQjhfOb5mkmVujLwnuzoD54nPjDYyGzf9o2p+aKYns6am9IWbzfR9XLCbjqjnCwut8Wo5Go8/f/rfpTmlY8l1vscQT2V21Mu9mCnakY9pip5xSgiTPDShOZ1cX6xRuH4zZkigKKARRwSZMyXrsL56KfLgc5MkAgl/Iqb1LPyxxC/vOjCTa/dfQEaq0+ZHsyoZ/a14KBC5AvmwUf3EZ3+ZnZkwCiNIv50QP/V8RYh3R2w3OGf5PKfP3KHL8E9eVVZl3pbmkoksRR4tiX3MAGFdBcqGD/rwRxOwA9kw2zXGFyr/+uVTQN/wxprc+PAIT+dkLDwiUEsiWywcf8INpqEdcf/wZ2uogNWmjBhw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB8429.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(76116006)(8676002)(508600001)(66476007)(64756008)(66556008)(66946007)(66446008)(6916009)(5660300002)(86362001)(8936002)(26005)(186003)(316002)(44832011)(38070700005)(38100700002)(122000001)(52536014)(55236004)(53546011)(7696005)(6506007)(54906003)(9686003)(2906002)(83380400001)(4326008)(55016003)(71200400001)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OzEE/KfErwS4jk3wMFrZgu4IAcOfUhxVqyAowy0csIED0eWkkLesoMrq7tZg?= =?us-ascii?Q?iQU/F261zoZjZY/eIyZgsnhBW6+H3u8E25Osd2Lsh4CBLwvcUqK0FSGkk9od?= =?us-ascii?Q?huG201cAKz5g9e7cmUdygZwzUIOFVqpnKrxHgQLoMYlkCqJJ5icSTwQ3aPwx?= =?us-ascii?Q?QlPrsFYfdUWi9rObbMmh/h8CHdNFIOSw+yUYErg3+AAFsfw0jzJRwbm87IST?= =?us-ascii?Q?IQJi066S7sUwN5WasonrhwOwPHzHMR/c7IOw6qWAVA3DxK59KcVlyEYL5UaC?= =?us-ascii?Q?qFtervjY7TPuDrULXvnHnDDWgBjiEF56vsRVgySxXXcdv1r96eBVB40JKtVv?= =?us-ascii?Q?YgbCHk+Qg9zVjn4XDtOGBwuWxNeL+PIX5K9s8WiIs8d1VwmFJO0OUChz0iVE?= =?us-ascii?Q?1HZclY0Y9TPlrXgNbchAQynshEYWyNDxZ+h7xKJeD/DlKVBtPmUIJr3qLxgR?= =?us-ascii?Q?1YxTKR3u4k115zgRCA72HuoAPGatTw+wCGP5oXUMkRnvbieE0ecu+sEBExQ6?= =?us-ascii?Q?u7urbv9Lg7WarNj65jYoT7jgGnReJv/lZ8hwjSGgW0SkuLjVwhphCbKsbgz9?= =?us-ascii?Q?Py0KAWVg6PA10ofkEmrg/QsCwnjSAmOC3Abj3r/iiahxtf8n02LiXqnKRaG7?= =?us-ascii?Q?guaUANvX7KLL0+eAgzyMmSUnIhoHM5ZPAWFeaZTmFj6ckIN/8ixO2wxFb/Am?= =?us-ascii?Q?mdvvSr0j1/E385WmaHN21k4RFvF+WDYQc9UvZy/a3sHdfzkPbQrHPNeKU93m?= =?us-ascii?Q?/tN8WeovDSZz1qtTdU2S0vLryixPAaiUaGD3y6/NnnDP61bymAaL8CVz/8Au?= =?us-ascii?Q?9oz+Icok9Vf6nEYzO5bfcFMhQgwjR2GfpSxaawSFcngFmbK1Lu57L5W7+zAM?= =?us-ascii?Q?q46g3MNu2qsSTpkOdw/1HXzOgqSlBAQHEwpwIMPfz6dA7dXDpPABlJEJd89O?= =?us-ascii?Q?GrVv6pdNpZBSXt3BYk7mWP7Dw1VaVUn4UDU/rNRH5IfpdjWqWzBpXR0h5COY?= =?us-ascii?Q?xyr0ptfBwnWF6pT3R8oyC84HlPotrRJc9R81QcjVPwuyuyQhvq+xMvK/oZfO?= =?us-ascii?Q?UKca8zwJVP6k0MNqnDgjr/S+s2mBcIsVY00ODEIzmNv5viUzuXMC0zmEOIG5?= =?us-ascii?Q?UnxzBZ+ZCTh8rcTT9in5kSA024YXDe88DXXA1AZ9d2tfv2MRpE98YZuivnP5?= =?us-ascii?Q?DQinZ7DaHr78NI77iQMFpXuSPNxnyrCa3RdXdrnKgJPEl/W7J5yXsKnnManZ?= =?us-ascii?Q?wX6ELWjqV2++snfciKlmsf6bxUXEvbPDDgSlNr8MuJcMURm11hvBeeoEA/i7?= =?us-ascii?Q?JileAGKiFHpX0ooHGqfdtILS9RK5Hk3fLVy7ohqGKFHVld6YhrGgS3mW2lvZ?= =?us-ascii?Q?guFnQ4GO3AXTl9Rb7gwlnZLHkboQ6k8C0dOySDldfq036LfANF4V1hsgAwvk?= =?us-ascii?Q?T3SF4A1epX7nBLJaySP/3YKJiL4RgdiVXJX6iah2XD2E8H4PT/WVoQhMBqq1?= =?us-ascii?Q?2x4IpmPxxQxYhcujGFI1Aeeei5TUYimvN25ECi40dcZDwJjIzdbPYtLLKSpX?= =?us-ascii?Q?VbIZAqSQIemk7RZ7zFxFSHMHYtKtLICSCkcxJyd4N9EkssUTrTlW6/jbNA80?= =?us-ascii?Q?AA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8429.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdd64210-0a38-4fd1-657a-08d9ce948edd X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 08:39:29.5567 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zjBEK3gm3wv3NmRGYqBJYLohXkZsw59PSO2hY1bWzmlphBBA2YcCW8ao13ePB3zzPoM+xy6rUiNEbKafDbgpVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6249 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Nipun Gupta > Sent: 03 January 2022 11:17 > To: Stephen Hemminger > Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com; Hemant > Agrawal ; Jun Yang > Subject: RE: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue f= or > ordered >=20 >=20 >=20 > > -----Original Message----- > > From: Stephen Hemminger > > Sent: 27 December 2021 23:32 > > To: Nipun Gupta > > Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com; Hemant > > Agrawal ; Jun Yang > > Subject: Re: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue= for > > ordered > > > > On Mon, 27 Dec 2021 21:46:35 +0530 > > nipun.gupta@nxp.com wrote: > > > > > @@ -1003,16 +1003,20 @@ dpaa2_eventdev_txa_enqueue(void *port, > > > struct rte_event ev[], > > > uint16_t nb_events) > > > { > > > - struct rte_mbuf *m =3D (struct rte_mbuf *)ev[0].mbuf; > > > + void *txq[32]; > > > + struct rte_mbuf *m[32]; > > > > You are assuming nb_events <=3D 32. > > Why not size the array based on nb_events. >=20 > Agree. Actually I will use DPAA2_EVENT_MAX_PORT_ENQUEUE_DEPTH here. >=20 > > > > > uint8_t qid, i; > > > > > > RTE_SET_USED(port); > > > > > > for (i =3D 0; i < nb_events; i++) { > > > - qid =3D rte_event_eth_tx_adapter_txq_get(m); > > > - rte_eth_tx_burst(m->port, qid, &m, 1); > > > + m[i] =3D (struct rte_mbuf *)ev[i].mbuf; > > > > Why the cast? it is already the right type. >=20 > Will remove the cast. mbuf is void *type in event structure, so it seems better to cast here. >=20 > Thanks, > Nipun >=20 > > > > > + qid =3D rte_event_eth_tx_adapter_txq_get(m[i]); > > > + txq[i] =3D rte_eth_devices[m[i]->port].data->tx_queues[qid];