From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 795B9A0C46; Fri, 17 Sep 2021 10:30:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09F3A407FF; Fri, 17 Sep 2021 10:30:22 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by mails.dpdk.org (Postfix) with ESMTP id 4521C406B4 for ; Fri, 17 Sep 2021 10:30:21 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W2id3++vQJXmti/bP9kbbvfndWojQojP1csCrLtcJmNlduDPu0B/3IlsBN8RgIh5MNbiJ8sT1gielZoOQxrm06E/zfGRoa4jn7pOGLJNiZrmAA/+Gu4/zH0ngmKO34aFPyd8yQycYODsq+mf6jwzv2LS3VvoW/Ysji0g6AKaYcBRnOkIE6ZFa6fgty2aMRh/9aAK3ZI8dvC74NQpiWJlNxuMbFJXeyy8bqW2taQT23oIoBHHxZOQpqJqEhq8cfpgyDPbwPPGlFtgn5DNoBGfyY2/VWSeuEsSMW1YrvlIB4EpIMAzJWkKoEZlUgUzzIwHlpBRKTzsiXGDp88fEfOXzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D2X7mk5Tl34ujtmw19FAumddHRPvBDQH/hbpx0zfeuU=; b=ZW07H6RrnyjN42Ts4bFhrr0rTvpAXwJNFHsD0zPK0+kMzRIuVvKib3oFBdnl6VXM+KIk2aigPo/054ug/vckLuKc4c4cibfXbDp8XQOyTmY2E3YT1gcixxwXIbLcto06OS5cXe76zGx2O32dlYZjb05qghB4UhdpyaG9hUR6rQJfQD7K+fEFUS1jWrj3Yxq/2Y0543V7uv9kXk4mf896ZO2VBKUIkWB1Y0zw5fAMI37XQESaFN5hn8rRRYr99ICuD333kv9xmpcLNDhu8PP8089/J2j6NGpkUHWTn60nZX3dqJEnDpi+jRys1xr5V7Hju5BOXwQiAjiKjexS8ID28Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D2X7mk5Tl34ujtmw19FAumddHRPvBDQH/hbpx0zfeuU=; b=oB/bOMnlzlvaCgE/BbiFvobtgA9wy9xa+w0ySXS96ZYwYgJaE8+IKVlez9g2l1iezWtxLVKGkV/o0FDP7eCjiuLecxtWLLfEPjF0qisIRy5voL5F+eujEw8zT9Hsz7HPe2DAR2KE/x4IB/VkqN+IkT6bgLiEOLYiPwqhtCYRjtQ= Received: from DB9PR04MB8429.eurprd04.prod.outlook.com (2603:10a6:10:24e::23) by DB3PR0402MB3852.eurprd04.prod.outlook.com (2603:10a6:8:f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.16; Fri, 17 Sep 2021 08:30:19 +0000 Received: from DB9PR04MB8429.eurprd04.prod.outlook.com ([fe80::dcda:93c2:47e7:19b4]) by DB9PR04MB8429.eurprd04.prod.outlook.com ([fe80::dcda:93c2:47e7:19b4%9]) with mapi id 15.20.4523.017; Fri, 17 Sep 2021 08:30:19 +0000 From: Nipun Gupta To: "Chautru, Nicolas" , "dev@dpdk.org" , "gakhil@marvell.com" CC: "david.marchand@redhat.com" , Hemant Agrawal , Tom Rix Thread-Topic: [PATCH v5 1/9] bbdev: add big endian processing data capability Thread-Index: AQHXp8/lfX4zdE2PN0S2+9bxhmgAeKuiTc2AgAWV3BA= Date: Fri, 17 Sep 2021 08:30:19 +0000 Message-ID: References: <20210318063421.14895-1-hemant.agrawal@nxp.com> <20210912121510.22699-1-nipun.gupta@nxp.com> <20210912121510.22699-2-nipun.gupta@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac59c932-786a-4da7-a491-08d979b56265 x-ms-traffictypediagnostic: DB3PR0402MB3852: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8t1ADJgqPQ3OhN8IuFBH9RAHSDXqH5oUjsXIEw6YhAJvhXUBT19UCSqp9KAXL+FqGz1f9qIVGOtCRYylvQ1s1ONRaFDaKFQKC5hjFGINieXm+ohnywk4RnIzQ0zIq1Jyr0BDlKeIlilpzg0rXSPQOXCaWHX93gjfGCSFaP/SOgJbdJv2Gc0iRlYhZyGO29RWB8hgvo2jZ5MfeLB8M31YEyxtR/WxwiRDqyH9w7aVg+aB2/SpsJ8EUkNZWgExV4zrBChuTwjXUlroDRbO+DAtUancUiXMt8hwjyzQ7gUs7eD4dU+sZofHht9azchc+NPgqR7IIrVW2sE+HDite87L6MZhbJ2hzHReQw2jhxvdtAO/mdaFDT9kZsaXOkijBfIE5ek7XIVgc9yzJJhvrJDKNc2optzqfEKAKpq693XT5hVwpmJ3qCj4ZyJcwyJ2Z27ttKObTwWRvch5nmBW+cz078XaKIc9EwK5/hdi+wFYVpe5DOdknfqG/X7AyM7qXDTrbprRktNOJSnF8g1b9F8z0RoEMCbgzRW/5lYUWzZPGJHVG7xALjmKONNLDUq2HYUVom9iDxYqz+OHPAFOtqwZzA+tWGXZ/IDETtXe4VbtZ8lsHTC71b8x1LmQNiuiFvgXGATuRAOgtz+zCHMzq7A90aKa1ozkRRvMeLnISnWfX8Tiv3+nZ/i3VqFF9lj5DZORdjv34BO9hE3vCXSotw8CBQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB8429.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(396003)(136003)(366004)(110136005)(44832011)(54906003)(316002)(38100700002)(122000001)(66556008)(66446008)(86362001)(478600001)(52536014)(55016002)(71200400001)(8936002)(8676002)(26005)(9686003)(5660300002)(55236004)(6506007)(53546011)(7696005)(186003)(83380400001)(2906002)(76116006)(4326008)(38070700005)(66946007)(66476007)(64756008)(33656002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2cFHhILYuMgzUiH+EYL/4e8DltGLcXKJFsbFlcJy4Lu0MGIQmX9nWaWTbrF0?= =?us-ascii?Q?72UNtELMvKmZEKynSU2pOTZsUrnNNwVlCH4XNbTwjvRgQgC7hyFWg6PDHGGM?= =?us-ascii?Q?iAspk2OU5SwjxwwfoCTifcCcw3biMmxEKgobgSRS6d3VWtTf9GZfTbwf/GsQ?= =?us-ascii?Q?PtLa0jeVyyZ3b+trpQQ4ApQhHPXQy4EnwgTwquZV2gnsGtSAwOaW2Y6Ngs0G?= =?us-ascii?Q?DXi8lVx0eLaQXfd6+vaZBZ5yK6DfFjzIX+POYD50RZiNF604AdpE5YubQQsH?= =?us-ascii?Q?nCcF0RGxYlL3tI38Fjij6lg/IBzM/Ch4XChyTdyr+47IaVVxDYKsWCAZtMZB?= =?us-ascii?Q?BJLOPqBAeG8275I68B2leC1rV/jK4fCLRFpiS7PdpERHpS2S8nfnlvyujVFs?= =?us-ascii?Q?zM9u8g/JpphYpZgxGWgeY/AoKd1cJ+Gw7xNmbYVRlxbmD4+mrvcLlS+XP2xe?= =?us-ascii?Q?JGoxyNOWKhguIXkQSZ3WJwGOI255wdTuXihxg3mL8nBFbGxnJqcQWV1QQ7KF?= =?us-ascii?Q?Q8tUPKojqpgHwtLW31Gju8G33gz+LxiUFV3GGeGi5xVUsSWSwAt2u/Cd9xuH?= =?us-ascii?Q?QBq/Jc50QzKYvciikjgOZwvPhAlJf1NiBupLBeX7Acf/g6HyspDWy79esaVQ?= =?us-ascii?Q?9gmA6dVBJwGvdjS31VaYhu6W2xAoxVyAvgX/QRmPvU5bBd43a11UJbysUlxm?= =?us-ascii?Q?CxSJliDiIqLatrk5XhJI1fe9lPt83ib209KOzD/2wzibVyMoOpJUlJ598jUf?= =?us-ascii?Q?uHADzQ/LMvNDw72Dhsh4RqUDU3rEPELQh0HTRfxdlRJMjOQ2Zi5XKN6YYSYS?= =?us-ascii?Q?i9gNNI0IVW4Ij5DcINtSF7Sr2z/NYVwNdoLgyakQiJtL+MtBxNptKJzXtU5L?= =?us-ascii?Q?xo+hJ60NtRvR8yX4ss1pdO9mvz/SHcIGURjmQZn6y5b/PvPcYOUKZ+fvTT6H?= =?us-ascii?Q?o1rd8P7+FOpRSQ1qvWUAPAnlT2/VObrPmL5b0SjBNR8KdaRNjTwNeYPnIlYe?= =?us-ascii?Q?tSvVVt4oz/lvFX12IYMV7ZOq7EECug4jyqwxtAlsTrPb/BWVYB9i4H9upbzu?= =?us-ascii?Q?xyVoYDa8oJk2Dt4elGwPjJkTZ8eQxzR7T2Uyp6Fb2Dq09L7c9vjM/OOueqzk?= =?us-ascii?Q?MNWJ3+gR97AHp3JkjB8wUB1EiWTtKXUtYw2oX+FWopOot4jypdo+iAFh2g6J?= =?us-ascii?Q?yJiRuTVXf2Vx2A0UlXIC576ZdM8tYp68F0BVWhyAjwLjLoI9OsmsoJDeUHDW?= =?us-ascii?Q?xk6bgUccgqpT68dyypBHX1kfCzAog6ZuRVM9HdexW41cBAcncVW2f1CSp4Ka?= =?us-ascii?Q?kofHCMrpnmGrkA4KOyjlXdwY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB8429.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac59c932-786a-4da7-a491-08d979b56265 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2021 08:30:19.5699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ld5aBB+/OUmPPy2Uf/12JuEEp/WmlzNvv3CoFCTdQfxnrfILqWIsZ4a2KHWb3uze2S1J44qYf3xxGNh/FX+RoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3852 Subject: Re: [dpdk-dev] [PATCH v5 1/9] bbdev: add big endian processing data capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Chautru, Nicolas > Sent: Tuesday, September 14, 2021 12:10 AM > To: Nipun Gupta ; dev@dpdk.org; gakhil@marvell.com > Cc: david.marchand@redhat.com; Hemant Agrawal > ; Tom Rix > Subject: RE: [PATCH v5 1/9] bbdev: add big endian processing data capabil= ity >=20 >=20 >=20 > > -----Original Message----- > > From: Nipun Gupta > > Sent: Sunday, September 12, 2021 5:15 AM > > To: dev@dpdk.org; gakhil@marvell.com; Chautru, Nicolas > > > > Cc: david.marchand@redhat.com; hemant.agrawal@nxp.com; Nipun Gupta > > > > Subject: [PATCH v5 1/9] bbdev: add big endian processing data capabilit= y > > > > This patch intoduces a new capability of the bbdev device to process th= e > > LDPC data in big endian order. >=20 > Hi Gupta, >=20 > As mentioned in previous patch iteration earlier this year I believe this= is not > really an operation flag but more a different device capability. > ie. you would have the same formalism for all operation (5GDL, 5GUL, 4GDL= , ...) > for that PMD/hw and that is not something you will change dynamically as = an > option. > I would suggest to add this under "struct rte_bbdev_driver_info" which ca= n be > used to capture device specific capability and information. In term of pr= ocessing > and operation, everything is the same except endianness assumption for th= e > input/output data. Okay, it can be done this way. Then it would be assumption of the driver, t= hat the operation is in the format as per the driver info. Ill change it in respin. >=20 >=20 > > > > Signed-off-by: Hemant Agrawal > > Signed-off-by: Nipun Gupta > > --- > > doc/guides/bbdevs/features/default.ini | 1 + > > doc/guides/prog_guide/bbdev.rst | 6 ++++++ > > lib/bbdev/rte_bbdev_op.h | 14 ++++++++++++-- > > 3 files changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/doc/guides/bbdevs/features/default.ini > > b/doc/guides/bbdevs/features/default.ini > > index 5fe267a625..ae5aacf8f7 100644 > > --- a/doc/guides/bbdevs/features/default.ini > > +++ b/doc/guides/bbdevs/features/default.ini > > @@ -14,3 +14,4 @@ LLR/HARQ Compression =3D > > External DDR Access =3D > > HW Accelerated =3D > > BBDEV API =3D > > +Big Endian Processing =3D > > diff --git a/doc/guides/prog_guide/bbdev.rst > > b/doc/guides/prog_guide/bbdev.rst index 9619280ffc..6540b514bb 100644 > > --- a/doc/guides/prog_guide/bbdev.rst > > +++ b/doc/guides/prog_guide/bbdev.rst > > @@ -747,6 +747,9 @@ given below. > > |RTE_BBDEV_LDPC_ENC_CONCATENATION | > > | Set if a device supports concatenation of non byte aligned output |= +------ > > --------------------------------------------------------------+ > > +|RTE_BBDEV_LDPC_ENC_BIG_ENDIAN | > > +| Set if a device supports Big Endian data processing | > > ++--------------------------------------------------------------------+ > > > > The structure passed for each LDPC encode operation is given below, w= ith > > the operation flags forming a bitmask in the ``op_flags`` field. > > @@ -942,6 +945,9 @@ given below. > > |RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_LOOPBACK | > > | Set if a device supports loopback access to HARQ internal memory | > > +--------------------------------------------------------------------+ > > +|RTE_BBDEV_LDPC_DEC_BIG_ENDIAN | > > +| Set if a device supports Big Endian data processing | > > ++--------------------------------------------------------------------+ > > > > The structure passed for each LDPC decode operation is given below, w= ith > > the operation flags forming a bitmask in the ``op_flags`` field. > > diff --git a/lib/bbdev/rte_bbdev_op.h b/lib/bbdev/rte_bbdev_op.h index > > f946842727..9e9b5be81f 100644 > > --- a/lib/bbdev/rte_bbdev_op.h > > +++ b/lib/bbdev/rte_bbdev_op.h > > @@ -186,7 +186,12 @@ enum rte_bbdev_op_ldpcdec_flag_bitmasks { > > * for HARQ memory. If not set, it is assumed the filler bits are no= t > > * in HARQ memory and handled directly by the LDPC decoder. > > */ > > - RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS =3D (1ULL << > > 18) > > + RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_FILLERS =3D (1ULL << > > 18), > > + /** Set if a device supports Big Endian data processing. > > + * If not set Little Endian data processing is supported by > > + * default. > > + */ > > + RTE_BBDEV_LDPC_DEC_BIG_ENDIAN =3D (1ULL << 8) > > }; > > > > /** Flags for LDPC encoder operation and capability structure */ @@ -2= 06,7 > > +211,12 @@ enum rte_bbdev_op_ldpcenc_flag_bitmasks { > > /** Set if a device supports scatter-gather functionality. */ > > RTE_BBDEV_LDPC_ENC_SCATTER_GATHER =3D (1ULL << 6), > > /** Set if a device supports concatenation of non byte aligned output > > */ > > - RTE_BBDEV_LDPC_ENC_CONCATENATION =3D (1ULL << 7) > > + RTE_BBDEV_LDPC_ENC_CONCATENATION =3D (1ULL << 7), > > + /** Set if a device supports Big Endian data processing > > + * If not set Little Endian data processing is supported by > > + * default. > > + */ > > + RTE_BBDEV_LDPC_ENC_BIG_ENDIAN =3D (1ULL << 8) > > }; > > > > /** Flags for the Code Block/Transport block mode */ > > -- > > 2.17.1