From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 20E2142606; Thu, 21 Sep 2023 10:55:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99FA84026D; Thu, 21 Sep 2023 10:55:15 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2076.outbound.protection.outlook.com [40.107.22.76]) by mails.dpdk.org (Postfix) with ESMTP id 2B1C74014F for ; Thu, 21 Sep 2023 10:55:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hg+Y2o8H7VDPHJ6hZ8ZoghKVcLnjE49INxrzl37JCNdZFQEZSZcRNVByvrWuPcq/EAp7gTAcLPitZ2wKNSxKftip52tolYbjd58jmWCuc1QD7vd+LqLtliIB3hVh2WPfm5LApKM4oQ5+IFlQN1jZhYbcUlVlk0bCmg1reXs0dToQ+Yiza7ZHzoYW7sMa3I8PkuGUfvr17JLMxOfA81VJN0opO0wADmkuOwVSXZQfZr/aOjPd3POABUeSXmcHH2zhroYOWEmmDrRjKTrSQFZ8J6ZE2az3puDNuCBAvdud1nJq7+t37EvW2M9a5Pvrk9G7EWX+6ua5HJIrfB8QfOTg3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S40UjCDQeRidDM+KKUcBzRzQW8Syjasp1/ks1R//qZs=; b=NPeXq5/aa+RsQwUBhSPQR+7msWLlmH01/AlsIzdXTs73Iix/CfPnOXLgoAhzNBEK5/Albxssi+x8Au9fYabAkQGCg9VNUWPoUXW6yh45pxGhPoIzLDJhcg/24P8r+31DH9Qg7WkZqejSrNligFqU4WdbvjdTBeIGLY9DL1BSH5eIOzZIN5N/wHB6ucDiRt5991tfqf15X2ey6yGVcPeWhw7uWm/cX+CQ1DYaFtZSCqlBXSvKM/tDzobjgMBjEvKJGDfXv3Q4mrlO+VKVAH4ESmbQrp+Vb1DHxSna2aSZjB1R6K2LdDh6iGDpUbjmRc4O2SVj7GNwhPK6qGMXFfVRgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S40UjCDQeRidDM+KKUcBzRzQW8Syjasp1/ks1R//qZs=; b=EdQDBYZvNLyDRY4AYC6UYfTTzILbavUgfo59AclLYghVjBXCFRHFa3GawGT7gp82PQSVta8rstutUp9dbegb95GONeACvbvDU4HiWYw4ZP3pn1rFGY/YRiei1MYvSqr1vnB/7wJzeMLMSglX9rjcz6NMVc5Ls3AlUpWor2uu1VM= Received: from DB9PR04MB9332.eurprd04.prod.outlook.com (2603:10a6:10:36c::6) by AS8PR04MB8166.eurprd04.prod.outlook.com (2603:10a6:20b:3fa::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Thu, 21 Sep 2023 08:55:13 +0000 Received: from DB9PR04MB9332.eurprd04.prod.outlook.com ([fe80::e651:8962:2ada:bd0]) by DB9PR04MB9332.eurprd04.prod.outlook.com ([fe80::e651:8962:2ada:bd0%4]) with mapi id 15.20.6792.026; Thu, 21 Sep 2023 08:55:12 +0000 From: Hemant Agrawal To: Akhil Goyal , Franck Lenormand , Apeksha Gupta , Vanshika Shukla , Gagandeep Singh CC: "dev@dpdk.org" Subject: RE: [EXT] [PATCH v2 00/13] crypto/dpaax_sec: misc enhancements Thread-Topic: [EXT] [PATCH v2 00/13] crypto/dpaax_sec: misc enhancements Thread-Index: AQHZ68cp2FtqH81c20iyoq3rypYAgrAk7RqAgAANt0A= Date: Thu, 21 Sep 2023 08:55:12 +0000 Message-ID: References: <20230823070855.27532-1-hemant.agrawal@nxp.com> <20230920133403.6420-1-hemant.agrawal@nxp.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DB9PR04MB9332:EE_|AS8PR04MB8166:EE_ x-ms-office365-filtering-correlation-id: 1cdc7a50-dbe3-47d6-a123-08dbba8077ad x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aczv1tvgvFxchbG1zOdeVacr9Z35fvpAQAzMq9tISDtKnKGKFr6naZeESJewWhIxP/ASMgM+lVeuytmc2vtpfrrZk9j+jV1+VyVltNZoqhLPjdYBxeTRZ9CRMByIkk2k3Br85vo+1mC+HuIW17Rf7bFkgkJQUZ4gCt6wAravSifzeSNZGfPxXY6HZOH4r/TXUqgdIj1sSdv3IQuQRU+u/eSplXtcuCotAK2t953fxSDRwGRm2fW252/l/vs4XOmKV147TSNQxfxHOvtKThU/cL9VuPlp9ufKzmosVzH7VSffvyhv5bJ648Fe4jQ4+xB/eNv7y5BLSO5JVGjIVhOtc8YWj8cs7nMpxTW2qqgfmAkZA2wdRDEBmU0Dqemzh+gfPuXrN8KH68ympvdw8rVaCEejqDJhjFn4fzaih8HT9IbwTix4D/qZgRXm+jRRLWyEGiPqeSm8q3eN5JggP6z59+LfrLxK5zRSE+fgS7qhvZLx8mAb7qvZa1YxaoT4gtrxqrNityrxAKAn3Ri5DcaPQFYOTWlReSrAiurhZxVWyRauWkGxf7t5tFkiuXBJvc7hJBoGXrslrthOQvIR8W6V/XkJkx6Gaz7rsWocuP+nlIItl25xmyfuIRihXiatvUPD x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9PR04MB9332.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(396003)(366004)(39860400002)(346002)(451199024)(186009)(1800799009)(83380400001)(55236004)(7696005)(6506007)(53546011)(9686003)(5660300002)(4326008)(52536014)(2906002)(8676002)(64756008)(316002)(6636002)(44832011)(33656002)(41300700001)(8936002)(478600001)(71200400001)(55016003)(122000001)(38100700002)(66946007)(76116006)(86362001)(110136005)(38070700005)(26005)(66556008)(66446008)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/FMZtmleVYpL40+hAKsxBkFfyTKLh5SfivjkqB0PivyZBPvDbUZr6NpQOxb3?= =?us-ascii?Q?ISs4dKnSN4Cd+goddkstns9ELFinqovyhgoLSTxTIb5x47TrMQ0Y35LXldOT?= =?us-ascii?Q?pTf+vUnHBrg6pq2dY4sx+r5su4iP4ssq6CChWobx0LO+SO07OvYB6WMwe3Ow?= =?us-ascii?Q?3XYAiKX8szdiWzwT9bbN20T7uOCBybgMDjVepXNhbxSunytNN5/4xHucTF8n?= =?us-ascii?Q?ouHeJgXZKoZoxyH7uu0g/UVnVxDNHbpW73Yf+zHCddrvg1EvD/bnwxZKDwUu?= =?us-ascii?Q?vWfIL1X5YcysidT0kLKwb+PgoqpU21IxoOK13oMCQGQx2dUNDfwbqYgbE4Wv?= =?us-ascii?Q?o85s+GaJH0oVOyXaBGS9BSO0LAt5xnfsLN/8tXDtvbsdOzZvChTQEI+xy7fF?= =?us-ascii?Q?8RWOGRmDKrWQUuW0hGfFSGcfTQXbbfSJu6oxYke18pPRAP9u6AQqXMAWNxHe?= =?us-ascii?Q?kPpxnkSVLrYVmylAFn6+zRevuve3QPGWchgTpFLdgRuzE4iuH9s5zIKkxK/K?= =?us-ascii?Q?5B1l6zgukUn7Fq4Hb4fZe0q3XYYvl8BtQu9EtWf+O3YehTbtkiS1O99pV4b7?= =?us-ascii?Q?QxgpMCI0UzDj/hsYmcP91Am8IpwhYldno1IkTV+VOuoqch7u60/6XUOmeSQ/?= =?us-ascii?Q?j6Gy6pukHjDSqJHZX1cJhEZA6xa0uM1RQLVV/0K1G7mpfwMwMhldcC2JPblV?= =?us-ascii?Q?Vlo54I31kbEP35d1rgq3PhhOy6GqEuFdB9L7aGtN+ElarOnjjphbqZ+kx65J?= =?us-ascii?Q?oBJxhtMGVhsg/pAxZ0m+UcODDiupaynZjMkUwPzBpstxoD5J3p1Agg4n9b7Q?= =?us-ascii?Q?6wosxahGyumwmUOCQdzmBBy4keCux1YS38qN6cbjizYVmXsskOlzPXRaYbg9?= =?us-ascii?Q?aP5ZkpkKhs/nBnO5sDymi3e4HI6LmIbGg9aNJ7qmi7+Kw7fdFDFv6HEF085b?= =?us-ascii?Q?a226VLdCOgInDUYqlc9wbN3RCOFqloGmgUmh6vYlXTKv368lORd9ctWLPD0j?= =?us-ascii?Q?lMsZocHu9KQbWM0Ag7CLJH4lfErzqaiNfD0OQsYr94mf9cSyHdg8wPuPCigE?= =?us-ascii?Q?/JE5x0AdMy8m10x3ax/JHtHE9AScy72N8nkBzSfasO2Ca7v596NPtVmybiuj?= =?us-ascii?Q?eufi6KZ+3OZdpqGcQM3aebe3oMOlQPQuJ+VZ1x8L+7Y4k+Bjl/FXoiUYByd5?= =?us-ascii?Q?yfJH2jVUw93g14El223O168F/v76OrYwbbftBmF4X/ccK1NuVGXbNHHYCeE2?= =?us-ascii?Q?FkTygIjhlqrDEXLh9KykxiQMTkussfeXBO/fauwZst/zUxI7JnvgoS1Mblvg?= =?us-ascii?Q?xthHEUVj2OCL70DYzSXoCy6wl9hjAGFezcsxwPKT1rtQqebKGlcVUJoSbx7j?= =?us-ascii?Q?ezkIRWU3OyLxxrbykgZQwvc30DKMaavq6R3l7DXhjW0W2w/QDM+n+xA68QLF?= =?us-ascii?Q?9ZtqPSYloYFwG/M0liR/0EVBGl9se4bLVUvpt3IkwFWMV8EGUKk+XGweoitZ?= =?us-ascii?Q?NsEdFli8MtOaIhMZKVKd0iYslajbrwqDW305ge3FcGez2IT0MPtwhnNbyz09?= =?us-ascii?Q?rcx+S+2sv+eLhX8FLwWjK612fGOUH3hG1QpU0RRT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9332.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdc7a50-dbe3-47d6-a123-08dbba8077ad X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2023 08:55:12.9026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WNCGV8jYuJUYCC1zZ57In2IJ3EGxuWm99WwC8oSwb+pZIRwni+mbCtfY1ivR1SSK4+YMqCp6IatTRl2+oduAQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8166 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, September 21, 2023 1:35 PM > To: Hemant Agrawal ; Franck Lenormand > ; Apeksha Gupta ; > Vanshika Shukla ; Gagandeep Singh > > Cc: dev@dpdk.org > Subject: RE: [EXT] [PATCH v2 00/13] crypto/dpaax_sec: misc enhancements > Importance: High >=20 > > v2: compilation fixes > > > > This series include misc enhancements in dpaax_sec drivers. > > > > - improving the IPsec protocol offload features > > - enhancing PDCP protocol processing > > - code optimization and cleanup > > > > Apeksha Gupta (1): > > crypto/dpaa2_sec: enhance dpaa FD FL FMT offset set > > > > Gagandeep Singh (3): > > common/dpaax: update IPsec base descriptor length > > common/dpaax: change mode to wait in shared desc > > crypto/dpaax_sec: set the authdata in non-auth case > > > > Hemant Agrawal (8): > > crypto/dpaa2_sec: supporting null cipher and auth > > crypto/dpaa_sec: supporting null cipher and auth > > crypto/dpaa2_sec: support copy df and dscp in proto offload > > crypto/dpaa2_sec: increase the anti replay window size > > crypto/dpaa2_sec: enable esn support > > crypto/dpaa2_sec: add NAT-T support in IPsec offload > > crypto/dpaa2_sec: add support to set df and diffserv > > crypto/dpaax_sec: enable sha224-hmac support for IPsec > > > > Vanshika Shukla (1): > > crypto/dpaa2_sec: initialize the pdcp alg to null > > > > drivers/common/dpaax/caamflib/desc.h | 5 +- > > drivers/common/dpaax/caamflib/desc/ipsec.h | 9 +- > > drivers/common/dpaax/caamflib/desc/pdcp.h | 82 +++--- > > .../common/dpaax/caamflib/rta/protocol_cmd.h | 5 +- > > .../dpaax/caamflib/rta/sec_run_time_asm.h | 2 +- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 245 +++++++++++------- > > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 64 ++++- > > drivers/crypto/dpaa2_sec/dpaa2_sec_raw_dp.c | 47 +--- > > drivers/crypto/dpaa_sec/dpaa_sec.c | 15 +- > > drivers/crypto/dpaa_sec/dpaa_sec.h | 42 ++- > > drivers/net/dpaa2/dpaa2_rxtx.c | 3 +- > > 11 files changed, 326 insertions(+), 193 deletions(-) > > > Please improve writing the title and description of patches. > Applied to dpdk-next-crypto. > Please review the patches applied. Make sure not to repeat these things. [Hemant] Thanks >=20 > crypto/dpaax_sec: support SHA224-HMAC for IPsec > crypto/dpaa2_sec: support copy DF and diffserv > crypto/dpaa2_sec: support NAT-T in IPsec offload > crypto/dpaa2_sec: support ESN > crypto/dpaa2_sec: increase anti replay window size > crypto/dpaa2_sec: support copy DF and DSCP in IPsec > crypto/dpaa2_sec: prevent FLE offset overflow > crypto/dpaax_sec: set authdata in non-auth case > crypto/dpaa_sec: support null cipher and auth > crypto/dpaa2_sec: support null cipher and auth > crypto/dpaa2_sec: initialize PDCP alg to null > common/dpaax: change mode to wait in shared desc > common/dpaax: update IPsec base descriptor length >=20 > Few capability changes in dpaa2 driver were specific to LX2160. > But are common to other dpaa2 devices. I hope those are taken care of wit= h > appropriate checks. [Hemant] Yes, your observation is correct. However we have not tested these= things yet on dpaa, once we test, we will submit the patch. Regards, Hemant