From: Feifei Wang <Feifei.Wang2@arm.com>
To: "thomas@monjalon.net" <thomas@monjalon.net>,
Phil Yang <Phil.Yang@arm.com>
Cc: "Bruce Richardson" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
"Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Ruifeng Wang" <Ruifeng.Wang@arm.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
nd <nd@arm.com>
Subject: [dpdk-dev] 回复: [PATCH v1 2/2] devtools: use absolute path for the build directory
Date: Wed, 11 Aug 2021 03:14:33 +0000 [thread overview]
Message-ID: <DB9PR08MB6923A53FB3FE94CCDF6244CBC8F89@DB9PR08MB6923.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <2432521.6uc7bEPLWt@thomas>
Hi, Thomas
Thanks for your reviewing.
I agree with your comment.
As your concern, this patch is simple but may have some negative effects.
Thus I will drop it from series in the next version.
Best Regards
Feifei
> -----邮件原件-----
> 发件人: Thomas Monjalon <thomas@monjalon.net>
> 发送时间: Friday, August 6, 2021 11:43 PM
> 收件人: Phil Yang <Phil.Yang@arm.com>; Feifei Wang
> <Feifei.Wang2@arm.com>
> 抄送: Bruce Richardson <bruce.richardson@intel.com>; dev@dpdk.org; nd
> <nd@arm.com>; Juraj Linkeš <juraj.linkes@pantheon.tech>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; david.marchand@redhat.com
> 主题: Re: [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the
> build directory
>
> 01/06/2021 03:56, Feifei Wang:
> > From: Phil Yang <phil.yang@arm.com>
> >
> > To make the code easier to maintain, use the absolute path for the
> > default build_dir to avoid repeatedly calling of readlink.
> [...]
> > --- a/devtools/test-meson-builds.sh
> > +++ b/devtools/test-meson-builds.sh
> > -builds_dir=${DPDK_BUILD_TEST_DIR:-.}
> > +builds_dir=$(readlink -f ${DPDK_BUILD_TEST_DIR:-.})
>
> It means that all uses of builds_dir will get the absolute path.
> It may have consequences on meson configuration, and will make outputs
> and logs longer.
>
> I'm not sure this change is desirable.
>
next prev parent reply other threads:[~2021-08-11 3:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 1:56 [dpdk-dev] [PATCH v1 0/2] relative path support for ABI compatibility check Feifei Wang
2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 1/2] devtools: add " Feifei Wang
2021-06-22 2:08 ` [dpdk-dev] 回复: " Feifei Wang
2021-06-22 9:19 ` [dpdk-dev] " Bruce Richardson
2021-06-01 1:56 ` [dpdk-dev] [PATCH v1 2/2] devtools: use absolute path for the build directory Feifei Wang
2021-07-28 7:20 ` [dpdk-dev] 回复: " Feifei Wang
2021-08-06 15:43 ` [dpdk-dev] " Thomas Monjalon
2021-08-11 3:14 ` Feifei Wang [this message]
2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 0/1] relative path support for ABI compatibility check Feifei Wang
2021-08-11 6:17 ` [dpdk-dev] [PATCH v2 1/1] devtools: add " Feifei Wang
2021-10-15 10:02 ` [dpdk-dev] 回复: " Feifei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB9PR08MB6923A53FB3FE94CCDF6244CBC8F89@DB9PR08MB6923.eurprd08.prod.outlook.com \
--to=feifei.wang2@arm.com \
--cc=Phil.Yang@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).