From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A0FCA056A; Wed, 10 Mar 2021 20:51:06 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 861A822A403; Wed, 10 Mar 2021 20:51:05 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00058.outbound.protection.outlook.com [40.107.0.58]) by mails.dpdk.org (Postfix) with ESMTP id 16C4D40F35; Wed, 10 Mar 2021 20:51:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EO4U2CKzqkZuzJRTLFd/BndYWo9ot4PUPyRsarIceSk=; b=dQhQ7roeEIvOeYnSQ/RgKH8KL5ZpbyohCaF+/QW8c3fP6IWbyQmLGS6YYhw/E96QL2F9hxSlKb4ZsRxzWxca0TRy64kGRVCXOuAOiuujfFSqUMw3a4IWvye/YWN5qRcji7b74sNC7YDiHQC0EqlYIt1kf0EQhahpTrKHb9o+b2Q= Received: from DB6PR0301CA0041.eurprd03.prod.outlook.com (2603:10a6:4:3e::51) by PA4PR08MB6191.eurprd08.prod.outlook.com (2603:10a6:102:f3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17; Wed, 10 Mar 2021 19:50:57 +0000 Received: from DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::ae) by DB6PR0301CA0041.outlook.office365.com (2603:10a6:4:3e::51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 10 Mar 2021 19:50:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT042.mail.protection.outlook.com (10.152.21.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.31 via Frontend Transport; Wed, 10 Mar 2021 19:50:56 +0000 Received: ("Tessian outbound 520e67c3dd94:v71"); Wed, 10 Mar 2021 19:50:56 +0000 X-CR-MTA-TID: 64aa7808 Received: from 8dc009366f7a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FFF90DFF-9B7B-4D65-AC6F-AA88FA7D3780.1; Wed, 10 Mar 2021 19:50:51 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8dc009366f7a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 10 Mar 2021 19:50:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jH6GjhwNeSJftr/i4Gb4DBUjKU1hEbqaWVUGWP9DGNo0MWMCvu4gcpyOoe55RG++jL+Oy+eTjAAamsi0Gp/a0pJ8D0dzq9CHKCRXOvKsfNaHzWMup3lTk6XZTfaio72Glhbecz5t07VAwpX/QemUok8OGYjZ1uDJ4EjPnw++z0lXwJ5oVdKllyJv1RD5DgVYSD52AILN6PLur3B99C89vweTvDroxF6l4UsjaU4WGlcle32b9xc7C4i6AXqC6fUhSrbX9MIVBQe5LQBrBb3lBCd3yX+gDRVuhqf9DSJA2FwX2amBTimf3e/LrlJPvMD3FR2RLRugx90l0snPDkzZww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EO4U2CKzqkZuzJRTLFd/BndYWo9ot4PUPyRsarIceSk=; b=ggggRDLtILnRQGuZNDiPUaCPghrAHWZhwa6qR+YsaCkBUdmQAuC3vBK6JbApBLfKDbziK8ktD4ANJy5W3KF3/OvHCI+8Lfw3X2E/9cP0O+wXqpfSf1Sl5W3cSsn9+3ySwbKVx76TKZ/H5Vo4H5k53sZQS7+O66uBxiSjTCJPk2MBmgeYmALFT9z7jCkjRPtdCBu82KRrJEs+IThCJ1qzJEUngKEYec1dMUHwmtxPF9wZ9KGriSHoomf1ogQMfZL6KVY8RyW645+wdKfhR6y82CAX8TStt2a7aHOatU6lyfx/ZNwF6jgxe5MsCMPFPBLWo28VMB1ZgNJhzD2ORBEeQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EO4U2CKzqkZuzJRTLFd/BndYWo9ot4PUPyRsarIceSk=; b=dQhQ7roeEIvOeYnSQ/RgKH8KL5ZpbyohCaF+/QW8c3fP6IWbyQmLGS6YYhw/E96QL2F9hxSlKb4ZsRxzWxca0TRy64kGRVCXOuAOiuujfFSqUMw3a4IWvye/YWN5qRcji7b74sNC7YDiHQC0EqlYIt1kf0EQhahpTrKHb9o+b2Q= Received: from DBAPR08MB5752.eurprd08.prod.outlook.com (2603:10a6:10:1ac::21) by DB8PR08MB5323.eurprd08.prod.outlook.com (2603:10a6:10:fa::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.19; Wed, 10 Mar 2021 19:50:49 +0000 Received: from DBAPR08MB5752.eurprd08.prod.outlook.com ([fe80::4102:e0d0:7df0:362]) by DBAPR08MB5752.eurprd08.prod.outlook.com ([fe80::4102:e0d0:7df0:362%7]) with mapi id 15.20.3912.030; Wed, 10 Mar 2021 19:50:49 +0000 From: Kathleen Capella To: Feifei Wang , "jerinj@marvell.com" , Ruifeng Wang , Beilei Xing , Jeff Guo , Bruce Richardson , Jianbo Liu CC: "dev@dpdk.org" , nd , Feifei Wang , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector Thread-Index: AQHXFVbR8hBrcv2NLU6+frG7tqiAzqp9m4aQ Date: Wed, 10 Mar 2021 19:50:49 +0000 Message-ID: References: <20210310024029.20772-1-feifei.wang2@arm.com> In-Reply-To: <20210310024029.20772-1-feifei.wang2@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C7A915177B95DE4492F989B8EBF7800C.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [64.121.153.90] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: ab25442a-1f4a-4a00-d135-08d8e3fdd268 x-ms-traffictypediagnostic: DB8PR08MB5323:|PA4PR08MB6191: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:6430;OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LluO2rIH7LSmjyLZitpysN9lLCpb5NcMhDLleZ5F89ARAw+omPZhwwaUPfVN+8lijSSLCPPTqBg8GjgKKkp7RJNXR6PB2GS8KkMWLYC3bKwLV2P40nFW7rFCmyKpcRZiGPSznN9a5wDoZu22c736X9r08jLv2uDWA2ZPUVBQFrvqaOGG7p2ApF/MmR4R+ShKmIPvEK/ZQ2z135XaEwkDBnnnoxWOC3EohgkIylCJWazbfUp4Gb1lBn3gshqK9xxubR5bmFdSBarlfOusEPnLieqQdr/O2x7WpwJ19F6SSfd6DnawyjT90N1lBO24aSKcKNzyxmwdc7fqLW05yCbAb5pJu4bgLEj3M/J1kM3mDEJUB30jwsjDcmd6WCBaPugTJtcQv8hx6eD9MgK4ltKs65qoKGcvPr/JwFFjYp84vtm7TOxFbj1HF1V1i/LbN+R8fizPXwhDclsbqQhk2C8WcOzau0zNWjUtCgidXJ51iyaBJJbRvfZTHVulpzDqMFbRTdftT6XNXASF1vf0JfIRKQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5752.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(66556008)(9686003)(64756008)(66446008)(33656002)(5660300002)(55016002)(76116006)(86362001)(478600001)(66476007)(66946007)(71200400001)(8676002)(186003)(54906003)(8936002)(6506007)(7696005)(52536014)(110136005)(26005)(316002)(83380400001)(53546011)(2906002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?8Fh4HgSj3EP5KbKw9COQ6LmgFc8TdJmfDCG75u4pkAKZM1twMgVMB6LmWA7j?= =?us-ascii?Q?cG3nXsyIHYWUIMlUXi3iOnXvJMshwGYwAM8OL43qol7VZpvM0lDnVjdQY4Oh?= =?us-ascii?Q?yF8vdYJ5LRmUl2HoYOUOTtMQ5A5YfYMzqGvR/RlFQnsZMpwncLgv9wjhDKSc?= =?us-ascii?Q?FQNqSJwZZRP/IzP1+CugyI5p6lGdaNSKky7szcmWuVneI7H1HWBnQheoU/lJ?= =?us-ascii?Q?kWUszshNMK1zpScCsIWTpx6arvqZf6nDOVpXiqgtgT3P2XvVqmQF6lG6LnAp?= =?us-ascii?Q?nVEF+8IsISEXqrdlQxuKWrAi6BzVI1ESQDxD36J9Q6PBpNRRMtjCSGw/3ibg?= =?us-ascii?Q?VFELlcUPHRgaZ9w6tHKWc1C8gf+FQvz1HWoCWe4lxbS2CX/4R6TgKZeAYPFr?= =?us-ascii?Q?OSBKsB4IxdL1SW3SWnOzsXLqLpGkVTla99weRYl1X837E3U+R/EtScxae4AP?= =?us-ascii?Q?dq9P6/xxqEFJAf/d+PVM1HWyqrxhJrWnQWfhJ6pfzzykcE1V9r3OM6G4Bn49?= =?us-ascii?Q?BYmd5itNCiHPqm5iZbM5/z9aPXoaOixFot7IFj/SGB+YYLR9Fy4YvCB88TtP?= =?us-ascii?Q?fHvicmnH1VTEMIVmWasRGwM6eHbmHcd6f8TjdGxuvKGAsVC+PH7Q8l06PbTo?= =?us-ascii?Q?YlLG+XrA59QW8NMBo2lYk27m6e43+zKrqUp+NVlORTrfx+X1JVS02wJXsg73?= =?us-ascii?Q?onhhfzcBwjfYCW9ZPKwWvXyo+pqBmRzqxi3aZKkZEkpmtsNSRR5C7zfxNYQ2?= =?us-ascii?Q?Su3WPzdEI+fbM+K2ZCySS6LgtXNLm1ha2ALQLc1zsCagfgnfB4hQxO4k4HGJ?= =?us-ascii?Q?BcUYFecCxESJUD7nZRNk3qY1ztrlhOPcbr3zIAfGSkG/zqLh88ssKhaaPr7g?= =?us-ascii?Q?oLSMFpdSXpxg53DN46G7AORtpxWAP+tNY/iEH3BFTPGqK7t3lY7zTywf57Qc?= =?us-ascii?Q?rtFVRf8/ojXSNLawrxCbEAW67cLhu9pGHHxvdrkfusmc0eviSqGsmBMhRGiN?= =?us-ascii?Q?MQ2PIRhkEr94iDlIWexZ7EHoxnSVFseAKPpnoBCbnrhyo8e+VKS1AVUTwvUX?= =?us-ascii?Q?cZ1bllcu1Xs01G0zsGn0eaLGaflSEEw83QDDzLRVHVxsfkLm7IFEsQGmALTr?= =?us-ascii?Q?AR8zhWw6wLzxKq3Bt6akMdXchszQTMVgHfuPAA7RNQXR/5ugEpaV0S+yzDC2?= =?us-ascii?Q?U1WaON3MvogRt0+rVCG+TbPzryzbxEgaKfib+jHXlx28nH/95pTs6dpNmkz0?= =?us-ascii?Q?K2FwQ0Ypsw7aMrRo8D/xW+T7L9ezDhMEaP8LMhNJyCFA+RIqon9MC770aQ3N?= =?us-ascii?Q?1P4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5323 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b27e0d66-f784-4fe7-ce98-08d8e3fdcdde X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dA3k3t/RctiQLvTL9YS2jseeS1sy/m22q1L5OaMHa5aivwzw/bORM/Eyr5V3gWW1l2RXnN3QPUar3ZTG8suvHgUl9wESuPnSiQ8/waZz5qCbArc3W/emLYNnD6zzWwALSEe9zHjiVhEX6cDJ8wAZ60Ukik+SCksFP5iiGYMjqrgyt7CFG0M0RiOxZFWHdcRdNDC7LCONuhsaceiPx0Ea7NPUYMS4Io7DWA1yEAcfiqIpV+4rh6dN3CgiMrvrCZwLY+HT9d3IgSTtx8m+Kbr3TKhSaPl9VGaO8+bcCWOUzcw5LnFaGkqZChD3ZTWxFCLDHdceU0Mu4ybDlywYkpSjoHwLxBhsazKaQAtiyotzqStsevWYPKabUUsd7CQl7rRnW5khqjgLdQh4PioIjjAvsFjuzFG1dhoWV0eQQEuJlGgxjXdekeUQTrLZYWdpxVo0p3D+be4IQbrxIuk6flisLDHeQUaAnj+CwO/PgEoKVdNvcsv3y5awUWsjxl9HD7ljLKj3NIH0G1EwMUCvEb8k28XPTxbKuUwgMCZAzmagTopijRM5Z0hm5rYlAIOLypzGpfINzfNXw+ybINj565Pkid1Hy6bgDbsHAVEZjqpjEboq3ob3FUbKaqUEutdY/fPuq/edtgbOAjKmKwsEv9OfnQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(136003)(39860400002)(376002)(396003)(36840700001)(46966006)(7696005)(5660300002)(82310400003)(70586007)(478600001)(70206006)(6506007)(356005)(450100002)(52536014)(53546011)(86362001)(8676002)(47076005)(8936002)(9686003)(55016002)(110136005)(54906003)(81166007)(4326008)(82740400003)(2906002)(336012)(36860700001)(186003)(26005)(33656002)(83380400001)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2021 19:50:56.9051 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab25442a-1f4a-4a00-d135-08d8e3fdd268 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6191 Subject: Re: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON vector X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Kathleen Capella > -----Original Message----- > From: dev On Behalf Of Feifei Wang > Sent: Tuesday, March 9, 2021 9:40 PM > To: jerinj@marvell.com; Ruifeng Wang ; Beilei Xing > ; Jeff Guo ; Bruce Richardson > ; Jianbo Liu > Cc: dev@dpdk.org; nd ; Feifei Wang ; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/i40e: fix parse ptype issue for NEON v= ector >=20 > In i40e NEON vector rx path, the packet descs processing is incorrect. > This caused wrong packet type been filled in mbuf. >=20 > To fix this, when shifting the pktlen field to be 16-bit aligned, it only= needs to > process the high 16bit of the packet descs instead of the high 32bit. >=20 > Test Results: > Architecture: arm64 > NIC: XL710 > Driver: i40e > Package: Ether()/IP()/ >=20 > Without this patch: > desc_to_ptype_v: ptype =3D 7 (error) >=20 > With this patch: > desc_to_ptype_v: ptype =3D 23 (correct) >=20 > Fixes: ae0eb310f253 ("net/i40e: implement vector PMD for ARM") > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > drivers/net/i40e/i40e_rxtx_vec_neon.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c > b/drivers/net/i40e/i40e_rxtx_vec_neon.c > index d81269624..ada82a14d 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c > +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c > @@ -310,10 +310,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue > *__rte_restrict rxq, > /* pkt 3,4 shift the pktlen field to be 16-bit aligned*/ > uint32x4_t len3 =3D vshlq_u32(vreinterpretq_u32_u64(descs[3]), > len_shl); > - descs[3] =3D vreinterpretq_u64_u32(len3); > + descs[3] =3D vreinterpretq_u64_u16(vsetq_lane_u16 > + (vgetq_lane_u16(vreinterpretq_u16_u32(len3), > 7), > + vreinterpretq_u16_u64(descs[3]), > + 7)); > uint32x4_t len2 =3D vshlq_u32(vreinterpretq_u32_u64(descs[2]), > len_shl); > - descs[2] =3D vreinterpretq_u64_u32(len2); > + descs[2] =3D vreinterpretq_u64_u16(vsetq_lane_u16 > + (vgetq_lane_u16(vreinterpretq_u16_u32(len2), > 7), > + vreinterpretq_u16_u64(descs[2]), > + 7)); >=20 > /* D.1 pkt 3,4 convert format from desc to pktmbuf */ > pkt_mb4 =3D vqtbl1q_u8(vreinterpretq_u8_u64(descs[3]), > shuf_msk); @@ -341,10 +347,16 @@ _recv_raw_pkts_vec(struct i40e_rx_queue > *__rte_restrict rxq, > /* pkt 1,2 shift the pktlen field to be 16-bit aligned*/ > uint32x4_t len1 =3D vshlq_u32(vreinterpretq_u32_u64(descs[1]), > len_shl); > - descs[1] =3D vreinterpretq_u64_u32(len1); > + descs[1] =3D vreinterpretq_u64_u16(vsetq_lane_u16 > + (vgetq_lane_u16(vreinterpretq_u16_u32(len1), > 7), > + vreinterpretq_u16_u64(descs[1]), > + 7)); > uint32x4_t len0 =3D vshlq_u32(vreinterpretq_u32_u64(descs[0]), > len_shl); > - descs[0] =3D vreinterpretq_u64_u32(len0); > + descs[0] =3D vreinterpretq_u64_u16(vsetq_lane_u16 > + (vgetq_lane_u16(vreinterpretq_u16_u32(len0), > 7), > + vreinterpretq_u16_u64(descs[0]), > + 7)); >=20 > /* D.1 pkt 1,2 convert format from desc to pktmbuf */ > pkt_mb2 =3D vqtbl1q_u8(vreinterpretq_u8_u64(descs[1]), > shuf_msk); > -- > 2.25.1