From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6AD47A0A02; Wed, 28 Apr 2021 01:27:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5D3D40F35; Wed, 28 Apr 2021 01:27:08 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60081.outbound.protection.outlook.com [40.107.6.81]) by mails.dpdk.org (Postfix) with ESMTP id 06CFF40147 for ; Wed, 28 Apr 2021 01:27:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eUqmPxbsIPxzefhP4bjVr6mVPRwFvwmfhM6PBYjoe9M=; b=rpZsvNP5dVhpKPgGvSvuIxQQgeBxAhxeBr1ObxXZ7b73AQHk62NTF9A/HOtKUR/Z9IU3baS+6O8tXaZq/qDM+HHuc09fsOe1qxjenl611dTmA7biyAXvdXe0I9JpRapQ3StXYQQi/JpNk5pXK/hILGWrH7hFBvuUfKA5ijHOCaE= Received: from DB6P195CA0017.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::27) by VI1PR08MB4094.eurprd08.prod.outlook.com (2603:10a6:803:e7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 27 Apr 2021 23:27:02 +0000 Received: from DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::38) by DB6P195CA0017.outlook.office365.com (2603:10a6:4:cb::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Tue, 27 Apr 2021 23:27:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT020.mail.protection.outlook.com (10.152.20.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Tue, 27 Apr 2021 23:27:02 +0000 Received: ("Tessian outbound 81a4524e9a48:v90"); Tue, 27 Apr 2021 23:27:02 +0000 X-CR-MTA-TID: 64aa7808 Received: from c251da39a838.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 41B57E8A-86CF-431A-A47A-E9D06443E273.1; Tue, 27 Apr 2021 23:26:52 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c251da39a838.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 27 Apr 2021 23:26:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oxil8q0I9lDo1tEx5kfw0tn84i4lFpbZQCqZRDZfGfDwdXALe/NPnLn1Fkl45D/RPktRS5QbjANY7dqe5+VBuhdsAeP0m3EZWbNk/nJY6co6zW3k9S/HEBj03Hfm2Er8OGL8CVIzvjuEHyo5Y5+mAFRlPioRPiKGiZBoaCADP+fbPHoEnf0wu+cGkitg7ipUALa3v3mxeMKcIJAc2w8TKOkMJ4YwYJctZ30vfhIK6oJLOge9BOWcV0doAwj8WW6S//4QcqvjOdZTcqr3FcH6C6rEYqRHqc4j5IXQYwvmftssGw4T9fJUuxKdGU89FUW5QZQJ7tO00FC7NVXp8+99xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eUqmPxbsIPxzefhP4bjVr6mVPRwFvwmfhM6PBYjoe9M=; b=jB4XtL7zyfrJ8MqVlgxFhvolFjG0YCcFCBQuj3Sgg1D2LbhGU4InsJaBPi+nFOgFErm6dpNTNlQjTGpu/5ePhH0IaARTgJ8OZ75rND9Q7+mhdSi7sfGt3b3E52NfdySitliL2627taWst4CeU+cPgBEa1pGsCMxr3N8Yh7r9uHKv8whIdxiPXef7kz+dnzbBx0i70I6aViNhHfqKUjaM2vmMLnMN1AzRLVBx+TeB+F2JxhD6rESSU10kpUQVXUOCTh3SAKJySaszCpx16nc1e527uKDwKBjYTpz7zJ06xt8LAr6aDQw/uF0lWZPB6+nHRriwDDeQ0pzGT+7iLb3iNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eUqmPxbsIPxzefhP4bjVr6mVPRwFvwmfhM6PBYjoe9M=; b=rpZsvNP5dVhpKPgGvSvuIxQQgeBxAhxeBr1ObxXZ7b73AQHk62NTF9A/HOtKUR/Z9IU3baS+6O8tXaZq/qDM+HHuc09fsOe1qxjenl611dTmA7biyAXvdXe0I9JpRapQ3StXYQQi/JpNk5pXK/hILGWrH7hFBvuUfKA5ijHOCaE= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR08MB2647.eurprd08.prod.outlook.com (2603:10a6:6:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Tue, 27 Apr 2021 23:26:49 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e%7]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 23:26:49 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , "thomas@monjalon.net" CC: "Yigit, Ferruh" , Stephen Hemminger , Jerin Jacob , "Ananyev, Konstantin" , Kathleen Capella , "dev@dpdk.org" , Dharmik Thakkar , Ruifeng Wang , "david.marchand@redhat.com" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Stephen Hemminger , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] L3fwd mode in testpmd Thread-Index: AdcV2H0Bhkmz7z6QTBeC8FixZy3dngAaQ6AAABIFuOAAAQNCAAAAQNqgA/efEhAAAYi7gAAF6HhgAAl7GoAEe3+OoAB4fPWAABDYiwAABc478AAb06kAAAAT1EAAAsPMgAAAvRgAABixsSA= Date: Tue, 27 Apr 2021 23:26:49 +0000 Message-ID: References: <81781e97-735c-f584-4148-ff07dedc5cb4@intel.com> <4144195.lBnvlMlemC@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F41A30E613BA1440A54A9F0ECA0DC670.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: c53aa4a8-a401-4caa-ce1e-08d909d3f640 x-ms-traffictypediagnostic: DB6PR08MB2647:|VI1PR08MB4094: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CE9XyMbhfOhkobyLNAYqjrbIc4NdJRoEfu9dM5KXD+AXAdtoF/SYOY+F9P0a379/D6vIlerZmQoe2l67/UXtKg1I7Ou4v1y7CkjbbF10l/8PRLfU4Ed7yxQAHV0CFjbeSctLuQaLW/THcUma4KHWTWNRbMkFKagWamK5taE4T3c6gHaPc4MMDfRSntotXatkrhUvgOOxnBAGl+Ljig1JWcvS2aZHAKiWHi9utYYxxZ6RyBhjw/i6sP//lEB41sd0dTzNdrjpRqnxNZvLY0aRV8xcaMYjcTYskYmMOMIG4Fslsyim1gF33x7hbiHGkR50WXXJxKWbj9l7XNM2ALfZ3MNOazsmqNw/gEANNUZCRdp0ONWtYMUIpGK8SImhYA9clbmfX6WxOqiXTwBVxKClFvXWx2iLF0zK/tr2edyYnAZwfR0upzVRjowSUrSESsfw3TKAai1JBeaN3ybCYXoIoZIle7QZDoCSxOUJZp2JvN20/sg2PHooSEyU9VtlxrTxXLoFvSqNyMDDbkWMn9uOjNv+sM6q4+ZAghOLMTv2W8IceslCBZnRQzbw1WHXN7VzDq7xW2bEzJOy9+MM5pzGTo6mmXwKFg337uQ9zn5XwwCTnlrtcABPviOvp02SDWFhDpjG5HdvCIV42ryu4ANEiw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(136003)(396003)(346002)(366004)(316002)(76116006)(38100700002)(66556008)(64756008)(66446008)(66476007)(26005)(33656002)(5660300002)(186003)(66946007)(86362001)(71200400001)(54906003)(8676002)(8936002)(52536014)(122000001)(6506007)(7696005)(110136005)(9686003)(55016002)(478600001)(2906002)(7416002)(4326008)(32563001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?wEDhB/By3J3UbVX/gIvgMIHU5nCi0tz76IsUjy/YDPqdcpVZPa+IUdRZ8JUU?= =?us-ascii?Q?pwZ3Ty+B631OhfB6wShtvpLoaxlcI5c1Lyrau2esEmhGVTX32a5g00hBXCpQ?= =?us-ascii?Q?xO/NEb89i6jdrLHVIkXYoFj/CsKmPSX0+8KGrFAfR2nMAb19Pw7n7lo8T84n?= =?us-ascii?Q?O8P/QhXxfab666CpMULgAs6dfrd5OrRhJOUkL47khR7MAJb6ryWA4AcfhvE5?= =?us-ascii?Q?UJO47bDRSBJ47aQBj6T1lI8rwj5d3tzbvrS1HP+reEZbxWQh/uycE/b7cFvT?= =?us-ascii?Q?LTdkqga9jeZHdB8kUdUpAxFkj0dcuiedBnJRaVCJaejz27zQTYvqbZU+v5/H?= =?us-ascii?Q?uDnfSxRjine4CcSYytQifVdDZ0rm8/F98vdLBk9VnZjnuQm3/688tWpefHih?= =?us-ascii?Q?2eZO9KBGS6ormy9mN3z3HF/eQ1ozO1nKaiGPGkTObElrBYKl7qPhD484Lo6G?= =?us-ascii?Q?y3WPrvt48VIMtpy1S8dDS18i95fcPhfF40vCeOpeSi5B0/J1wOGmdm3myafE?= =?us-ascii?Q?yjBSAVeuKZJsoJC3eErQF7sYXlYnaHiBiaB2iJkSDcs4zypWaJFrgb/QBJ/l?= =?us-ascii?Q?hI8SfrsQnn8pbpyjF9pBaVT7GaBVnrNLXFsDV/HIR9ILKNIYiR9RX7K+DDlK?= =?us-ascii?Q?q+7JJq5aOhbz5rYQ0mRuI7igb88Ihkv+2uXTEpSe8EcPjL6ttGuTep9UDqFY?= =?us-ascii?Q?0bosz2URvJIbitdFF/L7fY9tfsyMs648rmbQ3zNk6JaCzHIdmmU57z0ebv5q?= =?us-ascii?Q?dWD672V2AmjsEO6RH+gMKKuXGpzVuJZZcR23xKPStKsMcVwXmTVuiksevyJI?= =?us-ascii?Q?cQAzWXX1Vqe/ucLI605YXKVSWxX4xV7T+f2CKvydGZvSmwbDqtJKYwzIf6An?= =?us-ascii?Q?FnOiYiJZlxSit5fShBVDIXpA8Rb0kym1gIxeWcC3Av7KVli9JJ/at/N6a7G4?= =?us-ascii?Q?D5bmtfxWsoGbCwelOKEr1pYccHGj1398TCQ/ynPETkSOo8IEQO6loCnLRQaN?= =?us-ascii?Q?gnRIHVC+lOp9d5OgvHBEjfNcsh87850NF+mbL+Rgj6tOJx6kJgnInkh+l5B6?= =?us-ascii?Q?mTipYZNUJ7Eeqf/H436D1odAN4XLWKbrPlGDKNHxR3J4CIYh05UMAfIf4p1X?= =?us-ascii?Q?QEK3JASQWtO62ovESRWuW0x+vZC1JXKBt7IHMzUilFoW3yq9jkApPwGrgdBm?= =?us-ascii?Q?SV7X6il7MJndESAoP/KpHwWs42BkqCREnokPZiyNofD6hulPWTXj1YlHgL7A?= =?us-ascii?Q?f9TIMh48YkJMSkWPaFDKJrS8cUgrIfidV0ksvNIH7nKBO/bO5pZkgjMjN7bA?= =?us-ascii?Q?RTZBe8N2oFQcYS9YFxOIlZxK?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2647 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 3bc99b48-a153-43ca-9e2c-08d909d3ee67 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TkacIyCc0Jlf9cJBxfmJBDwoxerVE87l969jzSD5TWFaNqI7ThngmCXs9rjVblekqoiGypH+tNynFhbB3IkHFU/MgQv4DIMPf+EIT/nHEBjVSyMhi68tB8ns4OZPfCM5NrtrpR5Rj9FbptJ0oksM7QoqsW9MWcrk+S2UJ7oz0SOBk/3+O88fabiN5NTyNt4kitDgxs0F/h10Rh3u/uMZhz6Np+n3p2wjEWJaeAd95J+6quXqxPRadmL/JUbuOJA6FWasuswmrzBEw7DxvYJWIS96w1Ch7jAcci1xIrog00dY1yllaEcrVvD/C5/cuvObwdFttjjYq9vPWtI+FUvzRift4tnF3jiKfChvgQjL1rTVuKhkTn2Xb5VYmQMhOevqs2Qu3ySaldCf+v0Jd1jxJAOLZJr2PWYk/dwhOnAg8egJtdx6AgXs1FhKN1Ec5Hzzv6E9kTUgI2A4LvRQQvDPaW1VAAb33Y3+gZ2lsuu0wIKhTndEe5a7606AzZl46RIn053bTMDw5kCqdQwguY7yh/68h8gQyCvZ8N3aXpJLqyhzGSknQodbvsCAgekdCafegwqWGd6JphYIl4NTg7tU66nO+Z8gWCJLnoOeEQ0S3SCG9NZAe+Jbsp3baltIU6fDdvSdwzG8Riu+GWOV3x/mH2YVZSYDNrL3Vnmr1CzYifAUIVln5ErFUIljm7psImtFGhCUvOBwP9zdDZefrhRX2w== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966006)(36840700001)(54906003)(34020700004)(336012)(9686003)(36860700001)(26005)(110136005)(70586007)(70206006)(316002)(8936002)(52536014)(356005)(86362001)(4326008)(6506007)(55016002)(7696005)(8676002)(82740400003)(186003)(5660300002)(2906002)(33656002)(478600001)(47076005)(81166007)(82310400003)(32563001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2021 23:27:02.3757 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c53aa4a8-a401-4caa-ce1e-08d909d3f640 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT020.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4094 Subject: Re: [dpdk-dev] L3fwd mode in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > This discussion has ended up as a stats discussion. But, we also = need > to be able to change the configurable parameters easily. > > > > > If we implement the stats and ability to change the configurable > > > > > parameters, then it is essentially bringing in some of the > > > > > capabilities from > > > > testpmd to the sample application. I think that will result in lot = more > code in the sample application and will make it complicated. > > > > > > > > > > Instead our proposal is to take L3fwd to testpmd and use all the > > > > > infra code that testpmd provides. We see that this approach > > > > > results in less > > > > amount of code added to DPDK overall. > > > > > > > > > > > > > Agree that it may help testing to have l3fwd support on the testpmd= . > > > > > > > > Two concerns, > > > > 1) Testpmd already too complex. > > > > 2) Code duplication. > > > > > > > > For 1), if the l3fwd can be implemented in testpmd as new, > > > > independent forwarding mode, without touching rest of the testpmd, = I > think it can be OK. > > > > > > In fact, l3fwd is also quite big and complex: > > > $ wc -l examples/l3fwd/*.[h,c] |grep total > > > 6969 total > > > > > > Plus it will introduce extra dependencies (fib, lpm, hash, might-be > > > acl?) I am not sure it is a good idea to pull all these complexities = into test- > pmd. > > > I can't imagine that l3fwd app need ability to configure each and > > > every PMD parameter. > > > From my experience in l3fwd most of cycles are spent not in PMD > > > itself, but in actual packet processing: header parsing and > > > checking, classification, routing table lookup, etc. > > > > testpmd goal is to test the driver, not the libraries. Agree. I think the L3fwd should be an exception as the performance of this = application is a key metric for DPDK. > > > > > > Not sure how to address 2), also lets say we want to add new > > > > feature to l3fwd, where it should go, to the sample or to the testp= md? > > > > l3fwd is not targetted for testing. > > > > Maybe we just lack a new test application for routing libraries? May be. But, I would think the unit tests for the routing libraries should = be enough. > > > Yes, I think we do. However, I also think that there are quite a few > advantages to having l3fwding supported in testpmd - particularly in term= s of > code reuse, since testpmd already has a lot of the functionality that one > would look for. Furthermore, since testpmd has multiple forwarding engine > support, it makes it very easy to add lpm, hash etc. as separate forwardi= ng > engines, rather than trying to mash them all together into a single one. +1 >=20 > The main downsides are as you point out: > 1. repurposing a PMD-testing app for also helping testing libs. The count= er > point here is that for much testing, the key perf metric for a PMD that w= ill be > looked at is the l3fwd'ing one rather than an iofwd one. > 2. the extra dependencies for testpmd. I think that if we do look to merg= e in > the extra functionality, we can make the presence of the new forwarding > engine dependent on the presence of the required libs. +1 >=20 > Overall, I'm cautiously in favour of this work, since I believe the benef= its > outweigh the disadvantages. Having l3fwd testing in testpmd would also > allow us to consider simplifying l3fwd example so it is more of an exampl= e > and less of a "testing-app-masquerading-as-an-example". >=20 > /Bruce