From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84BD5A04BE; Sat, 5 Sep 2020 03:47:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 948201B952; Sat, 5 Sep 2020 03:47:51 +0200 (CEST) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-eopbgr90072.outbound.protection.outlook.com [40.107.9.72]) by dpdk.org (Postfix) with ESMTP id 84D15255; Sat, 5 Sep 2020 03:47:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrNJ9VRD3OYe/p4PB/gy7pDVE6zv5dyJoBqwyevx9zo=; b=9FuLApDc+OYkoyMT66jkfC5OvGQ6vtgQUnIA/ACFdVi2FtPSZGSIKEjAfrRhZ6f4UJDk64M5pYPC8zpR8qOCimCx4lNtHCXFm0+nqMkrcO05SgdT/Cu00KL2xHaHTRc3pujLgVtESe1cyiIgPEU63Kv95GiaKiG2jZQhFbv1XoY= Received: from AM6P191CA0058.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::35) by PR2PR08MB4730.eurprd08.prod.outlook.com (2603:10a6:101:19::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Sat, 5 Sep 2020 01:47:48 +0000 Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::2a) by AM6P191CA0058.outlook.office365.com (2603:10a6:209:7f::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15 via Frontend Transport; Sat, 5 Sep 2020 01:47:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16 via Frontend Transport; Sat, 5 Sep 2020 01:47:48 +0000 Received: ("Tessian outbound a0bffebca527:v64"); Sat, 05 Sep 2020 01:47:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from 2ae476cccf17.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B4903732-1845-47D0-9CEF-8E73B00D38C2.1; Sat, 05 Sep 2020 01:47:43 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2ae476cccf17.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sat, 05 Sep 2020 01:47:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQ4LAAoVRzO6QX0YrIxHBBAZA2Kzx2LlycryppoxspFHuwF34iZAbfTlOJIvLIuKLQEbrvaV+RLsXBFuNRtz2ttrIEWuLSWR6rhd28YvIACtK1F+lv19b/Idcoe3o1tbjR1wNOfCmljrnm7ew96ixvzfvalufKSpDlvjyJB3m2c5c40nP+C2tOYa2fND1yOleArGt8D89caSyDJxd7+jZwYwIZQ7IBlqa8nDOtFV/JTXExmIL/TG7CUOpmSYg/Y2W8uugDAyjR0Ql7DzrICyb0bCPZkYP9p9AVyYGXJTMwseDEepCXcF0FXVxeOHm4AO2YhmaR7uGFL64hVK+PjmaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrNJ9VRD3OYe/p4PB/gy7pDVE6zv5dyJoBqwyevx9zo=; b=gmGih5s+z2aj7jpb8HKLRrWTCOikb+cJ+i1D9bQOswu29YqmAgwe8z5Y2jb4mXqFLj18Fk22unjR8lzaLZU9mMieIrj+vM2OIbQiikN9Atan+xz8S8DLh2C/UK+Lmqt8YixyFEdzSO56J6e7YgADIJBwwhqar4ClUA+d/y2fVx5kwH09wnz0nTdIuysIZF5ipXi6XbrlXuEcKmSP/Gkr5/2WUCpFdIF59NKt9niToynWXAkCFYMAZv5zcX2GXVVW200qwtMI2YH5eEpZJOXlTS9E4N0QiOVDR/BswluVYYRS/b4YOkTxFpqYSO2viuecQygbjbNuAkve/19um0LAoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrNJ9VRD3OYe/p4PB/gy7pDVE6zv5dyJoBqwyevx9zo=; b=9FuLApDc+OYkoyMT66jkfC5OvGQ6vtgQUnIA/ACFdVi2FtPSZGSIKEjAfrRhZ6f4UJDk64M5pYPC8zpR8qOCimCx4lNtHCXFm0+nqMkrcO05SgdT/Cu00KL2xHaHTRc3pujLgVtESe1cyiIgPEU63Kv95GiaKiG2jZQhFbv1XoY= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR08MB2854.eurprd08.prod.outlook.com (2603:10a6:6:1c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Sat, 5 Sep 2020 01:47:41 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805%6]) with mapi id 15.20.3348.016; Sat, 5 Sep 2020 01:47:40 +0000 From: Honnappa Nagarahalli To: Dmitry Kozlyuk , "dev@dpdk.org" CC: "stable@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode Thread-Index: AQHWgvyweTESRn+ce0WfGVKxMpOpqalZRrKg Date: Sat, 5 Sep 2020 01:47:40 +0000 Message-ID: References: <20200831213811.21521-1-dmitry.kozliuk@gmail.com> <20200904204734.17042-1-dmitry.kozliuk@gmail.com> In-Reply-To: <20200904204734.17042-1-dmitry.kozliuk@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C89A6362A984284E9E1BB48355D56897.0 x-checkrecipientchecked: true Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 8e2df68a-6ed2-4508-0966-08d8513db188 x-ms-traffictypediagnostic: DB6PR08MB2854:|PR2PR08MB4730: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3173;OLM:3173; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5upYRQFlnB/4k8yDA7ADPf6X0aa+uHdB7qwNtGci1DaCFPO7L8o29N3vELWJmqltKdPNm5SlurW/6PmaYf4MJRtUf+71uIthfOGzR1D81QU7klQXoPt4BGAKPe0uNP1eEn8dg8V+QWpnsmsQ0R54hQLapgct6VTWNrLA4u2grbhy06i0/flNSW7mGgya2zPCmpQWcKiyZhZ+ceYeQ6f3A5auUMC1BwttQEVyXQGfVmVKKin6JCp9TCp7e0/VY344s2MBEAkDMlYj6GrnOm2TE4OtUX1YW5BIWbSks0aBhU934Te2zFg9ctkkmP1jYiEOik+hy88bm8kLw/9+H1ihbQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(64756008)(66476007)(6506007)(316002)(7696005)(66556008)(71200400001)(66946007)(4326008)(52536014)(76116006)(86362001)(66446008)(110136005)(54906003)(8676002)(33656002)(478600001)(186003)(83380400001)(55016002)(5660300002)(2906002)(8936002)(26005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: GYxRBtgESEQRCBgiuM1N9/ZMKlwJaFaIMwz5GzGnbpw7mpgrSESCr5/GjG7N++ldZl/BHYagPirAdqA/B+Rn3GPZznjdfF76v/JvQHutTU+ryerBcGyVcKmbfe10xsFuUWZ/85FkJPoHzkk0yWaONcLm5Xd2+KtX6/O12TMeWGHqgeDzeXnijCTDcEx3scqWyysNz2uneXsQVR/YqzQccLbqWPI8iObOLnsULqLIeMGdVgj2hzqEb/J13riBwn3ma6o5aMm4di9672195v9OhaThBhA2zT1SMWTbhefT9ebeVWX18jjpzqKFCIbeeXDqCLnxy6zHRi7t5lDDMTBpVaqQMPY3t84CUMOdq2/afH4iUSEyph72+4sKs3JV2FQil4+7OCkpS+qOsrL8OBw1oILRzncV/vzyhoaf58BMP7LZPKkQSztOt6/aQWFW8tNHH0jEeLQKCGncm4qQFxs1uqBvSKCvInpsAnWF4B7D5jIuPPP/2FDWcR0rRrlZC5Z893U9AuwVZR0f6qVkfguiQFBalK0t/Oc1Yat2f6nm3tIF6H6o3aWcP8rlG2kFwQt3XSH/iAcHQu/aK/xLnjtODfjERpLg65SG/kTp9cjHXx/e9r7E9dSEj3u52ssLYhdi9YmrC/jFaozeGomHufy3AQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2854 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 9b20a924-08a1-46af-7d21-08d8513dacfb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J7r4wjC3HN7XhdxiYruoHQcqF9mnH98C3PVb3bl8+UnYnuO7EkNGPDC5r1s/F/ctN7XNw4FXZYlHgUdQinuYXxKoKGS6gu7bQpBO4b1aPf/PX1TZb0p/dd4mbL2hgty5T0sYB4glZTf+CQ825TCACDdZsyryw/QP+TZiVrkzd0bQH/0zyoG9xWUZJk+FMq8UIajQ0WacFXk57vuVPGgFrfkWKu74/kTZE6m83jJ/ROB4xigpBxEjSoP4UbcqwCyOaobsLKqYNL1bMVyhacRokDkAtbC/Gd+WtiS8XvsWWAN0ty/hhquCFtrJk4LGh8CuAvW5OmdFrri5GeraKs1ItYSWDg2QtQ+KhUeZTNLTX1EnDI/FcyKbRByvWcP4UOjfyuGleKPY4SkUvQlYvgopvA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(46966005)(4326008)(450100002)(54906003)(186003)(82740400003)(86362001)(5660300002)(33656002)(356005)(336012)(316002)(81166007)(110136005)(2906002)(26005)(36906005)(8676002)(52536014)(47076004)(8936002)(7696005)(83380400001)(70206006)(55016002)(9686003)(82310400003)(6506007)(70586007)(478600001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2020 01:47:48.5522 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8e2df68a-6ed2-4508-0966-08d8513db188 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4730 Subject: Re: [dpdk-dev] [PATCH v2] lib/rcu: avoid literal suffix warning in C++ mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Sequences like "value =3D %"PRIu64 (no space before PRIu64) are parsed as= a > single preprocessor token, user-defined-string-literal, in C++11 onwards. > While modern compilers are smart enough to parse this properly, GCC 9.3.0 > generates warnings like: >=20 > rte_rcu_qsbr.h:555:26: warning: invalid suffix on literal; C++11 > requires a space between literal and string macro [-Wliteral-suffix] >=20 > Add spaces around format specifier macros to make public headers > compatible with C++ without causing warnings. Make similar changes in C > source for style consistency within the library. >=20 > Fixes: 64994b56c ("rcu: add RCU library supporting QSBR mechanism") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk Looks good, Thank you. Reviewed-by: Honnappa Nagarahalli > --- >=20 > v2: fix subject line, adjust C source for style consistency. >=20 > lib/librte_rcu/rte_rcu_qsbr.c | 13 +++++++------ > lib/librte_rcu/rte_rcu_qsbr.h | 14 +++++++------- > 2 files changed, 14 insertions(+), 13 deletions(-) >=20 > diff --git a/lib/librte_rcu/rte_rcu_qsbr.c b/lib/librte_rcu/rte_rcu_qsbr.= c index > aebfdb0da..a5f9de326 100644 > --- a/lib/librte_rcu/rte_rcu_qsbr.c > +++ b/lib/librte_rcu/rte_rcu_qsbr.c > @@ -244,10 +244,10 @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v) >=20 > fprintf(f, "\n"); >=20 > - fprintf(f, " Token =3D %"PRIu64"\n", > + fprintf(f, " Token =3D %" PRIu64 "\n", > __atomic_load_n(&v->token, __ATOMIC_ACQUIRE)); >=20 > - fprintf(f, " Least Acknowledged Token =3D %"PRIu64"\n", > + fprintf(f, " Least Acknowledged Token =3D %" PRIu64 "\n", > __atomic_load_n(&v->acked_token, > __ATOMIC_ACQUIRE)); >=20 > fprintf(f, "Quiescent State Counts for readers:\n"); @@ -257,7 +257,7 > @@ rte_rcu_qsbr_dump(FILE *f, struct rte_rcu_qsbr *v) > id =3D i << __RTE_QSBR_THRID_INDEX_SHIFT; > while (bmap) { > t =3D __builtin_ctzl(bmap); > - fprintf(f, "thread ID =3D %u, count =3D %"PRIu64", lock > count =3D %u\n", > + fprintf(f, "thread ID =3D %u, count =3D %" PRIu64 ", lock > count =3D %u\n", > id + t, > __atomic_load_n( > &v->qsbr_cnt[id + t].cnt, > @@ -402,7 +402,7 @@ int rte_rcu_qsbr_dq_enqueue(struct > rte_rcu_qsbr_dq *dq, void *e) > * other issues. > */ > rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Skipped enqueuing token =3D %"PRIu64"\n", > + "%s(): Skipped enqueuing token =3D %" PRIu64 "\n", > __func__, dq_elem->token); >=20 > rte_errno =3D ENOSPC; > @@ -410,7 +410,8 @@ int rte_rcu_qsbr_dq_enqueue(struct > rte_rcu_qsbr_dq *dq, void *e) > } >=20 > rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Enqueued token =3D %"PRIu64"\n", __func__, dq_elem- > >token); > + "%s(): Enqueued token =3D %" PRIu64 "\n", > + __func__, dq_elem->token); >=20 > return 0; > } > @@ -449,7 +450,7 @@ rte_rcu_qsbr_dq_reclaim(struct rte_rcu_qsbr_dq > *dq, unsigned int n, > rte_ring_dequeue_elem_finish(dq->r, 1); >=20 > rte_log(RTE_LOG_INFO, rte_rcu_log_type, > - "%s(): Reclaimed token =3D %"PRIu64"\n", > + "%s(): Reclaimed token =3D %" PRIu64 "\n", > __func__, dq_elem->token); >=20 > dq->free_fn(dq->p, dq_elem->elem, 1); diff --git > a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.h index > a98e8f0f8..aa237cf75 100644 > --- a/lib/librte_rcu/rte_rcu_qsbr.h > +++ b/lib/librte_rcu/rte_rcu_qsbr.h > @@ -552,7 +552,7 @@ rte_rcu_qsbr_quiescent(struct rte_rcu_qsbr *v, > unsigned int thread_id) > __atomic_store_n(&v->qsbr_cnt[thread_id].cnt, > t, __ATOMIC_RELEASE); >=20 > - __RTE_RCU_DP_LOG(DEBUG, "%s: update: token =3D %"PRIu64", > Thread ID =3D %d", > + __RTE_RCU_DP_LOG(DEBUG, "%s: update: token =3D %" PRIu64 ", > Thread ID =3D > +%d", > __func__, t, thread_id); > } >=20 > @@ -580,13 +580,13 @@ __rte_rcu_qsbr_check_selective(struct > rte_rcu_qsbr *v, uint64_t t, bool wait) > while (bmap) { > j =3D __builtin_ctzl(bmap); > __RTE_RCU_DP_LOG(DEBUG, > - "%s: check: token =3D %"PRIu64", wait =3D %d, Bit > Map =3D 0x%"PRIx64", Thread ID =3D %d", > + "%s: check: token =3D %" PRIu64 ", wait =3D %d, > Bit Map =3D 0x%" PRIx64 > +", Thread ID =3D %d", > __func__, t, wait, bmap, id + j); > c =3D __atomic_load_n( > &v->qsbr_cnt[id + j].cnt, > __ATOMIC_ACQUIRE); > __RTE_RCU_DP_LOG(DEBUG, > - "%s: status: token =3D %"PRIu64", wait =3D %d, > Thread QS cnt =3D %"PRIu64", Thread ID =3D %d", > + "%s: status: token =3D %" PRIu64 ", wait =3D %d, > Thread QS cnt =3D %" > +PRIu64 ", Thread ID =3D %d", > __func__, t, wait, c, id+j); >=20 > /* Counter is not checked for wrap-around condition > @@ -643,12 +643,12 @@ __rte_rcu_qsbr_check_all(struct rte_rcu_qsbr *v, > uint64_t t, bool wait) >=20 > for (i =3D 0, cnt =3D v->qsbr_cnt; i < v->max_threads; i++, cnt++) { > __RTE_RCU_DP_LOG(DEBUG, > - "%s: check: token =3D %"PRIu64", wait =3D %d, Thread ID > =3D %d", > + "%s: check: token =3D %" PRIu64 ", wait =3D %d, Thread > ID =3D %d", > __func__, t, wait, i); > while (1) { > c =3D __atomic_load_n(&cnt->cnt, > __ATOMIC_ACQUIRE); > __RTE_RCU_DP_LOG(DEBUG, > - "%s: status: token =3D %"PRIu64", wait =3D %d, > Thread QS cnt =3D %"PRIu64", Thread ID =3D %d", > + "%s: status: token =3D %" PRIu64 ", wait =3D %d, > Thread QS cnt =3D %" > +PRIu64 ", Thread ID =3D %d", > __func__, t, wait, c, i); >=20 > /* Counter is not checked for wrap-around condition > @@ -725,10 +725,10 @@ rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, > uint64_t t, bool wait) > /* Check if all the readers have already acknowledged this token */ > if (likely(t <=3D v->acked_token)) { > __RTE_RCU_DP_LOG(DEBUG, > - "%s: check: token =3D %"PRIu64", wait =3D %d", > + "%s: check: token =3D %" PRIu64 ", wait =3D %d", > __func__, t, wait); > __RTE_RCU_DP_LOG(DEBUG, > - "%s: status: least acked token =3D %"PRIu64"", > + "%s: status: least acked token =3D %" PRIu64, > __func__, v->acked_token); > return 1; > } > -- > 2.25.4