From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81FD2A04B1; Wed, 26 Aug 2020 22:51:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6646FAAB7; Wed, 26 Aug 2020 22:51:38 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by dpdk.org (Postfix) with ESMTP id D3E561F1C; Wed, 26 Aug 2020 22:51:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kh0flCgvekCnA63XQXX9r777ECYeRsbdKU0JgILCy/A=; b=h6EFyoDJKHRvN8bWMhS8Q7pTH0g63hAfSLHIwxfaCp2PtcTnqhWYv84J7aCnG6TlDYv1NdWff+CVoNr+mH4LoklyORYGxCtb9U+35Owp30+h3q8ctdcdKvgTRin9BOuidKckvHIH8F5ZTeDcqwETT9TtDOyZ6h8K6+sgV3gXumw= Received: from DB8PR06CA0028.eurprd06.prod.outlook.com (2603:10a6:10:100::41) by AM0PR08MB5396.eurprd08.prod.outlook.com (2603:10a6:208:182::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.24; Wed, 26 Aug 2020 20:51:35 +0000 Received: from DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::22) by DB8PR06CA0028.outlook.office365.com (2603:10a6:10:100::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.20 via Frontend Transport; Wed, 26 Aug 2020 20:51:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT026.mail.protection.outlook.com (10.152.20.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Wed, 26 Aug 2020 20:51:35 +0000 Received: ("Tessian outbound 7a6fb63c1e64:v64"); Wed, 26 Aug 2020 20:51:35 +0000 X-CR-MTA-TID: 64aa7808 Received: from 128ebc649f5e.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 878701F6-5377-4ED1-BE23-09564E1DB227.1; Wed, 26 Aug 2020 20:51:30 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 128ebc649f5e.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 26 Aug 2020 20:51:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zd9fuJSj19WjONxNmlrDSb5ztBvSlLhul5Hc9YUoJwDkKpSHoq++IewuwtK3+ZuqjyUlsgRftFJk0vTZdQFhWWyiAQb0n0DmtHrTFoK6/IZkiWvC2b61b20K00GHNV70HxdcpOHybzftvfKV7sAT214s5R6zoNoDMT54jQwi2tJAOPz8YgGICd5buwP/Gfj1ew8dd/Naqcqv9dty9iIWJEa5n1l/ueQlalinzHxSfVRTyrsfH+i08UUc5YoHi/ToLPLI1WZg8nJ6fSuNa5yB9/TTCihPM4AkxgkHvZ6HFcSZXGxqfjjF02P0/FOX980pgRyO9y0roLJf3Zkt140uOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kh0flCgvekCnA63XQXX9r777ECYeRsbdKU0JgILCy/A=; b=AqrDyevhHCS8jQ975b/FmNo+uDyKNhFvAU84IuQnV7hM57K5sS6cPgH+Gnu2qHlLP0J7iYZRCN0AHaceR83keakdBWHiiJA7tXPIaAcOUjbu5tBYZeaU1sohaMBxZReRIajXjT38yMrMKOJBmYHXfhMIpkc3ILrSEjMQkRzWUNCY3ws64PQY3JIyXsrDBOwq6vMsAVNvPCfriTYy48iT/W9MRJ86V6/8shTWiVv/ozxIi0pFkrotEogRKdOrlbsYk7V7x4RCxS8FAPDHOy95gtMnevwrs5tiSITx4Sb8mn1GmIxfgmfVsoTqK4Jm8rqKamuJ540qneYeNP65Nz7drQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kh0flCgvekCnA63XQXX9r777ECYeRsbdKU0JgILCy/A=; b=h6EFyoDJKHRvN8bWMhS8Q7pTH0g63hAfSLHIwxfaCp2PtcTnqhWYv84J7aCnG6TlDYv1NdWff+CVoNr+mH4LoklyORYGxCtb9U+35Owp30+h3q8ctdcdKvgTRin9BOuidKckvHIH8F5ZTeDcqwETT9TtDOyZ6h8K6+sgV3gXumw= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3084.eurprd08.prod.outlook.com (2603:10a6:5:22::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3305.26; Wed, 26 Aug 2020 20:51:27 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805%6]) with mapi id 15.20.3305.026; Wed, 26 Aug 2020 20:51:27 +0000 From: Honnappa Nagarahalli To: Feifei Wang , Konstantin Ananyev , Olivier Matz , Gavin Hu CC: "dev@dpdk.org" , nd , Feifei Wang , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elements Thread-Index: AQHWau/QUvNLMJTOJ0mdmIddNC8XIqlK3o5Q Date: Wed, 26 Aug 2020 20:51:27 +0000 Message-ID: References: <20200729063105.11299-1-feifei.wang2@arm.com> <20200805061421.13037-1-feifei.wang2@arm.com> <20200805061421.13037-4-feifei.wang2@arm.com> In-Reply-To: <20200805061421.13037-4-feifei.wang2@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 32E55C2CA773A544A0517977F04473B2.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.112.90.121] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 770e8d98-ac8b-4137-bffa-08d84a01d203 x-ms-traffictypediagnostic: DB7PR08MB3084:|AM0PR08MB5396: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:191;OLM:191; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6ks4qbpnqoV3eQiFhUNJVjmSdW46fdp1RloA7Uaf3UA1tiOexNiXtgRt65tCc7+Yvy/jZPwApagotG9yS+wyCC0+1Dcp/phIj9fXRfIloolgDa0dHb8/G3BaLguiLe8zvhMTZ/Y4CH5A7I1FtX8Cr5uv7BWmFyboCSaJrISMnBsWeInhH6jgldePTezamnln7JiZVIzoxeDZAaAfv2dXmOnS+Aa7NyIwjPQ4IlKyvRY+T3x4smIbudf80nBUmY5CnWtlurrjod3xRA4hy2UwX2VrAUPCifP9m81J/l/OE9evbsG/w4p4epl9mnCcdD4K78xGL3DlX3weUOnNX+Z58g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(346002)(366004)(396003)(136003)(9686003)(6506007)(4326008)(186003)(83380400001)(2906002)(7696005)(55016002)(86362001)(71200400001)(26005)(6636002)(66476007)(66946007)(5660300002)(76116006)(33656002)(8676002)(8936002)(66446008)(64756008)(66556008)(478600001)(54906003)(52536014)(316002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: rwL5cpEZ39oVpapDW3APleywQKdo68mYhXh696nj9fWJPlgD5KbjLVSxfqEODgUQo5goasPRiq5RfN5txTi/dwTwJ6ebshZr2OeUmus6qy3BiOVarGs0a3k3ELH8z1HTuF+lSmZpKwcufd2bquOw8SpD0Zusx0Ypfpf0cIKTgQAdrwGbibVX4k5oxqrPXZm0y0ayV1gwx4Xj4ltY1wyOjfOJopgGEgNYXrMrObBoSw8Nf9k0KNa6qrs1XmmYMTQ2IC/r41GHEvDgowcnFu2BYDS/s/2IWlMR2HQbiv+dQX//WeC81ezYGqLDrwk5Wc9tEhE3uzXEFy6i01AnsgxIWCWArK2aIhYcrhAbYoDjtT77+GWN9q0U02/sorbh//L4wLtn8sB+pVlVJKBcuLIga+JdByuqTbjsZtCy07t3Zn13HsLuQUDafLFJjFRRbFLkr1lBg9in2UnNZHBD954zgLRqut6ax7W0eq0M5eRJ34okVZIEIjz1IcLewqCHnTj9HWp6Yl30zTBARjIQXltZ9A37er1Vl1AZGm2+r/CX7TF5nr7NSqM+KBPeUGBdmgLS/FQv4gmxNSlh4noKTaLdHsyNLLx5p9k23mhlg/BfbORYUXwCBXev+oqiDgA9eMToSKXX0ZJs4pJ6S7RyD+EzNQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3084 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b063d7a6-9e61-4563-673b-08d84a01cd49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tYSObDXfWLmlBydBp4ItJqEa+czCC9dGbv5tKnZsSClCOl15v8R3VdJwFBVbZecAKcxtAIgfnP+uO/f/6tBw8FGqQOBgMmdIjFYkC1AsPZJXhDBPEhW+kNZg97/fYxYHPeZ06L0D1H9SYAYrLux5ZFSG5tWKQPLBSFlCawYNO13Bmxvx/w1N3ZEpUfwuY1lxeFxl87lG8JypC7HF2AZjn1zn4ggQcoZOKmIutL2PpJTCkMRy+Li3rJI9g733xRq1GgT4KcI7a17oRgYLRM22pmih0c0nYr529NarNpQn0g422vx8SS7lwe1BA9oeR/L4O9lYIJ2wGZQ/ohnMuwh6u/L4kUA5HKWmzoxZXMO2ZumU4JwZoAsDPdT90vhk7phKgFFD+KTHHQT4sE2XzMFJJg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(346002)(39860400002)(46966005)(2906002)(4326008)(54906003)(110136005)(86362001)(7696005)(70206006)(356005)(81166007)(478600001)(52536014)(70586007)(9686003)(47076004)(55016002)(316002)(6636002)(82310400002)(5660300002)(33656002)(26005)(8676002)(186003)(336012)(83380400001)(82740400003)(8936002)(450100002)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2020 20:51:35.1724 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 770e8d98-ac8b-4137-bffa-08d84a01d203 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5396 Subject: Re: [dpdk-dev] [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elements X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Subject: [PATCH v2 3/4] test/ring: fix the wrong number of enq/deq elemen= ts >=20 > The actual capacity of ring should be the (RING_SIZE - 1), thus only (RIN= G_SIZE > - 1) elements can be enqueued into the ring. >=20 > Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests= ") This issue is not because of this commit. It is coming from af75078fece3. > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > app/test/test_ring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_ring.c b/app/test/test_ring.c index > c508a13a9..51bae0d48 100644 > --- a/app/test/test_ring.c > +++ b/app/test/test_ring.c > @@ -822,7 +822,7 @@ test_ring_basic_ex(void) > printf("%u ring entries are now free\n", > rte_ring_free_count(rp)); >=20 > - for (j =3D 0; j < RING_SIZE; j++) { > + for (j =3D 0; j < RING_SIZE - 1; j++) { > test_ring_enqueue(rp, obj, esize[i], 1, > TEST_RING_THREAD_DEF | > TEST_RING_ELEM_SINGLE); Can you validate the return value of this function (which should have caugh= t the error)? > } > @@ -833,7 +833,7 @@ test_ring_basic_ex(void) > goto fail_test; > } >=20 > - for (j =3D 0; j < RING_SIZE; j++) { > + for (j =3D 0; j < RING_SIZE - 1; j++) { > test_ring_dequeue(rp, obj, esize[i], 1, > TEST_RING_THREAD_DEF | > TEST_RING_ELEM_SINGLE); Same here. > } > -- > 2.17.1