From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CB37A0093; Wed, 11 May 2022 01:28:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 34651406B4; Wed, 11 May 2022 01:28:30 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10085.outbound.protection.outlook.com [40.107.1.85]) by mails.dpdk.org (Postfix) with ESMTP id 469574067E for ; Wed, 11 May 2022 01:28:29 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KtyrQdEenb9Dy9pwUqszByZgpqKKUc3ZviIEA2WsvD7VM4GUB5K5Vl3a0NPMuMDaboISAtkpdpy3eoCxBtZNuuHkZyxmBruHcHhmWJQT5qbnaKYxpXQ3duE70IuqUh87Q4RAxUJfMxv4VW9n+mGe4PQ2MOPAKQ54wxvV1jPa/U7IENyOU+lFdFuopijkG7TdmUm1Tgk0GLKDYtNfZll6O7eP9KdfDjvdry78agEeN7g8Vm3Nkg/ffoqIBmMzcQQuCzpwPOX9lw7MhBJGmhyoLx2EwFD0Xd6LVQQAYxsOJlL969gBDiMhA73PgKzOAJ4fZ5S6gwB00f9iZV9/ZcWeTA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1WOnUjyoGDdu9yVybLXeNrFaVshOMrbdgHc9PZa8GU=; b=h7n4hqt8Mgr00lR0VYKI20OXZaP50WAOaZaD1BueUgCXKjPmXZAlv9gXoyLKIL+yQ2T3E8EbTZSda9EkgonpuWDzR9h8bzu9xeqO1b51HmQbTvtr4oFtPPBkOmgE5Yv43tK9Vj2XckrCmzsNZ5IckVMi5uAojdJMh0iPuJpDIvpuGphndynGn/LcQzAd7H2OtZROP/6uVn4MvEkEJVGgJoOiJonPlOrB+RJA/1POzWyFm8gQtoqE/X13dOhZZCKfjRcMaHEs+kKKI3aT7oddd3+BK9/+NrH36Af5sbOQapJWNQDbRHceNpYh7DUqGiKp/iNDtN7kJYIAzj14qCrj5Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1WOnUjyoGDdu9yVybLXeNrFaVshOMrbdgHc9PZa8GU=; b=VjAvjFedBo6nCWEoPuiCrxy2EV/r0KTH1oYHpYsCWxZi47NJ6B0xjQeB+ec61GsRVHm0OnJrqNllq69ZK3+Jetr2a23OMDgjduZ1VmkeCzYqD7+cFUe5Z2hmvEHHg6xceDPsK0ITNkl3msKxcrZzedeFlPPg9lAbPRnQjUyuR3A= Received: from DU2P250CA0002.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::7) by VI1PR08MB2960.eurprd08.prod.outlook.com (2603:10a6:803:44::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.21; Tue, 10 May 2022 23:28:15 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:231:cafe::6a) by DU2P250CA0002.outlook.office365.com (2603:10a6:10:231::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23 via Frontend Transport; Tue, 10 May 2022 23:28:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.15 via Frontend Transport; Tue, 10 May 2022 23:28:14 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Tue, 10 May 2022 23:28:14 +0000 X-CR-MTA-TID: 64aa7808 Received: from a130abd3abc7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 75776A2B-AF8C-4A0B-9432-C5A68AAEAF8C.1; Tue, 10 May 2022 23:28:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a130abd3abc7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 May 2022 23:28:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E8QxGSrweXogufrll8TWzvkCtQfp86PO+YxbqZ1kAMkpf5x2+p8+/h98lU/qx3VP689Q1u0bSTnUI/l8tBxKdxIGisUfIvu9/nZCRERzFnI5C9m49jV0GhV+NZgDH8r3hhBqmjBte85LZnJFBFKDJE9AZaRlMPO4PlhGt+bdk9hFc1oo8LD+gCIohBjnTYHmP50cWQkvfTohhDf83Skp3JQJTIrs+0VPNKREG6E3szXuwbezyy30mQ5ls0EIRRV0IRwb8T97Lbt5sF99K6CnPkPMWbmHkDApi48Wh7l1eAT/V5FDaaEZQEXCZOImDl2TQ06IM2YdkrqOnAY34O72xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1WOnUjyoGDdu9yVybLXeNrFaVshOMrbdgHc9PZa8GU=; b=PPf/+CMjrCABygp/u9u2RkzIg0WMVvrsJ3AJ96pMhJymnIoLhfguGa4nIXTnDqQq+1FvcdNC3m/jHdw6d1jiJDdPfAUJE8PkuJuLBLuD3ZnUj4hAsewiGe5GWJvsGZNlt++vsPUJF9nAWYuupCcv9cBV1aMbSgjCJfuw1wwi5w5IZGfizqXBTq8KbunUhG8snWJtXYLN44fs7rh6nWOdcO7cq3O7gYOBH1uuvDTjxyb3v7zQe5hpA5MKB7ZYRIb5/uzDRIR2Kj3g83nHx08ioQTuiQa5QUMZt3AdSrCK3o9lXD+/wmEeRKrBX49RkTe7bmII12KBYx1LFPQBtKeSLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1WOnUjyoGDdu9yVybLXeNrFaVshOMrbdgHc9PZa8GU=; b=VjAvjFedBo6nCWEoPuiCrxy2EV/r0KTH1oYHpYsCWxZi47NJ6B0xjQeB+ec61GsRVHm0OnJrqNllq69ZK3+Jetr2a23OMDgjduZ1VmkeCzYqD7+cFUe5Z2hmvEHHg6xceDPsK0ITNkl3msKxcrZzedeFlPPg9lAbPRnQjUyuR3A= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3483.eurprd08.prod.outlook.com (2603:10a6:10:4a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5227.23; Tue, 10 May 2022 23:28:06 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::44cf:1f8d:e477:1f99]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::44cf:1f8d:e477:1f99%8]) with mapi id 15.20.5227.023; Tue, 10 May 2022 23:28:06 +0000 From: Honnappa Nagarahalli To: Stanislaw Kardach CC: "dev@dpdk.org" , Frank Zhao , Sam Grove , "mw@semihalf.com" , "upstream@semihalf.com" , nd , nd Subject: RE: [PATCH 09/11] test/ring: disable problematic tests for RISC-V Thread-Topic: [PATCH 09/11] test/ring: disable problematic tests for RISC-V Thread-Index: AQHYYKXYMLbRD+2nGEu8vTld0kZoL60YyVMg Date: Tue, 10 May 2022 23:28:05 +0000 Message-ID: References: <20220505173003.3242618-1-kda@semihalf.com> <20220505173003.3242618-10-kda@semihalf.com> In-Reply-To: <20220505173003.3242618-10-kda@semihalf.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 04B1A9BC2070FF4BB1687861EBB61C42.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: addd9530-d3c1-4461-ed1d-08da32dcc1a4 x-ms-traffictypediagnostic: DB7PR08MB3483:EE_|DBAEUR03FT041:EE_|VI1PR08MB2960:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LdeDuiSjA06AnL0TC/titUCXAIx4D6kvBXk8Kn/wXNCvugsHaEZjbIm+lxnvdeV2Hdhh0N7BbpaOtTKD1MKKooKWodwPxNhO5LdNlC/enjZK/ZYHkOVk42Es16nHO9357H8bJKy8+87juNI3U3sMls5nQC4XItFonclYZ8YKg9eobNF9iwjm3hz594aUgS6PW4XMTYUfqGmlTR5yH1B4MEpBEeXiSFH2DY73X6N4ODnSWra6U+pZ5/hio77i27aGSL5xiag5onIPtMVxDOnGDCP30sK4Wx9OtXY10XjbEi8QEhWeSkJCtCtj94CAiu9u8u1bXWZWN8oc5odBVnLmy8nKRVe6EHpMZfxUqdXTDFj8Y8SUSOVeDiHPM9GM2lMclIrSqLWY8if+ydAJGI20hJLyFyLZ/PtFBb7PWm09c1cEElgvlzNarRls1buPsK8CaYBw2i+AjMmwL2IOKf1ORkbUoiWCvxECy1aSIT/CjsOQW2czNTrp4uaCfa+hJS5Zi2EoAp4DKQPzrtfoDCO27XXoRn7/6vlIDwPzT57aGbTb92yK6yRdvf+0Y1fqkq4s6Vk7oIDq2eYu0FTna/WxtBLD+LrzuJKbsRQorjeuwY9DwWWVj7vNqKbqyN9rEoumcbfYbXgWNmsrlP1sDFaB2KShzrNJPrJmenZmvDma9udekas13zlcEGwuLhtpNIWTHHWDImBmtymuqINrsC2bRQMM8oCaPhsBHsgdRKbNpFpavBht4ztdx77EbzAQjL8g6Bc8T2pXB2ZW1Mi9MyRSL99xpFklyqz5cQgM+HUtdb4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(186003)(122000001)(33656002)(7696005)(83380400001)(2906002)(26005)(55016003)(9686003)(8936002)(86362001)(38070700005)(508600001)(38100700002)(5660300002)(966005)(71200400001)(76116006)(66476007)(64756008)(66556008)(54906003)(6916009)(66946007)(66446008)(8676002)(52536014)(4326008)(6506007)(316002); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3483 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 288fe399-371d-44fd-cf63-08da32dcbc38 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5NW/4cmwKbFBtAcdiplPg3ABIPRwUg2cRHOfhRNSY3AlpesPTrcN/+Gg6HZ+OMIYtDoQk4f3NsVAPfctFDkQcGeEDszFVM7MG4zOMcNYRsI1u5ryq2rLGGU+BagL5Lin9eVceIgMVhspIovPAaq6XMQalrjL7HbZrLTtaDa9qTPLFoMQYQvVcmFGc/dn0ODtp+LHOyVthyO0wH96yTOryVO/7UCJkM+vZE24WbKbxXZVHoEslaMqrG9Ns+wwWKFewcR73i8UHkLzInAF9r9nTPqavgjpjl5aMFqLnLjGF1fjCCp2UKVDkYB/EUOg1ua11MhpNIqVLj00j7NNMMDWcqsYmll0TOPdRgr5sWGiVs1vMlrAd7DnzSlYQS3EVnKZpG6bldncAvN5kWZ4TSZ23kqMln+NZAtOviA/JxJV4Kx57r56eKo3RBT6wVRhQS4KQnQr/bPWTd4X4NejvJH9jGex02OLC6pBGbUUwgAyVLJ4SHRi95Bp+vRRfwnH0FLRgpxWjshbrfvwowGcTTGvL/PYIhg8qW4dm3L5mKi5IgF56yNxZe1p03rzufcnSvNl24KqyS66w7rvbTuBX4zwrNP2ALEBmgh6HjqI2UQPYX9foWsMRmstJYVtg1WBHdYukpt9thnqWaKIkdsAZ/FzSo7VpNsvoS1oMqvklUaJKq7y3XvlUMUdyMqX8luKyUZ2NexA+2WC2FoOIaRdzISD0KCKciC5fhovadr36dGqiaC36MdNDuOYuZrjUzhTTi73TMV3YAI1e9aUFiD53c5ZTA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(508600001)(70206006)(9686003)(26005)(86362001)(55016003)(47076005)(966005)(70586007)(316002)(36860700001)(81166007)(7696005)(186003)(40460700003)(2906002)(4326008)(54906003)(8676002)(6862004)(336012)(356005)(33656002)(82310400005)(52536014)(8936002)(6506007)(83380400001)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2022 23:28:14.9351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: addd9530-d3c1-4461-ed1d-08da32dcc1a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2960 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > When compiling for RISC-V in debug mode the large amount of inlining in > test_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c) lea= ds to > large loop bodies. This causes 'goto' and 'for' loop PC-relative jumps ge= nerated > by the compiler to go beyond the architecture limitation of +/-1MB offset= (the > 'j ' instruction). This instruction should not be generated by th= e > compiler since C language does not limit the maximum distance for 'goto' = or > 'for' loop jumps. >=20 > This only happens in the unit test for ring which tries to perform long l= oops > with ring enqueue/dequeue and it seems to be caused by excessive > __rte_always_inline usage. ring perf test compiles just fine under debug. >=20 > To work around this, disable the offending tests in debug mode. Is this still required given you have submitted [1] [1] http://patches.dpdk.org/project/dpdk/patch/20220510115758.457794-1-kda@= semihalf.com/ >=20 > Signed-off-by: Stanislaw Kardach > Sponsored-by: Frank Zhao > Sponsored-by: Sam Grove > --- > app/test/test_ring.c | 8 ++++++++ > config/riscv/meson.build | 5 +++++ > doc/guides/rel_notes/release_22_07.rst | 3 ++- > 3 files changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_ring.c b/app/test/test_ring.c index > bde33ab4a1..7d809c147b 100644 > --- a/app/test/test_ring.c > +++ b/app/test/test_ring.c > @@ -955,6 +955,7 @@ test_ring_burst_bulk_tests4(unsigned int test_idx) > return -1; > } >=20 > +#if !defined(RTE_RISCV_WO_DISABLE_RING_TESTS) > /* > * Test default, single element, bulk and burst APIs > */ > @@ -1189,6 +1190,7 @@ test_ring_with_exact_size(void) > rte_ring_free(exact_sz_r); > return -1; > } > +#endif >=20 > static int > test_ring(void) > @@ -1200,12 +1202,18 @@ test_ring(void) > if (test_ring_negative_tests() < 0) > goto test_fail; >=20 > +/* Disable the following tests on RISC-V in debug mode. This is a > +work-around > + * GCC bug for RISC-V which fails to generate proper jumps for loops > +with large > + * bodies. > + */ > +#if !defined(RTE_RISCV_WO_DISABLE_RING_TESTS) > /* Some basic operations */ > if (test_ring_basic_ex() < 0) > goto test_fail; >=20 > if (test_ring_with_exact_size() < 0) > goto test_fail; > +#endif >=20 > /* Burst and bulk operations with sp/sc, mp/mc and default. > * The test cases are split into smaller test cases to diff --git > a/config/riscv/meson.build b/config/riscv/meson.build index > 0c16c31fc2..50d0b513bf 100644 > --- a/config/riscv/meson.build > +++ b/config/riscv/meson.build > @@ -141,3 +141,8 @@ foreach flag: dpdk_flags endforeach message('Using > machine args: @0@'.format(machine_args)) >=20 > +# Enable work-around for ring unit tests in debug mode which fail to > +link # properly due to bad code generation by GCC. > +if get_option('optimization') =3D=3D '0' or get_option('optimization') = =3D=3D 'g' > + add_project_arguments('-DRTE_RISCV_WO_DISABLE_RING_TESTS', > +language: 'c') endif > diff --git a/doc/guides/rel_notes/release_22_07.rst > b/doc/guides/rel_notes/release_22_07.rst > index 453591e568..4d64b68dfd 100644 > --- a/doc/guides/rel_notes/release_22_07.rst > +++ b/doc/guides/rel_notes/release_22_07.rst > @@ -76,7 +76,8 @@ New Features > * Debug build of ``app/test/dpdk-test`` fails currently on RISC-V due = to > seemingly invalid loop and goto jump code generation by GCC in > ``test_ring.c`` where extensive inlining increases the code size bey= ond the > - capability of the generated instruction (JAL: +/-1MB PC-relative). > + capability of the generated instruction (JAL: +/-1MB PC-relative). T= he > + workaround is to disable ``test_ring_basic_ex()`` and > ``test_ring_with_exact_size()`` on RISC-V on ``-O0`` or ``-Og``. >=20 > * **Updated Intel iavf driver.** >=20 > -- > 2.30.2