From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27163A04B1; Wed, 4 Nov 2020 18:57:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F30972BD5; Wed, 4 Nov 2020 18:57:31 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30072.outbound.protection.outlook.com [40.107.3.72]) by dpdk.org (Postfix) with ESMTP id 0BF5723D for ; Wed, 4 Nov 2020 18:57:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WatVVaOnlGTynVfT3G3HkR2e/rm4eqIiNTLvSM0j8Ak=; b=f7XITmFzOsi7Qrr6IhftfnvGzGmR53bGRUr/E+ORzYy/37x+3x9IIGQWeIYIBkjeNxWCO2XG3ssIIQ+t09JuYPExTax/iyjW1b//iQ8ULFKhSO1Mm27ftHpYFpnFBl/FSZchWS6ANG3NqdKAlcOash2AjmnhVeXH/kzMJ5bqLx4= Received: from AM6PR08CA0011.eurprd08.prod.outlook.com (2603:10a6:20b:b2::23) by DB8PR08MB3979.eurprd08.prod.outlook.com (2603:10a6:10:a5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Wed, 4 Nov 2020 17:57:26 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::86) by AM6PR08CA0011.outlook.office365.com (2603:10a6:20b:b2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Wed, 4 Nov 2020 17:57:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Wed, 4 Nov 2020 17:57:26 +0000 Received: ("Tessian outbound ba2270a55485:v64"); Wed, 04 Nov 2020 17:57:26 +0000 X-CR-MTA-TID: 64aa7808 Received: from d1f2a5a076b3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1486552C-E0B4-4FD1-977E-DD5F64C56C5C.1; Wed, 04 Nov 2020 17:57:21 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1f2a5a076b3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 Nov 2020 17:57:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnDf+JjO21I1gYMgHLhBz9PlDn5f0uspNXRcMfj2Xr3i+yckv9NjF4Z5l2eX2m9FjUNsqI0EX8RYu/Udc6RK3c3BV8cbaD97ML14alSPkJ2VQvOg7X8AKja0qMTZLXUuVMFTn2fuOVt57+cPnm/XgcfVkowP6cBmYYVxKxfOCK9MU99opGoAfV7UMdy87xs8VUMO42kcTlu8jpbfB05flPlIIXHYazyTEwkJbRLzv/s4sLYtT2B1355JXNSjXCNLvdpox3+jsRNN0pLKD9t2MCP/FSoV5nN3iiDHYVALcBMz0OITIX/CRw5torcWFvYKXPjFVQR6hvBzt0orNF+YsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WatVVaOnlGTynVfT3G3HkR2e/rm4eqIiNTLvSM0j8Ak=; b=oHDYs7xLDpjKP9jVYU3Ui08AmSV+liAsvRA3BqMxTTdazynpC36FQcoycnhT6YVps99JH3z6SWpzBc4mvI9hRA4VQTUX15W57TygTNWn/kBko0zte7Bbu39qZQvUEFh/cH8JKvAo2bhAnkWm7AkxiYLauhoIHV7P0979v+KGNkgJUpYLNPRMktZhQB6yoRJCVo8Q0/jzt5chklrl8upYANYBfdQiCud+zhAfDjIC6sBRAgdxClkR4pEslP113K0hiZYVI9NpoDZh+OYJPGZneEC8S24zysQLvS3vSNyH5rBJygr9iZXUrZYUl59ZHJLeGzzDegbsBbi8dwkywJXGMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WatVVaOnlGTynVfT3G3HkR2e/rm4eqIiNTLvSM0j8Ak=; b=f7XITmFzOsi7Qrr6IhftfnvGzGmR53bGRUr/E+ORzYy/37x+3x9IIGQWeIYIBkjeNxWCO2XG3ssIIQ+t09JuYPExTax/iyjW1b//iQ8ULFKhSO1Mm27ftHpYFpnFBl/FSZchWS6ANG3NqdKAlcOash2AjmnhVeXH/kzMJ5bqLx4= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB4025.eurprd08.prod.outlook.com (2603:10a6:10:a9::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.30; Wed, 4 Nov 2020 17:57:19 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3499.032; Wed, 4 Nov 2020 17:57:19 +0000 From: Honnappa Nagarahalli To: Olivier Matz , "dev@dpdk.org" CC: nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH] test/mcslock: remove unneeded per-lcore copy Thread-Index: AQHWssyXYKS3pQyOBUyejxb/wxvDDam4QZHw Date: Wed, 4 Nov 2020 17:57:19 +0000 Message-ID: References: <20201104170425.8882-1-olivier.matz@6wind.com> In-Reply-To: <20201104170425.8882-1-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 12AD5F95A82A2D428C948C203B736661.0 x-checkrecipientchecked: true Authentication-Results-Original: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c5beb5e0-2b8f-4aaa-1b92-08d880eb1704 x-ms-traffictypediagnostic: DB8PR08MB4025:|DB8PR08MB3979: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: i+GAINO4ZltRl67EaVwr/uCdceCxmnLSEE0rTabtrVMLsdVZP5ThQv7vm0mGwGxk48aurpsSffHBd1dnzGgMOFqE9Kkr4CrCMXpct/uWypV++qa+16Nx0mBSuTVqlDQKXHC4hkouPhRzz//IY16r0OUkncReaY+EDjeN5/nnu/H84Q9t8yYQl31aTbFpED6FUFp/SD2cGbZEGzQtDshw9H9/NHcQslW+UKUhP0CJqXTShSVS0wJ2uuqQyDXxxlz6pjXZXDD8OgQ4NxnC30KfPcmXYvQfXr4+xJN78VTBJt7r39kda9c06PtbKbgrjNe0OXFNoxH6iYZ7ADIcrkE/2g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(376002)(39860400002)(346002)(136003)(33656002)(2906002)(478600001)(186003)(83380400001)(86362001)(26005)(8676002)(4326008)(55016002)(8936002)(316002)(5660300002)(9686003)(52536014)(54906003)(7696005)(66446008)(76116006)(64756008)(66476007)(66946007)(66556008)(6506007)(110136005)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: gSNNqhN91xMAuKcK8eRTIeKrIqJCIXkmpiMlYQhVsFqd0QBhUUnk/eMCHlgcrO3s/bjmiCGo1ipl+ARWnq0vd50nvgh5y4q3DhUb/EGjDeqUwUQfTt2XhCzrMhW+1stJv8gUvLLBoPVwrvU6n+AVaC84YGkK9XU4G6lgFJC0EcdB6PRwLShLwlmaa4mWp0T4gCoHzzJAwzf6fTBii2A7eDzVgRKokG2S2LJK3YNf/t80vchBj40cGUzqRejmYbHJt0XUfV8XcqIiGkdW8i0sTejAu10M9Q3MrXY+XAnyeQOvJDpAMNpiuggDuNzhpF0fFRQuJ/kl0U0oQde+OxVPGuqKKFEtVvICTnXDLhOIEBwz+FzT/U/Nv6Foccy/L4+biozQfzq+9+4pO4z+GVQOg8RZV8kFtdSESo3mTRmlcYXpKvTompo1i5RbYRgJKunkrL9wq4pP4Kh5urixiP7fJnXP7G18bpJLJtK9lJbyJugATML5o6VzqSVaAKyUiKNmU0oIDiBCgAfbjve2nNP14vG6CCDExSk0dRXR8NMxmFiS8ChABEHuM5o9mySbpuYpREOb+I3TMDc+HY0d+HD2xtxa/jAkfYHEMdYLzbqry5+2Y+/+/XyG2XDgIK8ryLs1qs30gEfqCk8h6J2g/r20Uw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4025 Original-Authentication-Results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c4eeb023-d349-48b0-9d57-08d880eb12ae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: liiWowMx+MSqxhBTxWlgeqF6q1zeRfYRdOTYvP5Nri80x5Bd9N5tUTbdKzMi3jtS9nTP+rR/cjB0qURyYe3GrPaAnfXdxhIUpTH/bHTxcbY/a+oyIN2T48j5xLSh+G6ILNZ9RH5DQbs2FYGJ8hloApHxMWK3A2mRrYEuC+WbSJJa8Fd80HJrgk0fEVNt/SPqezpKYVXRc1/CySSkoOiiEIeGsc5rJ2cG6DWU8hFeXfRTu6TIH/jkzvQ16rJ0BQayChSyTdCVc9ohqyWsrsoU9it/y5jWzRyyPaqFxXeuGCDpItZbNT88Q7MPMZOU3eS8kp8hzQzNRzUBJwtozRKrlepwVWZPmJwa8VeVKKQzJSLLVij4DzG8DGbps6ZJfGe159dPZkasFt2MW3elQ1eSyg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(136003)(376002)(46966005)(8676002)(7696005)(26005)(82310400003)(186003)(2906002)(6506007)(81166007)(8936002)(356005)(336012)(86362001)(478600001)(4326008)(55016002)(70586007)(70206006)(82740400003)(52536014)(9686003)(36906005)(83380400001)(316002)(33656002)(54906003)(110136005)(5660300002)(47076004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2020 17:57:26.4200 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c5beb5e0-2b8f-4aaa-1b92-08d880eb1704 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3979 Subject: Re: [dpdk-dev] [PATCH] test/mcslock: remove unneeded per-lcore copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Each core already comes with its local storage for mcslock (in its stack)= , > therefore there is no need to define an additional per-lcore mcslock. >=20 > Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") >=20 > Signed-off-by: Olivier Matz > --- > app/test/test_mcslock.c | 16 ++++++---------- > 1 file changed, 6 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test/test_mcslock.c b/app/test/test_mcslock.c index > fbca78707d..80eaecc90a 100644 > --- a/app/test/test_mcslock.c > +++ b/app/test/test_mcslock.c > @@ -37,10 +37,6 @@ > * lock multiple times. > */ >=20 > -RTE_DEFINE_PER_LCORE(rte_mcslock_t, _ml_me); - > RTE_DEFINE_PER_LCORE(rte_mcslock_t, _ml_try_me); - > RTE_DEFINE_PER_LCORE(rte_mcslock_t, _ml_perf_me); > - > rte_mcslock_t *p_ml; > rte_mcslock_t *p_ml_try; > rte_mcslock_t *p_ml_perf; > @@ -53,7 +49,7 @@ static int > test_mcslock_per_core(__rte_unused void *arg) { > /* Per core me node. */ > - rte_mcslock_t ml_me =3D RTE_PER_LCORE(_ml_me); > + rte_mcslock_t ml_me; These variables are modified by other threads. IMO, it is better to keep th= em global (and not on the stack). From that perspective, I think we should = be taking the address of the per lcore variable. For ex: rte_mcslock_t *ml_me =3D &RTE_PER_LCORE(_ml_me); >=20 > rte_mcslock_lock(&p_ml, &ml_me); > printf("MCS lock taken on core %u\n", rte_lcore_id()); @@ -77,7 > +73,7 @@ load_loop_fn(void *func_param) > const unsigned int lcore =3D rte_lcore_id(); >=20 > /**< Per core me node. */ > - rte_mcslock_t ml_perf_me =3D RTE_PER_LCORE(_ml_perf_me); > + rte_mcslock_t ml_perf_me; >=20 > /* wait synchro */ > while (rte_atomic32_read(&synchro) =3D=3D 0) @@ -151,8 +147,8 @@ > static int test_mcslock_try(__rte_unused void *arg) { > /**< Per core me node. */ > - rte_mcslock_t ml_me =3D RTE_PER_LCORE(_ml_me); > - rte_mcslock_t ml_try_me =3D RTE_PER_LCORE(_ml_try_me); > + rte_mcslock_t ml_me; > + rte_mcslock_t ml_try_me; >=20 > /* Locked ml_try in the main lcore, so it should fail > * when trying to lock it in the worker lcore. > @@ -178,8 +174,8 @@ test_mcslock(void) > int i; >=20 > /* Define per core me node. */ > - rte_mcslock_t ml_me =3D RTE_PER_LCORE(_ml_me); > - rte_mcslock_t ml_try_me =3D RTE_PER_LCORE(_ml_try_me); > + rte_mcslock_t ml_me; > + rte_mcslock_t ml_try_me; >=20 > /* > * Test mcs lock & unlock on each core > -- > 2.25.1