DPDK patches and discussions
 help / color / mirror / Atom feed
From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
	"techboard@dpdk.org" <techboard@dpdk.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
	Christian Koue Muf <ckm@napatech.com>,
	Renyong Wan <wanry@3snic.com>, nd <nd@arm.com>, nd <nd@arm.com>
Subject: RE: Process for adding a new driver?
Date: Mon, 18 Sep 2023 14:36:13 +0000	[thread overview]
Message-ID: <DBAPR08MB581431E6F0B8A61CD511558098FBA@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87BB8@smartserver.smartshare.dk>



> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Monday, September 18, 2023 2:08 AM
> To: techboard@dpdk.org; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Ferruh Yigit <ferruh.yigit@amd.com>;
> andrew.rybchenko@oktetlabs.ru; Christian Koue Muf <ckm@napatech.com>;
> Renyong Wan <wanry@3snic.com>
> Subject: Process for adding a new driver?
> 
> Dear DPDK tech board,
> 
> The process for adding a new library to DPDK is well documented [1].
> 
> What is the process for adding a new (NIC) driver?
> 
> It seems like the task of reviewing NIC PMDs from vendors other than
> Broadcom/Intel/Marvell/NVIDIA falls entirely on the next-net tree
> maintainers, Ferruh and Andrew, which doesn't seem like a reasonable
> burden.
> 
> The Napatech driver is too large for Ferruh to review, which in my opinion [2]
> is an unreasonable argument for not accepting it.
> 
> And the 3SNIC driver got no attention by any reviewers [3]. (Although
> Stephen did provide some basic feedback after they polled for review.)
> 
> Overall, I think we should put much more trust in hardware vendors to
> provide high quality drivers for their hardware. We want vendors to upstream
> their drivers, with all the benefits of having the code public. If we make it too
> difficult, they will simply keep their drivers private instead.
Difficulty vs quality control? IMO, it is good to add more drivers. May be we need to control quality through testing reports?

> 
> @Maxime: I propose to put this on the agenda for the coming techboard
> meeting.
> 
> 
> [1]: https://doc.dpdk.org/guides/contributing/new_library.html
> [2]:
> http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D87BAF
> @smartserver.smartshare.dk/
> [3]: http://inbox.dpdk.org/dev/6df9c00f-23a0-423f-840b-
> 4ecf20ff82fc@3snic.com/
> 
> 
> Med venlig hilsen / Kind regards,
> -Morten Brørup


  parent reply	other threads:[~2023-09-18 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18  7:08 Morten Brørup
2023-09-18 11:46 ` Ferruh Yigit
2023-09-18 14:36 ` Honnappa Nagarahalli [this message]
2023-09-18 19:58   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBAPR08MB581431E6F0B8A61CD511558098FBA@DBAPR08MB5814.eurprd08.prod.outlook.com \
    --to=honnappa.nagarahalli@arm.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=ckm@napatech.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mb@smartsharesystems.com \
    --cc=nd@arm.com \
    --cc=techboard@dpdk.org \
    --cc=wanry@3snic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).