From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Vimal Chungath <vcchunga@amazon.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
"alisaidi@amazon.com" <alisaidi@amazon.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"juraj.linkes@pantheon.tech" <juraj.linkes@pantheon.tech>,
nd <nd@arm.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
Ruifeng Wang <Ruifeng.Wang@arm.com>,
Feifei Wang <Feifei.Wang2@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] build: add Graviton2(arm64) meson configuration
Date: Wed, 28 Oct 2020 22:52:27 +0000 [thread overview]
Message-ID: <DBAPR08MB5814339DE499E6FCFEE0959698170@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1MBr4vAoN3S7xM6SC_NgCo23jr0fDyHnO5U92ZHFsh_kQ@mail.gmail.com>
<snip>
> >
> > Hello,
> > IMO, Juraj's patch for meson build rework for Arm platforms will need
> some time. Keeping the RC2 deadline in mind, it makes sense to accept this
> patch and target Juraj's patch for 21.02.
> >
> > Any opinions?
>
> I feel, Recent Juraj's changes looks in good shape, I think, once he fixes your
> review comment and sends the next version. We can test it and give the final
> reviewed by and merge it in RC2.
> IMO, Those changes are critical to adding a new platform when MIDR is the
> same value.
The main aim was to have the ability to build for a specified SoC. It is available for cross-builds, but not for native builds.
>
>
> >
> > > -----Original Message-----
> > > From: Vimal Chungath <vcchunga@amazon.com>
> > > Sent: Tuesday, October 27, 2020 3:18 PM
> > > To: dev@dpdk.org
> > > Cc: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Dharmik
> > > Thakkar <Dharmik.Thakkar@arm.com>; alisaidi@amazon.com;
> > > bruce.richardson@intel.com; hemant.agrawal@nxp.com;
> > > jerinj@marvell.com; jerinjacobk@gmail.com;
> > > juraj.linkes@pantheon.tech; nd <nd@arm.com>; thomas@monjalon.net
> > > Subject: [PATCH v2 1/1] build: add Graviton2(arm64) meson
> > > configuration
> > >
> > > Add meson build configuration for Graviton2 platform with 64-bit Arm
> > > Neoverse N1 cores. This patch makes the following changes to generic
> > > Neoverse N1 config:
> > >
> > > 1. increase lcore limit to 64
> > > 2. increase memory support to 1TB
> > > 3. remove +crc from -march as that is default when setting armv8.2
> > >
> > > For more information about Graviton2 platform, refer to:
> > > https://aws.amazon.com/ec2/graviton/
> > >
> > > Signed-off-by: Vimal Chungath <vcchunga@amazon.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> >
> > > ---
> > > config/arm/arm64_graviton2_linux_gcc | 17 +++++++++++++++++
> > > config/arm/meson.build | 12 +++++++++++-
> > > 2 files changed, 28 insertions(+), 1 deletion(-) create mode
> > > 100644 config/arm/arm64_graviton2_linux_gcc
> > >
> > > diff --git a/config/arm/arm64_graviton2_linux_gcc
> > > b/config/arm/arm64_graviton2_linux_gcc
> > > new file mode 100644
> > > index 000000000..022e06303
> > > --- /dev/null
> > > +++ b/config/arm/arm64_graviton2_linux_gcc
> > > @@ -0,0 +1,17 @@
> > > +[binaries]
> > > +c = 'aarch64-linux-gnu-gcc'
> > > +cpp = 'aarch64-linux-gnu-cpp'
> > > +ar = 'aarch64-linux-gnu-gcc-ar'
> > > +strip = 'aarch64-linux-gnu-strip'
> > > +pkgconfig = 'aarch64-linux-gnu-pkg-config'
> > > +pcap-config = ''
> > > +
> > > +[host_machine]
> > > +system = 'linux'
> > > +cpu_family = 'aarch64'
> > > +cpu = 'armv8-a'
> > > +endian = 'little'
> > > +
> > > +[properties]
> > > +implementor_id = '0x41'
> > > +implementor_pn = '0xd0c'
> > > diff --git a/config/arm/meson.build b/config/arm/meson.build index
> > > b49203fa8..0e7124843 100644
> > > --- a/config/arm/meson.build
> > > +++ b/config/arm/meson.build
> > > @@ -86,6 +86,16 @@ flags_octeontx2_extra = [
> > > ['RTE_ARM_FEATURE_ATOMICS', true],
> > > ['RTE_EAL_IGB_UIO', false],
> > > ['RTE_USE_C11_MEM_MODEL', true]]
> > > +flags_n1generic_extra = [
> > > + ['RTE_MACHINE', '"neoverse-n1"'],
> > > + ['RTE_MAX_LCORE', 64],
> > > + ['RTE_CACHE_LINE_SIZE', 64],
> > > + ['RTE_ARM_FEATURE_ATOMICS', true],
> > > + ['RTE_USE_C11_MEM_MODEL', true],
> > > + ['RTE_MAX_MEM_MB', 1048576],
> > > + ['RTE_MAX_NUMA_NODES', 1],
> > > + ['RTE_EAL_NUMA_AWARE_HUGEPAGES', false],
> > > + ['RTE_LIBRTE_VHOST_NUMA', false]]
> > >
> > > machine_args_generic = [
> > > ['default', ['-march=armv8-a+crc', '-moutline-atomics']], @@
> > > -97,7
> > > +107,7 @@ machine_args_generic = [
> > > ['0xd09', ['-mcpu=cortex-a73']],
> > > ['0xd0a', ['-mcpu=cortex-a75']],
> > > ['0xd0b', ['-mcpu=cortex-a76']],
> > > - ['0xd0c', ['-march=armv8.2-a+crc+crypto', '-mcpu=neoverse-n1'],
> > > flags_n1sdp_extra]]
> > > + ['0xd0c', ['-march=armv8.2-a+crypto', '-mcpu=neoverse-n1'],
> > > +flags_n1generic_extra]]
> > >
> > > machine_args_cavium = [
> > > ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],
> > > --
> > > 2.16.6
> >
next prev parent reply other threads:[~2020-10-28 22:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 1:11 [dpdk-dev] [PATCH 0/2] build: add Graviton2(arm64) config Vimal Chungath
2020-09-09 1:11 ` [dpdk-dev] [PATCH 1/2] config: add Graviton2(arm64) meson configuration Vimal Chungath
2020-09-12 3:23 ` Honnappa Nagarahalli
2020-09-12 18:24 ` Vimal Chungath
2020-09-14 4:49 ` Honnappa Nagarahalli
2020-09-17 8:23 ` Jerin Jacob
2020-09-17 17:11 ` Honnappa Nagarahalli
2020-09-18 4:02 ` Jerin Jacob
2020-09-18 17:42 ` Vimal Chungath
2020-09-19 19:06 ` Ali Saidi
[not found] ` <FF6ABD1C-A636-4F68-879E-FA7B2A615D2C@amazon.com>
2020-09-20 0:41 ` Honnappa Nagarahalli
2020-09-09 1:11 ` [dpdk-dev] [PATCH 2/2] config: add Graviton2(arm64) defconfig Vimal Chungath
2020-09-09 8:03 ` [dpdk-dev] [PATCH 0/2] build: add Graviton2(arm64) config David Marchand
2020-09-12 18:28 ` Vimal Chungath
2020-10-27 20:17 ` [dpdk-dev] [PATCH v2 0/1] build: add Graviton2(arm64) meson configuration Vimal Chungath
2020-10-27 20:17 ` [dpdk-dev] [PATCH v2 1/1] " Vimal Chungath
2020-10-28 4:28 ` Honnappa Nagarahalli
2020-10-28 9:29 ` Jerin Jacob
2020-10-28 22:52 ` Honnappa Nagarahalli [this message]
2020-10-28 6:07 ` Ruifeng Wang
2020-11-03 18:06 ` [dpdk-dev] [PATCH v3 0/1] " Vimal Chungath
2020-11-03 18:06 ` [dpdk-dev] [PATCH v3 1/1] " Vimal Chungath
2020-11-03 18:32 ` Thomas Monjalon
2020-11-03 18:38 ` [dpdk-dev] [EXT] " Jerin Jacob Kollanukkaran
2020-11-03 18:51 ` [dpdk-dev] " Vimal Chungath
2020-11-03 19:39 ` Honnappa Nagarahalli
2020-11-03 19:45 ` Honnappa Nagarahalli
2020-11-03 20:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB5814339DE499E6FCFEE0959698170@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=Feifei.Wang2@arm.com \
--cc=Ruifeng.Wang@arm.com \
--cc=alisaidi@amazon.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=thomas@monjalon.net \
--cc=vcchunga@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).