From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0FD2A0524; Fri, 6 Nov 2020 07:29:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 21FDA2C2A; Fri, 6 Nov 2020 07:29:19 +0100 (CET) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40079.outbound.protection.outlook.com [40.107.4.79]) by dpdk.org (Postfix) with ESMTP id 024212C1A for ; Fri, 6 Nov 2020 07:29:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWam9TlnQt1HrRaFj4undq8ZSEHXuCfl4ZChOBJJRe4=; b=DVFXvQCZcry5lNS1CMR2/icKQdAibBfl9Cc7GOFYML0tO9E5Jl9W71zqaBzq5fdl6kNcDZjdK4311mWqU+L4BuFit5t8cDjF4HKtmgIl+9Xs/IgVN+CaVDCbHmdMY4oWFKzCLK9NgWwpwu/QNmN2IRZVJ+v39ZIzJ2rEMgZZ9io= Received: from AM5PR0601CA0025.eurprd06.prod.outlook.com (2603:10a6:203:68::11) by VI1PR0802MB2176.eurprd08.prod.outlook.com (2603:10a6:800:99::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19; Fri, 6 Nov 2020 06:29:15 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:68:cafe::d5) by AM5PR0601CA0025.outlook.office365.com (2603:10a6:203:68::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 6 Nov 2020 06:29:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Fri, 6 Nov 2020 06:29:14 +0000 Received: ("Tessian outbound 721d19b423ff:v64"); Fri, 06 Nov 2020 06:29:07 +0000 X-CR-MTA-TID: 64aa7808 Received: from 07cb1121e0c5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 30C8CB0E-A678-496E-A843-57AFC1AE4C80.1; Fri, 06 Nov 2020 06:29:02 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07cb1121e0c5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Nov 2020 06:29:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hKHEKHrKKnM6IPCgofR8s7dCcRGoUKOiRCBLaXF5rnf6QMzzVxsJzjnCVk8drwxvS9a2u8mqmBOqZLJzS4FftgifGMbCwm7ho1EH+kJyIaHIWN91QT8XADvep9Wfw6PAA35IblB4OWzzA8c1yavZU1mpao45Snu/E+Sw4E9/iZwI+NJDRhg1rx4YuhU+ncxGwCqD5pumnSx2KI2Qu8HUQ+vJffU9HleKgHZgi1c6mzyFvpx32IEj2pyAdmO9DjglLPkFxiPGMK5KEzLDhsf1FipBBIsXswvQzhepWBE1aZn3f2VbefwFuf+HZ3DkPlLx6bSboG3gI4Iw/OEfWoBTvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWam9TlnQt1HrRaFj4undq8ZSEHXuCfl4ZChOBJJRe4=; b=PxsZ7ITroKXwYb6rJqKcHIGfONklWgOPFApE+waGFbY87FbN/uAW3PGQWIJSKfo/8GzsFOZD5nguuiw5a/DmqnQauKvB4swWpK3RG8PfhwGgvvqwcMqvz6Jcr6O40OuViGbq6NLzEMnf7i3ztiZxaRoHStQAQYKpwxk6BElb48ADe3OWtcYGfJ2un4+rB5NZ0uEnzfD/n6ncDju322JdTOE1ecwJuRFntdoUKDiUXYsH2KVrBuSZB6kLfV0EQLzqMrW65qv8qoLlmqCIwqoM8tgiso7KXkfGdpSEx2xrlS/0EXCrHdALa3DOuWr3ZL13G4PCzG9pta9rRbSiXvCm5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zWam9TlnQt1HrRaFj4undq8ZSEHXuCfl4ZChOBJJRe4=; b=DVFXvQCZcry5lNS1CMR2/icKQdAibBfl9Cc7GOFYML0tO9E5Jl9W71zqaBzq5fdl6kNcDZjdK4311mWqU+L4BuFit5t8cDjF4HKtmgIl+9Xs/IgVN+CaVDCbHmdMY4oWFKzCLK9NgWwpwu/QNmN2IRZVJ+v39ZIzJ2rEMgZZ9io= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DBAPR08MB5734.eurprd08.prod.outlook.com (2603:10a6:10:1aa::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 6 Nov 2020 06:29:00 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.021; Fri, 6 Nov 2020 06:28:47 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" , 'Ferruh Yigit' , Jiawen Wu CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "konstantin.ananyev@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD Thread-Index: AQHWs1YqGJ+Rz3T5Ekq9s5s5Zk/si6m6orvw Date: Fri, 6 Nov 2020 06:28:47 +0000 Message-ID: References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <003e01d6b351$709871d0$51c95570$@trustnetic.com> <3558935.noZgFSCOjD@thomas> In-Reply-To: <3558935.noZgFSCOjD@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F2EA39FB47C03543B459F470250C2973.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b6eb2f98-849a-420f-d611-08d8821d481d x-ms-traffictypediagnostic: DBAPR08MB5734:|VI1PR0802MB2176: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WLlyhmuUt3x5Cdn2Jc0GNOLtcbhr9/igg4+pJi5Ut/mbYWepzYVlpkr6gdwVPg3PsSU6tRcOk/ocSdMfrNe9N03RlHePJi8o7j5m8XjFtH/6ge4LMHt5krtptEuunUnwQDp7hHMoGqSXzHA1+nXLZ7l17PQ4++m9mWmqOfxAIhIKXW6yPblbmqEfUXnaGw+Mo4OSjSBsLEkl7AhTh5tkwdb7ixVKLIP00gVrKv5a8KHQAHzRLNQ1jJaCcew1Ce1YTzfJTGzY13QalIOkgMJhYrITiEt1HCWuDBWSG3mdn7RSaWgKRHS+5Vl1SJONVd8cBrv+n9uRj+ZYs8D51zjFLQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(39860400002)(376002)(396003)(136003)(66946007)(66446008)(64756008)(8936002)(55016002)(9686003)(76116006)(316002)(8676002)(66556008)(54906003)(71200400001)(66476007)(110136005)(33656002)(52536014)(7696005)(5660300002)(26005)(53546011)(83380400001)(4326008)(186003)(2906002)(6506007)(478600001)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: n5znZlBV/ttjxeWSCGmeDDODOhBhXcvCMyMkIN+cJKY0VfYDSRlABbKtwVvmWqKi7HmDh+gL3K59jp+FwiuZLkuzBtaXN3sXg0JNmzyYrDsdI7pQcS3B7vosho3k6C+xOdsc3TnTZ5A/epgDsNXYm4KblR/BpTA0DDcEgg8/Gdk9qIGiAXcJTChVGJo1DTKROjD4mJZCEoqDh4pgPdH44tXSiQ5S/z76auSEzTBLOmq4w9ORuGKxvgW2zfTFzTqpon6VLxtCn1E8KfWMnARfkOLD4j5ZS4ZN/DipN+RpIFBqmDTkKOc6xDjuHxphFS21/7dwNNjmIPN78e8GWTTstTI4UaB0eVNWIH80nCoNSluE/IBICHvzlzMX1rRvpPM2b0S49TQmwPDsujVbOXcIyAXnMN4bfPH0wwSitG+bsZTp0o0S9Y2t74x+xSXqeQXj10W+gB9230h/gdW4WZ1ocLWjxFTum8QucG94jsh9PsoWaxfkmwL15N9tnK8zxTxEZ/O4+4+ZgtsuAs9HiRBBLUS3zj2odyM1j6Oe7BsRZm02AVMaTY7QJbvUDMR/pzOmXA35T/9IF00HDtcqnjK3PrOLp4uIw7UeVCvBTEC6RhscXPgW48bXLq31Sr1NnnrQiXoEr9QLe5T6YqTRbe4s+w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5734 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f272c035-f29f-4c53-7c63-08d8821d37d9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hEVyi2kILOAoHdslA3YSBwhSxrmtPyIvtnh6eFqNu95pqz9ilhZ8svP7OROdutBPJj7dElv3xvlJJcgwHjCgV9m/MMWRgTyux6GGb5LyUCnV8Ya3RevdGQ9wbjzlM3Lb9WkISfBpxI7uy393viF4Qsh6NdTXyCdr5NW9JYhU8n1SQBGz1hgzTLbyrSgFJX2AyPYI0sW/GIIUv4vriwbfYPlVxmCIFhaKN1IaFjn4MCWrYwk7Wrnxj+KJfxX2Vp4t2LMroaYoGPxTrlFAcll6/bwtup1TA+oUHuXrM4Wr63CORvmvw9TJikfDdb6ahgIGb814MhVc5tjYqosO5rP+oqAJOlSJr76UKenDKKBKuwYpKco4efjx1g3IGdnO5vknWnA4zfRPYbVeFQ+CVUXoBw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(396003)(39860400002)(46966005)(70586007)(70206006)(82740400003)(2906002)(26005)(8936002)(33656002)(8676002)(52536014)(186003)(478600001)(82310400003)(47076004)(86362001)(356005)(81166007)(110136005)(55016002)(36906005)(7696005)(316002)(6506007)(9686003)(83380400001)(54906003)(4326008)(53546011)(5660300002)(336012); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2020 06:29:14.7433 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6eb2f98-849a-420f-d611-08d8821d481d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2176 Subject: Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > +Cc Konstantin and Honnappa for guidance >=20 > 05/11/2020 09:55, Jiawen Wu: > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > When pulling in the main branch, I see some checkpatches > > > > > warnings (in order of criticality): > > > > > Using rte_smp_[r/w]mb > > > > > Using rte_panic/rte_exit > > > > > Using compiler attribute directly > > > > > > > > > > Please could you fix them (at least first two) before the second = series? > [...] > > > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no > > function can be an alternative. > > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to > > replace 'rte_smp_rmb()', is it the correct usage? Yes, rte_atomic_thread_fence(__ATOMIC_ACQUIRE) is the correct code to repla= ce 'rte_smp_rmb()'. However, I took a look at the code and it is not clear to me if the barrier= is required or if it is in the correct place. >=20 >=20 >=20