From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E776A0545; Fri, 13 Nov 2020 05:56:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ED71D56A3; Fri, 13 Nov 2020 05:56:10 +0100 (CET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2046.outbound.protection.outlook.com [40.107.20.46]) by dpdk.org (Postfix) with ESMTP id AA714569B for ; Fri, 13 Nov 2020 05:56:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KvqCzN4trNXuBj4/KMt/3PJ0MWdaZIKVF8FzbGz46v4=; b=yKHoke61LjwD0UYA0mX31tXt5RHKmmBSqBvDW0OTQj7fxAXpj7Q6AEBEHrRy9/g4p8oa/n9d7FkRczsO5kk+rKiCNv8YSNC17TPNYLwL/Op+hHF4+D+8Uhtxqljg7vGTB4Ctb3jkFuSVjNeY6Lqhp/V5B1o2icA0oU9W0knmJLw= Received: from AM5PR0402CA0010.eurprd04.prod.outlook.com (2603:10a6:203:90::20) by VI1PR08MB3247.eurprd08.prod.outlook.com (2603:10a6:803:3d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Fri, 13 Nov 2020 04:56:06 +0000 Received: from VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::64) by AM5PR0402CA0010.outlook.office365.com (2603:10a6:203:90::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 13 Nov 2020 04:56:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT009.mail.protection.outlook.com (10.152.18.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Fri, 13 Nov 2020 04:56:05 +0000 Received: ("Tessian outbound d6c201accd3c:v71"); Fri, 13 Nov 2020 04:56:05 +0000 X-CR-MTA-TID: 64aa7808 Received: from 92496d7bcb06.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9A0E0F45-1FBA-4309-8E13-591114630480.1; Fri, 13 Nov 2020 04:56:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 92496d7bcb06.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 Nov 2020 04:56:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSZ6poWRl5GyhOnEfxVBoPjsdqkK27PW9sEz0pcQ3j3woB3xiKBz3mFsFNsMGDCEkcNpfSHU1vF2N7oCGSG3ktDWpt5foNoGY2PA5XAbUn5BhMgKQWA175nkNDXPhJRerpqrCB+5vlNHNzClazpWY8htv0hbWxhauNmR+imoneqgeGmeR/XA8gYo3Boz3OlxO1giK9jaSTuVF/Lvvt3UFc8miWJLsGhs3JrzALASx3qeooWW0yq3BzL6SAlD45vOxts2PJCMwlP5ZzXl+0G7HZrTf8K4f/oTeMWo8y8lCjx9KWZkDaAC5JySbTxJ9/bMn2ddNrG2KpO7Ma9BE9AD3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KvqCzN4trNXuBj4/KMt/3PJ0MWdaZIKVF8FzbGz46v4=; b=Mme71vqEv4TVS9ECxkVDudXKbp0s54Qi21ciHHiLA/4y+UcBSHAM4bgLZQiKWimm8rVyfnqf2GrP25Nc3mpVULF1d1sL+4pvRFsI27e+wPLdy1olka6RzCAOyVr9kCpTAE+KlyZSete4+MVt/YGUzr2+P0ZFhNyLC1zEvlf5KynzS9B88m9oj2GP58mB2JhKKzh66YN0zEmkh6wcRWcMxlHB2LPBrpnuV+SWqmN5bnOjn4vrg/0+i5The264iySRcnS+SYUUdmY/gXc2kWmEHly17GjRk2kpPc0aml5IJ73SFAx22ALW5oHLMNEhWDhmcjcn3WhLaZ32xvkIjwNURg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KvqCzN4trNXuBj4/KMt/3PJ0MWdaZIKVF8FzbGz46v4=; b=yKHoke61LjwD0UYA0mX31tXt5RHKmmBSqBvDW0OTQj7fxAXpj7Q6AEBEHrRy9/g4p8oa/n9d7FkRczsO5kk+rKiCNv8YSNC17TPNYLwL/Op+hHF4+D+8Uhtxqljg7vGTB4Ctb3jkFuSVjNeY6Lqhp/V5B1o2icA0oU9W0knmJLw= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB4027.eurprd08.prod.outlook.com (2603:10a6:10:a7::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Fri, 13 Nov 2020 04:55:58 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.025; Fri, 13 Nov 2020 04:55:58 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , "dev@dpdk.org" CC: nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to build Thread-Index: AQHWuRFmAcS7tlV8Ok6cDO8JjJFzY6nFfrcg Date: Fri, 13 Nov 2020 04:55:57 +0000 Message-ID: References: <20201112163134.1893190-1-bruce.richardson@intel.com> In-Reply-To: <20201112163134.1893190-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D1548E4D21813E4EAA0FCAC0E0A032F7.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 57ff2b3b-af46-4e6d-49c3-08d887906d97 x-ms-traffictypediagnostic: DB8PR08MB4027:|VI1PR08MB3247: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FCK1ijopkFRTnYrcyNhsWoLNMylEfmYif9nDX6fER9vZxngW8gIFYFhGLDPiV8Td5SqsjrfwBjOoJNY0XjMgakPQ+PNHSQbrb5hYySMKhN48cyDXpEPUVzxYu2mmQrKkQtHLVxB197VWfiM8rUQqYWiBmn6TjguTvce1TWxx33f/FcQrAtrRP74TLhqe+S94wqeQ3L7XOepIJfdZ+byROCJxtJ9GRGwNTI9AcFerGoR49nvIDCTFuM9UMjKs8nxeceselHXTKjzhadswdOCJ42MPtPden0vq/M23h7/1y22aA5SZkmnx18yEfWZWAq4Ozz+h3rD7P6HeIJWlNyC1FQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(64756008)(54906003)(66946007)(110136005)(186003)(71200400001)(52536014)(66446008)(76116006)(33656002)(66476007)(8936002)(66556008)(4326008)(7696005)(26005)(478600001)(86362001)(6506007)(5660300002)(2906002)(55016002)(316002)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: c5LFD9YLCiIe4H/MMB9IE3kksRak49WRUY+UVLJDhYfCyc2mrKvWXcY4nFztgXx4BbDfoQ2DuQb+RFX3FRrnXL9QuSiRTr806uuOiDB3EOPjvB05UStIpng6MJtGKycFBpF+wcbCkRaFoLR2k+X/F7Dnb+B+RKEKk/Jgd5y1vj5pdnYSUFG43HTfzDFWW8IXJy8SDniNS6cQOn4Jlbf/bBKGmbgs73EwWjvZXNPaf5+3W9LP7+nX5Tk6vlTxcv5di506zJrYfWEHUyTPj72CYYHAw0VKTioPFTDOUeXA1YDZ6i5vFFZNHlZiZTO6+mHShJ+GOYLGFA1Tv4TICRM7PISFs8gq8278PDYtDfN47/QCfB38ag/bxpPDaPfhtJOcrKU8zWcImljLa9sDa/V6tZmQgbWWw4Qq7gqvGDFu24t+N+AHUixBAErbOwLhSNfn2tfLLGT7zpSWE9IJlRIHpoIIL7iFNqGd5oUxXcA0pZUo0jjPF8dxnFI93vitjYGJXhiqg9lmmyn/KL0AyF2+SjRHEFO4J/ZTNDV6oa8QwiGbFWLN86dYqNdAl5a2WyPpTWyWUPxhJhAoa5APWTya++Tpkoj32N+cmSZwl7Hj71T4+yuA7TbHmL1bbCU2GM34llZokO1bogPLQmxULK+J0nXKKSWHbqd66HjMqsbT1091ilVgwx7pO+ML8Tya9CcexlS/FIIRgZPsPqJx9hBKkC6CGIfxFnuoF+8rHVsRoM1ep6Gie8VTy12LyKV4PNjfznRhOsJ5xsSmwHGttMpeYEBIEsl1Q1t12NiyWOAj7Jcj8IAZnUjhmYFmqlfHCAnMPirjqEEsMK8J3q/1pAfj6qNQT80VSe4uEsb9pfC4hJjqkanQipmjBXcVfSrtDcVCOZb6R/rCcmo0RTN+m98NzA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4027 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 510f1c98-9c42-4faf-0741-08d887906910 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jcuRt/Na/oHOlLdc/btuQPUp50mrBXBqjk9rCr2b/2TaMhEGxnvKffvnDsOp0XSYiqU8pfz43+OUnerN7r8GukT9NYK+KOWxhXf8/j1KjYbHLPpwS/FG5kzku0Ut63a7rEK3l2M7H5yvWOznm1+26r0pxizq5U0QBRHGTNdEaPINNnGo4soyXCR9NHPXHynOMRrTd2UU6mFiC99JvkZhlpYd+ZEPJbWK6re19ApXOzhigEXTqdLgCCMgOcXV4/Xn30lCDRq1Rd2cuXcN7l+NI7mZ2JvkVvph9O/xoBOJWj1o3/owwfT5+RvDVPthC6WGlhU/eFtnj5sjWgq7/StprU7UEvSBwS0ocVuGWd3h33l3un8gsDldgiqWDjeCmvLqJT13IrnEgyiwyN2BcFfR4A== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(46966005)(316002)(2906002)(54906003)(82310400003)(9686003)(47076004)(110136005)(186003)(336012)(70586007)(86362001)(70206006)(356005)(7696005)(82740400003)(6506007)(26005)(478600001)(8936002)(4326008)(5660300002)(52536014)(33656002)(55016002)(36906005)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2020 04:56:05.5307 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57ff2b3b-af46-4e6d-49c3-08d887906d97 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3247 Subject: Re: [dpdk-dev] [RFC PATCH] build: allow passing extra config header to build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > To allow per-build override of some settings, without having to change DP= DK > source-code files, i.e. rte_config.h, we can add an option to allow the u= ser to > pass in a file containing their own defines for the build. I guess, the file format should be same as any header file. One could derive a file from rte_config.h. I think this will provide good f= lexibility. If this is provided, we could deprecate options such as max_lcores, max_num= a_nodes. But it would mean, one needs to know the exact #defines. >=20 > Signed-off-by: Bruce Richardson > --- > This is just a quick RFC to show what might be possible and to help keep = the > discussion going on how to improve build config in DPDK! > --- > config/meson.build | 10 ++++++++++ > config/rte_config.h | 4 ++++ > meson_options.txt | 2 ++ > 3 files changed, 16 insertions(+) >=20 > diff --git a/config/meson.build b/config/meson.build index > 258b01d06..5c137e4f5 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -14,6 +14,16 @@ foreach env:supported_exec_envs > set_variable('is_' + env, exec_env =3D=3D env) endforeach >=20 > +if get_option('extra_config') !=3D '' > + extra_config =3D files(get_option('extra_config')) > + configure_file(copy: true, > + input: extra_config, > + output: 'rte_build_config_extra.h', > + install_dir: join_paths(get_option('includedir'), > + get_option('include_subdir_arch'))) > + dpdk_conf.set('RTE_BUILD_CONFIG_EXTRA', 1) endif > + > # MS linker requires special treatment. > # TODO: use cc.get_linker_id() with Meson >=3D 0.54 is_ms_linker =3D > is_windows and (cc.get_id() =3D=3D 'clang') diff --git a/config/rte_confi= g.h > b/config/rte_config.h index 25219f04a..2f5ecf999 100644 > --- a/config/rte_config.h > +++ b/config/rte_config.h > @@ -148,4 +148,8 @@ > #define RTE_LIBRTE_PMD_DLB2_SW_CREDIT_QUANTA 32 #define > RTE_PMD_DLB2_DEFAULT_DEPTH_THRESH 256 >=20 > +#ifdef RTE_BUILD_CONFIG_EXTRA > +#include > +#endif > + > #endif /* _RTE_CONFIG_H_ */ > diff --git a/meson_options.txt b/meson_options.txt index > 9bf18ab6b..91319b0e4 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -2,6 +2,8 @@ >=20 > option('armv8_crypto_dir', type: 'string', value: '', > description: 'path to the armv8_crypto library installation directory') > +option('extra_config', type: 'string', value: '', > + description: 'path to a header file with extra build defines. Will be > +installed as rte_build_config_extra.h') > option('disable_drivers', type: 'string', value: '', > description: 'Comma-separated list of drivers to explicitly disable.') > option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-', > -- > 2.25.1