From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84454A09D9; Wed, 11 Nov 2020 17:18:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01D4BDED; Wed, 11 Nov 2020 17:18:36 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150052.outbound.protection.outlook.com [40.107.15.52]) by dpdk.org (Postfix) with ESMTP id 116412AB for ; Wed, 11 Nov 2020 17:18:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AAeGHl6+q3BaDvn1nW+UhLM5v+SNfqqEZWeobfV3nM=; b=bZgImm1hleNo7/TTLNZh1RAgYQYAdQkiX8wLvwxPdSQDbYwzUGquiS71TIaQ67PfO/Fb6OeqJM0buTiso8INCN5+pL/xVVeHZgv4E9tDGKt9fHbE4E7c9hcpy7xyG8rqUYmVkth+4q2mwgDk4uAZyDevQ05i1USWMMR+SKj4tAM= Received: from MR2P264CA0118.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500:33::34) by VI1PR08MB3263.eurprd08.prod.outlook.com (2603:10a6:803:3d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 16:18:31 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:500:33:cafe::fa) by MR2P264CA0118.outlook.office365.com (2603:10a6:500:33::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Wed, 11 Nov 2020 16:18:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.22 via Frontend Transport; Wed, 11 Nov 2020 16:18:31 +0000 Received: ("Tessian outbound 13ed5f5344c0:v71"); Wed, 11 Nov 2020 16:18:30 +0000 X-CR-MTA-TID: 64aa7808 Received: from 4547d7484394.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B2C05C62-2946-4816-BABC-CC99A39C7469.1; Wed, 11 Nov 2020 16:18:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4547d7484394.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 11 Nov 2020 16:18:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EnKvZEqEUIZdBOg1Oj2K2JfTakMyXWF6cfiYU0DSLYDsrQspON3UvlvaHsR8qNw48Dnj4xh+PMTsck164jbNYaUISTYWCbvXpE+NMWetfMCxTuyus0rz0lRJlzFwE9EeBYNf0Jbeu9HU7mWvtFoO1eiXj52KaEaVZ391MmZ+iBRSn044qCMVBcybhcOetL+CvXrGCw3KCSyFwN9YZDdlTAEotpuNZwU8k2BL8d7eDWobjhJCRmO0hv5BvYt8I4Kf0MFzp9yXzIhFomshF6IbVjwQjUADNo/oE/I5mss2x/viVbjxsjTN3J3qzIq6MturSG8Yh/8t3gaETm6yMLgDfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AAeGHl6+q3BaDvn1nW+UhLM5v+SNfqqEZWeobfV3nM=; b=SuOsmLmCsqJtJNF6m9j0vPD6mRkbdI7SlGi7eVi2X/2Ie4r78mAU3IQhx0QldI7M6fjnEahmgofTpUqWUbZXxwwbpTKgJCSjp2YjZTC5tdHn35bAOkMoZYgI+yb2xDCwhGh/XSxTWsi9zZwWBjOX+Q72UsSgS75572o21lN9+r9AqErojhPhexuURzpuCxcCqFh0GgkatSb3USuaRdodK/wt76DXTJ33iTrOLQVOLCnq47aT2V3aQ4bGJIGcGzzpdfPPzsarGAF11nbL0iDTPgADY4amZPlbfCAZT+1vtKXn/TUUgcWv14t7GgalXhsrLrSmzA33n2VIvKKOCa2/LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AAeGHl6+q3BaDvn1nW+UhLM5v+SNfqqEZWeobfV3nM=; b=bZgImm1hleNo7/TTLNZh1RAgYQYAdQkiX8wLvwxPdSQDbYwzUGquiS71TIaQ67PfO/Fb6OeqJM0buTiso8INCN5+pL/xVVeHZgv4E9tDGKt9fHbE4E7c9hcpy7xyG8rqUYmVkth+4q2mwgDk4uAZyDevQ05i1USWMMR+SKj4tAM= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3609.eurprd08.prod.outlook.com (2603:10a6:10:42::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.23; Wed, 11 Nov 2020 16:18:23 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.025; Wed, 11 Nov 2020 16:18:23 +0000 From: Honnappa Nagarahalli To: Conor Walsh , "konstantin.ananyev@intel.com" CC: "dev@dpdk.org" , "linglix.chen@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2] app/test: fix to prevent zcd gcc compile error Thread-Index: AQHWt1EkEi/RJFRaa0KhZ2J94f3LbKnDHcgQ Date: Wed, 11 Nov 2020 16:18:23 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> <20201110110313.1924365-1-conor.walsh@intel.com> In-Reply-To: <20201110110313.1924365-1-conor.walsh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B956905A12777F42B74672DB52AABC39.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 2cd3a124-ff2d-4678-0d72-08d8865d6e3e x-ms-traffictypediagnostic: DB7PR08MB3609:|VI1PR08MB3263: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3276;OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Wh/dpWkoHmKBWiw94xxgzXiauKO9rjrdoYQ8H5zEu0ClJgKhMdze/HUiZt4Edjz6HeYRwaLQTjcERUY/hiNvQS8X1OiPN0mJWVfytzmHLgFIiC8drDkPJkyWAAMr87j7X9VW7HGSyPD8y5vQAkmuSaEmjeljK4L1gGh1Xjn9kI5/xVlaPosAVCHgX7p1h32FgccPCpaDaLcWm+d/sFlU+g2twzDTp/CC5Os3MYfLAn+qvNqIwWOvxc+sxaotDJ39D3keBYXQnhyr84jOQ/TPABrRoFHDYnwB88B8rGQfYWej+gQf55wQlKkyKN3stnYr X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(478600001)(186003)(66476007)(33656002)(8676002)(76116006)(316002)(55016002)(2906002)(66946007)(64756008)(8936002)(9686003)(54906003)(26005)(110136005)(4326008)(86362001)(83380400001)(66556008)(7696005)(71200400001)(53546011)(52536014)(6506007)(66446008)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RX0ZrJ2RKEKvSZP6ALXk890qdUm+dBdSGpLFp6+D09jxApzO1+q/tDt4C+gGI/iYvt5O2Hyc9A9Ss/N+BdczyZcEIqZEcEC4HLLHStQqaGJ9ZcO/Irh/5SN9SM46TSpN+soBec+HxWOmFudN4d51j278i4O/NmhPOrj8wq1O8Fv9fC+hVIg+a1h0YUH7Yk8IIlaWRZYijehjUbgEVvhi/JnIqnzk06rSR94ERl6iRS/ukc5gsPqq5QpwvOybET6utccXWAaHCpCYIdrPgQWHfef24zt0JgYDv6WdkyjpCchmyFRdQGaCiQdDRckVgjablbfxUCTy6onNxSj77z5pR/j26RDfZm8XceyAhwsbDmP/3+7KxouKb5SPj+/onYCMOuXvBqdQmD5lumbDecygTYU/0BLvSnHEct+PttiGlshN8+CcLLdSQt8cewwC7eAzPN3IeVILnX3iRf5mHxgzVWzei9eCgRwCdUl9QeONGs+iucm8srH4XAf+zvHvw5krbWBypDJXfnmqnKlQbZt2EjPvUPfXx2Qo7Pp8e+Rb2dXxxXtuilhHhm0boGUm2kW9d1hayDNHKurWXLFQpRTN4fzLuLjyiq7v8whxTzBpz4Ee0ZgCE7UqZmMyIwHIh/qpf8wCR0A/wLDEBSZFNjV1EhhMglTEbB6pkNVG2yeddvKYVKFPkHur733iRsdvpYhNP5yqsTaTlwm/5uM/toPyl6eIGpOYcJOE46rt1YgA7/3o/nCiQffVZM/bux3bld0DWrXdIbmtpVDFYf5LvOJXZKVbMLtn4hsAV+Ti6O8NK3rPKPC8hMA7Z2t5Fiynan7RaGyxIEFqtPOkXln04sFVKSMRBKoB4xLibUEF9zngJVm8LVyktFnIgoVN4Fi3ObQUFj9WkSOgyqNmvRyhWUtM4Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3609 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 16a8f9a9-3b78-4fdc-59cc-08d8865d697a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KDKwksxYabIxLL/k8Yho4RrUjTgv7VH22gwYeWaiTXEej9+vDHcuc7r9vkg0ApIq3Jyu6kFLq/xGEXdg9pbS0cv8ED4uwEzJAWpeO2wgbqRblL+tXCI737VggEvOOMT+WjZgbRlLiszeRIZLcSt4+CIdO3NlUbRBmb5OqI0zMbTAutHyEU/ZnfGe+yKZfHLH22h4xMVVwN/+wQv+DtcuRDGW13zWq/wGOdGItEUNn0dZBvLTN4hTjEtv2gUz2oDREiW5F/UMQJj1jtTtL9G8tImwwASxXzmFM5cznuLm1a6QhH26hZKj49OcgWyOJChz9wPcCd1blt8FlhB1eictNJOLSaF6HWliN7n3InGmaSMIVQV0293VQBvGyKuRSgPHxRMFeKvlxqv+Jrh5JPUN7Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(396003)(346002)(376002)(39860400002)(46966005)(2906002)(9686003)(8936002)(70586007)(4326008)(70206006)(81166007)(110136005)(53546011)(83380400001)(86362001)(52536014)(478600001)(8676002)(33656002)(36906005)(82740400003)(186003)(47076004)(26005)(5660300002)(6506007)(336012)(82310400003)(7696005)(356005)(55016002)(316002)(54906003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2020 16:18:31.1288 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2cd3a124-ff2d-4678-0d72-08d8865d6e3e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3263 Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix to prevent zcd gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Conor Walsh > Sent: Tuesday, November 10, 2020 5:03 AM > To: Honnappa Nagarahalli ; > konstantin.ananyev@intel.com > Cc: dev@dpdk.org; linglix.chen@intel.com; Conor Walsh > > Subject: [PATCH v2] app/test: fix to prevent zcd gcc compile error >=20 > When DPDK is compiled with gcc < 9 with the optimization level set to 1 g= cc > sees zcd in test_ring.h as possibly being uninitialised. To correct this = error if > statements from _st_ring_dequeue_bulk and _st_ring_enqueue_bulk were > corrected within test_ring_mt_peek_stress_zc.c >=20 > Signed-off-by: Conor Walsh Reviewed-by: Honnappa Nagarahalli >=20 > --- >=20 > v2: Moved from initialising zcd to changing if statements within > test_ring_mt_peek_stress_zc.c following list feedback as the > original method used may have masked errors within the library. > --- > app/test/test_ring_mt_peek_stress_zc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/app/test/test_ring_mt_peek_stress_zc.c > b/app/test/test_ring_mt_peek_stress_zc.c > index 7e0bd511a7..85f0262ba0 100644 > --- a/app/test/test_ring_mt_peek_stress_zc.c > +++ b/app/test/test_ring_mt_peek_stress_zc.c > @@ -14,8 +14,7 @@ _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, > uint32_t n, > struct rte_ring_zc_data zcd; >=20 > m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); > - n =3D (m =3D=3D n) ? n : 0; > - if (n !=3D 0) { > + if (m !=3D 0) { > /* Copy the data from the ring */ > test_ring_copy_from(&zcd, obj, -1, n); > rte_ring_dequeue_zc_finish(r, n); > @@ -32,8 +31,7 @@ _st_ring_enqueue_bulk(struct rte_ring *r, void * const > *obj, uint32_t n, > struct rte_ring_zc_data zcd; >=20 > m =3D rte_ring_enqueue_zc_bulk_start(r, n, &zcd, free); > - n =3D (m =3D=3D n) ? n : 0; > - if (n !=3D 0) { > + if (m !=3D 0) { > /* Copy the data from the ring */ > test_ring_copy_to(&zcd, obj, -1, n); > rte_ring_enqueue_zc_finish(r, n); > -- > 2.25.1