From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40564A04DB; Thu, 15 Oct 2020 18:46:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3935F1DD99; Thu, 15 Oct 2020 18:46:23 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2041.outbound.protection.outlook.com [40.107.21.41]) by dpdk.org (Postfix) with ESMTP id A43F91D9CC for ; Thu, 15 Oct 2020 18:46:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VX5f5VBpW/634K7zEsflP1ymwC6pInF9h/zc2gOMhqk=; b=LlFWJTsDj98roGDX4VnJgjz4sEzLakqPzIAKnVjnPzBo//D70FvVuBziIKDm6UTwK4nVyGEmahi7qhnJwMa8nupzjqPbXxQX1qmMBw4X1+RdC2FuhQhmj81FJ1ryVvUp1jwEJm7IaVg7KB7Oqm2hWKtXCs8BMw7gbTcPaxZm43g= Received: from AM0PR05CA0084.eurprd05.prod.outlook.com (2603:10a6:208:136::24) by VI1PR08MB3728.eurprd08.prod.outlook.com (2603:10a6:803:bf::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Thu, 15 Oct 2020 16:46:17 +0000 Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:136:cafe::87) by AM0PR05CA0084.outlook.office365.com (2603:10a6:208:136::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Thu, 15 Oct 2020 16:46:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21 via Frontend Transport; Thu, 15 Oct 2020 16:46:17 +0000 Received: ("Tessian outbound 68da730eaaba:v64"); Thu, 15 Oct 2020 16:46:17 +0000 X-CR-MTA-TID: 64aa7808 Received: from 34869c242f6a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FA72846E-BF7E-42BD-A978-649A618B77E5.1; Thu, 15 Oct 2020 16:46:12 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 34869c242f6a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 15 Oct 2020 16:46:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PuaH7ULO9VGpcbwEYEI0keGCnDPVq3MgTq4bA8xOMXW739+A8Hdql9vOEqfanMnRI44ZWVNFh7rYGWYu+vfJZ3i+o/Z0BZWiazzaQrnDhpvFKNm7MDO1lM24pc2Pmev26VT6G8Fh+RDrixVj7+47OORzJZQ+1gnzJ2K2T2XwR6qHm8FV0xIR+q4q7YQNHURkBUJ15CsYJl0yMwuOMhmsxMVRqwxe9i2l21xSPGX2gTP5IDFM1ajz444DSNF1vHnJd72gT9Kh9QKs+JZpFh1WmtUedt2dzQyeo3/orE5K/pxvEF0Ot2C6IWIZB6GeBWMge7+NW+96imLw9YeRfxllpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VX5f5VBpW/634K7zEsflP1ymwC6pInF9h/zc2gOMhqk=; b=HRMgB5sMhvdpDZiOWMce4EizYbi7H7rfvScCchvv8KhEyBTwNgEFMjkwH6hzYUo7WXPScO62CNO5vIXqN2pGhEgk7toLZz1ut36DkzuNAVd5uTAP5HW8Z+69IxPefN5aVF4M6McgLfRMqWCtd+633qWIJBdvDeRFUsmUxb7ZuQGukZJCRNPH07N3Wf5nO+k5iw3/CwqdRU5/4cxI1+xLLdJJD4BPKrrh13+t3lAeoN9Jdv2uXMXurwfyXTxU7druUNJbSNfnW2B2oQoibceXVVNjhwXjS9i/p2yXrvn8U9UEkzFqJ5f6WJEhEf9jBlz+oZCVAJgroj7tK0iEatVAYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VX5f5VBpW/634K7zEsflP1ymwC6pInF9h/zc2gOMhqk=; b=LlFWJTsDj98roGDX4VnJgjz4sEzLakqPzIAKnVjnPzBo//D70FvVuBziIKDm6UTwK4nVyGEmahi7qhnJwMa8nupzjqPbXxQX1qmMBw4X1+RdC2FuhQhmj81FJ1ryVvUp1jwEJm7IaVg7KB7Oqm2hWKtXCs8BMw7gbTcPaxZm43g= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0802MB2149.eurprd08.prod.outlook.com (2603:10a6:4:82::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Thu, 15 Oct 2020 16:46:10 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3477.020; Thu, 15 Oct 2020 16:46:10 +0000 From: Honnappa Nagarahalli To: Eli Britstein , "dev@dpdk.org" CC: "thomas@monjalon.net" , Asaf Penso , David Marchand , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH V2 1/1] eal: fix build with conflicting libc variable memory_order Thread-Index: AQHWowV354+v2N9bHka6DU2vz8rdgqmY3VWA Date: Thu, 15 Oct 2020 16:46:10 +0000 Message-ID: References: <20201015151017.8060-1-elibr@nvidia.com> In-Reply-To: <20201015151017.8060-1-elibr@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7BCDC6646F07DC468AFFD4AC26FA3647.0 x-checkrecipientchecked: true Authentication-Results-Original: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 9206b1ae-846a-479b-dffd-08d87129d661 x-ms-traffictypediagnostic: DB6PR0802MB2149:|VI1PR08MB3728: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1122;OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: EAgMgLkxNYvbsAsGoNniU3JAqIA7SSu/kCtI6/7JzQCvLRezATcPzlTvAA3wEtEub9tdKmFZy3b3J+SPiCPWnZ4UVW5EU0bkXVXWDFgAnQRxRO3HXSagUIyhWzhO4bul399flwtiie/kdzCM+GVfLIitYaER6xUy/lHK4cyUflFVU7DmQo/jZYdFREVe5uLgHkrbsMjYOxYRpb5e/fbcFACWU36yxliaAj7p6Y74qeIXyOnHpu+y/Eb4e7EhEgDTUH59K632FSaMvj4lOMgRNw2wa4LbMKKdyESesK38sTIiA+mB1uqhCZwlGNh1JKucuPJ8jiWHoEJFJRYm1VzloA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(366004)(376002)(39850400004)(136003)(346002)(110136005)(478600001)(316002)(54906003)(55016002)(83380400001)(76116006)(33656002)(6506007)(26005)(52536014)(8936002)(4744005)(71200400001)(2906002)(186003)(66946007)(86362001)(5660300002)(64756008)(66446008)(4326008)(66476007)(66556008)(7696005)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: fDWiVKG6CQQtSWfLyr8DwUN125r0JRFGEqmztJJlnjZ6Y1K/K1UPU2kfOEMiJ28M3ib8mNMoEjnBm3XIiL7TqvmOMn0RDff83sRyjoybMmcm6e29HCpiPb8wb3RuybN+0+1OselDrKMCkwxIxiKkh8H2ckNf4uJ0W2insG0Ex3E1GTFFtcR4G29JWW622zzzF1E2PYFgIU+1TG+v6QhAR46kGCtZuu2fw2rKLuMpeaz4HMT6UgVQUFrEePTB2ScjeSpyoooJ91eMoV9cxsUWf5pgKjcGcsssnODDfdvgoit8ufxhRh0eZ4NXzhhv4u4/GMjkygVls5LsoEL/KgvCH+9ovLy/1gEInRDjSorCdKK1N9O69TrM0lViHGpV9CTxR6BpiNge3Sz/ZU9O1+Xorx+QVaqNRYGVURcXIsi7nJ9xgp1qHZduqoiFOB94yU0m6cW4F1zNJlD7dA6KazZZMZh5B6pVB37pA45EZScq+LAoDp53if37UlLuz6kbiRp34m67SLUBNPdMfprAALRfFO40KRfQiFdaXm+b3sxsaBN3RkZ0dLtv504A1Xd6VmTR3eyFFQV19LWrXVqe6IabOEoxB7e/fclRMgXAlc8eguQBKtWuVmp0fRVZLEUhpNvQOgy7frgqzcoA+qb85FymJA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2149 Original-Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 211f16a8-2bbd-48fe-2568-08d87129d212 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MS7yZYdME4VWEp982p4l5h342pWKLsx2ayyhTeCGYn86J5r/cY/zlVeCEFgngs6bQpK2uFBNwm6q7z/Yzm4j7VqlMCuXItAKDkcqzRlrgYSNO8BpGyiKsQS66FWT1GzzOA5qHrXdvckTWHFudZjf1/mUtwkLE0+SHxMh4A/0jH+H7X6qzhyFmTSWL+zaQiCA6xafl+n+8AdA/c4BSb5qkFI/KaHUZHffTzpf/BMJPoeZ/zlFHhf7/hVqvjPgTgQGlkWRMKCsnpUUpBM86abX8wBqx5u3E7FXL03bL2Ij2FFxBbtP8ChzghK78HPrH31UDhRV7W0Yajfd0M15n10B6kdsrbf0bWJixGCoChDWb6hOrT07epOFlok8rJus5dH9uUlTNj+NJlzYbQoVtfI2Mg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(136003)(396003)(376002)(39850400004)(46966005)(6506007)(336012)(52536014)(356005)(70206006)(4744005)(54906003)(36906005)(478600001)(26005)(110136005)(70586007)(82310400003)(83380400001)(316002)(5660300002)(8936002)(2906002)(86362001)(33656002)(7696005)(55016002)(186003)(81166007)(82740400003)(4326008)(9686003)(47076004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2020 16:46:17.6721 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9206b1ae-846a-479b-dffd-08d87129d661 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3728 Subject: Re: [dpdk-dev] [PATCH V2 1/1] eal: fix build with conflicting libc variable memory_order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > The cited commit introduced functions with 'int memory_order' argument. > The C11 standard section 7.17.1.4 defines 'memory_order' as the > "enumerated type whose enumerators identify memory ordering > constraints". >=20 > A compilation error occurs: > error: declaration of 'memory_order' shadows a global declaration > [-Werror=3Dshadow] > rte_atomic_thread_fence(int memory_order) >=20 > This issue was hit when trying to compile OVS with gcc 4.8.5. This compil= er > version does not provide stdatomic.h, so enum memory_order is redefined > in OVS code. > In another case, if the compiler does provide stdatomic.h header, passing= - > Wsystem-headers in the CFLAGS will also cause that failure. >=20 > Fix it by changing the argument name 'memory_order' to 'memorder'. >=20 > Fixes: 672a15056380 ("eal: add wrapper for C11 atomic thread fence") >=20 > Signed-off-by: Eli Britstein Reviewed-by: Honnappa Nagarahalli We are missing the earlier ACKs.