From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 135F8A04B1; Wed, 4 Nov 2020 19:48:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60B8928EE; Wed, 4 Nov 2020 19:48:22 +0100 (CET) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10051.outbound.protection.outlook.com [40.107.1.51]) by dpdk.org (Postfix) with ESMTP id 8B6CD1DBD for ; Wed, 4 Nov 2020 19:48:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5DNi/S98nDeVnMTuu5IhqMwIss5IDDjLN9tgo5YJ70o=; b=LT1yK+X2xsuKgQVPghjiO+cIP4lTGLLKBpL0elzIplq+A/+P0yU7L/5tgnCRLi0ZiQDOmI0LV/hg4lOn7NZFhptYc0hAAkBBqVBzOu5/wzhdX+C7dEMqS/Y4mzOnGM2eYDYtoXq8yS7peofU0hOZATeDOHOeiyhOch94WVNCPvY= Received: from DB6PR0301CA0039.eurprd03.prod.outlook.com (2603:10a6:4:3e::49) by PA4PR08MB6173.eurprd08.prod.outlook.com (2603:10a6:102:e5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Wed, 4 Nov 2020 18:48:18 +0000 Received: from DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3e:cafe::58) by DB6PR0301CA0039.outlook.office365.com (2603:10a6:4:3e::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Wed, 4 Nov 2020 18:48:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT034.mail.protection.outlook.com (10.152.20.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Wed, 4 Nov 2020 18:48:17 +0000 Received: ("Tessian outbound c579d876a324:v64"); Wed, 04 Nov 2020 18:48:17 +0000 X-CR-MTA-TID: 64aa7808 Received: from 9191ac373092.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FDD314BA-5828-4F2A-A687-41A647C20F37.1; Wed, 04 Nov 2020 18:48:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9191ac373092.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 04 Nov 2020 18:48:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKfOkY9bIhELShKnlRsIInbKD9QSFO7iOXYJioOUsG+MsyssPNfn3XCCaAYM0I6MepNjpFtu//jYaJvmnR/O7BV8gsYqk8dUl04K2HYvo76cWdXVUpBw3hRlR3O+RhaBQ9lgjP6YQKDeoHl6hX25I+8ruyqpVoJZ5aJAl5NbD5gPjLF6MNM4K9UjBSZaCrho2+6pW0cROXgGMDVjywKSUI78c34QmAH9hJYkts2K7tEcCJHb6pcOA/k9zsoKZFwzE6ufudwf+9hdKjrOVRs+/CSs5TrXlcG+9kZde2D364YOYpPdlIgNGKTqnyXFHyDbO3cIL954iVJAJ9wF4tJogw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5DNi/S98nDeVnMTuu5IhqMwIss5IDDjLN9tgo5YJ70o=; b=Er8zwW5P1f2nxwPaYhWbf8DwHxDxNQu4TGFfPo6raRi69mR1RJ7J2M43bUefgu8wp4nYOVf785/oFFkV/o4MuCQX+cjrsLKSSG7DvuB4eNkL6ZbA+vDNO5mbORauYc2jtkb1A7+TrX1+sZ+PHsJe4s+pJpxPj7qOFRmjD4S29mK1WAARv8dfxPR1yxOLk9bzuUBH9jlu/akklisToENG6OPtX+wRkv/7OtrkNqqzfOGVcupOyxbk/TxQNJIhcgfCya9T6qRjmapHD//ss0D7kVdmbSD4rvME8tlFLpagWI5D87vtmYj8LGZ7XEIyfm2n9Nn7EGOglIQALGwTEb77MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5DNi/S98nDeVnMTuu5IhqMwIss5IDDjLN9tgo5YJ70o=; b=LT1yK+X2xsuKgQVPghjiO+cIP4lTGLLKBpL0elzIplq+A/+P0yU7L/5tgnCRLi0ZiQDOmI0LV/hg4lOn7NZFhptYc0hAAkBBqVBzOu5/wzhdX+C7dEMqS/Y4mzOnGM2eYDYtoXq8yS7peofU0hOZATeDOHOeiyhOch94WVNCPvY= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0802MB2376.eurprd08.prod.outlook.com (2603:10a6:4:86::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Wed, 4 Nov 2020 18:48:10 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3499.032; Wed, 4 Nov 2020 18:48:10 +0000 From: Honnappa Nagarahalli To: Conor Walsh , "konstantin.ananyev@intel.com" CC: "dev@dpdk.org" , "linglix.chen@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error Thread-Index: AQHWsszTRxk6cC6E8kGHmDv39SBl8am4TxpA Date: Wed, 4 Nov 2020 18:48:10 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> In-Reply-To: <20201104170306.1688771-1-conor.walsh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F48A64C467540E4F801A2C521010DB8A.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 68ff926f-f126-41f0-5f78-08d880f231da x-ms-traffictypediagnostic: DB6PR0802MB2376:|PA4PR08MB6173: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DtGlQc5z1TQYa1UEWbDbqyLnHKJrvDq6WVF6Wluvga3Hozqz+VQ3nBaSF+yqXpHIn9nDdsxQcWJ8kVYgFaF9YJJWwrrjf+U0lFzo0BPWIxIzcxxw0HsnOjPqpbK+nK/P6BbLKSsbLT6EOQpu92+INKulc/DzuFiYSBcOin+9LMQeSRvzsIwtoGCcHuDfy2YBDhi4mGh6gJbFvtHTbaKIkoyjcem9kyxQNrQwB5yE7v6ul+mGPwWVCjIY120n+sPPpG36kYnnZj1w1Va1f6fgwnfq2lmzIeAYf5nuGWQvU7+/U7n4uqaPuWD0IsFpRag+CJ2ZH5kk+fQYvCTdluulXQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(136003)(376002)(366004)(71200400001)(9686003)(26005)(83380400001)(316002)(6506007)(478600001)(86362001)(33656002)(4326008)(110136005)(8936002)(8676002)(55016002)(52536014)(2906002)(186003)(5660300002)(76116006)(66446008)(66556008)(66946007)(64756008)(66476007)(54906003)(7696005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: kLn71yuu2oCcySUbl2qZsLh92fhhvUPfK5fC1OQnCI7wuac8J+OIVO5HWEZQMrpqIRO6bNhfCnkQj1pvt7xnp94pYANvOcEXzWKZDYWWKMrMtXaXxHMbZIwU81INqQBdEfu3tVaXU0iJlHi3ihc11JOG8Ep97cjqahE9fGIQmuEBayQcnwO1zMCX9rewsNymR7tXUdBm0cLCaBpd4ChqONs3WgNEoXZJrn7gjteqQjhQmcfas4RW28lDubEUf6b/NXNV4eVjcPvSUXViKZRSFNZNbHanTiuN889F22DsuJgWp2lypCx85PhtWMO9zC+cNj/pIV4vr2eU6PJb0S1iD2ds6qdMgKToBDEVxx3S73Pwqno8XzyQ6EG+vQH9MGvJlra1RZOzXt5U9fSLRQ8vR0bZpwbfOVjZ9pB2IYTUFMEduVYda4aoC1snC8Wn+G27kg7vYg73Syw7wVdGj4PUSMUjCikYFwotwadMfr2THqq2dQ48PzXNhwePk8em/ARTntIiDekFfyKhaz8gIlM/mUWO2ptkl5LwtgRpRqjU9HYer/516d1P3MBDPPTzRCjGTW2kRfO86SvqBLiktN3+MP8reE9FWgiwkV7mb/Du0NrcCCryGCopNmDWltN4VgJG6VSy/ftYWqAgX/OWToqTng== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2376 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d63d7ceb-ec90-4626-6338-08d880f22d82 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5gxkgrqa6sAY/S+l5YJ20RcNn2gWGC4pzliIYvvUzf9d+Med8rpqK0pGvxuMa1kcbizGOqZypIs/z27vepGlhaohOeu6RnuUXeJGRV61keQty7N8JRR1r3Na3zkMQ8kQ9PNjF65zr75D+CLWorTdS3JkXklL7e2AvR6zMtjC+YbXixSqaD1hIQ0adizLQp8wy14b4L6Hvv00omhmlgC0Qnw9cOPxBLTkrQl75df18JhencZdG3xTtLrY3+LILlcklrbES+EyZBPsEfjssjDnMhY0XUb4iL6YlldOiqtftp7+Kq/h7VUSw218faRApuvbiIPZm+f1wpsL7S/Cy/YTXhbK0ypMLlgdw8ZduaYR8nrafaVY4vdN23hFArFcuI3ic/Y9Mcw9UI5cTTu7Bw545Q== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(39860400002)(136003)(376002)(346002)(46966005)(316002)(86362001)(356005)(81166007)(52536014)(82310400003)(8936002)(6506007)(478600001)(5660300002)(2906002)(54906003)(110136005)(7696005)(55016002)(33656002)(82740400003)(83380400001)(4326008)(70206006)(9686003)(8676002)(186003)(26005)(70586007)(336012)(47076004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2020 18:48:17.9691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68ff926f-f126-41f0-5f78-08d880f231da X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT034.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6173 Subject: Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Conor, Thanks for the patch. >=20 > When DPDK is compiled with gcc < 9 with the optimization level set to 1 g= cc > sees zcd in test_ring.h as possibly being uninitialised. To correct this = error zcd > has been initialised to {0} in test_ring_mt_peek_stress_zc.c. >=20 > Signed-off-by: Conor Walsh > --- > app/test/test_ring_mt_peek_stress_zc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_ring_mt_peek_stress_zc.c > b/app/test/test_ring_mt_peek_stress_zc.c > index 7e0bd511a7..ba0acf237c 100644 > --- a/app/test/test_ring_mt_peek_stress_zc.c > +++ b/app/test/test_ring_mt_peek_stress_zc.c > @@ -11,7 +11,7 @@ _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, > uint32_t n, > uint32_t *avail) > { > uint32_t m; > - struct rte_ring_zc_data zcd; > + struct rte_ring_zc_data zcd =3D {0}; I faced similar problems when I created this test case. I refrained from do= ing this initialization as it might mask the problems in the library. Is it= possible to identify which path in the library is actually resulting in th= is error? I would prefer to fix that instead. >=20 > m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); > n =3D (m =3D=3D n) ? n : 0; > @@ -29,7 +29,7 @@ _st_ring_enqueue_bulk(struct rte_ring *r, void * const > *obj, uint32_t n, > uint32_t *free) > { > uint32_t m; > - struct rte_ring_zc_data zcd; > + struct rte_ring_zc_data zcd =3D {0}; >=20 > m =3D rte_ring_enqueue_zc_bulk_start(r, n, &zcd, free); > n =3D (m =3D=3D n) ? n : 0; > -- > 2.25.1