From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82AA1A0548; Mon, 26 Apr 2021 22:46:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 009404068B; Mon, 26 Apr 2021 22:46:46 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10069.outbound.protection.outlook.com [40.107.1.69]) by mails.dpdk.org (Postfix) with ESMTP id 7A4B14068A for ; Mon, 26 Apr 2021 22:46:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QzXU1Cut3+xRVDjh7wLgS6/GDH76qIRUETKTBAH1WE=; b=vtUe1wLVfmziw6tZY1FQixBEzsn/Fdg0SWv45eMVlK5/56wkdeXHg8dSJV64EAZmgAP74CrKpnQwnQyL6LSadGovm6dJqq7ppSQXCiqNd6Izo8ziZuQjFjEm/vILOMgdfhUu+vY3FT+9Mv9ZOz95FvrugvcA9b2XUbKbp1CIB/M= Received: from DB6P195CA0024.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::34) by VI1PR0802MB2272.eurprd08.prod.outlook.com (2603:10a6:800:9d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.24; Mon, 26 Apr 2021 20:46:41 +0000 Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::9b) by DB6P195CA0024.outlook.office365.com (2603:10a6:4:cb::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Mon, 26 Apr 2021 20:46:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21 via Frontend Transport; Mon, 26 Apr 2021 20:46:40 +0000 Received: ("Tessian outbound 4ee49f77c636:v90"); Mon, 26 Apr 2021 20:46:40 +0000 X-CR-MTA-TID: 64aa7808 Received: from 4e0fb2f58284.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 601F7B03-7474-4254-8B26-F921B041E05B.1; Mon, 26 Apr 2021 20:46:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4e0fb2f58284.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 26 Apr 2021 20:46:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rs3aYI15cGchsQGesDKXhr1EdVRsQ09Miz0YLo/fSBIpsJKctf93SaIGn3fB75MnOxXfj/rxHnwAkmahL9mbe705vlzQ6QeaaBcItKUO1pKrk6I49qB4HvOqfECgsTie7Os8uvcxSufDas35e1kYh50JHyiQtYHFA964gSbEC6ilHR6oX4n3KbLnU5nKQRM4+b4H90iy8uBxcPzEuB8m5gFK4pmrMV15UzgotW/iI8qi/ZSgNc8QRS7Fb1iyKbsMXig5ptIn5ztH3ePL32SRj1XEzMzzvqM8yQJeNMLFfnH0ihi9A0X0PD1tmZoAyth1+38TfjgQxJUkQSfQsCiwdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QzXU1Cut3+xRVDjh7wLgS6/GDH76qIRUETKTBAH1WE=; b=fcvZnhu4U4UP+jcOkzPt/BbVttyokKH2X0jyFxXzYtJrEOO0h1QNQt7HZdn01z+CB6reYteFHk7Ph7HAqx3gCcbZGt3ijIufBI7gTaxJhkdiABDIkRmIMLk9+1ePyEVy45EjeQCMGpgKb9e//t0mfIbmjC8JeUaDaWLterKWbKi//cc3kQQQVul5qbunVPfc3JaSJej9niKCtx2AldLF2K2JJbbLVZaSuElgyFevNsoE2lC1YHiDX4iLFboJdkAwG0WIOONoLkIEhpgttZruD7vmFOH6LV3I/BDDNXs1ClL37vLH5zCKlOrtwpe/b0ggPm9w1Q5+7aWL4A/xCN/7+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/QzXU1Cut3+xRVDjh7wLgS6/GDH76qIRUETKTBAH1WE=; b=vtUe1wLVfmziw6tZY1FQixBEzsn/Fdg0SWv45eMVlK5/56wkdeXHg8dSJV64EAZmgAP74CrKpnQwnQyL6LSadGovm6dJqq7ppSQXCiqNd6Izo8ziZuQjFjEm/vILOMgdfhUu+vY3FT+9Mv9ZOz95FvrugvcA9b2XUbKbp1CIB/M= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR08MB2645.eurprd08.prod.outlook.com (2603:10a6:6:24::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Mon, 26 Apr 2021 20:46:28 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e%7]) with mapi id 15.20.4065.027; Mon, 26 Apr 2021 20:46:28 +0000 From: Honnappa Nagarahalli To: Stephen Hemminger , Jerin Jacob CC: Kathleen Capella , "thomas@monjalon.net" , "dev@dpdk.org" , Dharmik Thakkar , Ruifeng Wang , "david.marchand@redhat.com" , Bruce Richardson , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , Ferruh Yigit , "Ananyev, Konstantin" , Stephen Hemminger , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] L3fwd mode in testpmd Thread-Index: AdcV2H0Bhkmz7z6QTBeC8FixZy3dngAaQ6AAABIFuOAAAQNCAAAAQNqgA/efEhAAAYi7gAAF6HhgAAl7GoAEe3+OoAB4fPWAABDYiwAABc478A== Date: Mon, 26 Apr 2021 20:46:28 +0000 Message-ID: References: <2273212.ItJIoklBD0@thomas> <20210426104720.2b892045@hermes.local> In-Reply-To: <20210426104720.2b892045@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3494060DF5CB0144A12DDC3E8F2B75A3.0 x-checkrecipientchecked: true Authentication-Results-Original: networkplumber.org; dkim=none (message not signed) header.d=none;networkplumber.org; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: eea61a54-2502-43de-cc97-08d908f46503 x-ms-traffictypediagnostic: DB6PR08MB2645:|VI1PR0802MB2272: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: wxc0Mb4u7I2LHMmVDYSSoNElHYgmKuXeqIXPMaCgxgLhAWJ5wG4keb/GaVw5f/34jqwAcmqROMc6SxIgc1toAqkwd/90qK/KDIyhbYS5zva41ZtJpaAH4Wkp5DErqzPIhHmRhLmtbIYxlehFQ3akJApwhJlLWpHclmV1jKgll1JQEZHNRNiiL6OxWnQSxbyOM1D5yuMBcHBlTiE2tscxmDAGSJw77LyYBYQSdJd7d3y/MzsZFuI13YhaiYHSs5bN564+iWP3s9Dqocjs4A5Wosn5rRpRF9SQ/hGfVbGjHM7/vDujXPKmrblqzOBiwcG8Bg+v2Lqx7wF17ivzE+9xERLJniqciN8DodyWfGHUZsBJYVpvw54/WmgFGK72TNHXVuIXMZhiRgwk6OKAWTzXJ9K4BohSuNtv62F0taTxAN5WswhFfuynLOPvv3kj4EhGW1pccg+bZgETeBWrORKrYNtX2rYjCY5mvKZgZpBOc2/Xujhn/lS5bnsirPd+KPLtrTU5BAitL7buYtYe8uXWktVcHLGJNRwfIKTvpkybiXNnz09qhTpxCKlWJgqdYmsop4/JLRt5AN/Z5M14uWIhb3zAUEvGdE2ZBMQ9tKpUo8m9xDHu7JJwEaRD7f4Egz0CXiK0IxxTt+gtiswYRr6BGbs1/Hep0qd+EKMEbvDt8HaBQy+CBImySZ+diJR+ZOjk8qT+sCQp26E9DE36tlsQYOyX+0N+g1hOJEvIqfbvUm0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(366004)(186003)(2906002)(71200400001)(86362001)(83380400001)(55016002)(33656002)(478600001)(26005)(5660300002)(9686003)(38100700002)(52536014)(7416002)(53546011)(7696005)(64756008)(8936002)(66946007)(66476007)(66556008)(66446008)(8676002)(4326008)(966005)(76116006)(54906003)(6506007)(110136005)(316002)(122000001)(32563001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?r0PtwfzOiJsWvZNzDmqnh54deO1YEYfIwLJpOWzpou9s8Pkky8rWXVPttYZY?= =?us-ascii?Q?d3QbiLHwu4pP0pJPwtnBE1oRZtFIlcMUOXrdk00jMmBpP5zay68QjpIJpHDK?= =?us-ascii?Q?l1gxhNR0CXEgP3vAgDUV4bQA3ClOtu3EtcoFaiEw6kchxHzMadsz9KuDnTYv?= =?us-ascii?Q?9QWch+93lGy42/u0ZbY2ZCX3DuUXuIHxRRr1VVDb9w9mTn37Os5bbHH8PIXv?= =?us-ascii?Q?DglhUIDAk0E0vxq4JrU67zcdon+8ABUlqm9tJr7ffGg2Ru+wpiLzHMS2247a?= =?us-ascii?Q?GL6aqakBNaGBsMhSUxITVAD/CyMn7WjxICcl9MU3JI9s+w26Kv6XsmtPUSOy?= =?us-ascii?Q?Mq1cZN5dqv0SHijeu4xykExgQuqNNMFpHiiF+uF3qKLR/xT6oDroY095C0cD?= =?us-ascii?Q?jcv0c3U9qTfPJ6MUQN6AuGWJGSii6zEEGu++HNHz1ZIf+pQyD7bohRWjQYM5?= =?us-ascii?Q?wgLGvsvxmcKNZwxW5sslRl1A/pCP/bF/6B+tpQUj/6l8zCrwgQMPj0hdKhI9?= =?us-ascii?Q?YgN01KyKKHECkAwXSMspCkdZS90G3qUF4rsHkUzwS7sn7YmLIJQMqKw+uXnO?= =?us-ascii?Q?cPg58G3oeJ3oyk5VbEUVVbDU4DwFXtddBop1zva1M7o8VfSzFvFbq3z1SUYp?= =?us-ascii?Q?H0Ip++RURa0SMnUq+SqHWbfCrqwzHceEGNyTcMSHXd4F4dzbLHK+jDeUW22T?= =?us-ascii?Q?Z1GcEi2X+Ev1wC+fGbJp5rBmgNciIE+O8KOXx++tXKVOrHqKtmyM276W/Nul?= =?us-ascii?Q?Ut9COjOnRvhrmCvAEoaiGp5/BsTqlc86HzuTvR03UvKciR13V7tDiVz9z/Jr?= =?us-ascii?Q?bLcxGm6kTCaZA9F0dNBZcuNB2IiA5CXCp7TBkzEaqpzIAscE0f8FVPV02fDi?= =?us-ascii?Q?lu+as0yyKviAxwOMnP9fmMeGsyjulDl5rJBhZiUfpagU6pR9V48034MTIu2i?= =?us-ascii?Q?kTcMq35G9ZqTQpTzDAkxZEZJAMGR4tVerm/FgyM+B3XOlL7S2cy9kSvx7JMr?= =?us-ascii?Q?A3YAB1TWQs8jHH5mjiNiOb956c186FyczCsmqJ8qKISbBOb4yZyJeBL6sjWj?= =?us-ascii?Q?P4HfeNUQtjvSeHQTnnaOii1TndoUcyTHrCUhlwX+vRuDQU6kig9caTVALKtA?= =?us-ascii?Q?NDHfZZKI1dXfB6xb/vN0UO4JxJnB8+K/BpYA3+IJ/q3CyONX3GOE0a76x7hc?= =?us-ascii?Q?hBvQYqsDzEvd3BXuQ1XSO4ECdj1VcfPzby6mGICvZ/XfXeF2WRQdBqF+4Aog?= =?us-ascii?Q?fxzIZ3+jUeCkXia8csMDSboOm3UTPbk0X4NnfFymQzxR/DmgD39y+n2mlzYT?= =?us-ascii?Q?S1Tj8gqI8n3PJoK96bho7GDH?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2645 Original-Authentication-Results: networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 253605df-82b7-4d24-96b0-08d908f45d8f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v8kffPdvYGT1J/ybkfCRTenBKuBn2w+L+Momzg2ePVHBFD+ovbpIHkOs6iDvCCvGOOIQTa/g7gw/sQaVizA/HbokZtwCqzkmiNDTEbl/St0iHuzDfbs29b7ftBfBFpGYLFr71/khPo2FAabhRQBat8StND2n5ue0b62pPV1mTx2tWty6x+BKm773Tx4iIbOEWOS0JiL8Rm8bTysJ6D4grSqKEZ51ZJrJ4trDd9rKqsOZApR5csU4muSgBKJIAQjw8l+ASgblviehy/yqnYlmHZExoJjopuhk4TSTn5lOd1RLG3lkIOSEl+RLihct1ccRjBIGEorTY76A5ul3ITpmUWJjhzysW2ilta8D1r1LjWzURfoce3wRgj0YLs0O40ps9eIK57Q3hsHPzRlOOea+SsDgkPSPazZ9yGupYWk7PnHurVoWm97cou6m/plgBcoXuGokD/XAatNXaAIiXFMt86+u6epXbOsD50ejZDsf7dc/QumR0c49jt/beuLr+lc+7luH41OMwPqQQRUi/JrLw9KbLeFYgGaEkphQyIdFpMZKZ69YA0VSCHD+RMTAXkA99bBnvNo3rt1S8/FXcj7UaKEXaya7nF5KFoHr+dmcQJYVsTN5RgEGQ6HGKuR0RcJ7a1ReAiqdeL3xNIHVEZ+I4ExrQ68fPEJpEruzOhhrwiRheikqPd3Dkoft+OBIx5FbO6NoY3CZBkJgVrBRZYFMWbcI3z9AmKWyks1feIqMxlwC+WmZSilSbHmy67XYUZyUJNbojz4NoRz2OBUAekYYz1vavNhycxYhc14AbwQPH94= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(376002)(346002)(46966006)(36840700001)(186003)(47076005)(82740400003)(316002)(7696005)(6506007)(81166007)(70206006)(26005)(86362001)(966005)(2906002)(53546011)(8936002)(52536014)(34020700004)(82310400003)(336012)(110136005)(36860700001)(70586007)(54906003)(33656002)(356005)(83380400001)(9686003)(55016002)(478600001)(5660300002)(4326008)(8676002)(32563001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2021 20:46:40.9346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eea61a54-2502-43de-cc97-08d908f46503 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2272 Subject: Re: [dpdk-dev] L3fwd mode in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > > > > > On Thu, Mar 11, 2021 at 12:01 AM Honnappa > > > > > > > > > > > Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hello, > > > > > > > > > > > > Performance of L3fwd example application > > > > > > > > > > > > is one of the key > > > > > > > > > > > benchmarks in DPDK. However, the application does > > > > > > > > > > > not have many debugging statistics to understand the > > > > > > > > > > > performance issues. We have added L3fwd as another > > > > > > > > > > > mode/stream to testpmd which provides > > > > > > > > > enough > > > > > > > > > > > statistics at various levels. This has allowed us to > > > > > > > > > > > debug the performance issues effectively. > > > > > > > > > > > > > > > > > > > > > > > > There is more work to be done to get it to > > > > > > > > > > > > upstreamable state. I am > > > > > > > > > > > wondering if such a patch is helpful for others and > > > > > > > > > > > if the community would be interested in taking a > > > > > > > > > > > look. Please let me know > > > > > > > > what you think. > > > > > > > > > > > > > > > > > > > > > > We are using app/proc-info/ to attach and analyze > > > > > > > > > > > the > > > > performance. > > > > > > > > > > > That helps to analyze the unmodified application. I > > > > > > > > > > > think, if something is missing in proc-info app, in > > > > > > > > > > > my opinion it is better to enhance proc-info so that > > > > > > > > > > > it can help other third-party > > > > > > applications. > > > > > > > > > > > > > > > > > > > > > > Just my 2c. > > > > > > > > > > Thanks Jerin. We will explore that. > > > > > > > > > > > > > > > > > > I agree it is dangerous to rely too much on testpmd for > everything. > > > > > > > > > Please tell us what in testpmd could be useful out of it. > > > > > > > > > > > > > > > > > Things that are very helpful in testpmd are: 1) HW > > > > > > > > statistics from the NIC 2) Forwarding stats 3) Burst stats > > > > > > > > (indication of headroom > > > > > > > > availability) 4) Easy to set parameters like RX and TX > > > > > > > > queue depths (among others) without having to recompile. > > > > > > > > > > > > > > [Kathleen Capella] > > > > > > > Thank you for the suggestion of app/proc-info. I've tried it > > > > > > > out with l3fwd and see that it does have the HW stats from > > > > > > > the NIC and the forwarding > > > > > > stats. > > > > > > > However, it does not have the burst stats testpmd offers, > > > > > > > nor the > > > > > > > > > > > > One option to see such level of debugging would be to have > > > > > > - Create a memzone in the primary process > > > > > > - Application under test can update the stats in memzone based > > > > > > on the code flow > > > > > > - proc-info can read the counters updated by application under > > > > > > test using the memzone object got through > rte_memzone_lookup() > > > > > Agreed. Currently, using app/proc-info does not provide this > > > > > ability. We > > > > cannot add this capability to app/proc-info as these stats would > > > > be specific to L3fwd application. > > > > > > > > I meant creating generic counter-read/write infra via memzone to > > > > not make it as l3fwd specific. > > > Currently, app/proc-info is able to print the stats as they are stand= ardized > via the API. But for statistics that are generated in the application, th= ey are > very specific to that application. For ex: burst stats in testpmd are ver= y > specific to it and another application might implement the same in a very > different manner. > > > > > > In needs to be something like the app/proc-info just needs to be a du= mb > displaying utility and the application has to do all the heavy lifting of= copying > the exact display strings to the memory. > > > > Yes. > > > > > > > > > > > > > > > > > Another approach will be using rte_trace()[1] for > > > > > > debugging/tracing by adding tracepoints in l3fwd for such event= s. > > > > > > It has a timestamp and the trace format is opensource trace > > > > > > format(CTF(Common trace format)), so that we can use post > > > > > > posting tools to analyze. > > > > > > [1] > > > > > > https://doc.dpdk.org/guides/prog_guide/trace_lib.html > > > > > This is good for analyzing an incident. I think it is an > > > > > overhead for > > > > development purposes. > > > > > > > > Consider if one wants to add burst stats, one can add stats > > > > increment under RTE_TRACE_POINT_FP, it will be emitted whenever > > > > code flow through that path. Set of events of can be viewed in > > > > trace viewer[1]. Would that be enough? > > > > Adding traces to l3fwd can be upstreamed as it is useful for > > > > others for debugging. > > > > > > > > [1] > > > > https://github.com/jerinjacobk/share/blob/master/dpdk_trace.JPG > > > This needs post processing of the trace info to derive the informatio= n, is it > correct? For ex: for burst stats, there will be several traces generated > collecting the number of packets returned by rte_eth_rx_burst which needs > to be post processed. > > > > Or You can have an additional variable to acculate it. > > > > > Also, adding traces is equivalent to adding statistics in L3fwd. > > > > Yes. > > > > If the sole purpose only stats then it is better to add status in > > l3fwd without performance impact. I thought some thing else. > > > > > > > > > > > > > > > > > > ability to easily change parameters without having to > > > > > > > recompile, which helps reduce debugging time significantly. > > > We will not be able to fix this above issue. > > > > It depends on what you want to debug. Trace can be disabled at runtime. >=20 >=20 > DPDK has existing API's for application metrics but they are rarely used. >=20 > Why not implement rte_metrics in l3fwd and proc-info? This discussion has ended up as a stats discussion. But, we also need to be= able to change the configurable parameters easily. If we implement the stats and ability to change the configurable parameters= , then it is essentially bringing in some of the capabilities from testpmd = to the sample application. I think that will result in lot more code in the= sample application and will make it complicated. Instead our proposal is to take L3fwd to testpmd and use all the infra code= that testpmd provides. We see that this approach results in less amount of= code added to DPDK overall.