From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 236C0A00C2; Sun, 30 Oct 2022 23:51:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A732E42B7A; Sun, 30 Oct 2022 23:51:06 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by mails.dpdk.org (Postfix) with ESMTP id 0D34140693; Sun, 30 Oct 2022 23:51:04 +0100 (CET) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LQG5IgHA53gM5UXl+plot8Yd5s3FxGDRiJ2VvWV0VKoYV7aQRAMyrE4mK969Va75+YgF1PP6v7YSx0lgZ29EIXeyOBqxJiIlvgX08rUzGn+YG0uh6UNfAZnOLwe1U9NFuLI2xetvPFK1keCd63cI5txlSuLdEQBVaGh0WgZlzmZ3UJFTv69nKCZTCoDUqTOc+PGJHSawIiED9JKqu4kEz0/hZrNTqDseMKu6lgNSfiuPxNiG4B8YC04MqNxF+5HDI4ckQT5qh6bRUXYPXWW2OXBtVTp+HgZAqWn7AQFRStOaFWQcD49wJzkhR9FV2Du3WxFdI4O8EuaODomwyLXB3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Yd9/gKolgaNhMhPuwS6vKWtd/rliTqoy6XNgBcCQUk=; b=nAdVBJaUQp2uqji8xVLR39uUgrLKQl3VeemrtHUwXiWfEOPyhS0BN/jGL17pSLZcSmh3w8o/OcyweoZc19uGjgvFMjzlwQ0TQUatYa1tKwC977Gh5NxYDn41gFyhvyiNOUz6mvIzYsZcUBazTpa6xhRzqkrtJbiD702BVzO9dy+YHZgkNjv1gOAYsLba+QnloGDDaU53WTkd6JkidgQ4yIjOzWZauRVboBse0I4PgjcrlGoPyyVe3bgt6Oyn9EAIRmIyakptvD52OGxM5B77Lls4SdmXdPtA59grLGdXwinkjk2vVy9uIg6AAoCUO0kruZpSRJOG1V6KhuKs5VLkmw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Yd9/gKolgaNhMhPuwS6vKWtd/rliTqoy6XNgBcCQUk=; b=v+D+c/p56NTx4qAI/qTjARotRKQ0DpmU9btZxsZPXCYSsx9TaQIYxnW43X+0Xv9J7BKZwtl/Moag44tKE2zkS9LmXVJXIMZ3ZC2gTT3Q3OS0qfaw+Cn650ZVTmJrhPNHgyPmNR9ykePEwfkBd0zvddA9wM/Z/1uuuxU/YvkieHo= Received: from DU2PR04CA0318.eurprd04.prod.outlook.com (2603:10a6:10:2b5::23) by PAVPR08MB9307.eurprd08.prod.outlook.com (2603:10a6:102:304::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16; Sun, 30 Oct 2022 22:51:02 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::4e) by DU2PR04CA0318.outlook.office365.com (2603:10a6:10:2b5::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.16 via Frontend Transport; Sun, 30 Oct 2022 22:51:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.14 via Frontend Transport; Sun, 30 Oct 2022 22:51:02 +0000 Received: ("Tessian outbound aeae1c7b66fd:v130"); Sun, 30 Oct 2022 22:51:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 35aa3b42b1858232 X-CR-MTA-TID: 64aa7808 Received: from 3fe0cd9b7e93.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id AEA259F8-9E73-4C6C-8AF6-1174833B5882.1; Sun, 30 Oct 2022 22:51:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3fe0cd9b7e93.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 30 Oct 2022 22:51:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n6+e/bOJ+EzZOW2xckmqcgGNfEFRq/o2/Nr/FALy/1W08fEsG5x9W95FyptK367xTVqO9VYosGeranu1HyciQK8tGPG0AVnVd1F1kM3jJh2JVJ3b6S4vdjY4JEiJe4MXzsl5hbJrfQofZ1sS8hD+hDnrVTzHqG/JFnbxEd/UknX3MS+n5kIcx73KBc/7otl5btrGOcxAL6kAERFGHaob72B7gJHkCbEvQuQcvsS2UL5hLdkfIj2JxCAJ6unZElNsNxRk0oRb9mwzsFeU/PZMDU2HSxNW+mNIABS8l899RG1SrQ26bqT5o83ZhWnr61TcV1qrrQkA0TLFEYrQP81MbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Yd9/gKolgaNhMhPuwS6vKWtd/rliTqoy6XNgBcCQUk=; b=IcBVUNRyY3e+ENJbw3+L37zyuNHyTdIXm6+UjA9EMy1cpShuf+8MPW4zZVVgwGD/gfrp2FzWeEJcW7p29GFLkuumNISmrSdp09gsPFSCfNfJsFBpIHQijIt7h00IGsvFAo70jIHhXqwhnmKdsdx3ktbwsOcwZgoFHin5L/RGsFHfSIqNk3csPI5HV5U3MU4XsMCGXfxvlYOgCu+Qr6lGr6uwfHkbarJtZYzeSAeIV///cM48Oa74SC7ZGDcIpFcDfUsMO537CloAFkFTAwLDG6ZZQLDi2ppHMY34tmCoEFoZBNoq3zPVjduSlznnVNNu1SWhZb/S3YmNWw6tCi3nUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Yd9/gKolgaNhMhPuwS6vKWtd/rliTqoy6XNgBcCQUk=; b=v+D+c/p56NTx4qAI/qTjARotRKQ0DpmU9btZxsZPXCYSsx9TaQIYxnW43X+0Xv9J7BKZwtl/Moag44tKE2zkS9LmXVJXIMZ3ZC2gTT3Q3OS0qfaw+Cn650ZVTmJrhPNHgyPmNR9ykePEwfkBd0zvddA9wM/Z/1uuuxU/YvkieHo= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DU0PR08MB8729.eurprd08.prod.outlook.com (2603:10a6:10:403::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Sun, 30 Oct 2022 22:50:53 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::3fb6:b7b2:1e8d:11d6]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::3fb6:b7b2:1e8d:11d6%9]) with mapi id 15.20.5769.018; Sun, 30 Oct 2022 22:50:52 +0000 From: Honnappa Nagarahalli To: =?iso-8859-1?Q?Morten_Br=F8rup?= , Yuying Zhang , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang CC: Olivier Matz , "dev@dpdk.org" , "thomas@monjalon.net" , Andrew Rybchenko , Feifei Wang , Ruifeng Wang , nd , "techboard@dpdk.org" , Kamalakshitha Aligeri , nd Subject: RE: Copy-pasted code should be updated Thread-Topic: Copy-pasted code should be updated Thread-Index: AdjbWGfEPxN9xhyUTWC3ksfvr03I7QCTnycAAAT1IAADn/BtYAAd3f8g Date: Sun, 30 Oct 2022 22:50:52 +0000 Message-ID: References: <98CBD80474FA8B44BF855DF32C47DC35D86DB2@smartserver.smartshare.dk> <20221007104450.2567961-1-andrew.rybchenko@oktetlabs.ru> <4406925.8F6SAcFxjW@thomas> <98CBD80474FA8B44BF855DF32C47DC35D873D2@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D87461@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87461@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0F02B3DB1AB1204597160ADD2CC2C783.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|DU0PR08MB8729:EE_|DBAEUR03FT025:EE_|PAVPR08MB9307:EE_ X-MS-Office365-Filtering-Correlation-Id: cc9385c7-c22f-4fcb-4709-08dabac9383c x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qXJsOd5pesJL67b5JNkP9GU0ouzo6ufvWUwtxMwUOYnBwv3kwIsKIp7JlFrwoopONm+XeFtLQPjdSQkLasNQpU03jXhWzqPhYd3rJqxznL8XSYjhObooz8samKP2/ECzyNVMKOkDZZdET19WjtrMCoh8Aa0CUgNRhyy14p6JUSsvnO89BbzjHXIeMTNlrG3j2DbMgl8owULQMpRFZD/MX01QOxPRH0xJSOqPY5H49WQigD7oULZGP7fXT4ebCRy5b2Q4QAEA075u5HMdC5bHt1z8AN+8uu9E3XfUH2GofxTc3oMKyoRxnFWoheGuleezPqZX5bV5FoKUQbQ73JWht9Cg7zFqcd9aXWXO/9nWkXnl0KzHNp/gAL9bKRl+IPFDc59fwBF8Ghmdpwe1qCd4/o6FbMhdE/DHp1nP39Ph6JI+WSrdKP9Fjlmrenn9kkosqh/dzmSOjkK02xHYuQUaTB829bCZLYOhI298tZ96cvKfGYSmG9pTlKPEHrEmn1+UGwOso/u+kqvrRuXd53t/uPpLUdt6MVHdnAnTLsBi9sOrH2jfMkPzcd9/AdYJkqM7VTPPtTThMtL4tx+Q/GjTZ5Dcknh5GVkF1Vqz/Csh7Pgp7g+mefGTXmbBpoaRj14P8qldPMpffmkM0hpGrrbZRVDUkcikVzwdOQ4WNukZmfNz7Ndt8O+yeqSoDC5bGujnW4PsxnGsNxP3uMOdAHnyrjA05Wp4hc9XQvS66wiWvhBARjpeUSzsFFu3McbJUN3ADlck0zfSIYfb4+hYh7O5k5igLpgC0TH9879X+Ybw7SWP0wrynkO28aoFWTFkSrCIRUcXBUmMj+PLcrv8Jw9OXA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(346002)(366004)(39860400002)(396003)(136003)(451199015)(38070700005)(52536014)(26005)(9686003)(41300700001)(2906002)(15650500001)(8936002)(83380400001)(5660300002)(7416002)(186003)(38100700002)(122000001)(66556008)(55016003)(966005)(478600001)(71200400001)(8676002)(64756008)(66446008)(6506007)(86362001)(66946007)(76116006)(66476007)(4326008)(7696005)(33656002)(110136005)(316002)(54906003); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8729 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 24d069a2-eac8-490c-a182-08dabac9326b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FKG0TTxLg2+EhA542oqYXIbwzv6Oj+HuSs2d4N30QaIukpdiAYKrgx8CsAZ40RlDQUP5187vi0xu8iEtR02Ti0TLhS/LEUP+i640OmgeEi/xPu/4vlgdN4oESKD55TWQ6iGUSG/LsyEFm6FStdSMLFv9NW2AFEuuGT0LPpNhJM/tv3JbulPh4Fp5N7LBtGFpKaV/TPypj56xx9EUHMzvP9uL4Nsc1Vlt63j+sywJSPF9TJpCiSdJOS9n1zM1jDJTfkeHoRSo3L3LgqyW/6MX4cuMikLqh8097mmoPRtS5TE0PYGc4tzwahp9GqgsZYsBsfl4q1xIYkHYXt3o69XiMJvxLF5PJnX7sP19gPTkOI2Z4nxbcbRGqcXkKdZ8W338lTezb7cXPN0hplHxQV5eYybtw2z9OpQe+TpuvFHpH7KFeSZC/ihL90a0FFVa8CqQQ9ww6hRV3Tlx9GeiTgbfeQf63SYXleFWYNMyoX3vvBCOzQdykEDPM8gLlV3MvCwYX9RTkD4tmjaJq8/OTSkA3gvG4Yor9tknmGsjbSXnCx3p7WZYlF15jnuUNwCvVqocXTm7gsBVADFXmwDTwSu/camdPmElrXwjmJmhG9NIbjapzFneOpbNZZ98zDOlxO0mp0mrm5lBgTcrsg6U1CgQR82FgDMIoh7i7+xSJU+eTHmLXPIzzVZpdEXAM5UHYId3nOnYDG3DdNn4SLeQcxFP9W+y9rvAJnr6qJGUQrB8TOIyF+QNaxT318K7PzB9Fi/7JuNJSJLVjIxVLgQZ7+LgZP159piSQceot4PUyrXyg1tsZvM7gftbj2fTU82hiTFd X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(376002)(136003)(346002)(396003)(451199015)(36840700001)(46966006)(36860700001)(26005)(316002)(9686003)(478600001)(186003)(336012)(47076005)(966005)(6506007)(7696005)(54906003)(110136005)(82310400005)(81166007)(356005)(33656002)(82740400003)(86362001)(83380400001)(55016003)(40480700001)(2906002)(15650500001)(70586007)(70206006)(4326008)(8676002)(450100002)(5660300002)(52536014)(8936002)(41300700001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2022 22:51:02.0701 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cc9385c7-c22f-4fcb-4709-08dabac9383c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9307 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > > > > Dear Intel PMD maintainers (CC: techboard), > > > > > > I strongly recommend that you update the code you copy-pasted from > > the > > > mempool library to your PMDs, so they reflect the new and improved > > > mempool cache behavior [1]. When choosing to copy-paste code from a > > core > > > library, you should feel obliged to keep your copied code matching > > the source > > > code you copied it from! > > > > > > Also, as reported in bug #1052, you forgot to copy-paste the > > instrumentation, > > > thereby 1. making the mempool debug statistics invalid and 2. > > omitting the > > > mempool accesses from the trace when using your PMDs. :-( > > We are working on mempool APIs to expose the per core cache memory to > > PMD so that the buffers can be copied directly. We are planning to fix > > this duplication as part of that. >=20 > Is the copy-paste bug fix going to make it for 22.11? It will not make it to 22.11. It is targeted for 23.02. >=20 > Otherwise, these PMDs are managing the mempool cache differently than > the mempool library does. (And the mempool library instrumentation will > remain partially bypassed for these PMDs.) This should be mentioned as a > know bug in the release notes. Agree >=20 > > > > > > > > Alternatively, just remove the copy-pasted code and use the mempool > > > library's API instead. ;-) > > > > > > The direct re-arm code also contains copy-pasted mempool cache > > handling > > > code - which was accepted with the argument that the same code was > > > already copy-pasted elsewhere. I don't know if the direct re-arm > > > code > > also > > > needs updating... Authors of that patch (CC to this email), please > > coordinate > > > with the PMD maintainers. > > Direct-rearm patch is not accepted yet. > > > > > > > > PS: As noted in the 22.11-rc1 release notes, more changes to the > > mempool > > > library [2] may be coming. > > > > > > [1]: > > > > https://patches.dpdk.org/project/dpdk/patch/20221007104450.2567961-1 > > > - > > > andrew.rybchenko@oktetlabs.ru/ > > > > > > [2]: https://patches.dpdk.org/project/dpdk/list/?series=3D25063 > > > > > > -Morten > >