From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74247A0546; Thu, 29 Apr 2021 23:10:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BAD2410DD; Thu, 29 Apr 2021 23:10:15 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00042.outbound.protection.outlook.com [40.107.0.42]) by mails.dpdk.org (Postfix) with ESMTP id 61865410D7 for ; Thu, 29 Apr 2021 23:10:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mzgYN6PuJ30SK2/uUSDxjfDNZM6OvV6blEAma1NeqZk=; b=bkz8gfwuAmnuzmLebOCRoj5u3tQ1bjUozZgYQrEZ0KLfDcZ5uiHRegWkwcsVWAhZnjapSbpbrEer+4DI0PCQRjkDlrETqT7/mY1rAMX3S8/Z3hbufRtYP/6LRiC1iC1FXeTc41HRsdiEqSnaYNVMtxpSuedYWFlTi5BwRD+GNoY= Received: from DB8PR03CA0024.eurprd03.prod.outlook.com (2603:10a6:10:be::37) by HE1PR0801MB1899.eurprd08.prod.outlook.com (2603:10a6:3:4e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.24; Thu, 29 Apr 2021 21:10:12 +0000 Received: from DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::fd) by DB8PR03CA0024.outlook.office365.com (2603:10a6:10:be::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 21:10:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT063.mail.protection.outlook.com (10.152.20.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Thu, 29 Apr 2021 21:10:12 +0000 Received: ("Tessian outbound e566ed09e411:v91"); Thu, 29 Apr 2021 21:10:12 +0000 X-CR-MTA-TID: 64aa7808 Received: from 5ed2c9ec4ef8.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D050D74E-A7D9-48D2-BE17-D132C25566E1.1; Thu, 29 Apr 2021 21:10:07 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5ed2c9ec4ef8.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Apr 2021 21:10:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GATuuvFc9wpUnO0ZPoafHbexaEZ4GHjbKyTph/coNLN+MYfZ7oK6HlANu+iAO+uxSuDA7alkkQyo2qAyOZtpdOMzkf7ARPVP7jwLyCoLM4zALLgXRcOb4m7YLWlaiIkPbaGdQL1Uz395jWo1wyogwpROtIC2O+/NdDdv9zcGAQ1CL2/IdmQ297XfZiG5pwwX1ZwRnOufdEH71pcx5WvpDHI/l6s/HvYDmV+2Gjwjx92m7T0DYaUTJ/Y75y3K7U8xfTedWdrdyGUSbAbWx2OiP9xkKv//xgK5oRaS3dbnp2fdyB9ayrQYgYGyoSL+aQMIce5jHuIQ2t9gWj6KtgP6fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mzgYN6PuJ30SK2/uUSDxjfDNZM6OvV6blEAma1NeqZk=; b=galSRZxsqhxf8xkcXDuxZI3wm1yoTRdPMiwIDnqWp16iWGTAlLRpSdQdgHWBRfEkTUdkQOBCWLL39nhHNnlMe4QHkM6VvIXi6JGUrWHnEUBDLJJLgLuEU6kDvVZXEwHVg53I4ozlWaE3ss7R/1vr29+MWl8rCtnhlSeBKM9r2CZGrSOi3Dc2kSfTy48bQHFi4bV1tECuyUtJd0V5c535y+fCjBE2P8kVPgq7t4r1z5dxEL+co6HNRVbWuPiGzuLeWuu3HzeZ0+stSg3qfjb/V3zx0zWRNQdiyIjA5TnHWsiNpTURAa5DSP7i/kgSNo/LJvrFBabPd9xd4CUwimXk8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mzgYN6PuJ30SK2/uUSDxjfDNZM6OvV6blEAma1NeqZk=; b=bkz8gfwuAmnuzmLebOCRoj5u3tQ1bjUozZgYQrEZ0KLfDcZ5uiHRegWkwcsVWAhZnjapSbpbrEer+4DI0PCQRjkDlrETqT7/mY1rAMX3S8/Z3hbufRtYP/6LRiC1iC1FXeTc41HRsdiEqSnaYNVMtxpSuedYWFlTi5BwRD+GNoY= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB9PR08MB6892.eurprd08.prod.outlook.com (2603:10a6:10:2a7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Thu, 29 Apr 2021 21:10:05 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e%7]) with mapi id 15.20.4065.027; Thu, 29 Apr 2021 21:10:05 +0000 From: Honnappa Nagarahalli To: Tyler Retzlaff CC: Joyce Kong , "thomas@monjalon.net" , "david.marchand@redhat.com" , Ruifeng Wang , "dev@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync Thread-Index: AQHXPSpyd3IqPWgjJ0i2SYRXyHCPu6rL3LsQgAAHgwCAABMUcA== Date: Thu, 29 Apr 2021 21:10:04 +0000 Message-ID: References: <20210421071733.17794-1-joyce.kong@arm.com> <20210429190358.GG21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20210429193854.GH21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20210429193854.GH21799@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 8D009786E84CD14AA0D52DBAE2841A77.0 x-checkrecipientchecked: true Authentication-Results-Original: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 7f398f50-b84c-4d83-9022-08d90b532db2 x-ms-traffictypediagnostic: DB9PR08MB6892:|HE1PR0801MB1899: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: z5HKc3RoRtqXQC74TzKG5MfzCYTtLb6qWQ/kD6w4uWbktpEjZEvj2l5uROT5joFFpQQ+Wi3C0iqTnH4fdlA/HZXDNNWCRlTX0y5vatuLuhDWUXJAJX4hq/TQY5B+deCLa7rgjdhH95XRWXREGKuW2Jr6sqahYGuyxKisHzpftNYv2BEQxgbKFAfzqnOIyUQ91foThMqSMc28ViDRWur+9RsckxFYnT4t/zsnXFemAXQx61gzuOFzzTW/Tn4Xzc3ILswcMZpf+Kogzz/ZoqqMgkUXZ32/Cf73LV9RxtVH0m1OYs95tQ8esfDvjhW+XDRDPy89iYW8E/eiD9Jr0lcjcUy5PzJM166rHf3W1AsLho89K86pz7pfNPmZ4MhnVsaW8NKagCeejU5dC/fZnrg6RlIgVFyZja/2Iqw4WC5SK5vpJvm7CZCeiwCsFrahOgGlooj3qeRomyEYpXQjxaoGbb5XGSf8NFCSjcBhmovHKyvw1ZqkOiTpRkt47xRG+vMyGzmBLlY1pnc5XYpBBiJM4GC4I0AzJzAqIQTDEluTw6t4PS5gt0KGy0/29AmpOKZgEsNAsBlrrPohXlM0HP/NohnG9QmvMwio/NRYHHHf+OLeV7BtRsD7nuhYBGHLQCm+zyaotJ5gZrDA6SqNLY7VtvLKHFMOiKakq1OL/q28xmChjExYBHU0oo0Rwo+4YQ4F X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(376002)(396003)(366004)(39850400004)(54906003)(966005)(316002)(66476007)(66556008)(6506007)(66446008)(71200400001)(52536014)(5660300002)(64756008)(66946007)(86362001)(478600001)(6916009)(76116006)(8676002)(122000001)(2906002)(4326008)(7696005)(8936002)(83380400001)(33656002)(186003)(38100700002)(55016002)(9686003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Qm9wNevBRB1IcYECvTGCzwJ944uh28g8axw7ysnxOMkC6dFivj2dBs/y02vW?= =?us-ascii?Q?CbE5d67meGAmCOq+58nJ5tJLbDRNvx3cEClkpD6jrb1lf+IxPL87FEp+L/u3?= =?us-ascii?Q?ZQYrYVo8aaKn55ire+zN6KldjdZAWvXbF77C+YxLuOefu/ZB12VrgI69T0yC?= =?us-ascii?Q?XhCTXemp5cNQ70ocVLeVZQVf83Z9wWOJYTmEgrAFkpCgT94LsY3gkk3hLuXm?= =?us-ascii?Q?VySWfscIbokAbwM2OEJnrjMynVjbn1ICABHqpO6f/4EWwn6iIx1DdD6ikyVQ?= =?us-ascii?Q?7V6Be7KXpIvmlWY+NgaDfEjo2RRf38Y/kJHwVNOzvZFcYNHiKVvG99w3w682?= =?us-ascii?Q?IwFmBzl8HOUECBbG0CDtcQCxLS3UReMcbVjSBaQvtYa5UMcbfg+1SZDKa8aL?= =?us-ascii?Q?ckePreJCC9im/ez3tJ6wSHU3eQt8MsdCs2xLYBB9kOHU9LhBl9OrGW42Zon7?= =?us-ascii?Q?aiED3Av4fXSEa8pTfWK8xfSL90bdgBWKw9itSALuoyZa6mbf6gVIu6AB5qiC?= =?us-ascii?Q?AqvmXY58VNnpYRfTodgFRHLGPfEqCL0ZDYB0omSoY/a0g745jRW9BvcUhkmU?= =?us-ascii?Q?0Ztf4+kUhkHLo6gjKcQisovAGBGKoCGnTJkZvYdTgNTdANu27YLhxtjU0fb0?= =?us-ascii?Q?tqw9hPE6yGQ4W0OtJyHKoghUxL/t2uUh2SEDS5kTIFdtVbBxTuTRLQwwIlvN?= =?us-ascii?Q?a2Fn3PJ/h6vfUmZmrcjkK0I4Caldr/AhNERvOFtxevJrkMVm2EH9GAArKXsZ?= =?us-ascii?Q?1lHMR9KqZ29Lo13pBvom5lxCHRTHatVnGJH3XaPfMBoBRsrNxvi+HWSod0NR?= =?us-ascii?Q?URfzCzl+NS0EqXDs//lJuGwY5xwaH58SDcySwxFG+pqhN1ACCdL8hujKFlmg?= =?us-ascii?Q?13L5TSozlOKpsBzIE+DYkeRJJILcZWIt1QyWixv1Qs/IaYTxNqhQms+AwJk8?= =?us-ascii?Q?G7x8kd5dovnYautRL0l8GG7Li5JT7FuyeYC4s84cRg3c9K0TJImPySGo9kTd?= =?us-ascii?Q?KJFZQ7HWkjf9ImGKjuoIlrRESiT/yP6ZHstFustXOik4c/zh5r6rXPCgaLIl?= =?us-ascii?Q?pp7td4Tl1ySZCZhn3bGRjLFxXhdvw3QZ4NEQNHjDX7Mj4ZuqZBaqF4vPpxmm?= =?us-ascii?Q?UVWi+7f4qipx+nkxw6F4xiemTEdaXlL/a0dgEljKlT5bMYblCGPQYkPZPR+H?= =?us-ascii?Q?28OLUM3ri4riCt+JBV85ZEYG6zzt2lK0LOGOhK/F9o5hhvJO7YpkW9CFLdnN?= =?us-ascii?Q?LoQmcEgZFUfusZA2uIy7ihZCU2wtEC70ezN6bLlnje0HyFvc6P42s9lnpagL?= =?us-ascii?Q?u2HLREjmCN5xSAcv78Df20w8?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6892 Original-Authentication-Results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a3f4f3f-c6dc-4273-6462-08d90b532928 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n5CZSQqmDt1hgSvXuGsH4Pit7DsuTBSTpHzZVDr6TjgzsGedvFG5vU3y2Lon7gNcz+SD9Zbo7djMDwxrnFy419iperappcjyAZ0DTl3OvPaX2G1BHrLr3dSp9HwuJPGmF3qqN+a8oaAIVyYXffA6ZGXWmEDaUj4SS5GLhb7orddbJtholf4HVnpdomfW2gv84pJ1Lht5q4MD9a2EdbYopQ6vFKYSWSIdA09VGrO0dvFQDqmfxNTpdLyqwhxYzmXnT3VjyVxo2kH+ONEkdh8Ot1cwuxVH6NKIa69J/xstA4ma/SaxIL9jrOr+aSM4S4OESQCcrriezFgFR9u+Cu6oOxO4xaig56z01PzANM43wtHKjHoLUT4+55X9PSki7Dj5Y9p4AppgNMR75XezHkaoFWvki8rl0BAunMtFouIZp+XJCe2mDH8tHBnAPVlJBVtmM/MRY4nXMY1DtYHsudi7gZ1sC4wgFjUZBB1OeH86kp09sufGvJ/F3pCxMJaaWoCCRGm1LzbuI/mBCQoSEJQbegru4rreFAv+y4ZUmQDg5AIc5sxfcXLty64njr/3tUrSpaYDQHwPl48D7MpoiDe8GJqh/igOIxcfwG42SeI/2oHCEL0tr6bvU2YaSgYI6XTuJYbZfVMQdU4yUGeAaJBrSG5v4jRkst28SMk7KjFrsIaVMaWbxWuWOK5YA8HCBFc8CUpvoygX08ywu0q8br7YJh88Vx25CQ8DqyTKe7Zz6Z7aVxAZEew9c38p9as64kEZH9hXdn9AgzXXtmIxfOiDEw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(396003)(39850400004)(36840700001)(46966006)(47076005)(83380400001)(34020700004)(2906002)(36860700001)(966005)(26005)(82310400003)(81166007)(82740400003)(55016002)(5660300002)(4326008)(33656002)(52536014)(7696005)(8936002)(336012)(6506007)(54906003)(9686003)(86362001)(186003)(356005)(316002)(478600001)(70586007)(8676002)(70206006)(6862004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Apr 2021 21:10:12.6374 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7f398f50-b84c-4d83-9022-08d90b532db2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1899 Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic builtins for lcores sync X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > Subject: Re: [dpdk-dev] [PATCH v1] test/ticketlock: use C11 atomic > > > builtins for lcores sync > > > > > > On Wed, Apr 21, 2021 at 02:17:33AM -0500, Joyce Kong wrote: > > > > Convert rte_atomic usages to C11 atomic builtins for lcores sync > > > > in ticketlock testcases. > > > > > > gcc atomic builtins aren't 'C11' > > Sorry, I did not understand this, can you elaborate? I am referring to = [1]. >=20 > your subject line indicates the use of C11 which is a standard [1]. >=20 > the patch itself uses gcc atomics builtins which are not part of C11 stan= dard so > the subject line is incorrect and misleading. Ok, understood. How about the following? "use gcc's C11 atomic built-ins for lcore synchronization" >=20 > [1] http://www.open-std.org/jtc1/sc22/wg14/www/standards.html#9899 >=20 > > > > Not sure if these compilers are supported in DPDK. DPDK officially supp= orts > gcc, clang (not sure on icc). >=20 > dpdk may incorporate support for other compilers in the future so unless = there is > substantive justification for moving to non-standard/non-portable code i'= m > asking that this change not be made as it will complicate those future ef= forts. There is some history [1] behind why we are doing this. I guess new compile= r support needs to be discussed in the future. [1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/