From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: Luc Pelletier <lucp.at.work@gmail.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"jianfeng.tan@intel.com" <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic
Date: Thu, 8 Apr 2021 17:07:09 +0000
Message-ID: <DBAPR08MB581497145213EFC910B8CCF498749@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20210407201603.149234-2-lucp.at.work@gmail.com>
<snip>
>
> The affinity of a control thread is set after it has been launched. If setting the
> affinity fails, pthread_cancel is called followed by a call to pthread_join, which
> can hang forever if the thread's start routine doesn't call a pthread
> cancellation point.
>
> This patch modifies the logic so that the control thread exits gracefully if the
> affinity cannot be set successfully and removes the call to pthread_cancel.
>
> Fixes: 6383d26 ("eal: set name when creating a control thread")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Luc Pelletier <lucp.at.work@gmail.com>
Looks good.
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
>
<snip>
next prev parent reply other threads:[~2021-04-08 17:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 13:04 [dpdk-dev] [PATCH] eal: fix possible UB on creation of ctrl thread Luc Pelletier
2021-03-25 11:27 ` [dpdk-dev] [PATCH v2] eal: fix race in ctrl thread creation Olivier Matz
2021-03-25 14:42 ` Luc Pelletier
2021-04-02 4:34 ` Honnappa Nagarahalli
2021-04-06 15:57 ` [dpdk-dev] [PATCH v3] eal: fix possible UB on creation of ctrl thread Luc Pelletier
2021-04-06 16:15 ` [dpdk-dev] [PATCH v3] eal: fix race in ctrl thread creation Luc Pelletier
2021-04-06 21:10 ` Honnappa Nagarahalli
2021-04-07 12:35 ` [dpdk-dev] [PATCH v4] " Luc Pelletier
2021-04-07 12:53 ` [dpdk-dev] [PATCH v5] " Luc Pelletier
2021-04-07 13:22 ` Luc Pelletier
2021-04-07 13:31 ` Olivier Matz
2021-04-07 14:42 ` [dpdk-dev] [PATCH v6] " Luc Pelletier
2021-04-07 14:57 ` Olivier Matz
2021-04-07 15:29 ` [dpdk-dev] [PATCH v7] " Luc Pelletier
2021-04-07 17:15 ` Honnappa Nagarahalli
2021-04-07 15:15 ` [dpdk-dev] [PATCH v5] " Honnappa Nagarahalli
2021-04-07 20:16 ` [dpdk-dev] [PATCH 1/2] " Luc Pelletier
2021-04-08 14:17 ` Olivier Matz
2021-04-08 17:06 ` Honnappa Nagarahalli
2021-04-07 20:16 ` [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic Luc Pelletier
2021-04-08 14:20 ` Olivier Matz
2021-04-08 18:01 ` Luc Pelletier
2021-04-09 8:13 ` David Marchand
2021-04-08 17:07 ` Honnappa Nagarahalli [this message]
2021-04-09 14:34 ` [dpdk-dev] [dpdk-stable] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB581497145213EFC910B8CCF498749@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=lucp.at.work@gmail.com \
--cc=nd@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
DPDK patches and discussions
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
dev@dpdk.org
public-inbox-index dev
Example config snippet for mirrors.
Newsgroup available over NNTP:
nntp://inbox.dpdk.org/inbox.dpdk.dev
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git