From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA8BFA0A0C; Thu, 8 Apr 2021 19:07:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90E0B14118F; Thu, 8 Apr 2021 19:07:26 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10046.outbound.protection.outlook.com [40.107.1.46]) by mails.dpdk.org (Postfix) with ESMTP id 823A514118E; Thu, 8 Apr 2021 19:07:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDqIs+KpGroH6oEUbLG5iPC0n9hZa6p1zS2tm80GEGE=; b=s5pq3Toxm6UwFQMZgdEn7Bgwa+NLFLmlrSz+IgxCv8emJ2vpAcmutrPRuKMRfRE144iaMCmv8aig6OaT//q65PYFbtjR+Yrm3RWt4rEsjAt3NDjlJR78/ndunhI8DNvUW1qOaQmTkiw6CbAIesPRErmq2bAc9ePEOKIaL2zyeSs= Received: from AM4PR0101CA0062.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::30) by AM0PR08MB2994.eurprd08.prod.outlook.com (2603:10a6:208:59::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Thu, 8 Apr 2021 17:07:23 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:41:cafe::be) by AM4PR0101CA0062.outlook.office365.com (2603:10a6:200:41::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 17:07:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 17:07:23 +0000 Received: ("Tessian outbound 9bcb3c8d6cb1:v90"); Thu, 08 Apr 2021 17:07:22 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0b04dbd1b821.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A53840D-933C-4E6D-A3DE-FF965EEFFF19.1; Thu, 08 Apr 2021 17:07:21 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0b04dbd1b821.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 08 Apr 2021 17:07:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcdaRrX+6Iqw1O+fp5LgYS6rYVosIiOl123jTrsRy+0pdA3Duk19Dg+4TO6atI0ze8LgYUSC2YH1BFwwTO7jalaw6RpwzELcViHTgHjizTPpd37fddS0863SHSFQXc9MkRMYlMKRHu1Ke9UZJp5fMNBnCXNUCJn9xaN9j8H982BeqKBaxQSiBVQUP5gLTLn1msuXvnjuens/j6/q9oM+lnylFcytt8HdTIzQZsu0qNXQNe+tQoxOyCgDlLjmZ4GqzIndp/nEMXbtf9JZb5qUR9mcpWEDcRko6Tc7njMPFlLZyHBo9E3hZH1h7Tbw3TsD/ERUTcP1EponILwy+LyOuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDqIs+KpGroH6oEUbLG5iPC0n9hZa6p1zS2tm80GEGE=; b=Bs5MlO706jVOU36T1s++vCgC6AUK/MvJ1nVTjmqsMyYSwArGpVMYnCB64VFGuPqvpf3qAWmcGzeehN3zsXYaMe3EsYskZ7G1IW9tshwFUSN+BDOloXZtftRkXU0+yGIzgcP7Kan+NMI5MgWtvZUOeXZz/zIIdbmlleb0g9Tdau+bvmaZfJKvc8LT3F0WvHsbDBNIuz5+3vmrsjt3HrVWnGblbiPGmOih/LWIZAwovJ0lebYzazycvrg+EOKDTsHlwgk+v5Xeu6Ii/tQsLFBN4L6k2sPzrizqdIi+NWF6hHwha08AwgCThwn086NTv72BfRmyQ0MuAj8L2a/dwdm4yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iDqIs+KpGroH6oEUbLG5iPC0n9hZa6p1zS2tm80GEGE=; b=s5pq3Toxm6UwFQMZgdEn7Bgwa+NLFLmlrSz+IgxCv8emJ2vpAcmutrPRuKMRfRE144iaMCmv8aig6OaT//q65PYFbtjR+Yrm3RWt4rEsjAt3NDjlJR78/ndunhI8DNvUW1qOaQmTkiw6CbAIesPRErmq2bAc9ePEOKIaL2zyeSs= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB5482.eurprd08.prod.outlook.com (2603:10a6:10:116::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17; Thu, 8 Apr 2021 17:07:10 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e%7]) with mapi id 15.20.3999.032; Thu, 8 Apr 2021 17:07:09 +0000 From: Honnappa Nagarahalli To: Luc Pelletier , "olivier.matz@6wind.com" , "jianfeng.tan@intel.com" CC: "dev@dpdk.org" , "stable@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH 2/2] eal: fix hang in ctrl thread creation error logic Thread-Index: AQHXK+ytWp5/oBQY5U+J9bbYQ9uYbaqq2zDA Date: Thu, 8 Apr 2021 17:07:09 +0000 Message-ID: References: <20210407201603.149234-2-lucp.at.work@gmail.com> In-Reply-To: <20210407201603.149234-2-lucp.at.work@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7A27E25BB464BA4182A1754BBA18402A.0 x-checkrecipientchecked: true Authentication-Results-Original: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: b0ab8985-ed9b-440e-1e91-08d8fab0c6ea x-ms-traffictypediagnostic: DB8PR08MB5482:|AM0PR08MB2994: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:3276;OLM:3276; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JcB1eb2NgF85SwEAZxeOVOdBp5jfwRYhiwaMXxyxQodgWJYRFlD28QB/6GWGmJ42Tbb9RkdsV6SoU/2q8LsOiRuOUrd/sDePYp5MLBv6NDwEhCq+ZQPD/F2sVhdcdiGYVTwRSb1QSqKpTjVO3MCcJzISHZcLYougTBvDziCwEht3IxGSoUAVCOwX+4ckXPHj6AybVPttSz9ple8NnSztLsyXKOndn5CsiVkX3e/goUf9FOcKUicz4qXrZGiC07HVzvoqdAKg3TWmNlk/nuZgb6/nTTydiXhjRCf6zGxuViBnLNrokpy1MmfdAO0qpJ2F3n//YTfU5RvpboiOs/K/6ons/kIQukyZrD/ypRJ05O/Fbx/tl0Ez3OThS+5B9kJZvumtVrGX7EfqW3p0JKjFhLAdE6+rkWFgXoX4LwRNth+UMKMMVMiAFLPzljXFENWGUfsQyC11bf1kuPVwhoP6OiPR8d4NbUbxLSASgxuli1lattNrOLB2fqEvKinde7Ux0hFnX/RPbxHSq7HGQTg9xWd/JrTv9R6dD1kMrs6bkQnHZmYmVh8ZzvCseoNiuUdzETRnCbBteUAsyznf/tUbHGEnHN66gIND1roBQlkeaVX/YAyQvTzZj4vhbvlEk/Fo8XnZ4a24aZSqj9JEaVXBrm4h7I1gZpswB+tpZJslg+A= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(396003)(39850400004)(136003)(8676002)(33656002)(76116006)(66946007)(66446008)(64756008)(66476007)(38100700001)(66556008)(55016002)(2906002)(186003)(5660300002)(26005)(316002)(86362001)(54906003)(4326008)(9686003)(110136005)(71200400001)(8936002)(478600001)(7696005)(4744005)(6506007)(52536014); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?BOX5vt+euZo37BSSRm4O24gS2DMZqKMT/UHd6xaO56oOZUWTIEJdGgS8NKep?= =?us-ascii?Q?NGMHpru/wTTqzgfH7sDFgHXgMAovMziMvzLKZzdk/YxL3rpRKAGyQ/DYWOgq?= =?us-ascii?Q?KkAuS2nIY5ygZs/nqwSPGUV7c0KAY1kEUhEaF/TelOFWh8PiNujBC0G+7xpf?= =?us-ascii?Q?9jpoaJWXY+C36Qeitj2N9/n41MS2gdV6DKfhD0G7qlA8C42YxQ/Oykw0V3Ie?= =?us-ascii?Q?cZniKyCBASNwPXZg5Yj3LGlqfhu2Mly1Uk4Qqkj/FlpQDCMAmrGm4aWuuBvW?= =?us-ascii?Q?LLRWNflI8/fQ9FlQNem7Zfn77rmKEpBaQMdtB1m/enwfVtJGHFG1rS0JauxC?= =?us-ascii?Q?8hAwlXkOhIfpnk1r/LRgBsbzg1ivXgDwdx4CpQahIXsePYS7EFg31e2NenKr?= =?us-ascii?Q?w+tmuC/TTtAx5oyWqbd30ZkhsWKbox3o2aVHzbEz9joRJciLiatEmmWqUklV?= =?us-ascii?Q?h21aNG/HZDlF3GaFwuYSRpIm7qhTCrW5UA1TxgFPZf/dbYtzFmAUPkFbH0C0?= =?us-ascii?Q?O1TamtgtX4Fm2IKdoMIZJTX/jCvB/NUy74o3tuh8y0+VLoI0Nu2JA87KFcLg?= =?us-ascii?Q?EZAbwkCBV/fVKXrpYD+uN7TbXz+AKaVCStQnZkBacT/DwMjFzIHVfSmNLoMe?= =?us-ascii?Q?ZljepPMQ2rY+gfx0isSnfivAnNHPvhvlJj8J2AAgereSJ1z1XlM4t97OraCK?= =?us-ascii?Q?aJPwNdW9h3cfY4o+2J770xASMfqliX1Gz62psZUNDO19Uq3jJXmIQb5ehpM2?= =?us-ascii?Q?FKjt1JI7gjET+63q5k52wL1xrw7IGb3Br551RNiQmY3OhHwp08yLZ9UgYsCa?= =?us-ascii?Q?jQZpVAJ9mzsPXL1Y88bGpA1/i+yjgBVXiv8nWqWkjahvKQVf2sJRqEzDdo9k?= =?us-ascii?Q?wxL4qVqXY9XJIeqYbHVFhL0fby53haViu4uBDpmYedX7UZzTkeeEMG95hGvc?= =?us-ascii?Q?tdQPLj89gUiZdLEsL9C+mL24oZ3pUUuyKMFsD8UOwmT8NxKvYb7WrDWGPsDR?= =?us-ascii?Q?AL/OWVy/0Glfi39YfKy03tvEpwW+2wdzYhvNeWpRJkgKrSwqxYZQO4IJanFA?= =?us-ascii?Q?UUZquTyA7R6hlhT2/BybIXza/5BmEtGbsx3c+hidxeiKMab/Q9sSwl2nxy07?= =?us-ascii?Q?Fjnhp6sgH/ieIutLuutM8tQCBhlaY//yQNHSZA92XlJ12OM0KwrmYe4EzHQ8?= =?us-ascii?Q?jBVRxBy/lbqZQO4RUu5o0I/MSb42S8Rims8bwwTLAqpgf0EoFDXv5Q7Pe+xq?= =?us-ascii?Q?XYoUjXF4/0vD6Eq6NydEAmXxvbeigiNh3S/v3T5amvOztZerbdoF9IlIg/IO?= =?us-ascii?Q?bjmFdM3RRQRYaVZhM+bKVnuI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5482 Original-Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 55272bf6-a502-491e-c6e3-08d8fab0bf13 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /Y0qv3SMi4X5btrLF0g7JaSgSQCYxQYiYPu9lVzpSKAubigIP17Ykz5kuqVwOop7QqOK2JBeQu+/MfNOopMHXMjLjo2CF+6KczTozK6Ues/ILZjEJCrnHWI5PXjteDCOOJeB//s7w69ikyDRU4+ETLDvhkriKh2svX/IrxmfXpaPKjPY0TwKzgxF1RU+YXGpGJLMi/8THnOHRzdx7Wkr7g0dh0OED9HyKlzWzCn9hb2lWm0UUe+uEgI2C2TxZd0gj3Ds6Dd5SOgN77jIz9Q80qJcSxCce6OVqj2uYh0PlE2FtdBitO1IA95Kk+juDUM6aTs5cw3Gv7ZOqFEG0qkiywdVYC8IugjQKafOYFfKrvyk+Uwm1iVoneWHRLTLuJvYrYenvZMWDsWDU7YV2iOpBfT2o5nrnzD5U1yAD6Md0OxWFficMP+Byj4SfkrfMrLGx0rNu/dAgblYDOX/PZJgnJsQO/3ztZxo3eygwwlBGjufXLcUfOcBJzA/YxZDiPOPU0ZEOk1pn1RwogWDgwRu6ZyI6lStov5mqXB0vl+W2Jd6AirdxvatxP554hFCXidJJCSj2I38hnKslCHyqzdiOfe1ZD4XaXLY1KWQE0F6IgXij7HcDV9pGoomCSIGQmE8lQmSiOPhK9Ygc5+RTCr50eox2FaBZn/63kZUVnXcB0M= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(346002)(39850400004)(396003)(136003)(46966006)(36840700001)(356005)(52536014)(8936002)(7696005)(70586007)(336012)(86362001)(82740400003)(70206006)(2906002)(9686003)(47076005)(81166007)(5660300002)(55016002)(4744005)(110136005)(186003)(316002)(33656002)(478600001)(54906003)(82310400003)(36860700001)(8676002)(26005)(4326008)(450100002)(6506007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 17:07:23.0481 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0ab8985-ed9b-440e-1e91-08d8fab0c6ea X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2994 Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix hang in ctrl thread creation error logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > The affinity of a control thread is set after it has been launched. If se= tting the > affinity fails, pthread_cancel is called followed by a call to pthread_jo= in, which > can hang forever if the thread's start routine doesn't call a pthread > cancellation point. >=20 > This patch modifies the logic so that the control thread exits gracefully= if the > affinity cannot be set successfully and removes the call to pthread_cance= l. >=20 > Fixes: 6383d26 ("eal: set name when creating a control thread") > Cc: olivier.matz@6wind.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Luc Pelletier Looks good. Reviewed-by: Honnappa Nagarahalli > --- >=20