From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7021DA04DB; Tue, 10 Nov 2020 15:57:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6253AF64; Tue, 10 Nov 2020 15:57:45 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) by dpdk.org (Postfix) with ESMTP id DAEC3DED for ; Tue, 10 Nov 2020 15:57:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjTbw3n5hhhCtPFiOO/srGn7ERNol1y4YevlK9wYFM8=; b=MxWVufU+91Kr9alg5KKBedmUDDfph1T5wpUgvEAVFy4HWlpl21WPZ1FhQ0y56fqVZJ+h5Xp1txHBfEjVqmht9tEwPEMsZx+w2N7/sNWbmE3G3EDYBfM0oAKoJD769i1PrsuGeQx3RNVXlWCOeaqshcmZCZNyvrCxuyZC2JNVjIU= Received: from AM5PR0701CA0065.eurprd07.prod.outlook.com (2603:10a6:203:2::27) by DBAPR08MB5829.eurprd08.prod.outlook.com (2603:10a6:10:1a9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 10 Nov 2020 14:57:40 +0000 Received: from AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:2:cafe::54) by AM5PR0701CA0065.outlook.office365.com (2603:10a6:203:2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.14 via Frontend Transport; Tue, 10 Nov 2020 14:57:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT031.mail.protection.outlook.com (10.152.16.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.17 via Frontend Transport; Tue, 10 Nov 2020 14:57:40 +0000 Received: ("Tessian outbound d6c201accd3c:v71"); Tue, 10 Nov 2020 14:57:38 +0000 X-CR-MTA-TID: 64aa7808 Received: from f8cc293df5d3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DCFCC5A7-4255-4612-9555-303967173F67.1; Tue, 10 Nov 2020 14:57:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f8cc293df5d3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Nov 2020 14:57:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RJbz5aiP/d3Y8ttL0oCfwKosXcsPX0M1GqUoQeOKGuH7QNEa9dkk8YKp/yOjHWP4UmB3pg5GcQ1r7kOVFdOil/TZ07WCEaBtY58iRHreptbCfuijpX4Dv/DJm1nbsEusg4U6yEKWdHyy7MdZ4GRGwrY3iKcqZtFEq7dLPyVUyztY+iY9cUvpFmT1Un76skzfSPl9XM1dZDcXWFFfZrAwrvNlFSW5RUtvzCzuiS4EPZmWXVQoXRApXVQKcTkhlBbKQjfCVZaApD6B/BbygAAsstlIR0Xy/orvFwU0AHE92UkCmdUnlcaTJYdTMP2QUmP5jHDXZOIop/JrV6Gpm5jhkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjTbw3n5hhhCtPFiOO/srGn7ERNol1y4YevlK9wYFM8=; b=COqVOI5aNJtU6t6jSDFcBl0LrHss/rl3Jdav0qplZMqMsyxtuOi6kwg/p5heXCrxEsPOVAx2udseAS7J/xECgcT86wXoTE7KLAgBo1gHR/fLpxmSJzVjU2WVuR9gLuB5Tw/1nZUWDeZD/+aOzbmBOc8Tqs8/bIkGHIYWNHX4XvXh1C7jq3jpPM6jOKWMI/TJ0NgHPuHZxe61y+YeQDzXWxOvUoiMXJ7S62vCfiawE12x32POlisDBsDO+UW3G43uX3f9ipoN6Uv8wXZ+X9fkvXKMNR6318PY4h1OSuTTesUjj71RGiHfCSK+fe3wXKLpJPhU7lgCIQaRQZvSuprh8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pjTbw3n5hhhCtPFiOO/srGn7ERNol1y4YevlK9wYFM8=; b=MxWVufU+91Kr9alg5KKBedmUDDfph1T5wpUgvEAVFy4HWlpl21WPZ1FhQ0y56fqVZJ+h5Xp1txHBfEjVqmht9tEwPEMsZx+w2N7/sNWbmE3G3EDYBfM0oAKoJD769i1PrsuGeQx3RNVXlWCOeaqshcmZCZNyvrCxuyZC2JNVjIU= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB4953.eurprd08.prod.outlook.com (2603:10a6:10:ef::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.22; Tue, 10 Nov 2020 14:57:32 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.025; Tue, 10 Nov 2020 14:57:31 +0000 From: Honnappa Nagarahalli To: Conor Walsh , "konstantin.ananyev@intel.com" CC: "dev@dpdk.org" , "linglix.chen@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2] app/test: fix to prevent zcd gcc compile error Thread-Index: AQHWt1EkEi/RJFRaa0KhZ2J94f3LbKnBdI1A Date: Tue, 10 Nov 2020 14:57:31 +0000 Message-ID: References: <20201104170306.1688771-1-conor.walsh@intel.com> <20201110110313.1924365-1-conor.walsh@intel.com> In-Reply-To: <20201110110313.1924365-1-conor.walsh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 912C0789C45E9D4A973C26D193A948D7.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1a5cfad7-04ff-4dda-6aa0-08d88588f863 x-ms-traffictypediagnostic: DB8PR08MB4953:|DBAPR08MB5829: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AwR9m53vxmSGaZgKoS7hnmtQw5dmDvr+zAKPGqNg6OeVe+/LzPOj4W75b2GAOffYtEvL8c9WtmFYNnQdxOocctwDOnQgjplWkbXUAOX1/sWV9oyuDkwnu3mjvS5tRMjUiWGQ2t+QATQGZ+dxd4m3O5rh4mGGW2r3D3RNO35wkvS5vu0MwtWf/j0iEMTe5yCbILEDczXLpa/nF4LnPpdubPCoi8RTrql82pIR5lCbSzL77UnHAEXussk5qpROnJRGBC9GzzPFUTitDwEklJSneBm+GGksQSPYnWrLRdGq+7h9TCjqg68k4cWk9wEYYCRU X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(366004)(136003)(376002)(396003)(4326008)(2906002)(66446008)(83380400001)(55016002)(26005)(7696005)(5660300002)(6506007)(8676002)(33656002)(86362001)(66556008)(8936002)(316002)(9686003)(110136005)(54906003)(186003)(76116006)(52536014)(66476007)(478600001)(64756008)(66946007)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: WlkT3zWBiL4dKCMaWhA+5IFV8ymA7+/ZC3zuYo0RzCiiXdnfWTijvdbXXzTQDks8bOSmiK2QhB2HISC2ChlZ3shMe7G2yBSskmd46Sz8NvUnZiAKk3yzwIunfWJnm+x7ucnxVGszCldlPvijo2eEVrwW2guZ030x5/E+sUGXz2KOgRo7XKLt+ZVJs7vPBSg6XbQQg6OXbwE1bAbBIPL9Qppr9SiE9LwjwrBgJZiDsQ4ZIENZt77yLq7F1uIxlLAPvaxgSuqV9S7GAIzHBP0klPMxpe5fNi5z/Bg5Fj2qFEOyYrA2dNAI+z42u8FDPpYo/AeOUVtn2krwfU4rGyh2Zva2mHQ9X6obnWdlkyd0Gdssdoco/fkBXrL5SRn9FVNaqOqW5c4VZBluvP4TvaY1KSrSx23wKlSJJZ9u7XQc+d8bGnpbfLUB1w+EiX29jcUUv34V3pXA1MffEO5eeLwi6docOAHa2LKvHfRX3rH9e7IhR9ejatN9218mjLVNJ+hByr62ouZFvYM6XK9jiUyqVpC4zLt4DRCevp2RS0oO7YzSZ1OHOzY8MLWcqXw9hx1+0TGGEwz21IKMR9SosPnnhrM9tBRr8ZrJyuVhnvCmqaxq0ICcymcfN3dHFChzqsP6VYz6a3dUJZgOSjWcRmpZTWVu5zutGEfNj1qCHY2JUW8iB4jWt9gdQ8ySx57aMwlL2Z/jEpSb0vyyiEkJu5OZgKNb82tAop4PEagXEzBN9XqxRyrE7qcM94GcOomzBDEyTRmV4+ERjOqwlNS4OHRmZg3un8sHJB/htO5lGsrfbciqqwBlDwik97GhXOEvsdltz5yuPFoCmrt7HOAFdrrECAmFd0evdZhxj6hXWOJw8YY5M7wov3rDnNa7fFvAH4ciP0/1s2A7+PmG1a0IbdAKzA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4953 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: e62893a0-a700-4b2f-f00f-08d88588f37a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8wVNRRIb/vyW1c7eMTo9yrQyxZAAtNC11XnT7nsLNzwLiOIPR0G0AJ0Kg/9vkS+l1rhxtSzapxoODz+6d3/tQpLV0BTSHgph7okHb/N45UWsV3K9v70kDMzh9ZG3MfgcxVjiHbiYm48LxfhB1wQlVaj8evYBvE1aWYTInW/EiGkUXDLoXGzgfNsm4+JggtyGQdgE49HBtAbhClGvOzmXpO19w1FzgfbbJu0zn4PG5xjCW+hYzTShQALUWqQT3QCsad6zXkT/oVPav5I6vO9xQhzrWIQKyyVDVjWGYnThcQ/v8NaDOsMw59SepopRnwWjuQmnBk4ytIBBkak1a4MBmcBPitTH4luwpzsdSNg6mH7tciohnFF7R7apz5NMTwlzDvPRDSxAywChM3DCTSepJg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(136003)(39860400002)(46966005)(86362001)(2906002)(8676002)(8936002)(83380400001)(336012)(81166007)(6506007)(7696005)(54906003)(36906005)(316002)(4326008)(110136005)(186003)(356005)(478600001)(55016002)(5660300002)(9686003)(82740400003)(47076004)(82310400003)(70586007)(70206006)(52536014)(33656002)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2020 14:57:40.1696 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5cfad7-04ff-4dda-6aa0-08d88588f863 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5829 Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix to prevent zcd gcc compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > When DPDK is compiled with gcc < 9 with the optimization level set to 1 g= cc > sees zcd in test_ring.h as possibly being uninitialised. To correct this = error if > statements from _st_ring_dequeue_bulk and _st_ring_enqueue_bulk were > corrected within test_ring_mt_peek_stress_zc.c >=20 > Signed-off-by: Conor Walsh Thank you Conor, looks good. Review-by: Honnappa Nagarahalli >=20 > --- >=20 > v2: Moved from initialising zcd to changing if statements within > test_ring_mt_peek_stress_zc.c following list feedback as the > original method used may have masked errors within the library. > --- > app/test/test_ring_mt_peek_stress_zc.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/app/test/test_ring_mt_peek_stress_zc.c > b/app/test/test_ring_mt_peek_stress_zc.c > index 7e0bd511a7..85f0262ba0 100644 > --- a/app/test/test_ring_mt_peek_stress_zc.c > +++ b/app/test/test_ring_mt_peek_stress_zc.c > @@ -14,8 +14,7 @@ _st_ring_dequeue_bulk(struct rte_ring *r, void **obj, > uint32_t n, > struct rte_ring_zc_data zcd; >=20 > m =3D rte_ring_dequeue_zc_bulk_start(r, n, &zcd, avail); > - n =3D (m =3D=3D n) ? n : 0; > - if (n !=3D 0) { > + if (m !=3D 0) { > /* Copy the data from the ring */ > test_ring_copy_from(&zcd, obj, -1, n); > rte_ring_dequeue_zc_finish(r, n); > @@ -32,8 +31,7 @@ _st_ring_enqueue_bulk(struct rte_ring *r, void * const > *obj, uint32_t n, > struct rte_ring_zc_data zcd; >=20 > m =3D rte_ring_enqueue_zc_bulk_start(r, n, &zcd, free); > - n =3D (m =3D=3D n) ? n : 0; > - if (n !=3D 0) { > + if (m !=3D 0) { > /* Copy the data from the ring */ > test_ring_copy_to(&zcd, obj, -1, n); > rte_ring_enqueue_zc_finish(r, n); > -- > 2.25.1