From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
To: David Marchand <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Cc: Nicolas Chautru <nicolas.chautru@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
Gagandeep Singh <g.singh@nxp.com>,
Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Conor Walsh <conor.walsh@intel.com>,
Chaoyong He <chaoyong.he@corigine.com>,
Niklas Soderlund <niklas.soderlund@corigine.com>,
Rasesh Mody <rmody@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Jian Wang <jianwang@trustnetic.com>,
Rosen Xu <rosen.xu@intel.com>,
Tianfei zhang <tianfei.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, nd <nd@arm.com>,
nd <nd@arm.com>
Subject: RE: no printf in drivers code
Date: Sat, 4 Feb 2023 04:38:38 +0000 [thread overview]
Message-ID: <DBAPR08MB5814AAA143AE3B8DB39A732D98D49@DBAPR08MB5814.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8x=i5+qZQjkawum5d_cmJwfHB3=UW-v40OuT7ha_HDfPg@mail.gmail.com>
<snip>
> Subject: Re: no printf in drivers code
>
> On Fri, Feb 3, 2023 at 5:40 PM Thomas Monjalon <thomas@monjalon.net>
> wrote:
> >
> > 03/02/2023 17:18, Honnappa Nagarahalli:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > >
> > > > We have too many drivers using printf() instead of rte_log().
> > > > Please propose a plan to replace or remove the calls to printf().
> > > > If no plan, I could propose one but you may not like it :)
> > >
> > > Does it make sense to add scripts to CI to capture this issue?
> > > In general, we do not want printfs in DPDK code (other than tests,
> > > sample apps?)
> >
> > It's difficult to automate because printfs are acceptable in dump
> > functions, selftest, and testpmd code hosted in drivers directories.
>
> We can identify which parts need those, create dedicated helpers that do call
> printf (but are excluded from the check), and and then the printf exclusion is
> applied to the whole tree.
+1
>
>
> --
> David Marchand
next prev parent reply other threads:[~2023-02-04 4:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 13:57 Thomas Monjalon
2023-02-03 16:18 ` Honnappa Nagarahalli
2023-02-03 16:40 ` Thomas Monjalon
2023-02-03 18:35 ` David Marchand
2023-02-04 4:38 ` Honnappa Nagarahalli [this message]
2023-02-03 16:38 ` Walsh, Conor
2023-02-04 0:46 ` Chautru, Nicolas
2023-02-06 14:16 ` Niklas Soderlund
2023-02-08 12:32 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBAPR08MB5814AAA143AE3B8DB39A732D98D49@DBAPR08MB5814.eurprd08.prod.outlook.com \
--to=honnappa.nagarahalli@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=chaoyong.he@corigine.com \
--cc=conor.walsh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=ferruh.yigit@amd.com \
--cc=g.singh@nxp.com \
--cc=hemant.agrawal@nxp.com \
--cc=jianwang@trustnetic.com \
--cc=jiawenwu@trustnetic.com \
--cc=nd@arm.com \
--cc=nicolas.chautru@intel.com \
--cc=niklas.soderlund@corigine.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sunilprakashrao.uttarwar@amd.com \
--cc=thomas@monjalon.net \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).