From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0D8BA0547; Tue, 15 Nov 2022 02:45:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E4A740DFD; Tue, 15 Nov 2022 02:45:54 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140044.outbound.protection.outlook.com [40.107.14.44]) by mails.dpdk.org (Postfix) with ESMTP id 344E040150; Tue, 15 Nov 2022 02:45:53 +0100 (CET) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Amz+UhuRL1Jy4PrPXAPvtiJNl5sZDmizqIrBdQhgO0+Kx3pehNa7Z6lRIfMeLyYcr1xRn0dPDWYX48KAomzJYBFyj5BW3jVOf0glAOHZJkLolRMpKHM9BNCjO5lz7/5hAmNpeloaEC2uCLdFB3FHBBQwi6DPXaIoAxJcblpS4coZC32XyThuCZUT8PEI4CQF6+qTp0PEiQusfpuFcy9Pm5URqrbAlix91kBc9QrzzU2YUPwSKmReQ1xmdS93KdEkhO2odYSHyjY4eZdjYgLkbtvNZVYfIGcm4x50N314ImQBDJ3hRwJ6TW9IbR54qQGIFitJ462XZkyX2xk53d5llQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=esS1tH7UJm08XjAx8zNGZF5vZYRnGZqCNY3KgcUCglU=; b=IFXOu/6wnoI08thnxvEFgTQAObpbcgtceDxSTmTIdpR3J32tSbSRAHwLS16JF19SI1jIesY3vWgp3IP3VIUzRTVQgBCXm37mUHcgzTx5hi+aXxn9qQmqld90ahGqof+/gR4g+vgFoGtPIpIjhDs1hufY2Wb4HatBSCk+2L6uOVWPW+NQdAkoFBPtqU/+MBjyuOYmTiyqAOl1VAF9GYZxXQQN5g9j8zkzr00yP8Gmj8siqIXnSg+jJ6dUEDkAYHtWTGLifHkiDNZGOjc4kOBHDtxLQjQLIrBmtqKK1sIh7ukkOAhxJn47yjDk6tng4AfcKqYc7kiXCs665/vSXQX/HA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=esS1tH7UJm08XjAx8zNGZF5vZYRnGZqCNY3KgcUCglU=; b=c/2CBKRGwW0+/95isUdpbIDSnjwEPmP2KAVgkstKD6ZsPdgNW/g0YPtb2vVeH7Qzz5vFIsvmdhpBoz1jYzKF7yl7uOeK1NXdyvhOvth7R7EONam/y+qRuBDHfY8ErVoha7solApwh0ApUgBwWDheQXaQnacslnfFMNcWgCb8i3w= Received: from AS9PR06CA0687.eurprd06.prod.outlook.com (2603:10a6:20b:49c::32) by VI1PR08MB5357.eurprd08.prod.outlook.com (2603:10a6:803:12e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.13; Tue, 15 Nov 2022 01:45:50 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49c:cafe::b3) by AS9PR06CA0687.outlook.office365.com (2603:10a6:20b:49c::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Tue, 15 Nov 2022 01:45:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Tue, 15 Nov 2022 01:45:50 +0000 Received: ("Tessian outbound 0800d254cb3b:v130"); Tue, 15 Nov 2022 01:45:49 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1666623259fb7486 X-CR-MTA-TID: 64aa7808 Received: from 136ef854fd05.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8282690B-4660-4D17-AA1A-71B34C22AD49.1; Tue, 15 Nov 2022 01:45:38 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 136ef854fd05.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 15 Nov 2022 01:45:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UDq8/ePZODOy/Fnx8ziYRwRSoKK56BP9EiRjtSMV0WEz9+2gDHEcrS/1xBpZTHSy6/CaVZ43KllQg8lbY0RXk+Vlx3Dh3hyWc2C/0nHQ4Crx7hC2dFGFD6HAtZjYb+UFCUV0RzDYl9Fxl3JRBjUYOGjpTUPLs4fVOubHsYtis4cNfjAQK7Gd/5fjrg6Vn6EfNui8Be0YR6vUmTiufGfvwl8GuKf9aecvNPuKww6acPtGZ/lqRr9NQXJ29wde9LoVegw+vCIxPXh79hWf9EBKbcWFCfg4MbraoTpO31DTFPAtXEi5cw5csmA1oA9LlmUv1yq783qBnDxhXGkzgwISRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=esS1tH7UJm08XjAx8zNGZF5vZYRnGZqCNY3KgcUCglU=; b=eSiRa4kzfbXyxho3Mfv455CugyVUfLwv4Ib77kmCmGVVaj6QHfwps/cC5N5E6Awq5qkKbsLGgK1CvOdxdQ0TcOkdP3qF1TgMFLzsfPdnyT6ryl8aNS23E9rVrpUJ61Hivi6PQ1Qee8y9DiOc4B7Mcgou0gAozMmHCxxtAsIT5B7KhChpcdlLLORqYxZmMbD1uzUVKT/b20mBkgIba4Bg8rjUUeP9+EMVxxwqphObG4AeWrpf4I4j6lR2WsZg0EZCkZBB7/JWOsUW0mhu+1fJ0fkzp7JIEdaVr2LV5qO61KML5fffv3KCRM+LGBBpSg1BZ/QEnHrrUIX+Y0Me189VRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=esS1tH7UJm08XjAx8zNGZF5vZYRnGZqCNY3KgcUCglU=; b=c/2CBKRGwW0+/95isUdpbIDSnjwEPmP2KAVgkstKD6ZsPdgNW/g0YPtb2vVeH7Qzz5vFIsvmdhpBoz1jYzKF7yl7uOeK1NXdyvhOvth7R7EONam/y+qRuBDHfY8ErVoha7solApwh0ApUgBwWDheQXaQnacslnfFMNcWgCb8i3w= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB4PR08MB9142.eurprd08.prod.outlook.com (2603:10a6:10:3fe::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.6; Tue, 15 Nov 2022 01:45:34 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::3fb6:b7b2:1e8d:11d6]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::3fb6:b7b2:1e8d:11d6%8]) with mapi id 15.20.5834.006; Tue, 15 Nov 2022 01:45:34 +0000 From: Honnappa Nagarahalli To: Slava Ovsiienko , "dev@dpdk.org" , Ruifeng Wang , Matan Azrad , Shahaf Shuler CC: nd , Matan Azrad , "stable@dpdk.org" , nd Subject: RE: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms Thread-Topic: [PATCH v2] net/mlx5: use just sufficient barrier for Arm platforms Thread-Index: AQHY0js6kBq/o7BFf0Kgf4d3XmoqKq3zvuaggEvEB3A= Date: Tue, 15 Nov 2022 01:45:34 +0000 Message-ID: References: <20210606164948.35997-1-honnappa.nagarahalli@arm.com> <20220830200038.1694160-1-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0A5376768065574F9DB1C37DD23ED07C.0 Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-traffictypediagnostic: DBAPR08MB5814:EE_|DB4PR08MB9142:EE_|AM7EUR03FT031:EE_|VI1PR08MB5357:EE_ X-MS-Office365-Filtering-Correlation-Id: 75716756-4f54-4dfd-bb0d-08dac6ab1fdf x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QoLpLu403Jsy39+axsCWlhoqmfxmtYncDS1sFgabxjJQnpFgVAkPVb2iCuPt0zwKfSmxJd/UbB/BAlfA7r7GosZARp8ZJelWIVp3rNOAmb1+tUE4OmNpSKanTOGKaYXtCbI2d1CkWjU0GClE+GVDSiqO8kBmOaAktClghZjnh9IR8k9U0YkSx7jU59uiWBakiDUl78txkygBQ8ZC5MS7QVjy6vqPNGeAQiwZ7nU+mdQcVnPg9lp8xAvZESTQmU1Fj8Cnq7V/652b0hXk6C41ZexiCyWWdNDAt/aMcd/9zVe9p1FIouOXnENaCS7n5NrHaMBrYgRAuRzOPyGG0WxX8dW/RY88aiSlguNe+BUNr+T5ALgqEJpVtY37in+xdai47EHPRUql0RSg0RUIjWKnDhbPLc8wcNMMjhfJhgTUfu0uf2uz+Gf8a8tF0E2CS42c1JSTF2/6O4ihAJypJpsYfpiN0eMCdX83Mi3n4whvNOp7oGvtTAw0282XeExOnYGKP8D6wc7vxca0uw0R1QnpHlrO6xMyimD5FexxZ1E4iSjf0x6WVo+bMVAFi6W4ej/NzJLe8h0uOPfu/4eH4c3vNAqA9wXzf2q56Zuqm83mRFkxm80vdor4l+iM1lUoH+D9Jk+PGXSNkRBRqLHXKSgTiZ21XJSxCv1bL/ALFtZykr6EzYFrXt1jOdgWolR13J+ZQ7bzrKFuFlOPhLuIFcYrBDxukxyiTj5qoedMKxwQlOjqW8b+X3nukTt6PPUDKB4FCvPU6Rs4govPCkfe5KXnLGr5Lbf2sGTMdjNssq9ECYS9aUmD20ag0rPupW2W16l7PHS0HMtufob+mPYWXRaeog== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199015)(38070700005)(33656002)(478600001)(55016003)(83380400001)(122000001)(38100700002)(86362001)(7696005)(6506007)(26005)(9686003)(2906002)(53546011)(52536014)(5660300002)(66476007)(71200400001)(316002)(966005)(8936002)(54906003)(66556008)(110136005)(66446008)(41300700001)(64756008)(186003)(4326008)(8676002)(76116006)(66946007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB9142 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 972ed398-3f0b-4554-9aff-08dac6ab16a4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wlSiqrHQOv4ZVhAZka3I+q9kRko5rcuJDO8/WkT8uuvwDHNjnO/QoTqhaWR+X+Ny0Cb69q0VS4E0pALy/f/OcEm5lnG0cWpae8fY1c9r7SBm0vFRH2RqLGdtmasol48VpxLPPLyS62lSka0FPfE3/sYbyyif5DUA3J2Kvj+l8E/b6UPufCycnqDFny7T29H87JsepqG+LuK4Dm3jpVyz1xW/S8Bki0aGdgnfo/er8YcZuAsMaRRufjoouP/AcbcJC6o4uzCN1rrUG6RhYsbLGOFM+Vsfyq5TIUx9HRsKmPiS1Z0JYpDNXQ2shS8xQMQu4bS5rG4tdmgJaTZAVRo4pP2reInhjHFUOvJQjbWZUVOG5UZ9Kh4HOgvzpAvtFz15FNRW8/h//d7Kp/mv6znYzdpC0M2PWk39joOMDT+4mfylK+VgdA7+P253twUH+dNBp0pEWB6b+c/BYm3AymV9eHNOMC3QVdIrRkN86IQZILCJNY61Vv8zlBcZjdLtQupt11JO63jWGdt/9xEYxkGSGohy02D9OLGj2w+bzVAtZZlXnUYt6VYSAM7TZIEXBqrUe2tk5NzqPWlmNThbxd+E7ulp+oi9m0pQ4owDqfN+sVwhYUY+2EbB6SRZGOvs5hl/8mQI6LaUuMAvX7B5Iq7DqhhsudaDMG42MmQABlX0/x6m8PCPGX3XrnZzZk4FXymuVy4gsRSOfAdHuaPQ1zRAj3yVqvxCtxB2UH0akpl/acJ/Yeg3cW5PHQpCXTTJAzpX5e3XMIgJGZXX8/B3UgwnNWEuidCT/5kEy0zEyUTQXrdHH5hn1MjEHOYejnQFNwyosOozXxTBJGLIoadEl/60LQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(136003)(396003)(376002)(39860400002)(346002)(451199015)(36840700001)(40470700004)(46966006)(5660300002)(478600001)(40460700003)(52536014)(41300700001)(186003)(33656002)(86362001)(336012)(966005)(36860700001)(83380400001)(26005)(450100002)(70586007)(8676002)(82310400005)(4326008)(2906002)(47076005)(70206006)(6506007)(9686003)(53546011)(7696005)(55016003)(82740400003)(8936002)(356005)(81166007)(40480700001)(54906003)(110136005)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2022 01:45:50.2028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75716756-4f54-4dfd-bb0d-08dac6ab1fdf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5357 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > > > > Hi, Honnappa > Hi Slava, thanks for the feedback. >=20 > > > > We discussed the barrier here: > > http://patches.dpdk.org/project/dpdk/patch/20210606164948.35997-1- > > honnappa.nagarahalli@arm.com/ > Yes, I have changed the patch according to the discussion. i.e. barrier i= s > needed, but different (inner sharable domain) barrier is required. >=20 > > > > (BTW, it is good practice to keep the reference to previous patch > > versions below Commit Message of the next ones). > > > > This barrier is not about compiler ordering, it is about external HW > > agent memory action completions. > > So, I'm not sure the rte_atomic_thread_fence() is safe for x86 - patch > > impacts > > x86 as well. > The earlier barrier 'rte_io_rmb()', resolves to a compiler barrier on x86= [1]. > The rte_atomic_thread_fence(__ATOMIC_ACQUIRE) on x86 also acts as a > compiler barrier. So, there is no change for x86. >=20 >=20 > [1] > https://github.com/DPDK/dpdk/blob/main/lib/eal/x86/include/rte_atomic.h# > L80 Hi Slava, any more comments on this? >=20 > > > > With best regards, > > Slava > > > > > -----Original Message----- > > > From: Honnappa Nagarahalli > > > Sent: Tuesday, August 30, 2022 23:01 > > > To: dev@dpdk.org; honnappa.nagarahalli@arm.com; > > ruifeng.wang@arm.com; > > > Matan Azrad ; Shahaf Shuler > ; > > > Slava Ovsiienko > > > Cc: nd@arm.com; Matan Azrad ; stable@dpdk.org > > > Subject: [PATCH v2] net/mlx5: use just sufficient barrier for Arm > > > platforms > > > > > > cqe->op_own indicates if the CQE is owned by the NIC. The rest of > > > the fields in CQE should be read only after op_own is read. On Arm > > > platforms using "dmb ishld" is sufficient to enforce this. > > > > > > Fixes: 88c0733535d6 ("net/mlx5: extend Rx completion with error > > > handling") > > > Cc: matan@mellanox.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Honnappa Nagarahalli > > > Reviewed-by: Ruifeng Wang > > > --- > > > drivers/common/mlx5/mlx5_common.h | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/common/mlx5/mlx5_common.h > > > b/drivers/common/mlx5/mlx5_common.h > > > index 5028a05b49..ac2e85b15f 100644 > > > --- a/drivers/common/mlx5/mlx5_common.h > > > +++ b/drivers/common/mlx5/mlx5_common.h > > > @@ -195,7 +195,11 @@ check_cqe(volatile struct mlx5_cqe *cqe, const > > > uint16_t cqes_n, > > > > > > if (unlikely((op_owner !=3D (!!(idx))) || (op_code =3D=3D > > > MLX5_CQE_INVALID))) > > > return MLX5_CQE_STATUS_HW_OWN; > > > - rte_io_rmb(); > > > + /* Prevent speculative reading of other fields in CQE until > > > + * CQE is valid. > > > + */ > > > + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); > > > + > > > if (unlikely(op_code =3D=3D MLX5_CQE_RESP_ERR || > > > op_code =3D=3D MLX5_CQE_REQ_ERR)) > > > return MLX5_CQE_STATUS_ERR; > > > -- > > > 2.17.1