From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D40FEA0521; Tue, 3 Nov 2020 06:22:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B361CBE45; Tue, 3 Nov 2020 06:22:37 +0100 (CET) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70041.outbound.protection.outlook.com [40.107.7.41]) by dpdk.org (Postfix) with ESMTP id 4B560BC66; Tue, 3 Nov 2020 06:22:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=twzKiuwT/4t8pSgH9HsvJSV7lagviOxUvCjZjD7FWs0=; b=RIXZoJRoIKa446zU7VSRjvoWtqWZYHrsRZ9r2lrQFQ66wq190PAQErnYjeKRzfF83CoasUQSfDkBDCYIYar1ctn2sM1WMgGbnEwpA501EAypVNGf8lcEPNO38qob2Z5SUBmhtZ2BRNvGOQLsiDgw4jd3RMP2Nu7UXRQB7z1oILo= Received: from AM6P195CA0033.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::46) by DB7PR08MB3212.eurprd08.prod.outlook.com (2603:10a6:5:1f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 05:22:32 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::6f) by AM6P195CA0033.outlook.office365.com (2603:10a6:209:81::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Tue, 3 Nov 2020 05:22:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Tue, 3 Nov 2020 05:22:32 +0000 Received: ("Tessian outbound 7c188528bfe0:v64"); Tue, 03 Nov 2020 05:22:31 +0000 X-CR-MTA-TID: 64aa7808 Received: from 728c2c71bf3f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FFEA76E0-5138-4423-90D1-4224CEDE4B01.1; Tue, 03 Nov 2020 05:22:26 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 728c2c71bf3f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Nov 2020 05:22:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a87YsJPU4PdNFCvf1w1dgyqZlZquOIUfPOzpXE/x4n+Z6g/jsbcRNdkuCnmPF43XnRplXYnscsXghivyyDyXdLkfYR1P8ZjvKHd228dDOHN7EFkGHtP3Q4qZhMjaQXaexrhW0RCCLwplMh86koJmVidGECdyFeGS1/qQqB88i23JSGEpY9N/quxyDdwylTjalFb5lge0gQZbZT7fEhsmQ80HrJbXioVs1CJBJ2joIE5QmKo/UBRxQnXIKK2LDteFw3gPsPYOYCsf2JEXWCeOM8jllyV/XsvBtYLa0GSVOUlj7xSbgwHOUXs1OAghk23GKW3vmFYMjktS6zTO8GKuqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=twzKiuwT/4t8pSgH9HsvJSV7lagviOxUvCjZjD7FWs0=; b=C1DQU5o+cYb9PluafUYaznLtACYXHPaZkcCO2nQeGNHWZ1s6EHMS9xLSyxtgtB8GacMsh94ZerE48EQY8twcvXjMV7Xn8TphHyw1CfThc1q3W/Gn4a0y8P82CDzv8iZNH2eL1l4d2D8f1GDIjSpIANkUOrf6VxhMGMseSYwCs0Rui2m8SQgkEIAI047hzT29LrxmGLzG9CFL1d68vZnqDV4gFV4QM584lkGec5if/f+zQ/s0mVrlJToMEvp95AvDmRFxeDG88lOPJAoTzleewXJ+Na/B7betxiSxwGIwSmEQ9RFKuHc2879O7VmIjkRdoG8KB3W/TNtnvMam3EutGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=twzKiuwT/4t8pSgH9HsvJSV7lagviOxUvCjZjD7FWs0=; b=RIXZoJRoIKa446zU7VSRjvoWtqWZYHrsRZ9r2lrQFQ66wq190PAQErnYjeKRzfF83CoasUQSfDkBDCYIYar1ctn2sM1WMgGbnEwpA501EAypVNGf8lcEPNO38qob2Z5SUBmhtZ2BRNvGOQLsiDgw4jd3RMP2Nu7UXRQB7z1oILo= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0801MB1957.eurprd08.prod.outlook.com (2603:10a6:4:74::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Tue, 3 Nov 2020 05:22:24 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 05:22:24 +0000 From: Honnappa Nagarahalli To: Dharmik Thakkar , Bruce Richardson , Vladimir Medvedkin , Gavin Hu , Ruifeng Wang CC: "dev@dpdk.org" , nd , Dharmik Thakkar , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v3 3/4] test/lpm: remove error checking in rcu qsbr perf Thread-Index: AQHWsZ/5ZsCH4hj37kmBxrHFEN7NUam13z6A Date: Tue, 3 Nov 2020 05:22:24 +0000 Message-ID: References: <20201102235203.6342-1-dharmik.thakkar@arm.com> <20201103051224.12620-1-dharmik.thakkar@arm.com> <20201103051224.12620-4-dharmik.thakkar@arm.com> In-Reply-To: <20201103051224.12620-4-dharmik.thakkar@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 815E6B1CFB2281409C6813A1BF5A2B5C.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 85e49be1-8dfa-4386-526d-08d87fb8774e x-ms-traffictypediagnostic: DB6PR0801MB1957:|DB7PR08MB3212: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:392;OLM:392; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: UW5jodHl71I74P4lIxeyVdBbM8w0AXZWjlGl97jjlyogec1btoV+m3NURLCm8XUBU4fKiiVxqLRQosRmnInwddJIrOj+tO/Xspn5C/eihgTGLS5xZbaVI1fdH1K0KzavvXrlGkJeTSbP+kkJU/rVEhKx4iGj+T6dCFnFL3zwN6mMEFsNvlMOYEUn+QKSxCZ03DQxPMH0a5NSZXKtYM4U4oR+7vuYwOunWpG0zVmqzgdGzFNaYxsYFdVQXLHVeKHa+ryr8tMtMvxd8OnvS9llGNUV6q3Ri4/+AGR4/m0p9f2edPUX7mzbXQbEzn393Qgy X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(4326008)(478600001)(2906002)(55016002)(6636002)(5660300002)(9686003)(26005)(86362001)(8676002)(83380400001)(66446008)(66556008)(64756008)(54906003)(8936002)(52536014)(7696005)(110136005)(53546011)(6506007)(33656002)(76116006)(66946007)(186003)(71200400001)(316002)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: tPZq/HUKnPpBO2NWqnp0Nrcslfg6nh0M0ZGlvSrDo316qhktmsVz7BJa4p+OsNytmbAp5yApFMLedLkeccxyQnkXGAN1LAcgBwjJjrXlWO15z8BIb9VF+deFfLgK8wuQPVXm4oNHsEj7FSuVO0G9Bgqu82b5KK1p2VRORoPzxNgVm6R8kDwWM7qXgirRycNoiqggBj1Ej3cmu1tf2RMbHQTGinEcpNecp6g0l48woLkzBFCCw/L2Y0SIk0HCuugl74AYkniHY0drxqPB/1e+mXEUz8TZt6R//kHzHVkrj42l1s3CJxIbcz0U/Xo5zz8FLG3An/fNk7mjmQT0EraJSHpShqhhIgXG1ZJX93KeMUZkiBp2zCHOvUYeFcxsc4ryasH3Mezojhw6QIUrJ7Q/+JApPZpY5y/D2RhVrsnYD7VxQ8Ox0W2G5IlwPfQ6LsFK9aGxC4FbktdzJ2sBsAumuidHFU4TVPe/MeBlXZCxNE5HNdS+qXpXNCYpeLBKjpQRcRj5cNHJx/aqjPRz9E4LdXE/yA31PhSGJ5j/PGi/lV36muUNQn+QUfkofSqnWpgB/QhlQLe+jB2dgA9osoI9AUVJJvzi5FTuB0QROQsWLElWbLI1zXODJzJa6VQNPyejHEPCmwE7bTsy8/7uESYfoQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1957 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: eb0a3054-5583-40a4-6d3f-08d87fb87286 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1pkt2xFomhYMs2qpFIasfvZZkvJFIe5nUQoacZSW5hg8UHNzWRZaX/VkUKzuDH4Hrp3znnR5GtLylVWEZNOAajwP8ZlPYNaIRMEXRV8G3aOBF1CYJSQPw48FQBuBvO1w9TOhqKDU9SQpb1GrdakCCJ0KTyz8c7tUB9xNGhh1xy/rXdkEbNkegBJOti3OwO6CcDXAU4Ux5NeFLanUY2iv/1Jm//nTvViQNI6PzgyAOWvwo2YluWlkc7s+Fpuggb3riioyVrv4kGlmmV31NCOiDtih71vQhvBpUrx+oS7/itSt8LGiz5z3u/1l6Zck31wc/6JaN3kif7las0iV5pYZprdlhIHLDKBnOV8/T4hZCca3TDzx2N8sjuQhlwaNtjtSpORLCA1tMF/lHuZHCR9RXg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(346002)(136003)(39860400002)(396003)(46966005)(478600001)(82310400003)(47076004)(86362001)(356005)(5660300002)(70586007)(83380400001)(7696005)(450100002)(6506007)(81166007)(26005)(82740400003)(53546011)(52536014)(316002)(36906005)(4326008)(110136005)(8936002)(186003)(9686003)(6636002)(8676002)(336012)(70206006)(2906002)(33656002)(54906003)(55016002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 05:22:32.4447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85e49be1-8dfa-4386-526d-08d87fb8774e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3212 Subject: Re: [dpdk-dev] [PATCH v3 3/4] test/lpm: remove error checking in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dharmik Thakkar > Sent: Monday, November 2, 2020 11:12 PM > To: Bruce Richardson ; Vladimir Medvedkin > ; Gavin Hu ; > Honnappa Nagarahalli ; Ruifeng Wang > > Cc: dev@dpdk.org; nd ; Dharmik Thakkar > ; stable@dpdk.org > Subject: [PATCH v3 3/4] test/lpm: remove error checking in rcu qsbr perf >=20 > Remove redundant error checking for reader threads since they never retur= n > error. >=20 > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang Looks good Reviewed-by: Honnappa Nagarahalli > --- > app/test/test_lpm_perf.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) >=20 > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index > fc4c9b60cbbc..fa6ebc4f7547 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -556,11 +556,10 @@ test_lpm_rcu_perf_multi_writer(void) > __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED) > / TOTAL_WRITES); >=20 > - /* Wait and check return value from reader threads */ > writer_done =3D 1; > + /* Wait until all readers have exited */ > for (i =3D 2; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); > rte_free(rv); > @@ -605,10 +604,9 @@ test_lpm_rcu_perf_multi_writer(void) > / TOTAL_WRITES); >=20 > writer_done =3D 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i =3D 2; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); >=20 > @@ -712,10 +710,9 @@ test_lpm_rcu_perf(void) > (double)total_cycles / TOTAL_WRITES); >=20 > writer_done =3D 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i =3D 0; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); > rte_free(rv); > @@ -771,11 +768,9 @@ test_lpm_rcu_perf(void) > (double)total_cycles / TOTAL_WRITES); >=20 > writer_done =3D 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i =3D 0; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - printf("Warning: lcore %u not finished.\n", > - enabled_core_ids[i]); > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); >=20 > -- > 2.17.1