From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 349E0A09FF; Mon, 11 Jan 2021 18:40:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB413140F8B; Mon, 11 Jan 2021 18:40:41 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50086.outbound.protection.outlook.com [40.107.5.86]) by mails.dpdk.org (Postfix) with ESMTP id F1461140F87; Mon, 11 Jan 2021 18:40:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lCWHzT5kwGe7L3uGduEiQHIVpTqKQHPTQsuw3e4Gx9g=; b=0Elo/Rtg92VoH2ICp+PXsCY7LfylAuJO169R4lA5IXcQ8Z9JKU5sNBwUxUeaA48HMyO2WkdF5fUT9dSzPTkd2p3OCNkM5uDxkn/d0NXHBdNizHZXI4f7lX/Ej9sGUqATCcpb7fD3xcBbPafVyD36J+Pss1urYbRJPC1arGVXySA= Received: from DB6P195CA0022.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::32) by AM0PR08MB3523.eurprd08.prod.outlook.com (2603:10a6:208:dd::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Mon, 11 Jan 2021 17:40:38 +0000 Received: from DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::dc) by DB6P195CA0022.outlook.office365.com (2603:10a6:4:cb::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 17:40:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT056.mail.protection.outlook.com (10.152.21.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Mon, 11 Jan 2021 17:40:38 +0000 Received: ("Tessian outbound af289585f0f4:v71"); Mon, 11 Jan 2021 17:40:38 +0000 X-CR-MTA-TID: 64aa7808 Received: from c4fe39de446e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C37F2DAC-8B8F-452B-B962-178E7B13874C.1; Mon, 11 Jan 2021 17:40:33 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c4fe39de446e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jan 2021 17:40:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cIXKAx0Nee4mXGAM8gQceMlSuly+IFAl6N3TfyMasvDWkxcnS6UdrGcdFU1aJaB7R3dAXs9G6hcND0t+KSTo91aComHXeNL7hQwezRey7/pcJ+D+34KWTXWD0MgxHLYI5k8wgp2XIUbmclEr+lP64+bL5KpP+Hx2DzAAtqsuXj5FyEuq3HWlPLbcGHxHITCTZn+HEiCN15iEuAFnP6TTn1xwUfv7GUJh1M+UTtAG8f5011PmFFJnuKPezBdPItHJmUEbkqd5wx9JJfS3VrUS9cDj4qLZuPhKRolx0gepF5rIL2164hizOBNA/Cnvaamb+Gk2H46xd1qO3P4XmCa+iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lCWHzT5kwGe7L3uGduEiQHIVpTqKQHPTQsuw3e4Gx9g=; b=Qv3vTmdb/AV7ZORxsJsjfu35I5bSUIXqTKcW+4wnwC3RThqbWPo/PMzUDO4X8rFmOnpKDcMySX7JacHEMHSdNU/N/Rbgo6VtCttoZ1qGmA1LeKQMnmbi6uYhxb3G+23NNUc7B4HrXGbPrH0dkMe+YTLrG9fbSHONeB/jFwIMWl2U4QWMhKICk9EfO4hhTe6ruFeIahS57mbMKwPZ70pP9Osehoe3hnBrjrGRdnNjGimhY8mbMye3k0KKl1sejslWFko4bj7hSAF7xtwXEEVwdd3pwJ5Voqe96Q8lYHo2WOJlh6CdAaZg9a5EFqsutMwVz/mUigiTfSM6CAZfXzzMOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lCWHzT5kwGe7L3uGduEiQHIVpTqKQHPTQsuw3e4Gx9g=; b=0Elo/Rtg92VoH2ICp+PXsCY7LfylAuJO169R4lA5IXcQ8Z9JKU5sNBwUxUeaA48HMyO2WkdF5fUT9dSzPTkd2p3OCNkM5uDxkn/d0NXHBdNizHZXI4f7lX/Ej9sGUqATCcpb7fD3xcBbPafVyD36J+Pss1urYbRJPC1arGVXySA= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DBBPR08MB6073.eurprd08.prod.outlook.com (2603:10a6:10:1f7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6; Mon, 11 Jan 2021 17:40:31 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::d03e:850a:8127:2438]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::d03e:850a:8127:2438%3]) with mapi id 15.20.3742.012; Mon, 11 Jan 2021 17:40:31 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , "dev@dpdk.org" CC: "thomas@monjalon.net" , "aboyer@pensando.io" , "stable@dpdk.org" , Honnappa Nagarahalli , nd , nd Thread-Topic: [PATCH] build: provide suitable error for "both" libraries option Thread-Index: AQHW6CGbVH7pr3+YD0GZvLKO7LvqtKoisHdw Date: Mon, 11 Jan 2021 17:40:31 +0000 Message-ID: References: <20210111135559.1169775-1-bruce.richardson@intel.com> In-Reply-To: <20210111135559.1169775-1-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1D6E0AC6EE69E04C9946E9CF64B7C6AC.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7e059a00-bc46-4fa3-3929-08d8b658022b x-ms-traffictypediagnostic: DBBPR08MB6073:|AM0PR08MB3523: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: g50MpJZfoICRdCngx/uaCuvmruN4A+Dp7fG6T9QcdSw6QPDMlkWJYibRPrQfYOZsXWrAjQyEAHdjD4YqZ58fiXODx0JbK1xpbMz72LfGKawFYfNik1T0azYCB6gZEzqXCJes3NI5qdkNlgznTB+oxj74KY56V2L0ip1xcgmOjQw3b3b9jrPAeDn13PIPLv+8KhRA50D9Y2Lgju/Wlm9QgFbhzPbtBwvM2dhzIdTPbM5khC3kIlnkfFuNDa1HU06SvVwjpdYuddV7yu2CV25WNXUNjY/sATQamJfMDVSMXU9ldf6HoBYYjKLbEy2boP+d51J/uupZAYVPYj1/559062zFUUNt2HEmSovHCZUQwCWk1+cT0qcPdzMxCLjJ8QqvYpeE356qePUU0n08hgxMgA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(9686003)(2906002)(8676002)(316002)(4326008)(54906003)(8936002)(478600001)(64756008)(186003)(66446008)(55016002)(66946007)(6506007)(52536014)(66556008)(66476007)(76116006)(26005)(33656002)(71200400001)(5660300002)(7696005)(83380400001)(86362001)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?yV2cp7xMbR2bXdWu+wtHDlA5Qf+Xa+z8Bvz0rBLeieiciazwIdIRrEn6BxDy?= =?us-ascii?Q?kEjxdCCnFI2R81zOg4gg6sW+9D+aUCLOCZisEnVfSjjrh+gzDXPPU2lptWNY?= =?us-ascii?Q?R0eQOZVbZNMQg2uR8yVnyWo8BuYXnyWsb5w3S6ak8Ben/NkIOUTMX7YzApqk?= =?us-ascii?Q?0LQ8cVxB79n3gFjeUV/3dN/lJT+eyyZ7tZlgQKokZNldvi21stkSNGVPjhcA?= =?us-ascii?Q?1KsJ1YZ7P5ZmsN7vA4v9Gx366yace8EFu6dcqhGQZE4hnnDKk5YeYaJj8YqS?= =?us-ascii?Q?6ZLcRcbY1SJLztw5rnHBp2atB1+QyWAp451b/cu3Nboem/OBxH1KZpWXg1AN?= =?us-ascii?Q?mfO3jxCkNpZTC/tl9wgHAgarzRqPZhVm4UdcECNPJwc9kR7WMYNqRlREYWBq?= =?us-ascii?Q?Bum1m3Xzg+wNmQUgRdXj+3sJi3PFkUanV3Ypc9JDajXdzJNsV6XVlP7SnDZV?= =?us-ascii?Q?AEKkYPnOhsQ0+OTj/8oZRpQeZKmUM1ZbGig59vq7LC0ILV/gxb55CpcsQr+I?= =?us-ascii?Q?T3BTBlmAkWZsQyR7RunrXwdaWEIgz9R5oLeFlp9YjXltXBeO/elDxZeue+JZ?= =?us-ascii?Q?5DVL8emcxUkMn8l8d5TAdmPEplRxA897vBSFMh/1WIQ+9tJoSU5WmIrKuF0I?= =?us-ascii?Q?bwCEfXmwEqE1yu3m6n8MkAzuC7sks5+19bYzEMoq48iUUqh+VRynvkroRBYl?= =?us-ascii?Q?yBuCIezA9aVpFIkMcb5lqaF3DW5nEofAUAQSfnYs6qpUb+bGWBYbt0oQFdB6?= =?us-ascii?Q?IDRWs/U4gy4CfNCI5ehVdvfxsCsZWy4bXwg1lzIXRQpFIXdWeQqqeeid14Kl?= =?us-ascii?Q?0YdMioSKyFuj1v3GH78IAzGWTAJxIgz6C3WwbDIyqRkpUkeSI86OR+bIRw0M?= =?us-ascii?Q?6YArT2IhrvQrrApaRiqa0XOg7DUzZbIZ262nNj+b1YMEGR2KUbSuSaCYLK8c?= =?us-ascii?Q?SYeB6SIrBQiiwQh3brsG3NO8OflIq1JhlWAejm4gXmk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6073 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 78164662-5e51-4dd0-f83d-08d8b657fe4f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /PjZpzndRYjqlwUPAecMAsLalAblr1WdP3LAYw4stSIYRvX4SWB9E6Ov1hSZ7hov+UsxuVcrGDNG3d/Cffs5fMz0GhPcnWrtCfLPhvFU6YIXV1YaaQ258FSBYIbUYF6DC1JlyOMRIHZbP6N0Fq954/KXeCh5ERCnH8ZZ91zxBkBn1+YeSy2eoj1n8AVMh3Gxtwqt5avRSG8PhXljHWQgwAuV3ytL6K14vsG6OxHq4uxzhX63xW3nrcrIFYV4x1+dQRKV8FsBO7sxNbX/L47gcpck0wfNsWAKfdGxX+H5lQgwLJfGm3IhneNmiNbsH9s0a+h4Dd71qdJG7scBgh1CAs12sldorak5UucHh352N46ZhFuP6hMm46YFUr6N3GLZKm5zl7RA9Zyso2QoxniynAW2r8Kvr+4tGCT7PITWy4u/Jpvqh6O7SfSK4sJpiVvQIxFeiz+lDKfcXfxvsvw3DVnV4rlQEDDCdEyNA1BwKTo9EerhRki+3PvYXcSo2WhP X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(346002)(376002)(46966006)(70586007)(8676002)(478600001)(356005)(34020700004)(55016002)(5660300002)(70206006)(83380400001)(8936002)(336012)(2906002)(33656002)(6506007)(7696005)(110136005)(82740400003)(186003)(26005)(316002)(54906003)(4326008)(82310400003)(450100002)(52536014)(9686003)(47076005)(86362001)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2021 17:40:38.2599 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e059a00-bc46-4fa3-3929-08d8b658022b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3523 Subject: Re: [dpdk-dev] [PATCH] build: provide suitable error for "both" libraries option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Rather than having the DPDK configuration error out when linking apps and > examples when "both" is select for "default_library" option, we can detec= t > that setting earlier in the build config and provide a suitable error mes= sage to > the user. >=20 > CC: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson Looks good, thanks Bruce Reviewed-by: Honnappa Nagarahalli > --- > config/meson.build | 9 +++++++++ > 1 file changed, 9 insertions(+) >=20 > diff --git a/config/meson.build b/config/meson.build index > 3ddcc3539..05e9cede5 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -308,3 +308,12 @@ if get_option('b_lto') > add_project_link_arguments('-Wno-lto-type-mismatch', > language: 'c') > endif > endif > + > +if get_option('default_library') =3D=3D 'both' > + error( ''' > + Unsupported value "both" for "default_library" option. > + > + NOTE: DPDK always builds both shared and static libraries. Please s= et > + "default_library" to either "static" or "shared" to select default l= inkage > + for apps and any examples''') > +endif > -- > 2.27.0