From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70E45A0A0C; Wed, 30 Jun 2021 03:14:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5392F40E01; Wed, 30 Jun 2021 03:14:54 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) by mails.dpdk.org (Postfix) with ESMTP id 7ECAA40DF6; Wed, 30 Jun 2021 03:14:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rjdt2dbeW46zB/fECqd+PH6IjqzlGc9uYMMeYC+6/FQ=; b=A+VZjtV6emO/vQhKc86vRgKAE4ZJs65f1d/HrUUAIiYW5ErOQaEw0pZ9yLbUTFdoyCpqCER4NGjQi8QGeOAOpudDUuHuksIB4SKc+UR6CN6uB1C9JzANTt1f3DGCOAm1nRHNEj7F2y2/vkhdrQCcQjye33N2FMm41ajKQTPjOs8= Received: from DB6P193CA0017.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::27) by VI1PR0801MB1872.eurprd08.prod.outlook.com (2603:10a6:800:86::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.23; Wed, 30 Jun 2021 01:14:49 +0000 Received: from DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:29:cafe::7d) by DB6P193CA0017.outlook.office365.com (2603:10a6:6:29::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21 via Frontend Transport; Wed, 30 Jun 2021 01:14:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT038.mail.protection.outlook.com (10.152.21.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Wed, 30 Jun 2021 01:14:49 +0000 Received: ("Tessian outbound e0fcff857b11:v97"); Wed, 30 Jun 2021 01:14:48 +0000 X-CR-MTA-TID: 64aa7808 Received: from 2e4546bb7944.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 326C741C-F1D1-4CE0-94CE-F8EED9056812.1; Wed, 30 Jun 2021 01:14:43 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2e4546bb7944.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 30 Jun 2021 01:14:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OXt5h4qdLvX8wChPhv1lingFvU8DjVmUESBKM9yjht2EPRbjlVn6ypj3Vvo9S+oEOPa7RoKUsj19ogYB8c96j/USB5JrPEH3TZyF+ESTpThfsKJqujzJwET4r+80Pk7MuPNGCHZ1BiVYFbfXh4SB0GT3TEN+CBNQxv45EuJ5igAyyxiqtlFqjK9SUv09yUqXFjYnXhkxxIS3yEC9tRLIRi0L68ewjmNkgqcGkR/hB9K69YNhjquFCkuFWuSC6AGh7iDlZugLUawNG1jZuQnzAyz72NpLWc4caWfw90eXCDal+OF5kFNXLMkHCBVe4mZ9961dTp1S0qyM0LbzqKXATg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rjdt2dbeW46zB/fECqd+PH6IjqzlGc9uYMMeYC+6/FQ=; b=U9D3QKPk8TdQVCOcSu4ac31/GrzTOa8jK5I4Gs412cm3laBsMwXVegZuMQHX9NXvJitXCNsMH6XMUq5KKmmcW4CXQQ9fInY+PZVmhtaxZCEz5ebAjIYOrB5TXiv4Fb2celcT1o2sv43VTw2+QYzx9V85UbcAa78I47kn9ufFWndG1jKO2R5WQ7b4De4gevf6fVjEv1bJD5JTn1AtOQf35kak7TfZ1TcC1bhjx651VlG+iMZOSJGDYNgWY+STRo1dxxp7cxjyFz+iBXuGHSn/QEiLnIlR217p+E7lmatiFAcAkJRV0176J6MBn5sHkfu/WA3eI65yTr6MWTCq7fTdew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rjdt2dbeW46zB/fECqd+PH6IjqzlGc9uYMMeYC+6/FQ=; b=A+VZjtV6emO/vQhKc86vRgKAE4ZJs65f1d/HrUUAIiYW5ErOQaEw0pZ9yLbUTFdoyCpqCER4NGjQi8QGeOAOpudDUuHuksIB4SKc+UR6CN6uB1C9JzANTt1f3DGCOAm1nRHNEj7F2y2/vkhdrQCcQjye33N2FMm41ajKQTPjOs8= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0802MB2152.eurprd08.prod.outlook.com (2603:10a6:4:83::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.21; Wed, 30 Jun 2021 01:14:41 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f15f:821c:74c5:2482%2]) with mapi id 15.20.4287.022; Wed, 30 Jun 2021 01:14:41 +0000 From: Honnappa Nagarahalli To: Joyce Kong , "beilei.xing@intel.com" , "qi.z.zhang@intel.com" , Ruifeng Wang , "bruce.richardson@intel.com" , "helin.zhang@intel.com" CC: "dev@dpdk.org" , "stable@dpdk.org" , nd , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2] net/i40e: add logic of processing continuous DD bits for Arm Thread-Index: AQHXaAv3M1lTG7v5kEauXcMDiVyz1Ksryedg Date: Wed, 30 Jun 2021 01:14:41 +0000 Message-ID: References: <20210604073405.14880-1-joyce.kong@arm.com> <20210623084334.18158-1-joyce.kong@arm.com> In-Reply-To: <20210623084334.18158-1-joyce.kong@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0CCAEAD7EC3DA04EAC259B7EE1A5FC5B.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 58a58f4f-7c23-4447-d08b-08d93b6474bb x-ms-traffictypediagnostic: DB6PR0802MB2152:|VI1PR0801MB1872: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:125;OLM:125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 5Z3/s2fo+vTajwAa9Ip09CaTph9wk/552qnZtdZKRYiWxkg0abI8mg2PA7LFtjXRRHHXaX3uYXCw78b+TWxJaZPr+a7vY7WurZaJj+AwPiFpiHYxy+FyguZSKmRtqhMdWpi5FTNIxSdGjIFy25mW3ISVJhb6lHo7Wew8ZuaBpOdQmPuOt7bgGaZIvvoeYL4/DKhySFjg6vuoimngRd2hPkQoNYXQW5W2JHh3ztNwWytzA5D1E0t2S8dMG2rJrk3lwD7cFLcLMaRKhdMujCIM6IU2OmLGTb7hAWgS8rdQmI0epSY8pksrBFA9Tjz23tG1/2BMv4rygB3LUxdakT9x8+WxFSIAlfv9iUo4ZfsfzxMWCLVs9oFTDYY7GgvG2EY5osFi+n2WTjKIC05RROKsgXxRN/zK27ZTEF0NksKRqjOnrdAKoRv40E1taTZtIf4CMVh1Ao8si06RHRswzW2Jl/0mK3rTtOm5fkOPsENm4wkccklxvBrlZFfn/awXNdjzIX1UQiP9NMhHMON+V4922KwbGYherJaOTcDycBPs+QWdNfZNs73kh2JJ5/cM3j8YqtdhLr8rHldOSu1v4YEqDYoabBz8dsq7M1B9anu9SjU++pNQBVUQTTg+ViYX3p6dzh0JtQFuxngm6blfN3Di9A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(136003)(376002)(39850400004)(83380400001)(7696005)(478600001)(86362001)(4326008)(71200400001)(66446008)(64756008)(33656002)(5660300002)(66556008)(66946007)(66476007)(52536014)(122000001)(26005)(8936002)(186003)(55016002)(9686003)(76116006)(54906003)(110136005)(316002)(38100700002)(8676002)(2906002)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PeMkfroWWwboKGi0NdqA7S3vH4yK/mLiK+9VbkSwk2KTXXR9KWLTCcZgQOI0?= =?us-ascii?Q?QwYI94ShZNP2yO87RXCi3uzBMCFvHFGr5HscKIt+67Dj9yLy4KJ5SJkXqrXG?= =?us-ascii?Q?VFnaurbRA+W3Wv6pBu3VxqmZ8QodmfUbHXj+jC2tTmRoqQ4TJlI9HSrGvZVZ?= =?us-ascii?Q?uLxBcY69dyUI4NqJnozJEgrJ/e8grAGOY7G3lLOTpvE/lN5yxYzLg4pu4hx2?= =?us-ascii?Q?j5TbgxUXzxK/6y8+4TDK89EbQCJgJlam5uKp8hFaW+aOHEfwvx9rgg17T/lH?= =?us-ascii?Q?qnZVLhHuT75UfbR/RTycTz50s9aO5xreGWGCSfrg7tK8gBUgoJVO9JqVebQl?= =?us-ascii?Q?FqOYv5KU6xNPLa5DKMxtDv+DvlnHyoDCnhItWTdlyOQ26RwXOIdp2as3Fw2i?= =?us-ascii?Q?d+3dqwRM9X49CUqjDerHczM6SuhUwDkXl3reoPXnB0sA047HN/z4BCqWfYMh?= =?us-ascii?Q?q2Q1hQn/2uBRMsPCoqeAH3mvTE0EkMkEdqmQ2/IMAOchpxUW3DS0tRBwpuyS?= =?us-ascii?Q?lQ0BA0+TuF85dNOUcf+rHRbUfgzRxBPOVWtRzveaV3gEMcDRzKKQFiV/7RI4?= =?us-ascii?Q?eT+UTcr1a6l9gvrEPCooYZ7oKk49VJ0gjoQJv23jtVr2Gu7fSwHZuegcvFYI?= =?us-ascii?Q?z4lZTCxdrsIvZCU8iTTQWLu4YAOerpRPwqz1hdgg0lFVfLiFylI6Pzl6S+hh?= =?us-ascii?Q?YQmMWaK8zOGBIIlYV0lbb6c8NFt7LjUurCb5Ccy+CVGahqAwUaP8QIFKFXAY?= =?us-ascii?Q?D9LzbN864P/rdge/4KQvGsi047TDLjA/GiLh0vV6moSsrnDpUXJcHq4G34jJ?= =?us-ascii?Q?X02rj4xOSer+SoEolktupUFS6vBgN+9gXmwEnf9h5HyGgvwmKjcATLj3gChL?= =?us-ascii?Q?7j/hiHnhtrGLExJGFh9RY0gcxbvd+QBdX2biKy6jEfigk0PACRXTeIEIe8Xt?= =?us-ascii?Q?Jm6v4nIGplG4A8+GBosW5uK9P4gk7PVqkQSpC0kk5MejVIIKe4fk2HAXjrcn?= =?us-ascii?Q?rTMKifNaS7gfDRZQcrXTwVUNwKnPmaei76pb0ZwiiI3wJgc4HrEvTr12gNar?= =?us-ascii?Q?zyaMRkwqveJDtbWuubMX2oiSpwqDfkgL5TEIiwAHM0hB1MaQoImLYyzQLrcJ?= =?us-ascii?Q?/Izbz3kC0D4L2zENtcpmCc+n1rkdLnUknGZqI8iFTkf1RdmxG5gT0v9iZnaE?= =?us-ascii?Q?ctkAvUZiAuRhPGY+kHBOXMGK8lVZOgyhGXtIdb16313X+3NFB/CREos4Lpwp?= =?us-ascii?Q?JxX/A6dJRZBuFTOXkl2WlCv+kduIGm2Zm29+yoIeD6aaa+GzuKiFDYcQVFch?= =?us-ascii?Q?gci8MQqnXL5B99j1EzEdkNjS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2152 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: cd201cc1-255c-4f9e-dc3b-08d93b64707b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7CuXdXzi/psnxApQHFoFDYVqRjbRNcyZxUMpOYs3xfyHWyXgKLjPnt6TGBFSMmja+1vuNwRDVmZJhTe6GbiDOIKdjpQrbdzMQoEPsfYSNFT0dLRKnxznokhHQC4n8SIZvruuhHdbt44/zs+7vTBMgQqzA3oHNJi60Yu3tUfGgAKLNgfMWYzHjyAZzm/yJJf3kLHXGFnradXLZcn1jsuyvzUbuhLACGe6wZxn71hvVPGXjOPKRIXy/IRpuPhbtyqssOfWECiLBlnx7J2GZjVDnkZ8Z5K56p5hMb45gTUJ/2/1x3P5KEHiZd3+b5fQa76d1P+oEZvm9QS+RcjNLGAzu7RF/V5PLfS5f5IP2qA3C5b4wHSoGVMBc7BrAupFA8b08RGL48fvUX9ESlq3v8h8nLvM+RrNWNL8hg0dGizHF5PETzYMy1oAuqEemnrTa740SPsN17lLoZSCKHE1mv0VIQWNuCLnnSk6mI2zPymCeNfUp2caNPWz6CHcz7obAr3NFt5YvxQu1LYKE6EIraYRAkEfa95nkWhzXc0MotE52qcFmlMy/jwhvdFR7FycUwF2TNqfRiIucs5E3wr+Qfg4p9TBnrFJcgoDwc/dXRDcmtOQZUUU7cxKXGDBiP1U2gBGq83oW5PvkSCDtPPlQXrDDvo/w+nr+KnfVGXUXtiocmLWaQGRORa4z9446dXUG3R3 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(39850400004)(396003)(346002)(376002)(136003)(36840700001)(46966006)(33656002)(83380400001)(86362001)(81166007)(4326008)(336012)(9686003)(55016002)(5660300002)(356005)(8936002)(2906002)(478600001)(82740400003)(8676002)(6506007)(52536014)(7696005)(186003)(82310400003)(47076005)(450100002)(316002)(54906003)(70206006)(70586007)(110136005)(26005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2021 01:14:49.0779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58a58f4f-7c23-4447-d08b-08d93b6474bb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1872 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: add logic of processing continuous DD bits for Arm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > For Arm platforms, reading descs can get re-ordered, then the status of D= D > bits will be discontinuous, so add the logic to only process continuous d= escs > by checking DD bits. >=20 > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Cc: stable@dpdk.org >=20 > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++---- > 1 file changed, 15 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c = index > 6c58decec..86e2f083e 100644 > --- a/drivers/net/i40e/i40e_rxtx.c > +++ b/drivers/net/i40e/i40e_rxtx.c > @@ -452,7 +452,7 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > uint16_t pkt_len; > uint64_t qword1; > uint32_t rx_status; > - int32_t s[I40E_LOOK_AHEAD], nb_dd; > + int32_t s[I40E_LOOK_AHEAD], var, nb_dd; > int32_t i, j, nb_rx =3D 0; > uint64_t pkt_flags; > uint32_t *ptype_tbl =3D rxq->vsi->adapter->ptype_tbl; @@ -482,11 > +482,22 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > I40E_RXD_QW1_STATUS_SHIFT; > } >=20 > - rte_smp_rmb(); > + /* This barrier is to order loads of different words in the > descriptor */ > + rte_atomic_thread_fence(__ATOMIC_ACQUIRE); I think this should go into a separate commit as the following change is un= related. >=20 > /* Compute how many status bits were set */ > - for (j =3D 0, nb_dd =3D 0; j < I40E_LOOK_AHEAD; j++) > - nb_dd +=3D s[j] & (1 << > I40E_RX_DESC_STATUS_DD_SHIFT); > + for (j =3D 0, nb_dd =3D 0; j < I40E_LOOK_AHEAD; j++) { > + var =3D s[j] & (1 << I40E_RX_DESC_STATUS_DD_SHIFT); > #ifdef > +RTE_ARCH_ARM > + /* For Arm platforms, only compute continuous > status bits */ > + if (var) > + nb_dd +=3D 1; > + else > + break; > +#else > + nb_dd +=3D var; > +#endif > + } >=20 > nb_rx +=3D nb_dd; >=20 > -- > 2.17.1