From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C0F9A0C4C; Mon, 9 Aug 2021 15:19:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9805F4068A; Mon, 9 Aug 2021 15:19:00 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41]) by mails.dpdk.org (Postfix) with ESMTP id 368014003C for ; Mon, 9 Aug 2021 15:18:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBaz+Ek+edY1gr/9jae7yfMBueNKoe6Xoz4tyYERWPA=; b=+MvqmTBCKBNOxs+cgXhD3er35yPgAGypyEVKEeo7iewzlZ8AzA3Z9Si+Edabd/4lM+ixi93+YmI0uRj7pQVYCPea5EJLidlbcRLU3JfpM28fUcsr3Fa0Fzc0cRt1p27qDdDKhiEXRFnA606/DL77vWNhxWlCDUDpJacseP1Gizs= Received: from AM5PR04CA0006.eurprd04.prod.outlook.com (2603:10a6:206:1::19) by AM8PR08MB5684.eurprd08.prod.outlook.com (2603:10a6:20b:1dc::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.19; Mon, 9 Aug 2021 13:18:56 +0000 Received: from VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::4c) by AM5PR04CA0006.outlook.office365.com (2603:10a6:206:1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Mon, 9 Aug 2021 13:18:56 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT056.mail.protection.outlook.com (10.152.19.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Mon, 9 Aug 2021 13:18:55 +0000 Received: ("Tessian outbound efa8a7456a86:v101"); Mon, 09 Aug 2021 13:18:55 +0000 X-CR-MTA-TID: 64aa7808 Received: from a46ce8fe9932.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3B4B066E-7464-4BFD-ACF1-F90DD55042EB.1; Mon, 09 Aug 2021 13:18:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a46ce8fe9932.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 09 Aug 2021 13:18:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZgrJ+gAp3PT90e1eUC3hfpyfszVeRGvfa1GLi/jmthTvcMIQbNDhBgWgwOF8e6kRPAZG2kOFTE0EtbmU9fJktma543PKb9dJwnN4BqdK1KQwDN/oQQZP1NPZqwYBpzGkGklkr5SlSMqw5aBtUXsKjFTUMU613A1+0DVd3zIF0i8xQNrtIXSjK8E7iHD856t1z8WecZwrRpY/JaKvGF9SLk+Zd7kaKKUUMh6raqyBrwypr0FvYwf7YbI7blc4pQI71dZgP73W8sUN+MoVt+MJoxDC4hyLXhIn2MECEZhIJVoDlaNlVNdrpRh74g2at60iBnI5D5BhuV4KPkhl05gMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBaz+Ek+edY1gr/9jae7yfMBueNKoe6Xoz4tyYERWPA=; b=Cq4txAjPhL99xkXrsOy0UNln5ItyOBVlnocRuNz5kD7BMeJ1IN+jqi95vBr9NFzo0RQmGbI14BSomALPYw6NSh3cIEQSq9j1P0sQsx4AzjQ9LKb1H3vNYjmcrAvA2madUXgfLtCDLrhjqW77DcLOYJVv8p5Bm/YLUCX1s+rOVVuELo+HOJMvdmHGsK8hoFQP1HMPETtM9JzRoGLjDxg92A4xXUZv414QCHGv0qRwxSbYRxnfRblXo81m84736Q8H26Vw0qIFRLXTo2mIkZ0QPh6hjguRki9TwaG+7c6XLutZHLxWamJ4MxavxvzqjXty/mraA7xJWD67zn5fg2t3wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uBaz+Ek+edY1gr/9jae7yfMBueNKoe6Xoz4tyYERWPA=; b=+MvqmTBCKBNOxs+cgXhD3er35yPgAGypyEVKEeo7iewzlZ8AzA3Z9Si+Edabd/4lM+ixi93+YmI0uRj7pQVYCPea5EJLidlbcRLU3JfpM28fUcsr3Fa0Fzc0cRt1p27qDdDKhiEXRFnA606/DL77vWNhxWlCDUDpJacseP1Gizs= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0801MB1672.eurprd08.prod.outlook.com (2603:10a6:4:3a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.16; Mon, 9 Aug 2021 13:18:42 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::ac8f:622:c2d4:9e6d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::ac8f:622:c2d4:9e6d%7]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 13:18:42 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" CC: "dev@dpdk.org" , "olivier.matz@6wind.com" , "lucp.at.work@gmail.com" , "david.marchand@redhat.com" , Ruifeng Wang , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create Thread-Index: AQHXi5w29ykrwJKtz0WfBbjvvU4iCKtrJ2pQ Date: Mon, 9 Aug 2021 13:18:42 +0000 Message-ID: References: <20210730214453.19975-1-honnappa.nagarahalli@arm.com> <7793415.AuWXLK4XGA@thomas> In-Reply-To: <7793415.AuWXLK4XGA@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 66E4EB20EB7FE9438AF10A9B0D4DB845.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 11004e09-dd3d-488e-a86d-08d95b383d8f x-ms-traffictypediagnostic: DB6PR0801MB1672:|AM8PR08MB5684: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 45xn2jEr/DkxUYF4FXelXMjMZBXpGxFvGB32BiWwt12nGoWbcZgqQTspuSVkada1LZcDjc7tS5S/xrT024FFskozIvqCefFO02bFeRA3k89VSn4tSzDZ/4s31JkbU3d53LtNjT7Ru/4Q8mNVBw2gmxoBkJlctZgNv3itjRKoXTP91cZFaF8PVc9wqAcjGDqwy+G6X+NpuC75umAFpCWNHYpCRYbWdrj2paQW6d0jN+Lf3MaeB/4HEV/UD8Rfw7cItzNabsTw7A3v1MvZpQqKaJGTVOxq/HwB7hWOWHn+Lqlwe+vjCl+h5te4FK6ZoVPu0Yq8bVUPVFw6x/JZ3pW6TPQ/YnsnNoBBV1VEtTAWNAK1N9SzNtoAa1X9t5ttuTriyYUt3jhOWY1ceHrK+/jeqlNjXvT2kwdRVNKQ29ncdaIVf7yU0Ykd+bd3mk9l/9EGcNFV1NCsvz7heURfxiDNuRhzr0NAvbxN2TBXo6stJgE6OFc11I0n8Wej4mZRgNmLgt/OfxAIWzbwGbenPn4VCpMYZsHWjfBSAoqISyEFimQ+C3gt4qaUWGjHF6I4lHUJtnvqEf/VXE1YEgLns+m+lhw2VPV7SjIrU+FSNCikCUuENRxpYsLf/3JrlidRed63wco5HzD8TRwfdz2qxeua769VU9nt76v1GQduWgWoH16gozR+5JwroQNEHXxS9duOzGC8Qdud3tB6KeNabQGQyA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39850400004)(396003)(366004)(346002)(7696005)(122000001)(55016002)(9686003)(478600001)(83380400001)(86362001)(316002)(54906003)(38100700002)(71200400001)(26005)(6506007)(6916009)(52536014)(66446008)(64756008)(66946007)(66476007)(66556008)(2906002)(76116006)(4326008)(8676002)(186003)(5660300002)(8936002)(33656002)(38070700005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pKdChZ8+kuYLaHOqUpTixTdWm17ujpEH2KYD3Q0tagcpA3uDECylFnHQzMCP?= =?us-ascii?Q?b/XFYzfXOeHNFga/jnfK76gMeP7//pOQ4aowVEK/xjdaDOrCN1sznnWxgTvk?= =?us-ascii?Q?QrZLp4T0rMR2rZnWLovBmx4v6ovd1Mx3zu3r8nKd9dVUHUvW3b+1LndVlEn0?= =?us-ascii?Q?SiYKFlmI3W1nB4tfnZe5L4O46tL0MLRY8GjGNyg8iXETui7hRioqvTIVqVgS?= =?us-ascii?Q?sF9nl3PfooOv+cl5KdOTOsYVejP8i+dHjPtmsEcHeDDrYrSZLSYjgRJzBij6?= =?us-ascii?Q?hstI1A2gHYn9DXE/mIc6ZS9JP3GJGYO6U25ObdpoN+JNcUkur0AGgpK8k4ro?= =?us-ascii?Q?FkYibDEwIo4gc6yD8Ygy9NZXfWBrokaGO1tZ2Yuberra4Em4ymPUpX2cWnc4?= =?us-ascii?Q?gpN5PHNFdx4rhOKioBK8gOMC4GdI3QorsCPVraSGPGh3i6uBiUOvYKAXlnx9?= =?us-ascii?Q?g2IPUMbj87RMzrnkkVe9qc1BAF5Fy8ZIn2YFTLh46XAB2hDGdLLCgsQgdPHR?= =?us-ascii?Q?2RCgn0W7a9KZZymUm5B0SkgH8xq0nKfg6FLNPDh46mFzR1laz2ohj4GOI3ur?= =?us-ascii?Q?napGQ4PCrWTzOVxqvBHTDr1jtxHYjuprfC0lMJpquxki4bGBjCeWlo8it0oZ?= =?us-ascii?Q?fawQu/26pjuO47jJGWQGRkC6D/hxjhWX2UjA4JQBlUu3j41zcisQohc+JUPa?= =?us-ascii?Q?dCcPpwYenTiuqmSrKtAp9R0p8tCu+YtyFiM1HfaukaZLziu5J5bfro3Q4c0c?= =?us-ascii?Q?tYedZZzUv5t+06jXhIx4ZLYUGQHyl17Ow8vLBi9IicAiLzUKWxHyfZQqqzw8?= =?us-ascii?Q?sucjXmIOiAFWWsZAvZcHtnsJdqtfHFoUzne8uuj65zqNJCP6K2TLWwy4ZgW4?= =?us-ascii?Q?JiQPN8bgNsgiYoraqd8ZXVD6jxvVG4UZLcIPGAqtQU1kTCtcHqMy8Enu81QV?= =?us-ascii?Q?gvgsvi4o8VCWxpvNZulC4rT1uRfsvy1an2n/LTGMxYnkOvu7SpqX2FMOGFm3?= =?us-ascii?Q?vgsOXKUcEEmiF1sqC1QBt9cNOn31vLly9J0d/mt6WnW6erCxpMRD95mkCftO?= =?us-ascii?Q?5IMvIf1K0H6ybcctqByqXL8rbHxn0nk3P0cS+G/JXSUFoQVWZLpll/YHU02T?= =?us-ascii?Q?2xhk+Xxs6yRb/LL2qiIRkigw2pbQJxewVKdmuSrNG8otI/SHNx5RWVxV9kR2?= =?us-ascii?Q?exmgpHHbji39waHBflzDd19CawoH3uoFSBQ5BKtzR6ae1oZubEiUE564ZWa0?= =?us-ascii?Q?SauV3acv70vLMhR6yi4KloFQvaIDdkoD9NKxXbMKel+ddwym9co3akk0aiBU?= =?us-ascii?Q?iTOG+kUT631Ay5G6P5CouIOO?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1672 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 912e9cd2-db9f-4fb3-6165-08d95b3835ac X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d8exLWvXlSvP1aE7LzU+2JekesVRPEfCdvh3Td0kMv4jo7t9jr4TOWsWQ+rOn/bzu4OSUzly6BOLLwrP5zPVScMaAkwNLzIyjlJuG8jQ5qG6VN7H3RsoQEAs+7qSssDDDuv/oOmWJK5bNxSXvmtw8L6hDPu8lH8Bh/ALpYyRTAkJJ+HLDAcYim0CyVrydsWCck62ZYOQRTTs8OH1Df6C76vVINlHOazmU0tH6lC9SI3CG2hHRPNlxUX8ex3e39EUgIrj1gVAkKKoIuyq6F30do1owQ4I+E9PUTmbPJbjP8hV7FDvszYSK+fyRwsP0ZWXX8BZODfXs2bmYpW8Cmvg2/5rpwphbxASm2B8gl09fjKRK4lP8nx4aoM3+9mIoU2oVKjJVxchOMHsxp4PMHe+mCgNAf9fsXhYpAihibasyGwHgJjOWxMItuxJig7Kr0OQJx+83/OoJfCqjO0W2BVIARSPiD9i/kOM9By9jrXm2nhM+cqJZ6F1um5fFVrIYhW6pH/j772qz76J/kqDuD9a7lIJhyFB0EK3UVHtLthjHniIEF86qE/l75sSFcN6MCreauCPwqDICFb17fVv4kqrNypbZ64PeE0ETiYi2cTPRtyoiJn4xKmbuUzRTUuFKUZlxyJQU7NqAhB5bobY2iE9hoKYHiWRtGY5PEogPO7/uEievV8z7P9rZJdj/d1nK8A6 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(7696005)(4326008)(6862004)(186003)(8676002)(70586007)(70206006)(508600001)(54906003)(26005)(5660300002)(81166007)(8936002)(6506007)(33656002)(52536014)(316002)(86362001)(82310400003)(2906002)(55016002)(336012)(356005)(9686003)(83380400001)(47076005)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2021 13:18:55.7507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11004e09-dd3d-488e-a86d-08d95b383d8f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT056.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5684 Subject: Re: [dpdk-dev] [PATCH] doc: abstract the behaviour of rte_ctrl_thread_create X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > 30/07/2021 23:44, Honnappa Nagarahalli: > > The current expected behaviour of the function rte_ctrl_thread_create > > is rigid which makes the implementation of the function complex. > > Make the expected behaviour abstract to allow for simplified > > implementation. > > > > With this change, the calls to pthread_setaffinity_np can be moved to > > the control thread. This will avoid the use of pthread_barrier_wait > > and simplify the synchronization mechanism between > > rte_ctrl_thread_create and the calling thread. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > +* eal: The expected behaviour of the function > > +``rte_ctrl_thread_create`` > > + abstracted to allow for simplified implementation. The new > > +behaviour is > > + as follows: > > + Creates a control thread with the given name. The affinity of the > > +new > > + thread is based on the CPU affinity retrieved at the time > > +rte_eal_init() > > + was called, the dataplane and service lcores are then excluded. >=20 > I don't understand what is different of the current API: > * Wrapper to pthread_create(), pthread_setname_np() and > * pthread_setaffinity_np(). The affinity of the new thread is based > * on the CPU affinity retrieved at the time rte_eal_init() was called, > * the dataplane and service lcores are then excluded. My concern is for the word "Wrapper". I am not sure how much we are bound b= y that to keep the code as a "wrapper". The new patch does not change the high level behavior. Are you saying you are ok with the patch without the deprecation notice? >=20 > Anyway, there is not enough meaningful acks. >=20