From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B4BAA04B5; Fri, 6 Nov 2020 19:21:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 685DC126B; Fri, 6 Nov 2020 19:21:31 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by dpdk.org (Postfix) with ESMTP id 6CBBDF64 for ; Fri, 6 Nov 2020 19:21:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGWEKrGT+7Hx++FJWtcniWgrMM/lWGjWbSxlXZ2pcNQ=; b=fA/d5kGkNuH84Esp+sqYyPNdB6V3yby+o50X0v3RUYz6akr7Hs6et5p+yUWv7C7a/vbMH7ZE/0NL/a8RbQoL+/opgaOr7AvVZ3EoxZy27x8plV0ikjUIZLUams0Ot4EFDMLvNF0yAa49eJOKDUUUk/C3VmXOd53vKwUl2+aqu+Q= Received: from AM5PR0701CA0011.eurprd07.prod.outlook.com (2603:10a6:203:51::21) by DBAPR08MB5767.eurprd08.prod.outlook.com (2603:10a6:10:1a7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Fri, 6 Nov 2020 18:21:25 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::fb) by AM5PR0701CA0011.outlook.office365.com (2603:10a6:203:51::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.13 via Frontend Transport; Fri, 6 Nov 2020 18:21:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.17 via Frontend Transport; Fri, 6 Nov 2020 18:21:24 +0000 Received: ("Tessian outbound 39167997cde8:v71"); Fri, 06 Nov 2020 18:21:24 +0000 X-CR-MTA-TID: 64aa7808 Received: from c64bcff771e3.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4A4C6770-2457-4666-8CA6-56636E4B643E.1; Fri, 06 Nov 2020 18:21:19 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c64bcff771e3.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 06 Nov 2020 18:21:19 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JwnasCr+kLDdipMtOSAJ39Ul4va7Q7ltvyJTjfvDTP1dsrGOCthEJGYtTYuHOQTb/Mox2rD69z69ENUGWORwI6OXzCm1xJv7dIyhYjrI5Oxi+ovCjzqeHTaQ4hxR0czG9Gm1FpWu/0qkMw/mMtuEDjF6aV7BA5fopZCZ4UdFYU3ep2Rir3PZ1i+NfY3e4Ltp1bAmpyud2vyrMe+k4x+SkATtXknNuY7FAeJYQWzFarWFlKLBHGGfSSW01aTC1Y4g2JEa620l8Agzrze1Q/MZYFysURokiG3ivZsSA/iIg5DCXNLkGA80TknkcFNhdnGSO7qJJARntiSFDLiQ9DoZVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGWEKrGT+7Hx++FJWtcniWgrMM/lWGjWbSxlXZ2pcNQ=; b=V/t8XaDV7P/DsHiiRHeQnssR39Iao42HE0Bkm8W5SL96iIdOMvsx5som6yilSxnun50oqF7kopttCIG2Y98xeX2GcXsvxTKqlASiPHYI9SGt/a0wUGUcl877w6ZGsjvfXO3yGfqyUmxaFVf56qbxsNjgdpdlc9M0CHH1lSiN7yfNSfs7rFkA0lVoePn4wGpa1ewjkOcyAOgZrm4u24tWzAUI+hT/P0b7W4swvuAJQzixvPIDnjFs5IhiP67fnnHa/zK+rwNrr7Y+qeWGw/lH2PpH/f9pKv289YgZ8PfyEKDJutUg7tuwo5WdqlOg4MXKllSujnjEYxZdJ5e2rrxayQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PGWEKrGT+7Hx++FJWtcniWgrMM/lWGjWbSxlXZ2pcNQ=; b=fA/d5kGkNuH84Esp+sqYyPNdB6V3yby+o50X0v3RUYz6akr7Hs6et5p+yUWv7C7a/vbMH7ZE/0NL/a8RbQoL+/opgaOr7AvVZ3EoxZy27x8plV0ikjUIZLUams0Ot4EFDMLvNF0yAa49eJOKDUUUk/C3VmXOd53vKwUl2+aqu+Q= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB6PR0801MB1959.eurprd08.prod.outlook.com (2603:10a6:4:75::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Fri, 6 Nov 2020 18:21:17 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3541.021; Fri, 6 Nov 2020 18:21:17 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" , 'Ferruh Yigit' , Jiawen Wu CC: "dev@dpdk.org" , "david.marchand@redhat.com" , "konstantin.ananyev@intel.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD Thread-Index: AQHWs1YqGJ+Rz3T5Ekq9s5s5Zk/si6m7ayvw Date: Fri, 6 Nov 2020 18:21:17 +0000 Message-ID: References: <20201019085415.82207-1-jiawenwu@trustnetic.com> <003e01d6b351$709871d0$51c95570$@trustnetic.com> <3558935.noZgFSCOjD@thomas> In-Reply-To: <3558935.noZgFSCOjD@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D84EF9F6D0794641A9EE9D7F9ACA25E7.0 x-checkrecipientchecked: true Authentication-Results-Original: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; x-originating-ip: [107.77.222.32] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: f6d04efb-8fb0-49dc-c1cf-08d88280c545 x-ms-traffictypediagnostic: DB6PR0801MB1959:|DBAPR08MB5767: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zuoOs0mOqlR/ejLBmle/7cPYiiN6kXuRzyRWa97MMp6LGrVmPT42/0ROGLKZ5VVPTIsTRW0q8Yz+PpiyR4+06NZr41W/bCuZAPawigy+aRxDr0NDNQWEzEYP/e0nXTdK5eQbWB3ve5PFrAaE00hU78A8cYtwAnRMpZY5rStn4kFwjKO45e8nbG70RfpeBaPoZaCCugep/Wu7XG++jD+c7xoeBkFF9jIs8EyZAU5ABR0f98zi5DplSBXVxpURZHcoj3j+AQjGjZpqvSYQNEfUKNfQlSUFOELPqNeydolxuACY0X6II9DB/ZLOysNQ3vZUUefTus+O/arkYF/SYJximw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(376002)(136003)(39860400002)(33656002)(64756008)(76116006)(66946007)(52536014)(53546011)(66446008)(4744005)(66476007)(7696005)(5660300002)(6506007)(66556008)(4326008)(26005)(186003)(316002)(8936002)(83380400001)(2906002)(54906003)(9686003)(55016002)(71200400001)(478600001)(86362001)(8676002)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: mFktFZC/o4c1J0g/hCFXtYxm8hPFKMyqhh6hpXNB7EBPNWCRmfhfhao2enb2syC/SD6brB5Qo7IxObnkUDAs0jHAidemw/cZYyUZMBjwK+zJPZmaQtaiQG2FYvrddyZK2i0IsyYJRt+nPnStv93JNmOssJnkbb+jABDnwIxSuBPaFzzrrZACN0mEGj9jU2ScUEjkXaoE1DozWEbdLeUd8xnD5fETCKrWx5lW8U07XRQ1Wm7nygTC0jHhauWE2yOVL45yryXRMGugWioSK2imVHDMhAfvNNG/27SfiFLzlIagV2Y0NeJQJl92uo0HZRR2WTblD4E5lzKB42WC+qWxibl0Sf9S/kqyLigQMldbVBFcHzTFnFCpqChR6ehgOk5oI/O+G+AcbcvvjiScUxJJHDsSV6J/mr2Kzs/mxtZPCaxqgk6JqpAeFm+qhSbAqd+UxebRgUv48MsSvsvFgMF4uhY+2PKEyvBTzOC8AgPGF2USgBqDUVamEt0PJQzAo2fXj9ciQLGhEDgFcQlUBllhvzcnUSCI5ksDuW66l9hQN6e6xgbWp9LH4X5RpXpybm1R3A6CgoQj5PLqmS48vhVYdgi1EXFYrz7Dzc6J1Ifa7vl8zAkrigArhk/ZNaTaHmnyTdl+33+PdZTNtWY6pvD6/g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1959 Original-Authentication-Results: monjalon.net; dkim=none (message not signed) header.d=none; monjalon.net; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: dfaa5be0-be4a-48fd-05fc-08d88280c0a1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m0Nm0bt/Ly5arQ1+lZfV4bjmmyw8AMzrEuofsyx7E2o7XCu80zu4DDfnpGXTbNmi3ZX9NjYlWCbJsR2mTDHXyzKIp3GPNVXVqxGYD3kHs1IZnZdwKHwlfYWk8fU5pLK0CWjaLly1yckGXgvEHSWg6DZ7rUGcwA2PH06e9D/EERhHg33rA2/gcrE9ej1bIRn0YL6sdpGEA3UR8aOneYwffllns9Y3+ZCVxIU5eTUtd0Xthlhsz5gO0j36qieLuPJW34KXJAt1UkBRPjzwlX9oNRD0vpLTEoEGQSOZ12jLfUq3cZSizPe6P+RvU3JpPP9Yj5Swb/sbo7V+pyYdSMY3WrXsMOUdnMOoE0oJc65yrcYoBSgCGH49Quig4bO1Ve/GI7rgek9xr8rtpmWfQSYvSQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(39860400002)(346002)(46966005)(53546011)(8676002)(4744005)(2906002)(6506007)(33656002)(70586007)(70206006)(8936002)(82740400003)(26005)(47076004)(9686003)(478600001)(52536014)(7696005)(186003)(316002)(83380400001)(5660300002)(86362001)(336012)(82310400003)(4326008)(55016002)(110136005)(54906003)(81166007)(36906005)(356005); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2020 18:21:24.8993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6d04efb-8fb0-49dc-c1cf-08d88280c545 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5767 Subject: Re: [dpdk-dev] [PATCH v4 00/58] net: txgbe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > +Cc Konstantin and Honnappa for guidance >=20 > 05/11/2020 09:55, Jiawen Wu: > > On Thursday, November 5, 2020 9:55 AM, Jiawen Wu wrote: > > > On Thursday, November 5, 2020 1:24 AM, Ferruh Yigit wrote: > > > > On 11/3/2020 11:08 PM, Thomas Monjalon wrote: > > > > > When pulling in the main branch, I see some checkpatches > > > > > warnings (in order of criticality): > > > > > Using rte_smp_[r/w]mb > > > > > Using rte_panic/rte_exit > > > > > Using compiler attribute directly > > > > > > > > > > Please could you fix them (at least first two) before the second = series? Thomas, IMO, these should result in errors in checkpatch, not just warnings= . Do you see any issues? > [...] > > > > I saw ' rte_smp_*mb ' is in the deprecation notices, but there is no > > function can be an alternative. > > I would like to use 'rte_atomic_thread_fence(__ATOMIC_ACQUIRE)' to > > replace 'rte_smp_rmb()', is it the correct usage? >=20 >=20 >=20