From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 306E1A0546; Fri, 30 Apr 2021 15:41:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9A6E4014F; Fri, 30 Apr 2021 15:41:32 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75]) by mails.dpdk.org (Postfix) with ESMTP id 8F41A4013F for ; Fri, 30 Apr 2021 15:41:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90EvH6HYJ6eN8fRPxmzPsvtR7DbLmfAPCL55LiVf2xw=; b=RTlM7zhj1z4A5aYFSbf4hnBXl5vyFCClFn7EzstDC7uI35OeSPlv5ZOd59ooo4aOn0Xq9oYqLiO6fzmAaqqeWkUQTk9s6+QVhgwXmAMI4ivwVNQpvqdY1Iz0RHVEyF/YX8wK3sLCi6hz5f5hHiPWNqe1/jwYGm1JLf4ISzsiNik= Received: from AM6P192CA0005.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::18) by AM9PR08MB6852.eurprd08.prod.outlook.com (2603:10a6:20b:30f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Fri, 30 Apr 2021 13:41:30 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:83:cafe::eb) by AM6P192CA0005.outlook.office365.com (2603:10a6:209:83::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Fri, 30 Apr 2021 13:41:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.27 via Frontend Transport; Fri, 30 Apr 2021 13:41:29 +0000 Received: ("Tessian outbound 6c4b4bc1cefb:v91"); Fri, 30 Apr 2021 13:41:29 +0000 X-CR-MTA-TID: 64aa7808 Received: from 1d041ca92949.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 90FE9E64-6766-4C62-B9E1-15882DB8E1AB.1; Fri, 30 Apr 2021 13:41:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1d041ca92949.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 30 Apr 2021 13:41:23 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQu/HzuURXBc6aRHYx9wEJEMNJMT75huTu1qOkIX+MmwlAGStCp4N4XEIl2IWmgFWhoEEfzXuM7Q1i8ZFDqFKW52xDPcqntHLCwvnl9kYwmOFHSwEWD1RRlqVLMUIXQnZuDFHPBwW9L+v2etv5oomL/yvM7GopLUXUKchRMRLVriCNQsdAyo6giBJDobLBI4BNOLuuV7jC3bZkspqESme9SAX/nDJwOVF/xbOVH6qUyBF9dv8N590ESkJV6pLLiR2qe9uKdKjxWiRBKEqU8Q3OdSeXTa4kDEPGmZDWY46IA6wp9+w0gT2zaNQYtHp2qguiYfdFLF2i2vF3F2+2Vuiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90EvH6HYJ6eN8fRPxmzPsvtR7DbLmfAPCL55LiVf2xw=; b=ZRzl0GwKpPDQ0V0nmcDjECaWe5O6iTEnHuOB2pMK8Uc54ez4eQSNikvrqs9e5lOz5t3AqyTjcQf6o+JT+unRtvNs0qd1HGckiu7dCmx8I3LzYQzxjZV5/xUbDmF3hLmOXqi1PXhlW0/2FVr/F1lgGrO4fFT8iQJgEN9SD8GR4s/CJIt3TJs6Id6COVz5xQNvpby805B6I0UOnu80C29fFqKDkBIdH1wCwZOc3Sen69j/B06I6AEuZkKNVuieq/bS3QD0ORgwC4kpYpecsa6isf3MT7iIU5O0Ash8HactovNd0gQVR9JzIaIi5fakuN6eYWUvTAoCqmD/nfsEpwye6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=90EvH6HYJ6eN8fRPxmzPsvtR7DbLmfAPCL55LiVf2xw=; b=RTlM7zhj1z4A5aYFSbf4hnBXl5vyFCClFn7EzstDC7uI35OeSPlv5ZOd59ooo4aOn0Xq9oYqLiO6fzmAaqqeWkUQTk9s6+QVhgwXmAMI4ivwVNQpvqdY1Iz0RHVEyF/YX8wK3sLCi6hz5f5hHiPWNqe1/jwYGm1JLf4ISzsiNik= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB9PR08MB6732.eurprd08.prod.outlook.com (2603:10a6:10:2af::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Fri, 30 Apr 2021 13:41:22 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::2994:a01e:2de:f94e%7]) with mapi id 15.20.4065.034; Fri, 30 Apr 2021 13:41:22 +0000 From: Honnappa Nagarahalli To: Bruce Richardson , "thomas@monjalon.net" CC: Ruifeng Wang , David Marchand , dev , "jerinj@marvell.com" , nd , Honnappa Nagarahalli , nd Thread-Topic: Use WFE for spinlock and ring Thread-Index: AQHXPaGeO7lFzwWac0+IckOpalvfJKrNESCQ Date: Fri, 30 Apr 2021 13:41:22 +0000 Message-ID: References: <20200424070741.16619-1-gavin.hu@arm.com> <2370044.79WzprfWfc@thomas> <20248566.ii5BvqWlRQ@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B12168AF9307A248AF237D1B3D374F55.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 05748393-ea77-4ccf-ee3f-08d90bdda8ff x-ms-traffictypediagnostic: DB9PR08MB6732:|AM9PR08MB6852: x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4125;OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tHfq29CQnt3Hy4yVbTJw5ErWIIuqT2HWme7Kuvb2kY+c8kjRMh+ceOudX60s7BXdxfuLD4lLjuCr7hQ/q0QaN2l8LZbg8VaIBNGhtG8bqR9WpIMr37+XLyEkTrGaPecMcD6U/eev7qHiybsOWilfgDZpSqdsp56Gg1KOrLdSi1kwYMUw6+B0g8EJzmQaRMJX280HHi8M0UKT8rymI2LzbAOet3I2OuVg9NlGTPrB/UrIBikyEYYof0pwd6gyk7vFnSq45P6So2GwBxhd1H2gkKztFbCh34TT8uiCTfRTACtDFnrwZVrqHz9Nu7Wj/kEkNwNEx0bIeGQSy8GRYHsOVUDI9gL2cVaQ3QimietP507JHcorL2vQ8a5u3rxmtFG9p4Mgn8hM+XHu920YdI4dc58TVtn3uUgQMlg78QN/XfSPjjXgncrW8YqK46v1xPBUL6UfGRNy1uOcnfT+rQiC5UsrJqRPzL7YBcvmttnPbr+Bu/ucChhTBWQao+bD10Dj6nez5Jp/rq5YUUnt0sABo6KyKuORJg80zaqsbgsCxXjLi6k+2mZrO03Gto/vxVPOKbdUnr71zHXIQcAx/YKAFM2UbZVXcRruJmDY8c7UeC9jabxXLPqzsWmi+u5HKAAlDM8ABruMHbv/0Ow32UZ0ag== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39850400004)(346002)(396003)(376002)(366004)(136003)(66946007)(66446008)(9686003)(33656002)(64756008)(110136005)(66476007)(8936002)(316002)(8676002)(122000001)(54906003)(66556008)(55016002)(76116006)(83380400001)(478600001)(2906002)(26005)(6506007)(4326008)(38100700002)(186003)(52536014)(7696005)(71200400001)(5660300002)(86362001)(21314003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?rkWjXNSy+xtJIISKsXomLtKUbgIKvYHQN37EvmHHg1CSyE49gXfzYKkxgvCo?= =?us-ascii?Q?cUvX6TrgIs73AUJd3wqC5HG05jP1bQIlT4MenRU5bo1VxfRq0X4rimgPjKLA?= =?us-ascii?Q?VbH2UGsrru3eMToIzYV3uoz7O67L4VTmG7w36icHwhwhe1Obmc+L2vbg69WU?= =?us-ascii?Q?TpqncGoI7K375guXwPWQgFt/gKwYXqaYU4Mq8Om4ZQ4d13QMIKEoUWe486my?= =?us-ascii?Q?qFnLIsQQ6J3pxT9z61eYnv4ptnfq56XN5ZlshT/IyXHuQBXReTVc59HSC3WS?= =?us-ascii?Q?Dm1bYtqn9a3I5MdYph/d0ZVWwfaie95wWz2HQAVydQ2ubsgeb9bilt502YbM?= =?us-ascii?Q?dhbVe3Eo7LJBQFfeXFv2mY7+ldPMMEseyL+mEitwFxdCq/8CTL7a/ObufCPa?= =?us-ascii?Q?gpvgXRma4Dv8VV4z5btWhKgARgBD7e+qEmWwQf56Pu9Q9ujKG99QCocfW0u3?= =?us-ascii?Q?YOLqNq7V1kixusEwnyFSaC5wsLrLGAfkRCy2fGgsjGHVK1HJY+mGf1wmKcQK?= =?us-ascii?Q?bn+gsTVr3Rvq0khFvb4ipv0Y07aqAVqpHFxabpwl3Wi548LCpRBA9WLewSyL?= =?us-ascii?Q?46i6Csg6f4Ot51mGtf3KriZt3EWSk4nx9pxftUvEPTm5ayQh4sI90B/ra2RR?= =?us-ascii?Q?00lvibr77Kgv0r/Pb6Az0zqix2scJxufy0VjEndDMjBMJGhp/tvjh1x9rnsB?= =?us-ascii?Q?A+gj9IJJ6xerN//JuzFNLzX7gabz4yRg5R5Urlti813YxB+J7NNeiIUbtJD9?= =?us-ascii?Q?bz/OzTOtbruJXvYVsLIMyhACWle2fIWGw8f43/c8DdNZjLfpAccokgaM/1rY?= =?us-ascii?Q?mUFlbPrBga4kMVnD2odxMQvW4U7jGNF0wP38lbm2wGDbxpybnZy9vZEe4LvQ?= =?us-ascii?Q?tqZ1NFwu8nc5mI//5T+tqkTSN1rnwLyNU4jQ4htymqcRnD6aHwXJJIy6gV1G?= =?us-ascii?Q?SDI1FX7/U0wVGPoSwxx1uYlFV4qZZ5aYIsWSbogwF793VQgjPOGUNMrOgXcS?= =?us-ascii?Q?cCtVzQIPwU/0O7S6UPfllWqx2Ob8vp4Ch7XUGG2mkNqKBKYwvKJ8B7WQ9Iyu?= =?us-ascii?Q?gU0psZ8v0zFG7k3L5JpVdPcdKNmZTx26UdK84Mcn3Bc9v4ME1oOFiNfvV1WQ?= =?us-ascii?Q?5LoFmKvfxUHuhc8rpyFBKzwYdtBGpI4xGbg+a3mGt0E848wj7mQgub1u8DoY?= =?us-ascii?Q?jbmTO9n+6JWYLoH61k/8s0mSElYHFZclVrGtKpSf31/JitWEsHGW6l8ieeUV?= =?us-ascii?Q?1sDhBG9qR3X5oxLPn8qJ1sK91CVqEHGTQbNG4FMeO9M9QvPDrcjrzGHntw/j?= =?us-ascii?Q?DUjaCgO1KeK9aTi6A4QRFWv4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6732 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 13c75c40-6542-4e5a-4b62-08d90bdda4ac X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O/1JYhXTY1VRtUWxk2Tx2r+/wKMdZZ9x0zeD8SG4ZdCwY9IMdapJk6oMvKEFpQgCaiJDxoP4/VpSBEENl0oaTA+1e18enfi/oxQ2+FN1dd0PI8jcfXi/D7b+MpHfQrG/dF80qEXSwsmdFxW+swCQvOS4NB2maFEAVb/oqUYdvDjzTWjepLDWnPlTvVosTwnfCZhaCtlfajukuZmpi1fDCLbHs9IO2mlyUggfJD0AxLEZMz0TO7Md6rraU4/aYySGQF/dj0N4zSLb6l32nxtOthqgqnRI/HbfR0MIkoG7H30wCGss93vL3XpLLs6e6/QKic4ewcuuzirtB/6ojFu0KalUuAPMC7GMBGf2Qp4Jx1n2GfdOKBXkcaXpZbi14tGTis4woNHzinoKcWk64NRW1hFmubkC1bLNyEsdcOXSk6tg2V5kXPtKsYOcRUuQmhrx44EBBcwl2K3nHRhrxVSJX7UcedbZpaG6M6OuBY6nesjhSxVXljy+WeyPvIgzEVlRzH4qNuU+4VEx/8gqRihfPCu/Cq5MBxxmbkokVdsWiZjqL2lczPwf5jMU/Oc3WLeZ57FlUEkVxlykYg4q6V2Iirizlf0ICeur3NGcmZgYQJ28q+QvPHQqZyV80on3x/cBoBG/4adB4eakq6Slm0HQtmOQWVag0mMyuhzdNHJupKyw0wIQQclV26S3cdUC61qlV6Egn9gzC/q4muN54x/SuQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(39850400004)(396003)(36840700001)(46966006)(7696005)(36860700001)(34020700004)(4326008)(316002)(82740400003)(9686003)(83380400001)(52536014)(26005)(5660300002)(86362001)(33656002)(478600001)(186003)(2906002)(336012)(110136005)(70206006)(47076005)(70586007)(54906003)(356005)(6506007)(8936002)(82310400003)(55016002)(81166007)(8676002)(21314003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2021 13:41:29.9359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05748393-ea77-4ccf-ee3f-08d90bdda8ff X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6852 Subject: Re: [dpdk-dev] Use WFE for spinlock and ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > > > > > The rte_wait_until_equal_xxx APIs abstract the functionality > > > > > > > of 'polling for a memory location to become equal to a given > value'[1]. > > > > > > > > > > > > > > Use the API for the rte spinlock and ring implementations. > > > > > > > With the wait until equal APIs being stable, changes will not= impact > ABI. > > > > > > > > > > > > Afaics, there is no ARM target with WFE enabled and we lost > > > > > > ability to enable WFE support with removal of the make build > system. > > > > > > > > > > WFE can be enabled with direct meson file change. > > > > > WFE is not intended to be enabled by default. It can be enabled > > > > > based on benchmarking result on hardware. > > > > > > > > > > > > $ git grep RTE_ARM_USE_WFE > > > > > > config/arm/meson.build: ['RTE_ARM_USE_WFE', false], > > > > > > lib/eal/arm/include/rte_pause_64.h:#ifdef RTE_ARM_USE_WFE > > > > > > > > > > > > How did you enable WFE to test this series? > > > > > > > > > > I modified meson file to test. > > > > > Tests were also done with WFE disabled to make sure no > > > > > degradation with > > > > generic implementation. > > > > > > > > I don't understand the usage. > > > > Which platform should use it? > > > > > > Platforms that implement WFE semantic (e.g. N1) can use. > > > The user can enable this feature for power efficiency purpose. But > > > there is something to note as described in commit message 1be7855d77 > when the API was introduced. > > > > > > > Should it be a compile-time option? > > > > > > Yes, it should be a compile-time option. > > > It can be configured via c_args meson option? > > > > +Cc Bruce for discussing how to enable such feature. > > > > The problem with c_args is that the application has no way to know. > > > Agree about c_args not being a great choice. Why does this need to be a > compile-time option? Can runtime support not be detected in some > manner? The problem is inconsistency in performance on different Arm platforms. We = had decided that each platform needs to enable it after some testing.