From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 179C7A034C; Wed, 23 Feb 2022 07:13:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E721040E5A; Wed, 23 Feb 2022 07:13:54 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2087.outbound.protection.outlook.com [40.107.22.87]) by mails.dpdk.org (Postfix) with ESMTP id 93DEB40DF6; Wed, 23 Feb 2022 07:13:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0i1HZNjaJpPc62CRRtQZLAcuWUntJoaw2C0v7DhWxME=; b=dpk0cOaHhSD6+cpSx0Tz60r25QbLBNtGpOfBUAyz5Jww0u7ov/ITgL3Q30stZekezHYoWOtChUt05GmlaIoR4lfctDspgfDG63P8Vld6yP5gig5v9nekCSKYCG3W+9wuR4bfCe29Kq0sV3ycJBE6W14DeP3NPDmuxuZJj4lQF70= Received: from AS8P251CA0020.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::16) by AM8PR08MB5683.eurprd08.prod.outlook.com (2603:10a6:20b:1d1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.21; Wed, 23 Feb 2022 06:13:45 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::d7) by AS8P251CA0020.outlook.office365.com (2603:10a6:20b:2f2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23 via Frontend Transport; Wed, 23 Feb 2022 06:13:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.20 via Frontend Transport; Wed, 23 Feb 2022 06:13:44 +0000 Received: ("Tessian outbound 1f399c739551:v113"); Wed, 23 Feb 2022 06:13:44 +0000 X-CR-MTA-TID: 64aa7808 Received: from b8e10701010c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E94AFA63-AF85-41B3-BD72-C676F277DF2E.1; Wed, 23 Feb 2022 06:13:43 +0000 Received: from EUR03-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b8e10701010c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Feb 2022 06:13:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JxaYHZSKBNII5+QA5GZlxYn9Gsd1KgdqIKmtX7vb4WCAxnDmvJBM0A/lgG0yw6RfuLut/YFGCc4RKHFQi+I3zCxrTWjijMA5hKsss8lm1iBVfUl2681Y/mQ//UXU0eiho7wiQZQvhyMnlWD47wtqfDf42oEutHonlxa94/nTFvR6G6QCkc8JbcwkyDeVF9eZaHqp/bIh2DXnb3eXp54/R0V71qroYFRIfhG1a+gevgre3RqUHTVzt3Y9eJZpvvFLwFymE79S/yJhZVluDQ/C2gdUo/4oAPVC2N1rmQN8JUH2EY+bivQa6VcJImiDu8WYex7wZ+8VMaS0KHoeLGnUHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0i1HZNjaJpPc62CRRtQZLAcuWUntJoaw2C0v7DhWxME=; b=hIkF7usHltnkd7XfIrLB+uG7Y+7Yyyf+kiGN/0sgClDmGUxnLvVaw1lI9o0v5rqojSJmpKFLp2h6lOa6+O4xOELJ3LdWz8bO4XJ5DGJuRkdCK5WNTaCkHf86r6OlVmJnAWVtj00GccIoeUE5DGPCaG1Q3rXW5N4dx+4w/eenKarlK0XEEwW8kFpL9SFeacChjgWR1qCMDoZ7QS7U1nOsgE9d5GHtwXtXy6q0H5sUuS3RmX1od2ixiQJNu+DIf2LBBzw8bpMP1NabW7L+DwgrLlYL7qMu4wDqtg4TyjhNaYhmcfv5JHRB4VyzMT0yDyY0/lb7qgzB3cYNEZ2qjojoPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0i1HZNjaJpPc62CRRtQZLAcuWUntJoaw2C0v7DhWxME=; b=dpk0cOaHhSD6+cpSx0Tz60r25QbLBNtGpOfBUAyz5Jww0u7ov/ITgL3Q30stZekezHYoWOtChUt05GmlaIoR4lfctDspgfDG63P8Vld6yP5gig5v9nekCSKYCG3W+9wuR4bfCe29Kq0sV3ycJBE6W14DeP3NPDmuxuZJj4lQF70= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by PA4PR08MB6157.eurprd08.prod.outlook.com (2603:10a6:102:e3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Wed, 23 Feb 2022 06:13:22 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6d04:5964:7813:4891]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::6d04:5964:7813:4891%5]) with mapi id 15.20.4995.027; Wed, 23 Feb 2022 06:13:22 +0000 From: Honnappa Nagarahalli To: Honnappa Nagarahalli , "dev@dpdk.org" , "lijuan.tu@intel.com" , "juraj.linkes@pantheon.tech" , "ohilyard@iol.unh.edu" , "david.marchand@redhat.com" , "thomas@monjalon.net" , "jerinj@marvell.com" , "bruce.richardson@intel.com" , "stephen@networkplumber.org" , "bluca@debian.org" , "ktraynor@redhat.com" , "christian.ehrhardt@canonical.com" , "xuemingl@nvidia.com" , "stable@dpdk.org" CC: Kathleen Capella , nd , Ruifeng Wang , nd Subject: RE: [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code Thread-Topic: [PATCH v3 1/2] examples/l3fwd: use single set of variables throughout the code Thread-Index: AQHYKHv7yWCAUwIXYEKV+85Zp/n5GKygpzdQ Date: Wed, 23 Feb 2022 06:13:22 +0000 Message-ID: References: <20220202060403.118301-1-honnappa.nagarahalli@arm.com> <20220223060931.2661907-1-honnappa.nagarahalli@arm.com> In-Reply-To: <20220223060931.2661907-1-honnappa.nagarahalli@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5E9A3F7AD7FE0943B859E40BB9F52C1B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 22c465c7-eb9a-4f03-333e-08d9f693a5ae x-ms-traffictypediagnostic: PA4PR08MB6157:EE_|VE1EUR03FT013:EE_|AM8PR08MB5683:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3wml78xB0qu4OE+9XnezNG3jpnfLNn9ICxhgir6IEeZ+McWWCoXn2RpV62BW4At0VimOsLeW5rXDFvSIQkuXiiZbwXVzF2LURVrtymTaPnxfQqrktNlDAHBedFz4cFD2Ndn1JCTBky1QZSXaBXxulKn+UGnla5Wdkiwv8KuvswELMWTVjaBr25n+6Olp1F4UkHYWwxO4dYAprjFus7HFzNJnQj7Ze8MjSIRjEVTX7ngYXPL1EnZHcxvafdS3Ey35qzI0+iGDmLZCMdg0nHZN8MCCQLbB0o+rr4EqYejOAeuyPIw0fXeGcJqGTBVfJ6cbJ0/WWCcjZCoWrMf///VN2n3MpoBsk2CALWtdedUQFQorcXZZB+a3CG3OAhnNmxRBMi/D9jeJtYR9QfokE5oOLLtimkphanSPYrRecBgfEt2v8LgsYPHnuLNfDN2UWpj9Vrk6yhxh5aM8PB9Xy0MLQ3eEeehp36F9yOd3fkPcJKqQYT5luaUKzBmx9CeLLTaGU2unKeRAcatxs0w2rQlB5Cwy9/8CmOsrN9Uq1xD8K3Y4tAtw5NH1NeopBuqKr7Vw3K5jwxUWnflj8J/kFTVbDZxpxQo6i71wvbRs+Ac45k7Ri8k4sB78kmgCEgNv9StyCEUHE9SsBNluxj3Z8I6K4CuQDx109E8ims2eCK3ZxK2gNX8J8JqtyRCAMwDtxT9i2pqkG14qSbiEJoxwUAJw4X1KUaVrohL4jXKZakS50Ig= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(9686003)(53546011)(55016003)(316002)(38070700005)(508600001)(71200400001)(86362001)(6506007)(7696005)(110136005)(52536014)(8936002)(54906003)(66446008)(4326008)(8676002)(76116006)(66476007)(66946007)(66556008)(64756008)(26005)(186003)(921005)(33656002)(38100700002)(7416002)(2906002)(83380400001)(5660300002)(122000001); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6157 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1216726f-2761-473c-4cee-08d9f6939844 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vz3P3OWpwh1mduuL8Pmwp3ZHDs+rv63k+xo7ymP19J+B344gMaxLQDJk6jsBiwWZjJagpuu3YkBtbfLx0e6v93qrdY8TibgnwvFjRtmu6w7G224PdHIoazB8Qg3R8mjKEtVl4pkCL4WgvwM2PsNo98Rjnvh9JxK2Lu3vYtK0ZrRVHRDBDsgx8jJ+PaJ8aX2BhpPC0iVGevbBS/1D+1o5Ch4IBhEzLkT9lbyYBgK6jT8vHEefJJvbUT8J42QpBiOayRbytZqhf5zbGRcv0ca+i0qw3/B6zCUpqepvPs7uAbFULLroEDh2CNMnWKLBYB8ltfOph0r+GJTShvgIoU38fHD7eE6XLx2W/6QQpVmGPnVYcawY+Iax0WJ928l89jjRsDtjbvP/0bzxK+chBMrpMebB1rKyDNTgKdoMCFyJJtRoTzWMYzb13Zh/0nLvqQ6qPm2jIO1T8Ao/vgTOLkoGhVsVeK9RN8gPTFcPDC6xyk00gTS3qZuiIL1xMfB+WqHjVfi8YUVMefOqbGGnHUXhKuCypiW9eShG3xXfVJbQlrswzqAUIRa4fPKe1J3BCXVuwrHLWVLFqTqTjPz2QTiqIhuZCexdD0EQNYtKIlykd9KC2qPelfDjIw+h2TfBjVugW53DTvqYYl+yiTx6uk7aXIBVSebuSUBbNcnG9wjp8duAAD3pnoG0+g2FXe+uHZ7VipPWo9RYWu0SUbl15pZ9eQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(46966006)(36840700001)(52536014)(70206006)(70586007)(4326008)(508600001)(8676002)(110136005)(316002)(2906002)(54906003)(450100002)(6506007)(8936002)(7696005)(53546011)(55016003)(5660300002)(9686003)(86362001)(83380400001)(47076005)(356005)(921005)(81166007)(336012)(186003)(26005)(36860700001)(82310400004)(33656002)(40460700003); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2022 06:13:44.8512 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22c465c7-eb9a-4f03-333e-08d9f693a5ae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5683 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Question for stable maintainers.=20 DTS WG would like this patch to be merged in 21.11 and 20.11 stable release= s even though it is not a bug fix. This allows for a single DTS version to = be used with both those stable releases and master. Do you have any objections? Thank you, Honnappa > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, February 23, 2022 12:10 AM > To: dev@dpdk.org; Honnappa Nagarahalli ; > lijuan.tu@intel.com; juraj.linkes@pantheon.tech; ohilyard@iol.unh.edu; > david.marchand@redhat.com; thomas@monjalon.net; jerinj@marvell.com; > bruce.richardson@intel.com; stephen@networkplumber.org; > bluca@debian.org; ktraynor@redhat.com; christian.ehrhardt@canonical.com; > xuemingl@nvidia.com > Cc: Kathleen Capella ; nd ; > Ruifeng Wang > Subject: [PATCH v3 1/2] examples/l3fwd: use single set of variables throu= ghout > the code >=20 > nb_rxd and nb_txd are used in polling mode and event mode of operation. > nb_rxd and nb_txd are already global in polling mode but are not visible = to > event mode code. Make them visible to all parts of the application. >=20 > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Kathleen Capella > Reviewed-by: Ruifeng Wang > Acked-by: Bruce Richardson > --- > DTS test cases require changing the RX and TX queue depths. > Currently, this is achieved by patching the DPDK code. This patch set pro= vides a > mechanism to configure the queue depths while launching the application. = With > this change DTS test cases do not need to modify the DPDK code. >=20 > v2 - Single parse function, additional validation on input (Stephen) >=20 > v2 - Fixed typo (Ruifeng) and adjusted the commit msg (Kathleen). >=20 > examples/l3fwd/l3fwd.h | 4 ++++ > examples/l3fwd/l3fwd_event.c | 2 -- > examples/l3fwd/main.c | 5 ++--- > 3 files changed, 6 insertions(+), 5 deletions(-) >=20 > diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index > 38ca19133c..4ccdb28b4a 100644 > --- a/examples/l3fwd/l3fwd.h > +++ b/examples/l3fwd/l3fwd.h > @@ -81,6 +81,10 @@ struct lcore_conf { >=20 > extern volatile bool force_quit; >=20 > +/* RX and TX queue depths */ > +extern uint16_t nb_rxd; > +extern uint16_t nb_txd; > + > /* ethernet addresses of ports */ > extern uint64_t dest_eth_addr[RTE_MAX_ETHPORTS]; extern struct > rte_ether_addr ports_eth_addr[RTE_MAX_ETHPORTS]; diff --git > a/examples/l3fwd/l3fwd_event.c b/examples/l3fwd/l3fwd_event.c index > dd9eafa9b9..7a401290f8 100644 > --- a/examples/l3fwd/l3fwd_event.c > +++ b/examples/l3fwd/l3fwd_event.c > @@ -43,8 +43,6 @@ l3fwd_eth_dev_port_setup(struct rte_eth_conf > *port_conf) { > struct l3fwd_event_resources *evt_rsrc =3D l3fwd_get_eventdev_rsrc(); > uint16_t nb_ports =3D rte_eth_dev_count_avail(); > - uint16_t nb_rxd =3D RTE_TEST_RX_DESC_DEFAULT; > - uint16_t nb_txd =3D RTE_TEST_TX_DESC_DEFAULT; > unsigned int nb_lcores =3D rte_lcore_count(); > struct rte_eth_conf local_port_conf; > struct rte_eth_dev_info dev_info; > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index > eb68ffc5aa..acd186ab7d 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -53,9 +53,8 @@ >=20 > #define MAX_LCORE_PARAMS 1024 >=20 > -/* Static global variables used within this file. */ -static uint16_t nb= _rxd =3D > RTE_TEST_RX_DESC_DEFAULT; -static uint16_t nb_txd =3D > RTE_TEST_TX_DESC_DEFAULT; > +uint16_t nb_rxd =3D RTE_TEST_RX_DESC_DEFAULT; uint16_t nb_txd =3D > +RTE_TEST_TX_DESC_DEFAULT; >=20 > /**< Ports set in promiscuous mode off by default. */ static int > promiscuous_on; > -- > 2.25.1