From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2DF61A0545; Tue, 21 Jun 2022 18:33:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDF594069C; Tue, 21 Jun 2022 18:33:18 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by mails.dpdk.org (Postfix) with ESMTP id 9749340151 for ; Tue, 21 Jun 2022 18:33:17 +0200 (CEST) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oQyl6Dzfzk8q9+HdSIW7p/V5yV1Kk0YVTVgtyY+bL8fqxiJvvZkVAOTlYyxF4nxawRgyr6M7D7FUFggE58wCRPLLu1gpfxg29JpgabhYn0/yD0wwIN94kSIJi/A6Ra87rV8kOiz4OTJ3YHb/cpO18gMCN3PesW3IY2Mv/gC0Q3Qttmlh6tobd4MMLOuHBoCOxgZFbY8r5xTjAKvMgn7iNr+pf7tkeUBobZbxDyHEFvEWwzJk+hjR0g2KivM7JInON9xV2vfvQ81F+ix1g3VF5g8TD+Y39Q88yOmoQKc+A/u8s2186VcetTComZUH8zIIBT4XzkfWMyq9rE0xs4Njmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hiaOHpaerVKAhzhpTcBS9IeJexF5DhymKY/Czs39QI=; b=ejYm4CCbSLeCgCjMbuNk7gTxZr1TluB5n7/dJowgVpSo8FraXEA6FD1KCgoJJc7qP0QX0SMleD5wlR7yhuMsHDk93m2nfwZEddUrj6sYu7JAXG12Jk6Xk0jHxSRe8ZKoz/sHyDQpAailiIzbHXmnjAH8QxnDq/e2WNMZaX45zXF6aulGh3AcFGRO1PEF7LN5x8NfwJoJWoX4DMMZU7IQZBuqex9n3AfF9JrXye/rw+4hsXgu2LRHEIJm1gZSDoxMgkJOYENz0Q/TgeozmeATY82VioTQpIrzFepD6v0L6pasQVqEiwAF0rUC/2ZAZavXugHW8MWcekzHhfSOMZ7I0Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=dpdk.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+hiaOHpaerVKAhzhpTcBS9IeJexF5DhymKY/Czs39QI=; b=ftIde2YY4UgeCeXN7DqhbdolZTcDZRRAulls4tqpvurQPF82+4ObiV6IE/EDcCNXK/2aAwtPpxvqdwh6AFg7FN9R7j8Q/hZAq6VlNDF0lMtwWYx3audjkyTCON2OFjjPQUeGXbbPmZYJtuSVAl/yFEnJdJDwcdbIiENkOborNdQ= Received: from AS9PR06CA0332.eurprd06.prod.outlook.com (2603:10a6:20b:466::11) by DB9PR08MB7113.eurprd08.prod.outlook.com (2603:10a6:10:2c2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14; Tue, 21 Jun 2022 16:33:14 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::55) by AS9PR06CA0332.outlook.office365.com (2603:10a6:20b:466::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.15 via Frontend Transport; Tue, 21 Jun 2022 16:33:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.14 via Frontend Transport; Tue, 21 Jun 2022 16:33:13 +0000 Received: ("Tessian outbound 1766a3bff204:v120"); Tue, 21 Jun 2022 16:33:13 +0000 X-CR-MTA-TID: 64aa7808 Received: from efa2089e61e2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE27E5E5-97AA-4229-87DF-6EE9A40D113C.1; Tue, 21 Jun 2022 16:33:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id efa2089e61e2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 21 Jun 2022 16:33:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVzyiUsfSv2X/jKJ1YrKE/58fD8JK/Dl45LAo23UTnTK2ZpBc6ctPv3K7k1boi0fbyN6vHYXRlNz8Icumyx8Q+DIu77i8cVTbnssi2w14gK0XBEL++l7S1nrB5cJoK37rISTI0urOnUih0GVa1wtf1oA67VC/+RvJ4Rov6zTr8SGzreW9uyg//1jZ06WXPq5OmAAm45zz6MlhoEjJtxg5VRg5dzlW1KVVsNcp1o0dDQAEvBKBDEEY+q4k5Pehl85dpm5WIAHYFvIdicRkSaJbSNxBGhw2bCXIlWxFx+Kl6FjH3yLuafw337CgT8eOClyuZgNj8lraJQCQNShcUCZ3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+hiaOHpaerVKAhzhpTcBS9IeJexF5DhymKY/Czs39QI=; b=UCStFdXVGNX08cKvgWwqp/Xm/EobQXsgYcAlbjV4ppDww5arQLdpj+Icy4ax0ariVLCDtIo0CLU8Fb0kLAButQODW2Uc5UI3WaCvd2AOkg2IbgulhHOy8ZK4tIBJGmxHhEAYWVUJP+ScvsHzI5Y7dYaOZChsu/VovyLouw11I7cwx1DL/yJRZnFeahFFSXh9Tps35/+gMlA41JYqhUNXRmHck935FoMXWQkJkw7C4liBDuFDv3YnGzTMEWp2O6EbHY6tj6NdPq3TnTixXatZ1GoQ6Corh4mF/qFL97XOXbV7fzlCDkPi1qlwngMIsaiyRh97EVjYzHTQr9vsOSNgMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+hiaOHpaerVKAhzhpTcBS9IeJexF5DhymKY/Czs39QI=; b=ftIde2YY4UgeCeXN7DqhbdolZTcDZRRAulls4tqpvurQPF82+4ObiV6IE/EDcCNXK/2aAwtPpxvqdwh6AFg7FN9R7j8Q/hZAq6VlNDF0lMtwWYx3audjkyTCON2OFjjPQUeGXbbPmZYJtuSVAl/yFEnJdJDwcdbIiENkOborNdQ= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by AM0PR08MB3457.eurprd08.prod.outlook.com (2603:10a6:208:d7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.13; Tue, 21 Jun 2022 16:32:57 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f99f:a9c3:fe71:368a]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::f99f:a9c3:fe71:368a%5]) with mapi id 15.20.5353.022; Tue, 21 Jun 2022 16:32:57 +0000 From: Honnappa Nagarahalli To: "thomas@monjalon.net" , "Burakov, Anatoly" , Dmitry Kozlyuk , David Marchand , Don Wallwork CC: "dev@dpdk.org" , Stephen Hemminger , Chengwen Feng , =?iso-8859-1?Q?Morten_Br=F8rup?= , Bruce Richardson , nd , "Wang, Haiyue" , Kathleen Capella , nd Subject: RE: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory Thread-Topic: [PATCH v6] eal: allow worker lcore stacks to be allocated from hugepage memory Thread-Index: AQHYhVrzGEEBqzjfp0Cy2xOttByETa1Z74qjgAAC34CAAAIggIAAGZZA Date: Tue, 21 Jun 2022 16:32:57 +0000 Message-ID: References: <20220502141058.12707-1-donw@xsightlabs.com> <6401977.6fTUFtlzNn@thomas> <13664031.VsHLxoZxqI@thomas> In-Reply-To: <13664031.VsHLxoZxqI@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 550BAEB64481BD4091421E348D006AD1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 05a01cbe-d7f9-42a9-4282-08da53a3bcbc x-ms-traffictypediagnostic: AM0PR08MB3457:EE_|AM5EUR03FT060:EE_|DB9PR08MB7113:EE_ x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: M47wiuP8xNGy51pseo9EDFY070LD7YJEaR/ux3ggSgyewqkBub0+/mKzw4dDG4mK4ZoFQGLxEFem11t33l4PkX6AMbutstjiX0i8TSUE+IrTLObF/LYtkTQXQD+Qh+zErVIoHRedggDXp9akO/0nzpNACpL7e8zRYHrQRtXH4cS23WRbXmmYUHXDX9U+Q3ULNQags6f70HGMX1vvQt33kSOepAVNWELo8ZDPupb9TPYJ3OdyMQiTc1i78fk+gI4xhZEqXJx/J0EYZ9hp9knlMV5KSg/XgYc5afKia2bNkfRJ3giWwH3Lucxd+9BzLpGL+jHypgos2HcbfM2MDYH5ihOJHT62SHQuKVHRLUQP/WhOnCCLgpq6+Addh9ueE7Sx0y+YigfPzNpxXEUnF/bVEWKWptYel4m/al3ioxF0SF2N8QNAAH7w2OZYKPk8xBVqe5ghCIaQrc5zimGyERWMPR9LJ4KDCWQEV2MLlpOe7ZN736P3fq4RfnGeMzdHtsbs13D4uXROYre4mTVOuDIeHn58e18t4RRvjBoKpsWgfsAgo56DwGm2jP1n+xTV/kLLvNwYcuUX9C6Jlbyqcb8+vsiVCLJkxVxJwoKF187FhsmhT3j8adgp77e3xgS7hCGxr25XRgOcNWeNrM6icdtPSa8rUlZ/CiqeWWjCU2umO3zILK6YeljuY5Beh2jfZOqaxahHGRj80wD2Us+RPHea2w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(366004)(136003)(39860400002)(346002)(396003)(376002)(5660300002)(55016003)(33656002)(8936002)(7416002)(478600001)(186003)(71200400001)(122000001)(83380400001)(52536014)(41300700001)(64756008)(66446008)(110136005)(38070700005)(66556008)(66476007)(26005)(2906002)(9686003)(86362001)(7696005)(53546011)(54906003)(76116006)(8676002)(4326008)(316002)(66946007)(38100700002)(6506007); DIR:OUT; SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3457 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7c931e3e-d599-4b50-6481-08da53a3b315 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mfhYbo/HGQfgZjPNNgpasrSR4Jpr2+vpdFAYT2FO1kVl+cHmj2illiiwzth7dNXYVD9Lq2nL+/6LuD6Ab4O76gSstlpwAiYp7yEblyuNupAGbDHrjzeBKYjdJXsfWkdsoDItO1gn3s5UukWwRN6ceQRNCsBR3eBwZQ8Nu7shCG/FcmFimhHiJzrEMJJdmf91PpeB92objDpWAnE9e/bR5P6YPp2bwliCC8U1cm8Jm68hUZQZJ1cGULuBtdVpnxWLDrmmjIfSGZjx9B4ehDvGNNvqW7NP4P1BL5NVkr4/9CfvttHNjiTyTTN/QKaaXiKWYSy/lb63IoZLCpwXj2UT8ujcO8wO60jK7wO3wQRG1VbtKf6+DJiPWghco9jReQ2Z5bMTerrs70gxN03zO1ZuyzgmoUmZptqhZz5VOzeeZhhIBbtZdlIVP92ju35nuFuN3BgfDFsLxxNZGxGVru5tcKk47BV6OrgkY8IO/Ebinu/j61EyGhvyHjUTFJJh7ta1lfP9G1Y1KI20cTgAC6NvD14jY9dCwGa3xMbUQIYlYZGD7rqz1Sdqxi6Y79lvX3cRAB6gq9EshZuBHplVTaoCif6kEJur8baFMTSStkTjWZCNO1gQopQrF0dLX7j9DYlMyM0cDUKQohzaPq7E6nUqkdLwEu6CnwX4lP4xYliSmEtUHzUz6A11i/Qdbg/RAs+eMnn8pcQ0Pl/ahf8lx+QBHw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(396003)(136003)(346002)(39860400002)(40470700004)(36840700001)(46966006)(70586007)(9686003)(2906002)(8676002)(83380400001)(70206006)(47076005)(33656002)(186003)(6506007)(4326008)(26005)(8936002)(7696005)(40460700003)(53546011)(336012)(478600001)(5660300002)(86362001)(52536014)(41300700001)(81166007)(316002)(82740400003)(82310400005)(356005)(55016003)(54906003)(110136005)(40480700001)(36860700001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 16:33:13.6794 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05a01cbe-d7f9-42a9-4282-08da53a3bcbc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7113 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >=20 > 21/06/2022 16:52, Don Wallwork: > > On 6/21/2022 10:42 AM, Thomas Monjalon wrote: > > > 21/06/2022 14:31, Don Wallwork: > > >> On 6/21/2022 6:37 AM, Thomas Monjalon wrote: > > >>> 20/06/2022 10:35, David Marchand: > > >>>> On Tue, May 24, 2022 at 9:52 PM Don Wallwork > wrote: > > >>>>> Add support for using hugepages for worker lcore stack memory. > > >>>>> The intent is to improve performance by reducing stack memory > > >>>>> related TLB misses and also by using memory local to the NUMA nod= e > of each lcore. > > >>>>> EAL option '--huge-worker-stack [stack-size-in-kbytes]' is added > > >>>>> to allow the feature to be enabled at runtime. If the size is > > >>>>> not specified, the system pthread stack size will be used. > > >>>> - About the name of the option... I don't have a better name. > > >>>> > > >>>> Just want to highlight, that what this patch does is use the DPDK > > >>>> memory allocator for the stack memory. > > >>>> It happens that DPDK memory allocator is primarily used with > > >>>> hugepages, but this is not systematic for example with the "no-hug= e" > > >>>> mode of the DPDK memory allocator. > > >>>> > > >>>> IOW, in this patch current form, you can still run as: > > >>>> > > >>>> # dpdk-testpmd -c 3 --no-huge --huge-worker-stack=3D16 -m 40 -- et= c... > > >>>> > > >>>> Opinions? > > >>> The name of the option should not include "huge". > > >>> What about "--worker-stack" ? > > >>> If disabled (equal zero), the workers should use the default stack = memory. > > >>> > > >>> > > >> Wouldn't that have the potential to create confusion? The point of > > >> this change is to allocate worker stacks from hugepages. Removing > > >> huge from the option name could give the impression that the > > >> command is simply to control worker stack size. > > > It means if we control the worker stack size with a DPDK option, > > > DPDK memory will be used. > > > But we cannot force hugepage with this option. > > > Hugepage is not always available and it can be disabled in DPDK. > > > > The command could be rejected if hugepages are not available. > > That's not in the patch currently, but can be added. >=20 > David, Anatoly, Dmitry, what do you think? >=20 It should be a warning, but the application can continue to run >=20 >=20