From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D97C7A04E7; Tue, 3 Nov 2020 02:28:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B5846883; Tue, 3 Nov 2020 02:28:40 +0100 (CET) Received: from FRA01-MR2-obe.outbound.protection.outlook.com (mail-eopbgr90084.outbound.protection.outlook.com [40.107.9.84]) by dpdk.org (Postfix) with ESMTP id 59F695B3A; Tue, 3 Nov 2020 02:28:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCNwMTBQWgOpUdT2h7klYJkH7wta+MttuST+Pse0Ejo=; b=35vD4WxMhDdiUhb17jF9RwtMJIvXuc7eqTpc+WOLwI9vfhRJTZ7ppFkY0coxPLzN3//Fix89sf8wzV2Jc288FB8mV7qxT8aaYa9sVSgHSS3kz/5aApKhFwSOK5ysINRZYHfm1zu48Wme1lsGaid7sKuU2I0zyU4lqeQLscWt6gs= Received: from AM4PR0101CA0052.eurprd01.prod.exchangelabs.com (2603:10a6:200:41::20) by PR2PR08MB4761.eurprd08.prod.outlook.com (2603:10a6:101:17::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.28; Tue, 3 Nov 2020 01:28:36 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:41:cafe::9c) by AM4PR0101CA0052.outlook.office365.com (2603:10a6:200:41::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Tue, 3 Nov 2020 01:28:35 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Tue, 3 Nov 2020 01:28:35 +0000 Received: ("Tessian outbound 68da730eaaba:v64"); Tue, 03 Nov 2020 01:28:34 +0000 X-CR-MTA-TID: 64aa7808 Received: from 00f687534929.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60906221-7B66-4264-9631-A227BB2AB5D0.1; Tue, 03 Nov 2020 01:28:24 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 00f687534929.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Nov 2020 01:28:24 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b5ruTwQmxANyWVTHvYJ2HpEkN55blkWpOZitJVJUap7wBxiJYJHRbIJdSI0ZeSFU4WyW1J9oCRHEhiyE5eE4w0Mfqm4UBMfyY8MhXgHJeZAdOmQfH+9GmdhRO9SC241PyNSJHROxppVNLfD15tx6zozWs3Il3e4yWN16q+zB3f/s4EY5ep/FOxXR13Da/PmE8P3GkMLgXne2EHE8qUEHX9C+BvFdEPkmNUwHE2rHzx6nXMDidCmupklW8IGUvibHnEbQjDtbmr0yYZtYPJhXpXLMHSauZgWeJMHIgqhQHufuW1fIG0OboncSsWJChdncEQYNiwGKCWHcYzcc2cV8fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCNwMTBQWgOpUdT2h7klYJkH7wta+MttuST+Pse0Ejo=; b=HQbZoMSUm2l7rcDchd6P5Al3+WCNY4emoLVSogh1dA2dQt9ZHgrK3oxz2kJoigpsjiEb+gvyhdqpczfp5dXbeadOtTlzBm9QZh4+4WFHh5xcXJeH0OJ0ShBxOw0/+27rnxedJAIRgzPlrvvoBNAUgNKuhLM/8ihpV5W6gbmHL1UUchQxzzl823utdgXkhmaF1OtvDxYfs+qjWrXekKcA4H+4u9QzakD6eKIDwgGR3jA+buFzBqwY39pHTcr/5p4ZjPd/d2zMjjCn+f9qVEfHq6d0OxS38LsaiCMenRxk8p68qWfmBOoWzU7bTR156Lxn9lHTd6an59+SBgewOvDJYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yCNwMTBQWgOpUdT2h7klYJkH7wta+MttuST+Pse0Ejo=; b=35vD4WxMhDdiUhb17jF9RwtMJIvXuc7eqTpc+WOLwI9vfhRJTZ7ppFkY0coxPLzN3//Fix89sf8wzV2Jc288FB8mV7qxT8aaYa9sVSgHSS3kz/5aApKhFwSOK5ysINRZYHfm1zu48Wme1lsGaid7sKuU2I0zyU4lqeQLscWt6gs= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB5483.eurprd08.prod.outlook.com (2603:10a6:10:11b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 01:28:14 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 01:28:14 +0000 From: Honnappa Nagarahalli To: Dharmik Thakkar , Bruce Richardson , Vladimir Medvedkin , Gavin Hu , Ruifeng Wang CC: "dev@dpdk.org" , nd , Dharmik Thakkar , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf Thread-Index: AQHWsXOQgEk0/+6kqkqtIQjQz2BIAam1ng8w Date: Tue, 3 Nov 2020 01:28:14 +0000 Message-ID: References: <20201029153634.10647-1-dharmik.thakkar@arm.com> <20201102235203.6342-1-dharmik.thakkar@arm.com> <20201102235203.6342-3-dharmik.thakkar@arm.com> In-Reply-To: <20201102235203.6342-3-dharmik.thakkar@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1D243078969455498EAE68FEA174BAF2.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1629955f-1068-40eb-2636-08d87f97c8d5 x-ms-traffictypediagnostic: DB8PR08MB5483:|PR2PR08MB4761: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:4303;OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VsGGaQktTzCgRgCnEMt4toXjbnpeIAl/WZjqC4B0IoFPv/gqSyd33bjR3vVARm8OxhN39y6vVhiJOFinxQvcszDVLkZuLhPCvlSwRHQRiWMvZmOAVt0brqTx/WCfIKnCIqfl5QOVfzTtsfgLiUS7J2vz5DaW1NKjdkownBAYJxsxY/NLzAitENRG4LTM/nLspBnUDSyvMrIq956+UtdD22CM46GXt9fXjWZYXRrLVowlu9gKGFfEXlZPH8hfoZKQJd7I9QVZP3+pBD9fTmgpV4D7r8/BMZcO/jkWqlzKYUl3klwcEqyJI3hgVb1lKD1MqzoBlqmNHOaFR10ShsPIFQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(76116006)(186003)(71200400001)(6506007)(66446008)(52536014)(5660300002)(26005)(86362001)(8676002)(8936002)(66946007)(6636002)(2906002)(478600001)(66476007)(66556008)(64756008)(7696005)(4326008)(55016002)(83380400001)(9686003)(33656002)(54906003)(110136005)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: /Aqu6knQVMg9MCeiPwpZ4Li+Kmubv19krqelgmMVNoKlNxKi+gnNBNrTbAifpG7dUxmolfYpal291XyNX5yf41yvMLIlKcoBkNuTWO/SFwU50EAq7A6f+cifzTD/Y0mcqP4GVVNP4wmWUIJAaVK07YWzbux6Iuo3iJyvUDUsW3n1OzJFxoHhLGLrKF604cnTcDFsrFCRyeL0j7cJfDZue5auHs3r9DtUSlhU2o342qmv1DouTLXtKwFSFoofhDHDwbdzsQvNG+rXLO+mF6RIVLatTTqNFODrj8ut00xgp7qfQXP11HqK2m4qm3PkxydSY9QUdeUMIP+AnmEmg8vDT2HvujWrcKcKiwF/GXDQ2/2AkuyKnDbBj5elCSwCcEIRYTsMznoL8GjXfXD+skhHdY8PWJC3x+eLP7e2kpxl4ItgvEBf6Ux8NKiqb2NsD3FqLEm+3kZI969OtTUBQAgla0WnmQlRQD6z6Ve4RyNgf4/C3u0MkQGLGZMjf1IistHsH4aPuhcmvZ29tv4qZnLUkw76ZQH0rJHNpjyMq+pLKh3bPb5r5Z8E8m9paMMomqoPHkjblyMA3nNnuUkVYYYtWZreb7nKCrcsmXDX6djhw4/VNTEtqgl/9Fuzj69APgbLYgkTKLAZ+g47YZTva2o0eA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5483 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 8da2d602-f3b5-45d2-34d0-08d87f97bc45 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fYAHlAvuzqWlXtDUzn0KRiYsEgdUionjgA9HdznT/A4oh0PfK9TYTb0WI30Dm/2d7RBVfkAt/84fxA76pXH4qnNWY2IGvjkyV0dyuBqRAtVGb7B3vE7QATNpSmCbYUq0mBgEIonk7t+kH+TZSQ7XRzUS/9Za6BV/ijkDRU1Z4kDEJGwuUktOLCysQlogurT7+wxSRgZ1PTx4LLxi6+/8UHY2jxw76A+zYxwhyAW3p9xC+UQz8XgZ77G5xLpC2lUDkuG4KdE5+8PIlMvng/A36Y0KsmWXMB5Sm59Tw/l8gsFu8bF9oJolSXRTG6T6KRA20rfqv96JyK+lPcj2YNMhKjWtu8OKpyJwGb3WbxMeEmxq+mJLaCLBdK3HrecFvTmAEPHma2KmEbEtilB7KwLzGg== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(346002)(396003)(46966005)(316002)(450100002)(54906003)(8676002)(478600001)(4326008)(110136005)(8936002)(6636002)(86362001)(2906002)(36906005)(55016002)(9686003)(82310400003)(26005)(81166007)(356005)(6506007)(82740400003)(70206006)(70586007)(5660300002)(186003)(336012)(33656002)(52536014)(83380400001)(7696005)(47076004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 01:28:35.7447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1629955f-1068-40eb-2636-08d87f97c8d5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4761 Subject: Re: [dpdk-dev] [PATCH v2 2/4] test/lpm: return error on failure in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Return error if Add/Delete fail in multiwriter perf test >=20 > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > app/test/test_lpm_perf.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index > 45164b23214b..55084816ab91 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -453,6 +453,8 @@ test_lpm_rcu_qsbr_writer(void *arg) > next_hop_add) !=3D 0) { > printf("Failed to add iteration %d, route# > %d\n", > i, j); > + pthread_mutex_unlock(&lpm_mutex); > + return -1; Would be good to use the "goto error" method used in this file in other fun= ctions. > } > pthread_mutex_unlock(&lpm_mutex); > } > @@ -464,6 +466,8 @@ test_lpm_rcu_qsbr_writer(void *arg) > large_ldepth_route_table[j].depth) !=3D 0) { > printf("Failed to delete iteration %d, route# > %d\n", > i, j); > + pthread_mutex_unlock(&lpm_mutex); > + return -1; > } > pthread_mutex_unlock(&lpm_mutex); > } > -- > 2.17.1