From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4EF69A04DE; Tue, 22 Sep 2020 01:43:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA3A71D8F4; Tue, 22 Sep 2020 01:43:23 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10082.outbound.protection.outlook.com [40.107.1.82]) by dpdk.org (Postfix) with ESMTP id C96051D8EC; Tue, 22 Sep 2020 01:43:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffR13T4eG5F1ESMDzc3gTErDAcugYGRaIlu010XoEMQ=; b=RJo6WtxGMzNNw6PzKV7pWZb0+IegUq+pZlfh+nULp3FyBO2UGHQVeT5NLH/xuugAMLFCbNcyauRWBwbBkqF+t+Z79va+3QlraSng/reQNsXzB10gVlDoOVaiRkALByjD9F6a5gN4BThaJ4cpVZeVG03USdKzgnP8MzwpbowmOAs= Received: from AM6PR08CA0015.eurprd08.prod.outlook.com (2603:10a6:20b:b2::27) by AM7PR08MB5480.eurprd08.prod.outlook.com (2603:10a6:20b:de::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Mon, 21 Sep 2020 23:43:21 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:b2:cafe::83) by AM6PR08CA0015.outlook.office365.com (2603:10a6:20b:b2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.14 via Frontend Transport; Mon, 21 Sep 2020 23:43:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15 via Frontend Transport; Mon, 21 Sep 2020 23:43:21 +0000 Received: ("Tessian outbound bac899b43a54:v64"); Mon, 21 Sep 2020 23:43:21 +0000 X-CR-MTA-TID: 64aa7808 Received: from 0fb19c07d67d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C1661C90-51A9-4AE5-8F3C-3329E1464038.1; Mon, 21 Sep 2020 23:43:16 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0fb19c07d67d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Sep 2020 23:43:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEH3mne8pzBz0pUSvvpqMMvD1pFB3kn3lnsBnRcIlAYBasKYriYy340a238YWr363mOHHZj1N7J0KEzFz7T36fmUQjUqPbpmSjY5wWJR/OxEKIQZao9IRV8Hr2r4rdyBBL3cESv4I02zRLJaqa/xaIf0KmuKhgOdm88DvIwC2PG1Mji7/u7oBnQBZDtNG/iKos5DmdBFymkG6z71c3EYgT03uBsZ6xONGCRJesl0X5gSZdiCDgUPcQgq0uTstHo/IKS0FZ+tq7UNTHmZqSka90LSFeuUNYBjuEEcYHHLteQcZ2U8g/VqUEgxDq+SanpzRntYFwlEVqu7KId5ULvobQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffR13T4eG5F1ESMDzc3gTErDAcugYGRaIlu010XoEMQ=; b=mcEWGHHXP/ZrYcLg7NgEaJeT1KC91TWxBhuz0KBoE8zCOzIV6vnNxgHkwsXf6YXiZ8cQ74kwSs8VS60mSfGTuopcidoQy7fOCKAPqAkMgYYhXIb/Zmda4ZQsQKUqin2ND6ufgDfVt7k8DJvGuao7UifduOSFEFD97EKPNurs8SlEFuVyJTBlr0kgC8Z0IoAQ/6TW+EXysOzIMYZnbKaPxU5Sh9hJ3U5Grdp8YkACHZqrz1s48tg9wa0AfG6GdimVdjm97FKSM+RfOAUS/eGyzfobTguwNJuWc2w0RuhBbc3PW/zUVHv59qOgWpuuRjMYeA2qj+3x7f/C9th4Yjj16A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ffR13T4eG5F1ESMDzc3gTErDAcugYGRaIlu010XoEMQ=; b=RJo6WtxGMzNNw6PzKV7pWZb0+IegUq+pZlfh+nULp3FyBO2UGHQVeT5NLH/xuugAMLFCbNcyauRWBwbBkqF+t+Z79va+3QlraSng/reQNsXzB10gVlDoOVaiRkALByjD9F6a5gN4BThaJ4cpVZeVG03USdKzgnP8MzwpbowmOAs= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB7PR08MB3611.eurprd08.prod.outlook.com (2603:10a6:10:4d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 23:43:13 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::408a:40fb:7402:c805%6]) with mapi id 15.20.3391.024; Mon, 21 Sep 2020 23:43:13 +0000 From: Honnappa Nagarahalli To: "Mcnamara, John" , "Power, Ciara" , "dev@dpdk.org" CC: "Power, Ciara" , "stable@dpdk.org" , "Wiles, Keith" , nd , Honnappa Nagarahalli , nd Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail Thread-Index: AQHWjQRU7O1Xpbjb2UKYTFoI2jWj6qls/2fQgAbILjA= Date: Mon, 21 Sep 2020 23:43:12 +0000 Message-ID: References: <20200917150341.66298-1-ciara.power@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 734904CC085D5C488ABC74323F80DD03.0 x-checkrecipientchecked: true Authentication-Results-Original: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [217.140.110.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 7dd027ec-6306-47eb-99ed-08d85e881ff4 x-ms-traffictypediagnostic: DB7PR08MB3611:|AM7PR08MB5480: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /2vZ3yiymuheV+SKW8p5N0sZMxF83e6HTugBb+C2me7CMpbpSAcrrkjFzcddlGzpeHQflDzA9TmEPt9BPH7yksn+/oJKyNgC92mr/HDrWtpeQYp3Ornk+K/zqcqWf3ZuU3ilR5efRxytB2pwyG0FPs/je9GM5K+mtEAKXHvuKboqUccL1JnTSPGwzlLwC8mhTFdXOY7gsntVVYWNzz+s1zCVqdjlwcn8Em+3YyJaJOd8GuBZ3tAVDsaxPHRqSCcwy0DG1WITw/Mf/1ovD2B9EuIRDqC8YwwxDOWRzDQRFCNIzDcIXXiWI4qf3NjNRZD7LoPhXbozOMgQQEQy4p+lWZJZeHr+73z+pyefXxlTCuC0bvqwm58KkpEfSHF+gT642Ir2wug5XaKl6vWDbWotFg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(66946007)(33656002)(478600001)(7696005)(316002)(5660300002)(9686003)(76116006)(966005)(110136005)(8936002)(26005)(186003)(6506007)(2906002)(4326008)(54906003)(66446008)(64756008)(66556008)(66476007)(55016002)(71200400001)(52536014)(86362001)(4744005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: iVabMi9kdXlB23ETX5zDYSc44ObTLDh7g3vinPrKcjv9GZJnNJpSLO8F5WP9WX0CUOj7zj/jwl61lBMxYdXlMFD0lB/SVElorrfqC3urS+BFDgMD7Fc/ySu5Lh4kr1QyhMmdVMF4mi7sR7i/LYyuAWFKtEApMAO830c26uIMeRa/SGEZQ58TnZD1vUXWaoSQ26vUpaYypB4arNEVAIQMasVel5qUn0SqOjbNQEKSSCHHkPzW4jHre/L7XTj5kVdp83M48yt4sYQ5HBWABUWVd7U8zxOGyuhM+OeowVFlbLNhnqOu0EJ/sx0LHlHGk+GJ6RnwTY3YHRJEFyQ0cbV/FF4o5b8JvRBPxv7NJn6m0PGo5AjApAorDITyVVp4/glKs95DeQ+AAfFqaSD08/sNBSuz5xkXhUTElYCmxV9gUkKbeSuYjX1d+v4hiuz4QWTO9vMywz6Q//5JCOyPpYNehDAmkODOsRmGc2zjM1kqrCZlUlPrZD01m9f4zKvZ1Jq1lb84pBTw58hl7Riv9nvTZwQnEPexB/VvFwNWyopRWcvcsoquaBuQwvZBFgkVqprBrjTpyWTknjHMe9rICcbjhuYOgXWCAru2el6TGH2f+hg7WcBqr+4rDAgU8h7ErmnHpdi/Uvtp/ARrsPQpCmUN6A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3611 Original-Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 2ede0490-2bf7-4543-b6a4-08d85e881ad6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R79WxG4elZID2wcH9ejjbxkre1EPDDeCQf/Fohll8SQIuOMZgzCs0cAK3EDaSevoDM52a87oFMCaVzM5f6+igIsqRUBrkHOSwKxzMUqt1qZq1J7PCYuLynOt2/oQO2yqQi98N7zD6aeYcfUlyqjok5sybeUaykOITNLV4ZEGvDDL6kQe3EjymzYO1tyuMnlM7zU3vwlVIt1Q8j8m5R/UKX7Oyuprt+RWxiOjJ0Q1OagE7J/rnv7q/R0C2co5vRBmrwKVHIqOIxMZK4XzgLT6DL1Gb+aaS7ku7tve2NfQpLhta/JDcdvy3pObgtceVgPvAKNTbTUI9MWKeETu54waVvEOMN9h0SNVYlqhk2keofvbF5cPPId7p6hFJxAJBUKbhwA/rrCG+VgWfh0IAo4AQl2QU1VNwZ3IdUVhIY4J/9Eb6Bq8teVQJWVfyqdvNkj9f5Oy0tyBouKQMbPaTL5yXRXriHbFrGLSkgSJPNBi0SI= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(39860400002)(396003)(46966005)(336012)(316002)(52536014)(356005)(4326008)(8936002)(450100002)(70206006)(70586007)(2906002)(9686003)(5660300002)(4744005)(86362001)(33656002)(7696005)(55016002)(82310400003)(478600001)(54906003)(47076004)(966005)(26005)(110136005)(6506007)(186003)(36906005)(82740400003)(81166007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Sep 2020 23:43:21.6888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7dd027ec-6306-47eb-99ed-08d85e881ff4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5480 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > > If an error occurred when allocating memory for metrics or names, the > > function returned without freeing allocated memory. This is now fixed > > to avoid the resource leak in the case that either metrics or names > > had been successfully allocated memory. > > > > Coverity issue: 362053 > > Fixes: c5b7197f662e ("telemetry: move some functions to metrics > > library") > > Cc: stable@dpdk.org >=20 > Acked-by: John McNamara >=20 This is fixed in https://patches.dpdk.org/patch/75323/. Can you please chec= k if that suffices? =