From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 843B8A04E7; Tue, 3 Nov 2020 02:21:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 340496883; Tue, 3 Nov 2020 02:21:23 +0100 (CET) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2087.outbound.protection.outlook.com [40.107.22.87]) by dpdk.org (Postfix) with ESMTP id 1A16A5B3A; Tue, 3 Nov 2020 02:21:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLlRV1p5Yw0K1x4b/Y0LSRUKkClsxvC2XXLxn9lZZ1E=; b=LV2naNjxt+mm4Ur3WXgr7QaD3Y6ijXf9/9j2dqkFANdg2fx1CK6nhNWd2WtSr2UTyzSElcV3kH4CYwjqbQYfFX8W3i15kwVUTcW1VG/pAuihqhG3ivyfTJ6OcjEb5eDXLSfST94pXEQzyRrl1alR0sRyveHA/nTCsUgXuX5lp2Q= Received: from DB7PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:10:52::23) by VE1PR08MB5583.eurprd08.prod.outlook.com (2603:10a6:800:1ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.22; Tue, 3 Nov 2020 01:21:17 +0000 Received: from DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::81) by DB7PR02CA0010.outlook.office365.com (2603:10a6:10:52::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19 via Frontend Transport; Tue, 3 Nov 2020 01:21:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT055.mail.protection.outlook.com (10.152.21.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Tue, 3 Nov 2020 01:21:17 +0000 Received: ("Tessian outbound e6c55a0b9ba9:v64"); Tue, 03 Nov 2020 01:21:17 +0000 X-CR-MTA-TID: 64aa7808 Received: from 65c10be3aca1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EFF29293-91D2-4F79-93C2-150ADD264664.1; Tue, 03 Nov 2020 01:21:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 65c10be3aca1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 03 Nov 2020 01:21:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jWbnF2jio9WflxSKdpwPKtrAw+rNh/ptJR56KHw9WuZE9yvA3v1bjpzJgx7fUJQVjPvTLYTyskR0WkID6Huo12PlqAcZmFc7r0KbJ+gTWPQzPFF75WEoZnt5Y4eeDoVhl07Vh8OmXucTJZ6Bc4FCs39dROQ17mi90xH3fCowRZw8XhOY9kJIZd84ErqZDYNrwXQbYy+DuJhlrNcs2iDvmc+Lok8CFJFEnhvNfyxbE4eb3JYYQtjwgB0x56o7Db/OqlOw4RaLAdDT8GebAflTfAPyea/rFr5hLhIbChGX7FIRmbtyQjzC94djbHnVIx0nXWFE3zsWzP+vEEkwYTnalg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLlRV1p5Yw0K1x4b/Y0LSRUKkClsxvC2XXLxn9lZZ1E=; b=PDdGkKHeYvYqv9g5ZJ63OrouERKeNHnnYfmqiyhSCvPqBSG5VUErjB0bEOInBSbQgigGd09ORoPSa5KSzfC+lHCjB5YaE8Kxx61wF50qzVV+FdIwxcK5q5YzEW6eZE4up9en/Xvg8hexRqwTyeebPj5Etc9jLJLC6gygeDh6sSVaQvToTPVrd6kDXQuBKkD17nYAkXxcIyI+4eIZ4IkZKg5N2C7UMIeng+59rImNTePCpQ3b9MpYNNdIslFJ+OVitCeHHULUDkP0t7TZPVZ5yb+oC5Tutj6mjc8gPKC4ZbDLxDkK6WPs+KD1z7Yj+VnPWtwVHIBeKl1UpjfZBzM8tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLlRV1p5Yw0K1x4b/Y0LSRUKkClsxvC2XXLxn9lZZ1E=; b=LV2naNjxt+mm4Ur3WXgr7QaD3Y6ijXf9/9j2dqkFANdg2fx1CK6nhNWd2WtSr2UTyzSElcV3kH4CYwjqbQYfFX8W3i15kwVUTcW1VG/pAuihqhG3ivyfTJ6OcjEb5eDXLSfST94pXEQzyRrl1alR0sRyveHA/nTCsUgXuX5lp2Q= Received: from DBAPR08MB5814.eurprd08.prod.outlook.com (2603:10a6:10:1b1::6) by DB8PR08MB5483.eurprd08.prod.outlook.com (2603:10a6:10:11b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov 2020 01:21:11 +0000 Received: from DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d]) by DBAPR08MB5814.eurprd08.prod.outlook.com ([fe80::7814:9c1:781f:475d%4]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 01:21:11 +0000 From: Honnappa Nagarahalli To: Dharmik Thakkar , Bruce Richardson , Vladimir Medvedkin , Ruifeng Wang , Gavin Hu CC: "dev@dpdk.org" , nd , Dharmik Thakkar , "stable@dpdk.org" , Honnappa Nagarahalli , nd Thread-Topic: [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf Thread-Index: AQHWsXOSHKfCikIX4U64BjmbAUfObKm1m+bA Date: Tue, 3 Nov 2020 01:21:11 +0000 Message-ID: References: <20201029153634.10647-1-dharmik.thakkar@arm.com> <20201102235203.6342-1-dharmik.thakkar@arm.com> <20201102235203.6342-4-dharmik.thakkar@arm.com> In-Reply-To: <20201102235203.6342-4-dharmik.thakkar@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BC35A87FD6E82E478247F84A6C522DD4.0 x-checkrecipientchecked: true Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; x-originating-ip: [70.113.13.105] x-ms-publictraffictype: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: c06db0de-e2d3-40bf-b1ea-08d87f96c3ad x-ms-traffictypediagnostic: DB8PR08MB5483:|VE1PR08MB5583: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true nodisclaimer: true x-ms-oob-tlc-oobclassifiers: OLM:1923;OLM:1923; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mcnsuuwVqUosxBs3ycoqr6N1h4nCaR0vN795nXjF+rfsaPbptrIJ2Ln2m5UgimQ0VsMza/psPzHy2G3POspfEe9qg1oScC2wQHjJq3uq+HxxFn8o+mX2TzbM7bDXZTPs2StONEZbNUEeOKXuwPzIyhdgipGdcJDDtJ5uf8ZaSA5Ry+toacfViJlMcbGIeeeUhAlWR7iNmJvkrJsJiyh/zge38BL5dcIQcrKb4Z3A/x98cBmg/xumt8TE9jjM1+P1pe6ATd3aGENJw7QJhLaKZegKfQl1eX50m52drD35DLNmHzywa8NMQprF2xKolyj/ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBAPR08MB5814.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(346002)(39860400002)(136003)(376002)(110136005)(54906003)(4326008)(55016002)(33656002)(83380400001)(9686003)(316002)(26005)(86362001)(8676002)(71200400001)(186003)(66446008)(6506007)(76116006)(5660300002)(52536014)(66556008)(64756008)(66476007)(7696005)(66946007)(478600001)(8936002)(6636002)(2906002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 9o8WQVPtv8a2qm1LKM737sp1f1HfGCoeXZe1EkAu08GvfxKjOuzj7rBSDU8ZYMctOFG0863hWXq5ntSwaMmNsUbjxp2OUhHdaO8mBFHM/WR5s6oOZNZsRERlx101r1gAg2RMcLyK84DPdIfMKg1H/psu7RakT9fuN4ciLBvBKzU09JOEqshcdEH5jdn/qtMtX6C+VvSDu8N+k0JB+v+5o16vvICTZmQLg4IG3pBWxguOWooOHhzEiuNkPV1QvCGDaWyZY10w4lm0eP6uzd8KIkTy232oNAbZWENPf/cbz3BotH8qPkEp68jVW2ovUA97iBHYWzQfwgEcKdFhRYaSTq7MhEwhMoIY0Q3mHcaqMCQjOAF6DQYfwiPK4EaUulfb9eYyhfYwwxbjCBQ7gzFWB4vHGRp7Iq9uNRArieMS0PyF67fQDaLCl8hOqfZDo7Y4jeiUIBkCzZUIFjkalD02cAieuTPu1XniuwOEcO4OkSn01oJzQr7R9w+5Eb4P2MIrG0nu4dOIEPQYWjXUkHPjx1j2m5dr04YPBiZlKpowUCRkAyEfIMHuke8iqRJ3jjfHCbVwAxw2Cv/kE5KshHP2nWVS8TqAS4kLcXZkHWssl+/RaLLW1+bS/J6H99mWigwVGyOkzSbDB/uUcxq2Zh9jWg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5483 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: fe203fb2-c130-4b03-6e79-08d87f96bffa X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CtF4hHxQxe8wIZvtucZTJZfVr0K0ZVLHAxbBBJi9KFC2Del34oZFl8IrkOb4MS6Tmw55jwipPNL4Qu1nTDoHpgFK1vw/zMVogG1NdBjwG7N+kCyitCZI5cuYnHO86PR+xPqYIyULV2PHUuaRG7hlr/Mf99kp6D2ei/yx1qakT4EjKC6y9RqryYDYM+rUPKzlSL7moWlAkFasZ+xeIt6vDb+9SBe6QVDHwS5N4NmsoRFGGwYiWDCyW2M9ockPQLzMYG2W6oCi/xyPtZ69SqNME4U3/bhzh7O6pH/D9Z28X10gnsuhvCjI6326XHzD42LtN0lV006KHPx3TX3MtjPaLBXPIGt/9BNO6J/V+Jf4YXnrzh9ePUvnSOuOMIEscTOacPW2mZb/fzkAurQePzchVQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966005)(7696005)(110136005)(5660300002)(70206006)(52536014)(336012)(70586007)(316002)(33656002)(4326008)(6636002)(186003)(450100002)(54906003)(86362001)(83380400001)(2906002)(26005)(82310400003)(47076004)(478600001)(55016002)(9686003)(81166007)(8936002)(6506007)(356005)(82740400003)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2020 01:21:17.7587 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c06db0de-e2d3-40bf-b1ea-08d87f96c3ad X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5583 Subject: Re: [dpdk-dev] [PATCH v2 3/4] test/lpm: remove error checking in rcu qsbr perf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Remove redundant error checking for reader threads since they never retur= n > error. >=20 > Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests") > Cc: honnappa.nagarahalli@arm.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang > --- > app/test/test_lpm_perf.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) >=20 > diff --git a/app/test/test_lpm_perf.c b/app/test/test_lpm_perf.c index > 55084816ab91..224c92fa3d65 100644 > --- a/app/test/test_lpm_perf.c > +++ b/app/test/test_lpm_perf.c > @@ -554,11 +554,10 @@ test_lpm_rcu_perf_multi_writer(void) > __atomic_load_n(&gwrite_cycles, __ATOMIC_RELAXED) > / TOTAL_WRITES); >=20 > - /* Wait and check return value from reader threads */ > writer_done =3D 1; > + /* Wait until all readers have exited */ > for (i =3D 2; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); > rte_free(rv); > @@ -603,10 +602,9 @@ test_lpm_rcu_perf_multi_writer(void) > / TOTAL_WRITES); >=20 > writer_done =3D 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i =3D 2; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); >=20 > @@ -710,10 +708,9 @@ test_lpm_rcu_perf(void) > (double)total_cycles / TOTAL_WRITES); >=20 > writer_done =3D 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i =3D 0; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - goto error; > + if (rte_eal_wait_lcore(enabled_core_ids[i]); ^^ Do we need the 'if' statement? >=20 > rte_lpm_free(lpm); > rte_free(rv); > @@ -769,11 +766,9 @@ test_lpm_rcu_perf(void) > (double)total_cycles / TOTAL_WRITES); >=20 > writer_done =3D 1; > - /* Wait and check return value from reader threads */ > + /* Wait until all readers have exited */ > for (i =3D 0; i < num_cores; i++) > - if (rte_eal_wait_lcore(enabled_core_ids[i]) < 0) > - printf("Warning: lcore %u not finished.\n", > - enabled_core_ids[i]); > + rte_eal_wait_lcore(enabled_core_ids[i]); >=20 > rte_lpm_free(lpm); >=20 > -- > 2.17.1